danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-30 04:39:00 +01:00
Code Issues Projects Releases Wiki Activity

Fix #1676 - don’t modify original param types with templated by-reference

Browse Source
This commit is contained in:
Matthew Brown 2019-05-24 18:17:48 -04:00
parent 62dacaf97b
commit 9fb96793cd
2 changed files with 35 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Psalm/Internal/Analyzer/Statements/Expression/CallAnalyzer.php
View File

@ -1455,7 +1455,7 @@ class CallAnalyzer
$generic_params = [];
}
$original_by_ref_type = $by_ref_type;
$original_by_ref_type = clone $by_ref_type;
$by_ref_type = clone $by_ref_type;

34
tests/Template/TemplateTest.php
View File

@ -2538,6 +2538,40 @@ class TemplateTest extends TestCase
'$a' => 'C&I<C>'
]
],
'dontModifyByRefTemplatedArray' => [
'<?php
class A {}
class B {}
/**
* @template T of object
* @param class-string<T> $className
* @param array<T> $map
* @param-out array<T> $map
* @param int $id
* @return T
*/
function get(string $className, array &$map, int $id) {
if(!array_key_exists($id, $map)) {
$map[$id] = new $className();
}
return $map[$id];
}
/**
* @param array<A> $mapA
*/
function getA(int $id, array $mapA): A {
return get(A::class, $mapA, $id);
}
/**
* @param array<B> $mapB
*/
function getB(int $id, array $mapB): B {
return get(B::class, $mapB, $id);
}'
],
];
}