danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-30 04:39:00 +01:00
Code Issues Projects Releases Wiki Activity

Reduce duplicate calls

Browse Source
This commit is contained in:
Matthew Brown 2019-10-13 22:05:16 -04:00
parent 8c6b234c2c
commit a0d484a314
1 changed files with 22 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/Psalm/Internal/Codebase/Taint.php
View File

@ -328,24 +328,36 @@ class Taint
) : array {
$files = [];
$new_sink_file_paths = [];
foreach ($this->new_sinks as $new_sink) {
if ($new_sink && $new_sink->code_location) {
$files = array_merge(
$reference_provider->getFilesReferencingFile($new_sink->code_location->file_path),
$files
);
$new_sink_file_paths[$new_sink->code_location->file_path] = $new_sink->code_location->file_path;
}
}
foreach ($new_sink_file_paths as $file_path) {
$files_referencing_file = $reference_provider->getFilesReferencingFile($file_path);
$files = array_merge($files_referencing_file, $files);
}
$new_source_file_paths = [];
foreach ($this->new_sources as $new_source) {
if ($new_source && $new_source->code_location) {
$classlikes = $file_storage_provider->get($new_source->code_location->file_path)->classlikes_in_file;
foreach ($classlikes as $classlike) {
$class_storage = $classlike_storage_provider->get($classlike);
$new_source_file_paths[$new_source->code_location->file_path] = $new_source->code_location->file_path;
}
}
if ($class_storage->location) {
$files[] = $class_storage->location->file_path;
}
foreach ($new_source_file_paths as $file_path) {
$classlikes = $file_storage_provider->get($file_path)->classlikes_in_file;
foreach ($classlikes as $classlike) {
$class_storage = $classlike_storage_provider->get($classlike);
if ($class_storage->location) {
$files[] = $class_storage->location->file_path;
}
}
}