danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-12-04 18:48:03 +01:00
Code Issues Projects Releases Wiki Activity

Psalter add psalm-param modifying

Browse Source
This commit is contained in:
orklah 2021-10-04 00:33:23 +02:00
parent 2e7e343ef8
commit aba9541451
1 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/Psalm/Internal/FileManipulation/FunctionDocblockManipulator.php
View File

@ -297,8 +297,10 @@ class FunctionDocblockManipulator
$this->new_php_param_types[$param_name] = $php_type;
}
if ($php_type !== $new_type) {
if ($php_type !== $phpdoc_type) {
$this->new_phpdoc_param_types[$param_name] = $phpdoc_type;
}
if ($php_type !== $new_type && $phpdoc_type !== $new_type) {
$this->new_psalm_param_types[$param_name] = $new_type;
}
}
@ -346,6 +348,32 @@ class FunctionDocblockManipulator
}
}
foreach ($this->new_psalm_param_types as $param_name => $psalm_type) {
$found_in_params = false;
$new_param_block = $psalm_type . ' ' . '$' . $param_name;
if (isset($parsed_docblock->tags['psalm-param'])) {
foreach ($parsed_docblock->tags['psalm-param'] as &$param_block) {
$doc_parts = CommentAnalyzer::splitDocLine($param_block);
if (($doc_parts[1] ?? null) === '$' . $param_name) {
if ($param_block !== $new_param_block) {
$modified_docblock = true;
}
$param_block = $new_param_block;
$found_in_params = true;
break;
}
}
}
if (!$found_in_params) {
$modified_docblock = true;
$parsed_docblock->tags['psalm-param'][] = $new_param_block;
}
}
$old_phpdoc_return_type = null;
if (isset($parsed_docblock->tags['return'])) {
$old_phpdoc_return_type = reset($parsed_docblock->tags['return']);