danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-21 21:31:13 +01:00
Code Issues Projects Releases Wiki Activity

Remove stopOnFirstError config option, because it hasn’t worked for a while

Browse Source 
Fixes #248
This commit is contained in:
Matt Brown 2018-01-24 16:22:54 -05:00
parent 93ac3eaadb
commit b0f3992f36
10 changed files with 0 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
assets/config_levels/1.xml
View File

@ -1,7 +1,6 @@
<?xml version="1.0"?>
<psalm
name="Example Psalm config with recommended defaults"
stopOnFirstError="false"
useDocblockTypes="true"
totallyTyped="true"
>

1
assets/config_levels/2.xml
View File

@ -1,7 +1,6 @@
<?xml version="1.0"?>
<psalm
name="Example Psalm config with recommended defaults"
stopOnFirstError="false"
useDocblockTypes="true"
totallyTyped="false"
>

1
assets/config_levels/3.xml
View File

@ -1,7 +1,6 @@
<?xml version="1.0"?>
<psalm
name="Example Psalm config with recommended defaults"
stopOnFirstError="false"
useDocblockTypes="true"
totallyTyped="false"
>

1
assets/config_levels/4.xml
View File

@ -1,7 +1,6 @@
<?xml version="1.0"?>
<psalm
name="Example Psalm config with recommended defaults"
stopOnFirstError="false"
useDocblockTypes="true"
totallyTyped="false"
>

1
assets/config_levels/5.xml
View File

@ -1,7 +1,6 @@
<?xml version="1.0"?>
<psalm
name="Example Psalm config with recommended defaults"
stopOnFirstError="false"
useDocblockTypes="true"
totallyTyped="false"
>

1
psalm.xml
View File

@ -1,7 +1,6 @@
<?xml version="1.0"?>
<psalm
name="Psalm for Psalm"
stopOnFirstError="false"
useDocblockTypes="true"
totallyTyped="true"
strictBinaryOperands="false"

12
src/Psalm/Config.php
View File

@ -49,13 +49,6 @@ class Config
*/
private static $instance;
/**
* Whether or not to stop when the first error is seen
*
* @var bool
*/
public $stop_on_first_error = true;
/**
* Whether or not to use types as defined in docblocks
*
@ -316,11 +309,6 @@ class Config
$config_xml = new SimpleXMLElement($file_contents);
if (isset($config_xml['stopOnFirstError'])) {
$attribute_text = (string) $config_xml['stopOnFirstError'];
$config->stop_on_first_error = $attribute_text === 'true' || $attribute_text === '1';
}
if (isset($config_xml['useDocblockTypes'])) {
$attribute_text = (string) $config_xml['useDocblockTypes'];
$config->use_docblock_types = $attribute_text === 'true' || $attribute_text === '1';

4
src/Psalm/IssueBuffer.php
View File

@ -108,10 +108,6 @@ class IssueBuffer
self::$issues_data[] = $e->toArray(Config::REPORT_ERROR);
}
if ($config->stop_on_first_error) {
exit(1);
}
return true;
}

1
tests/JsonOutputTest.php
View File

@ -20,7 +20,6 @@ class JsonOutputTest extends TestCase
$config = new TestConfig();
$config->throw_exception = false;
$config->stop_on_first_error = false;
$this->project_checker = new ProjectChecker(
$config,

3
tests/ReportOutputTest.php
View File

@ -21,7 +21,6 @@ class ReportOutputTest extends TestCase
$config = new TestConfig();
$config->throw_exception = false;
$config->stop_on_first_error = false;
$this->project_checker = new ProjectChecker(
$config,
@ -39,7 +38,6 @@ class ReportOutputTest extends TestCase
{
$config = new TestConfig();
$config->throw_exception = false;
$config->stop_on_first_error = false;
// No exception
foreach (['.xml', '.txt', '.json', '.emacs'] as $extension) {
@ -67,7 +65,6 @@ class ReportOutputTest extends TestCase
{
$config = new TestConfig();
$config->throw_exception = false;
$config->stop_on_first_error = false;
new ProjectChecker(
$config,