danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-21 21:31:13 +01:00
Code Issues Projects Releases Wiki Activity

Add checks for !== true

Browse Source
This commit is contained in:
Matthew Brown 2016-09-01 00:07:20 -04:00
parent 47f66bf4dd
commit b40e057090
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/Psalm/Checker/TypeChecker.php
View File

@ -364,6 +364,21 @@ class TypeChecker
}
}
}
elseif ($true_position) {
if ($true_position === self::ASSIGNMENT_TO_RIGHT) {
if ($conditional->left instanceof PhpParser\Node\Expr\FuncCall) {
self::processFunctionCall($conditional->left, $if_types, true);
}
}
else if ($true_position === self::ASSIGNMENT_TO_LEFT) {
if ($conditional->right instanceof PhpParser\Node\Expr\FuncCall) {
self::processFunctionCall($conditional->right, $if_types, true);
}
}
else {
throw new \InvalidArgumentException('Bad null variable position');
}
}
}
elseif ($conditional instanceof PhpParser\Node\Expr\FuncCall) {
self::processFunctionCall($conditional, $if_types);
@ -386,7 +401,7 @@ class TypeChecker
return $if_types;
}
protected static function processFunctionCall(PhpParser\Node\Expr $expr, array &$if_types, $negate = false)
protected static function processFunctionCall(PhpParser\Node\Expr\FuncCall $expr, array &$if_types, $negate = false)
{
$prefix = $negate ? '!' : '';