danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-27 04:45:20 +01:00
Code Issues Projects Releases Wiki Activity

chore: fix cs

Browse Source
This commit is contained in:
Sam Mousa 2022-06-15 13:28:09 +02:00
parent 0e7ea855d0
commit b46f556662
No known key found for this signature in database
GPG Key ID: A18520F9B4301C9D
1 changed files with 20 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
tests/Internal/Codebase/InternalCallMapHandlerTest.php
View File

@ -9,15 +9,26 @@ use Psalm\Internal\Codebase\Reflection;
use Psalm\Internal\Provider\FakeFileProvider; use Psalm\Internal\Provider\FakeFileProvider;
use Psalm\Internal\Provider\Providers; use Psalm\Internal\Provider\Providers;
use Psalm\Internal\Type\Comparator\UnionTypeComparator; use Psalm\Internal\Type\Comparator\UnionTypeComparator;
use Psalm\Internal\Type\TypeParser;
use Psalm\Tests\Internal\Provider\FakeParserCacheProvider; use Psalm\Tests\Internal\Provider\FakeParserCacheProvider;
use Psalm\Tests\TestCase; use Psalm\Tests\TestCase;
use Psalm\Tests\TestConfig; use Psalm\Tests\TestConfig;
use Psalm\Type; use Psalm\Type;
use ReflectionFunction; use ReflectionFunction;
use ReflectionNamedType;
use ReflectionParameter; use ReflectionParameter;
use ReflectionType; use ReflectionType;
use Throwable;
use function count;
use function explode;
use function function_exists;
use function implode;
use function in_array;
use function json_encode;
use function preg_match;
use function print_r;
use function strncmp;
use function strpos;
use function substr;
class InternalCallMapHandlerTest extends TestCase class InternalCallMapHandlerTest extends TestCase
{ {
@ -147,7 +158,6 @@ class InternalCallMapHandlerTest extends TestCase
public static function tearDownAfterClass(): void public static function tearDownAfterClass(): void
{ {
self::$codebase = null; self::$codebase = null;
} }
/** /**
@ -182,7 +192,7 @@ class InternalCallMapHandlerTest extends TestCase
) )
); );
$callMap = InternalCallMapHandler::getCallMap(); $callMap = InternalCallMapHandler::getCallMap();
foreach($callMap as $function => $entry) { foreach ($callMap as $function => $entry) {
// Skip class methods // Skip class methods
if (strpos($function, '::') !== false || !function_exists($function)) { if (strpos($function, '::') !== false || !function_exists($function)) {
continue; continue;
@ -194,13 +204,10 @@ class InternalCallMapHandlerTest extends TestCase
// if ($function != 'fprintf') continue; // if ($function != 'fprintf') continue;
yield "$function: " . json_encode($entry) => [$function, $entry]; yield "$function: " . json_encode($entry) => [$function, $entry];
} }
} }
/** /**
* This function will test functions that are in the callmap AND currently defined * This function will test functions that are in the callmap AND currently defined
* @return void
* @coversNothing * @coversNothing
* @depends testGetcallmapReturnsAValidCallmap * @depends testGetcallmapReturnsAValidCallmap
* @dataProvider callMapEntryProvider * @dataProvider callMapEntryProvider
@ -217,7 +224,6 @@ class InternalCallMapHandlerTest extends TestCase
$this->markTestSkipped("Function $functionName has ignored prefix"); $this->markTestSkipped("Function $functionName has ignored prefix");
} }
$this->assertEntryIsCorrect($callMapEntry, $functionName); $this->assertEntryIsCorrect($callMapEntry, $functionName);
} }
private function assertEntryIsCorrect(array $callMapEntry, string $functionName): void private function assertEntryIsCorrect(array $callMapEntry, string $functionName): void
@ -233,7 +239,7 @@ class InternalCallMapHandlerTest extends TestCase
*/ */
$normalizedEntries = []; $normalizedEntries = [];
foreach($callMapEntry as $key => $entry) { foreach ($callMapEntry as $key => $entry) {
$normalizedKey = $key; $normalizedKey = $key;
$normalizedEntry = [ $normalizedEntry = [
'variadic' => false, 'variadic' => false,
@ -270,9 +276,8 @@ class InternalCallMapHandlerTest extends TestCase
$normalizedEntry['name'] = $normalizedKey; $normalizedEntry['name'] = $normalizedKey;
$normalizedEntries[$normalizedKey] = $normalizedEntry; $normalizedEntries[$normalizedKey] = $normalizedEntry;
} }
foreach($rF->getParameters() as $parameter) { foreach ($rF->getParameters() as $parameter) {
if ($this->skipUndefinedParams && !isset($normalizedEntries[$parameter->getName()])) { if ($this->skipUndefinedParams && !isset($normalizedEntries[$parameter->getName()])) {
continue; continue;
} else { } else {
@ -280,7 +285,6 @@ class InternalCallMapHandlerTest extends TestCase
} }
$this->assertParameter($normalizedEntries[$parameter->getName()], $parameter, $functionName); $this->assertParameter($normalizedEntries[$parameter->getName()], $parameter, $functionName);
} }
} }
/** /**
@ -292,10 +296,10 @@ class InternalCallMapHandlerTest extends TestCase
$name = $param->getName(); $name = $param->getName();
// $identifier = "Param $functionName - $name"; // $identifier = "Param $functionName - $name";
try { try {
$this->assertSame($param->isOptional(), $normalizedEntry['optional'], "Expected param '{$name}' to " . ($param->isOptional() ? "be" : "not be") . " optional"); $this->assertSame($param->isOptional(), $normalizedEntry['optional'], "Expected param '{$name}' to " . ($param->isOptional() ? "be" : "not be") . " optional");
$this->assertSame($param->isVariadic(), $normalizedEntry['variadic'], "Expected param '{$name}' to " . ($param->isVariadic() ? "be" : "not be") . " variadic"); $this->assertSame($param->isVariadic(), $normalizedEntry['variadic'], "Expected param '{$name}' to " . ($param->isVariadic() ? "be" : "not be") . " variadic");
$this->assertSame($param->isPassedByReference(), $normalizedEntry['byRef'], "Expected param '{$name}' to " . ($param->isPassedByReference() ? "be" : "not be") . " by reference"); $this->assertSame($param->isPassedByReference(), $normalizedEntry['byRef'], "Expected param '{$name}' to " . ($param->isPassedByReference() ? "be" : "not be") . " by reference");
} catch(\Throwable $t) { } catch (Throwable $t) {
$this->markTestSkipped("Exception: " . $t->getMessage()); $this->markTestSkipped("Exception: " . $t->getMessage());
} }
@ -304,8 +308,6 @@ class InternalCallMapHandlerTest extends TestCase
if (isset($expectedType)) { if (isset($expectedType)) {
$this->assertTypeValidity($expectedType, $normalizedEntry['type'], "Param '{$name}' has incorrect type"); $this->assertTypeValidity($expectedType, $normalizedEntry['type'], "Param '{$name}' has incorrect type");
} }
} }
/** /**