danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-12-02 09:37:59 +01:00
Code Issues Projects Releases Wiki Activity

Revert "Coerce value with array-offset to array|ArrayAccess"

Browse Source 
This reverts commit a8a67bc7e7.
This commit is contained in:
Matthew Brown 2019-08-07 00:36:45 -04:00
parent a8a67bc7e7
commit b5eb63bb2d
2 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Psalm/Type/Reconciler.php
View File

@ -125,10 +125,6 @@ class Reconciler
$new_base_key = $base_key . '[' . $array_key . ']'; $new_base_key = $base_key . '[' . $array_key . ']';
if (strpos($array_key, '\'') !== false) { if (strpos($array_key, '\'') !== false) {
if (!isset($existing_types[$base_key])) {
$new_types[$base_key][] = ['~array', '~ArrayAccess'];
}
$new_types[$base_key][] = ['!string']; $new_types[$base_key][] = ['!string'];
$new_types[$base_key][] = ['!=falsy']; $new_types[$base_key][] = ['!=falsy'];
} }

13
tests/ArrayAccessTest.php
View File

@ -528,19 +528,6 @@ class ArrayAccessTest extends TestCase
/** @psalm-suppress MixedPropertyFetch */ /** @psalm-suppress MixedPropertyFetch */
print_r([&$a->foo->bar]);', print_r([&$a->foo->bar]);',
], ],
'coerceAfterIsset' => [
'<?php
/**
* @return array|ArrayAccess
*/
function getBar(array $array) {
if (isset($array["foo"]["bar"])) {
return $array["foo"];
}
return [];
}'
],
]; ];
} }