danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-26 20:34:47 +01:00
Code Issues Projects Releases Wiki Activity

Prevent passing casts to byref vars

Browse Source
This commit is contained in:
Brown 2019-02-21 13:26:37 -05:00
parent 991fd90a12
commit b7a0950aea
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Psalm/Internal/Analyzer/Statements/Expression/CallAnalyzer.php
View File

@ -1211,6 +1211,7 @@ class CallAnalyzer
array $template_types = null
) {
if ($arg->value instanceof PhpParser\Node\Scalar
|| $arg->value instanceof PhpParser\Node\Expr\Cast
|| $arg->value instanceof PhpParser\Node\Expr\Array_
|| $arg->value instanceof PhpParser\Node\Expr\ClassConstFetch
|| (

9
tests/FunctionCallTest.php
View File

@ -1953,6 +1953,15 @@ class FunctionCallTest extends TestCase
}',
'error_message' => 'NullArgument',
],
'intCastByRef' => [
'<?php
function foo(int &$i) : void {}
$a = rand(0, 1) ? null : 5;
/** @psalm-suppress MixedArgument */
foo((int) $a);',
'InvalidPassByReference'
],
];
}
}