danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-26 20:34:47 +01:00
Code Issues Projects Releases Wiki Activity

Improve throw issue message

Browse Source
This commit is contained in:
Matthew Brown 2017-12-28 21:35:25 +01:00
parent b8c349166e
commit b96ab18d4b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Psalm/Checker/StatementsChecker.php
View File

@ -1093,7 +1093,7 @@ class StatementsChecker extends SourceChecker implements StatementsSource
return false;
}
if (isset($stmt->expr->inferredType) && !$stmt->expr->inferredType->isMixed()) {
if ($context->check_classes && isset($stmt->expr->inferredType) && !$stmt->expr->inferredType->isMixed()) {
$throw_type = $stmt->expr->inferredType;
$exception_type = new Union([new TNamedObject('Exception'), new TNamedObject('Throwable')]);
@ -1101,7 +1101,7 @@ class StatementsChecker extends SourceChecker implements StatementsSource
if (!TypeChecker::isContainedBy($project_checker, $throw_type, $exception_type)) {
if (IssueBuffer::accepts(
new InvalidThrow(
'Cannot throw ' . $throw_type,
'Cannot throw ' . $throw_type . ' as it does not extend Exception or implement Throwable',
new CodeLocation($this->source, $stmt)
),
$this->getSuppressedIssues()