danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-27 04:45:20 +01:00
Code Issues Projects Releases Wiki Activity

Simplify a bit of logic in switch analysis

Browse Source
This commit is contained in:
Matthew Brown 2021-05-13 17:31:17 -04:00
parent 18931295c4
commit bb8ce8817d
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Psalm/Internal/Analyzer/Statements/Block/SwitchCaseAnalyzer.php
View File

@ -203,7 +203,11 @@ class SwitchCaseAnalyzer
}
}
if (($switch_condition_type = $statements_analyzer->node_data->getType($switch_condition))
if ($switch_condition instanceof PhpParser\Node\Expr\ConstFetch
&& $switch_condition->name->parts === ['true']
) {
$case_equality_expr = $case->cond;
} elseif (($switch_condition_type = $statements_analyzer->node_data->getType($switch_condition))
&& ($case_cond_type = $statements_analyzer->node_data->getType($case->cond))
&& (($switch_condition_type->isString() && $case_cond_type->isString())
|| ($switch_condition_type->isInt() && $case_cond_type->isInt())