danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-27 04:45:20 +01:00
Code Issues Projects Releases Wiki Activity

fix comparison

Browse Source
This commit is contained in:
orklah 2021-07-31 15:30:32 +02:00
parent a6fa63a0cf
commit c5165710d3
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/Psalm/Internal/Type/Comparator/ScalarTypeComparator.php
View File

@ -412,12 +412,18 @@ class ScalarTypeComparator
if ($input_type_part instanceof TInt && $container_type_part instanceof TIntRange) {
if ($input_type_part instanceof TPositiveInt) {
if ($container_type_part->min_bound <= 0) {
if ($container_type_part->min_bound > 0) {
//any positive int can't be pushed inside a range with a min > 0
if ($atomic_comparison_result) {
$atomic_comparison_result->type_coerced = true;
$atomic_comparison_result->type_coerced_from_scalar = true;
}
return false;
}
if ($container_type_part->max_bound === null) {
//any positive int can't be pushed inside a range with no max without coercion
if ($container_type_part->max_bound !== null) {
//any positive int can't be pushed inside a range where the max bound isn't max without coercion
if ($atomic_comparison_result) {
$atomic_comparison_result->type_coerced = true;
$atomic_comparison_result->type_coerced_from_scalar = true;