danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-27 04:45:20 +01:00
Code Issues Projects Releases Wiki Activity

reworked one known operand case

Browse Source
This commit is contained in:
ebakulin 2023-02-28 00:12:18 +07:00
parent 31fcbd5f69
commit cf35b3ce0c
1 changed files with 8 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/Psalm/Internal/Analyzer/Statements/Expression/BinaryOp/ConcatAnalyzer.php
View File

@ -284,34 +284,16 @@ class ConcatAnalyzer
*/
$known_operand = $right_type ?? $left_type;
$numeric_type = new Union([
new TNumericString,
new TInt,
new TFloat,
]);
if ($known_operand->isSingle()) {
$known_operands_atomic = $known_operand->getSingleAtomic();
$non_empty_string = $numeric_type->getBuilder()->addType(new TNonEmptyString())->freeze();
if ($known_operands_atomic instanceof TNonEmptyString) {
$result_type = Type::getNonEmptyString();
}
$non_falsy_string = $numeric_type->getBuilder()->addType(new TNonFalsyString())->freeze();
$known_operand_not_empty = UnionTypeComparator::isContainedBy(
$codebase,
$known_operand,
$non_empty_string,
);
$known_operand_not_falsy = UnionTypeComparator::isContainedBy(
$codebase,
$known_operand,
$non_falsy_string,
);
if ($known_operand_not_empty) {
$result_type = Type::getNonEmptyString();
}
if ($known_operand_not_falsy) {
$result_type = Type::getNonFalsyString();
if ($known_operands_atomic instanceof TNonFalsyString) {
$result_type = Type::getNonFalsyString();
}
}
}
}