danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-27 04:45:20 +01:00
Code Issues Projects Releases Wiki Activity

Fix #608 - only check callable type if string/array is not also there

Browse Source
This commit is contained in:
Matthew Brown 2018-03-20 08:58:05 -04:00
parent 8dcb878af4
commit d17058e7d5
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Psalm/Checker/Statements/Expression/CallChecker.php
View File

@ -1481,7 +1481,7 @@ class CallChecker
} }
} }
if (!$has_valid_method) { if (!$has_valid_method && !$param_type->hasString() && !$param_type->hasArray()) {
if (MethodChecker::checkMethodExists( if (MethodChecker::checkMethodExists(
$project_checker, $project_checker,
$non_existent_method_ids[0], $non_existent_method_ids[0],
@ -1493,7 +1493,7 @@ class CallChecker
} }
} }
} else { } else {
if (self::checkFunctionExists( if (!$param_type->hasString() && !$param_type->hasArray() && self::checkFunctionExists(
$statements_checker, $statements_checker,
$function_id, $function_id,
$code_location, $code_location,

9
tests/ClosureTest.php
View File

@ -206,6 +206,15 @@ class ClosureTest extends TestCase
new A([new A, new A]);', new A([new A, new A]);',
], ],
'possiblyUndefinedFunction' => [
'<?php
/**
* @param string|callable $middlewareOrPath
*/
function pipe($middlewareOrPath, ?callable $middleware = null): void { }
pipe("zzzz", function() : void {});',
],
]; ];
} }