danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-26 20:34:47 +01:00
Code Issues Projects Releases Wiki Activity

Fix #1398 - improve casting rules for resource

Browse Source
This commit is contained in:
Matthew Brown 2019-03-01 00:50:22 -05:00
parent 42d4156423
commit d1cf9d61ba
2 changed files with 35 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
src/Psalm/Internal/Analyzer/Statements/ExpressionAnalyzer.php
View File

@ -416,33 +416,35 @@ class ExpressionAnalyzer
return false;
}
$container_type = Type::getString();
if (isset($stmt->expr->inferredType)
&& !$stmt->expr->inferredType->hasMixed()
&& !isset($stmt->expr->inferredType->getTypes()['resource'])
&& !TypeAnalyzer::isContainedBy(
$statements_analyzer->getCodebase(),
$stmt->expr->inferredType,
$container_type,
true,
false,
$has_scalar_match
)
&& !$has_scalar_match
) {
if (IssueBuffer::accepts(
new InvalidCast(
$stmt->expr->inferredType->getId() . ' cannot be cast to ' . $container_type,
new CodeLocation($statements_analyzer->getSource(), $stmt)
),
$statements_analyzer->getSuppressedIssues()
)) {
return false;
if (isset($stmt->expr->inferredType)) {
foreach ($stmt->expr->inferredType->getTypes() as $atomic_type) {
if (!$atomic_type instanceof TMixed
&& !$atomic_type instanceof Type\Atomic\TResource
&& !$atomic_type instanceof TNull
&& !TypeAnalyzer::isAtomicContainedBy(
$statements_analyzer->getCodebase(),
$atomic_type,
new TString(),
true,
false,
$has_scalar_match
)
&& !$has_scalar_match
) {
if (IssueBuffer::accepts(
new InvalidCast(
$atomic_type->getId() . ' cannot be cast to string',
new CodeLocation($statements_analyzer->getSource(), $stmt)
),
$statements_analyzer->getSuppressedIssues()
)) {
return false;
}
}
}
}
$stmt->inferredType = $container_type;
$stmt->inferredType = Type::getString();
} elseif ($stmt instanceof PhpParser\Node\Expr\Cast\Object_) {
if (self::analyze($statements_analyzer, $stmt->expr, $context) === false) {
return false;

9
tests/ToStringTest.php
View File

@ -186,6 +186,15 @@ class ToStringTest extends TestCase
takesString($a);',
'error_message' => 'InvalidArgument',
],
'resourceOrFalseToString' => [
'<?php
$a = fopen("php://memory", "r");
if (rand(0, 1)) {
$a = [];
}
$b = (string) $a;',
'error_message' => 'InvalidCast',
],
];
}
}