danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-27 04:45:20 +01:00
Code Issues Projects Releases Wiki Activity

float/int always 1 on "error", no PossiblyInvalidCasts by default

Browse Source
This commit is contained in:
kkmuffme 2022-08-03 23:48:49 +02:00
parent 39ec75523e
commit d32efb0619
1 changed files with 22 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
src/Psalm/Internal/Analyzer/Statements/Expression/CastAnalyzer.php
View File

@ -471,32 +471,25 @@ class CastAnalyzer
continue;
}
// always 1 for "error" cases
$valid_ints[] = new TLiteralInt(1);
$invalid_casts[] = $atomic_type->getId();
}
if ($invalid_casts) {
if ( $valid_ints || $castable_types ) {
IssueBuffer::maybeAdd(
new PossiblyInvalidCast(
$invalid_casts[0] . ' cannot be cast to int',
new CodeLocation( $statements_analyzer->getSource(), $stmt )
),
$statements_analyzer->getSuppressedIssues()
);
} else {
IssueBuffer::maybeAdd(
new InvalidCast(
$invalid_casts[0] . ' cannot be cast to int',
new CodeLocation( $statements_analyzer->getSource(), $stmt )
),
$statements_analyzer->getSuppressedIssues()
);
}
IssueBuffer::maybeAdd(
new InvalidCast(
$invalid_casts[0] . ' cannot be cast to int',
new CodeLocation($statements_analyzer->getSource(), $stmt)
),
$statements_analyzer->getSuppressedIssues()
);
} elseif (!empty($possibly_unwanted_cast)) {
IssueBuffer::maybeAdd(
new PossiblyInvalidCast(
'Casting ' . $possibly_unwanted_cast[0] . ' to int has possibly unintended value of 1',
new CodeLocation( $statements_analyzer->getSource(), $stmt )
new CodeLocation($statements_analyzer->getSource(), $stmt)
),
$statements_analyzer->getSuppressedIssues()
);
@ -703,32 +696,25 @@ class CastAnalyzer
continue;
}
// always 1.0 for "error" cases
$valid_floats[] = new TLiteralFloat(1.0);
$invalid_casts[] = $atomic_type->getId();
}
if ($invalid_casts) {
if ( $valid_floats || $castable_types ) {
IssueBuffer::maybeAdd(
new PossiblyInvalidCast(
$invalid_casts[0] . ' cannot be cast to float',
new CodeLocation( $statements_analyzer->getSource(), $stmt )
),
$statements_analyzer->getSuppressedIssues()
);
} else {
IssueBuffer::maybeAdd(
new InvalidCast(
$invalid_casts[0] . ' cannot be cast to float',
new CodeLocation( $statements_analyzer->getSource(), $stmt )
),
$statements_analyzer->getSuppressedIssues()
);
}
IssueBuffer::maybeAdd(
new InvalidCast(
$invalid_casts[0] . ' cannot be cast to float',
new CodeLocation($statements_analyzer->getSource(), $stmt)
),
$statements_analyzer->getSuppressedIssues()
);
} elseif (!empty($possibly_unwanted_cast)) {
IssueBuffer::maybeAdd(
new PossiblyInvalidCast(
'Casting ' . $possibly_unwanted_cast[0] . ' to float has possibly unintended value of 1.0',
new CodeLocation( $statements_analyzer->getSource(), $stmt )
new CodeLocation($statements_analyzer->getSource(), $stmt)
),
$statements_analyzer->getSuppressedIssues()
);