danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-12-12 01:09:38 +01:00
Code Issues Projects Releases Wiki Activity

allow arithmetics on variables as long as we're out of loops

Browse Source
This commit is contained in:
orklah 2021-09-20 12:09:27 +02:00
parent 012b65de78
commit d3d11471b7
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Psalm/Internal/Analyzer/Statements/Expression/BinaryOp/ArithmeticOpAnalyzer.php
View File

@ -311,8 +311,12 @@ class ArithmeticOpAnalyzer
): ?Type\Union {
if ($left_type_part instanceof TLiteralInt
&& $right_type_part instanceof TLiteralInt
&& !$left instanceof PhpParser\Node\Expr\Variable
&& !$right instanceof PhpParser\Node\Expr\Variable
&& (
//we don't try to do arithmetics on variables in loops
$context === null
|| $context->inside_loop === false
|| (!$left instanceof PhpParser\Node\Expr\Variable && !$right instanceof PhpParser\Node\Expr\Variable)
)
) {
// time for some arithmetic!
$calculated_type = self::arithmeticOperation(