danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-22 05:41:20 +01:00
Code Issues Projects Releases Wiki Activity

allow signature type for promoted property as well as property docblock (that will be used for param as well)

Browse Source
This commit is contained in:
orklah 2021-11-09 19:38:18 +01:00
parent f327c986d0
commit d409c063f3
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Psalm/Internal/PhpVisitor/Reflector/FunctionLikeNodeScanner.php
View File

@ -606,7 +606,7 @@ class FunctionLikeNodeScanner
}
//both way to document type were used
if ($param_storage->type && $var_comment_type) {
if ($param_storage->type && $param_storage->type->from_docblock && $var_comment_type) {
if (IssueBuffer::accepts(
new InvalidDocblock(
'Param ' . $param_storage->name . ' of ' . $cased_function_id .
@ -625,7 +625,7 @@ class FunctionLikeNodeScanner
$property_storage = $classlike_storage->properties[$param_storage->name] = new PropertyStorage();
$property_storage->is_static = false;
$property_storage->type = $param_storage->type ?? $var_comment_type;
$property_storage->type = $param_storage->type;
$property_storage->signature_type = $param_storage->signature_type;
$property_storage->signature_type_location = $param_storage->signature_type_location;
$property_storage->type_location = $param_storage->type_location;

13
tests/AnnotationTest.php
View File

@ -1319,6 +1319,19 @@ class AnnotationTest extends TestCase
new UserRole(new stdClass(), new stdClass());
'
],
'promotedPropertiesDocumentationForPropertyAndSignature' => [
'<?php
final class A
{
public function __construct(
/**
* @var iterable<string>
*/
private iterable $strings,
) {
}
}'
],
];
}