danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-22 05:41:20 +01:00
Code Issues Projects Releases Wiki Activity

Allow cloning interfaces

Browse Source
This commit is contained in:
Brown 2020-07-01 11:14:31 -04:00
parent fca350c498
commit e13da22292
1 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/Psalm/Internal/Analyzer/Statements/Expression/CloneAnalyzer.php
View File

@ -25,8 +25,7 @@ class CloneAnalyzer
Context $context
) : bool {
$codebase = $statements_analyzer->getCodebase();
$codebase_methods = $statements_analyzer->getCodebase()->methods;
$codebase_methods = $codebase->methods;
if (ExpressionAnalyzer::analyze($statements_analyzer, $stmt->expr, $context) === false) {
return false;
}
@ -52,7 +51,7 @@ class CloneAnalyzer
} elseif ($clone_type_part instanceof TObject) {
$possibly_valid = true;
} elseif ($clone_type_part instanceof TNamedObject) {
if (!$codebase->classlikes->classExists($clone_type_part->value)) {
if (!$codebase->classlikes->classOrInterfaceExists($clone_type_part->value)) {
$invalid_clones[] = $clone_type_part->getId();
} else {
$clone_method_id = new \Psalm\Internal\MethodIdentifier(
@ -65,17 +64,11 @@ class CloneAnalyzer
$context->calling_method_id,
new CodeLocation($statements_analyzer->getSource(), $stmt)
);
$is_method_visible = false;
if ($does_method_exist) {
$is_method_visible = MethodAnalyzer::isMethodVisible(
$clone_method_id,
$context,
$statements_analyzer->getSource()
);
}
$is_method_visible = MethodAnalyzer::isMethodVisible(
$clone_method_id,
$context,
$statements_analyzer->getSource()
);
if ($does_method_exist && !$is_method_visible) {
$invalid_clones[] = $clone_type_part->getId();
} else {