1
0
mirror of https://github.com/danog/psalm.git synced 2025-01-21 21:31:13 +01:00

Add explanation for MixedMethodCall

This commit is contained in:
Matthew Brown 2020-03-21 17:33:37 -04:00
parent e6a0fe0973
commit e5579332cd

View File

@ -5,8 +5,62 @@ Emitted when calling a method on a value that Psalm cannot infer a type for
```php
<?php
/** @param mixed $a */
function foo($a) : void {
$a->foo();
class A {
public function foo() : void {}
}
function callFoo(array $arr) : void {
array_pop($arr)->foo(); // MixedMethodCall emitted here
}
callFoo(
[new A()]
);
```
## Why this is bad
If Psalm doesnt know what `array_pop($arr)` is, it can't verify whether `array_pop($arr)->foo()` will work or not.
## How to fix
Make sure that to provide as much type information as possible to Psalm so that it can perform inference. For example, you could add a docblock to the `callFoo` function:
```php
<?php
class A {
public function foo() : void {}
}
/**
* @param array<A> $arr
*/
function callFoo(array $arr) : void {
array_pop($arr)->foo(); // MixedMethodCall emitted here
}
callFoo(
[new A()]
);
```
Alternatively you could add a runtime check:
```php
<?php
class A {
public function foo() : void {}
}
function callFoo(array $arr) : void {
$a = array_pop($arr);
assert($a instanceof A);
$a->foo(); // MixedMethodCall emitted here
}
callFoo(
[new A()]
);
```