From f24f361a95170d97bf9766d6f883110c041d63cb Mon Sep 17 00:00:00 2001
From: Bruce Weirdan <weirdan@gmail.com>
Date: Tue, 22 Jun 2021 21:20:10 +0300
Subject: [PATCH] Add documentation and schema entry for
 inferPropertyTypesFromConstructor

Fixes vimeo/psalm#5974
---
 config.xsd                          | 1 +
 docs/running_psalm/configuration.md | 9 +++++++++
 tests/Config/ConfigTest.php         | 9 +++++++++
 3 files changed, 19 insertions(+)

diff --git a/config.xsd b/config.xsd
index b8c55a9fa..ddc88d4f6 100644
--- a/config.xsd
+++ b/config.xsd
@@ -59,6 +59,7 @@
         <xs:attribute name="ignoreInternalFunctionFalseReturn" type="xs:boolean" default="true" />
         <xs:attribute name="ignoreInternalFunctionNullReturn" type="xs:boolean" default="true" />
         <xs:attribute name="includePhpVersionsInErrorBaseline" type="xs:boolean" default="false" />
+        <xs:attribute name="inferPropertyTypesFromConstructor" type="xs:boolean" default="true" />
         <xs:attribute name="loadXdebugStub" type="xs:boolean">
             <xs:annotation>
                 <xs:documentation xml:lang="en">
diff --git a/docs/running_psalm/configuration.md b/docs/running_psalm/configuration.md
index 1150e08ce..7cd85f6fb 100644
--- a/docs/running_psalm/configuration.md
+++ b/docs/running_psalm/configuration.md
@@ -213,6 +213,15 @@ When `true`, Psalm ignores possibly-false issues stemming from return values of
 ```
 When `true`, Psalm ignores possibly-null issues stemming from return values of internal array functions (like `current`) that may return null, but do so rarely. Defaults to `true`.
 
+#### inferPropertyTypesFromConstructor
+
+```xml
+<psalm
+  inferPropertyTypesFromConstructor="[bool]"
+>
+```
+When `true`, Psalm infers property types from assignments seen in straightforward constructors. Defaults to `true`.
+
 #### findUnusedVariablesAndParams
 ```xml
 <psalm
diff --git a/tests/Config/ConfigTest.php b/tests/Config/ConfigTest.php
index 8cb301070..531a6e4f3 100644
--- a/tests/Config/ConfigTest.php
+++ b/tests/Config/ConfigTest.php
@@ -1341,6 +1341,15 @@ class ConfigTest extends \Psalm\Tests\TestCase
         $this->assertContains('datetime', $this->project_analyzer->getConfig()->getUniversalObjectCrates());
     }
 
+    public function testInferPropertyTypesFromConstructorIsRead(): void
+    {
+        $cfg = Config::loadFromXML(
+            dirname(__DIR__, 2),
+            '<?xml version="1.0"?><psalm inferPropertyTypesFromConstructor="false"></psalm>'
+        );
+        $this->assertFalse($cfg->infer_property_types_from_constructor);
+    }
+
     /**
      * @return array<string, array{0: int, 1: int|null}>
      */