danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-21 21:31:13 +01:00
Code Issues Projects Releases Wiki Activity

Setting values on templated arrays should corrupt them

Browse Source
This commit is contained in:
Matt Brown 2021-05-05 00:46:43 -04:00
parent ba90267ea7
commit f95458be61
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/Psalm/Internal/Analyzer/Statements/Expression/Assignment/ArrayAssignmentAnalyzer.php
View File

@ -274,7 +274,24 @@ class ArrayAssignmentAnalyzer
$has_matching_objectlike_property = false;
$has_matching_string = false;
$child_stmt_type = clone $child_stmt_type;
foreach ($child_stmt_type->getAtomicTypes() as $type) {
if ($type instanceof Type\Atomic\TTemplateParam) {
$type->as = self::updateTypeWithKeyValues(
$codebase,
$type->as,
$current_type,
$key_values
);
$has_matching_objectlike_property = true;
$child_stmt_type->substitute(new Type\Union([$type]), $type->as);
continue;
}
foreach ($key_values as $key_value) {
if ($type instanceof TKeyedArray) {
if (isset($type->properties[$key_value->value])) {