1
0
mirror of https://github.com/danog/psalm.git synced 2024-12-14 18:36:58 +01:00
Commit Graph

4731 Commits

Author SHA1 Message Date
orklah
411399b600 Fixup!!! don't allow checks on literals 2022-01-05 12:22:44 +01:00
orklah
83a02d9a61 Fixup!!! don't allow checks on literals 2022-01-05 12:21:50 +01:00
orklah
5c0fc46734 Fixup!!! be more flexible on loose_equality for strings 2022-01-05 12:10:32 +01:00
Bruce Weirdan
dd09450092
Applied NullCoalescingOperatorRector 2022-01-05 13:09:37 +02:00
Bruce Weirdan
758e0afd96
Merge branch 'master' into rector-literal-number-separator 2022-01-05 12:32:52 +02:00
orklah
3fc8139205 Fixup!!! only allow general TInt to pass 2022-01-05 11:17:39 +01:00
orklah
950710a47a Fixup!!! make sure to add atomics with the correct offset key 2022-01-05 09:58:56 +01:00
orklah
36349a1370 refactor literal string equality check 2022-01-05 09:52:47 +01:00
orklah
2ada8ee8b0 refactor literal int equality check 2022-01-05 09:52:47 +01:00
orklah
a8c2fcde76 resolve ClassConst before checking equalities and fix things 2022-01-05 09:52:47 +01:00
Matthew Brown
f5d6d2380f Remove now-unnecessary code
Originally added in 8bc17e47be
2022-01-05 01:54:00 +00:00
Matthew Brown
7595a3c579 Make treatment of interfaces and classes more symmetrical 2022-01-05 01:10:57 +00:00
Matthew Brown
31dd30f3d1 Reduce by-ref args 2022-01-05 00:50:09 +00:00
Matthew Brown
26de4faa51 Unify names with intersection creation 2022-01-05 00:38:40 +00:00
Matthew Brown
0a78b320da Remove commas for now 2022-01-04 23:15:16 +00:00
Matthew Brown
9e64375e25 Break up two intersection methods
At some later date it may be worth seeing whether these can be consolidated into a single intersection method
2022-01-04 23:09:02 +00:00
Bruce Weirdan
5758d31161
Apply literal number separator rector
I opted for customary 3-digit groups, except version id, where 2-digit
groups are used to match the version id encoding.
2022-01-05 01:00:05 +02:00
Bruce Weirdan
0c13d8e719
Indent heredoc
PHP 7.3 allows indenting of heredoc / nowdoc strings.
2022-01-04 19:57:41 +02:00
Bruce Weirdan
f5dc2ee964
Merge branch '4.x' into upstream-master 2022-01-04 19:42:08 +02:00
Matthew Brown
63f3460df7 Make clear that class string check for trait $this key only applies to certain assertions 2022-01-04 17:08:34 +00:00
Matthew Brown
4e81d0c5ab Remove an untested chunk of issue-triggering code that has only ever caused anguish 2022-01-04 16:36:33 +00:00
Matthew Brown
0fffb55a83 Simplify some logic around negations to prevent unecessary looping 2022-01-04 16:08:06 +00:00
Matthew Brown
2c6d4f8687 Fix erroneous intersection
Found during a line-for-line port. We’re using this value in two different places, and it only makes sense to use it in one
2022-01-04 16:04:36 +00:00
Fabien Villepinte
c42f3d51bd
Fix typo 2022-01-04 16:27:06 +01:00
Fabien Villepinte
2f3af4a5bc
Remove unused import 2022-01-04 16:13:48 +01:00
Fabien Villepinte
1fa6b612b1
Fix parse_url() return type 2022-01-04 16:09:18 +01:00
Bruce Weirdan
02b91cc54e
Replaced deprecated webmozart/path-util 2022-01-04 15:15:34 +02:00
Bruce Weirdan
30013cb81a
Drop orphaned token
Refs vimeo/psalm#7285
2022-01-04 10:13:44 +02:00
Bruce Weirdan
ff9b214f65
Merge branch '4.x' into upstream-master 2022-01-04 10:07:18 +02:00
orklah
6f9cbc698b resolve type alias and class const on UnionTypeComparator 2022-01-04 00:14:08 +01:00
orklah
a53b5215b8 add missing phpdoc 2022-01-03 23:52:48 +01:00
orklah
e3bb251757 handle cases where the classconst contains a compatible int type 2022-01-03 23:45:23 +01:00
orklah
6ea950c2eb Identify ints from TClassConstant when checking for LiteralEquality 2022-01-03 23:40:39 +01:00
orklah
6905daedd7 handle the case where the expansion was not successful 2022-01-03 23:30:36 +01:00
orklah
60732d00ba resolve ClassConstant for both sides in isContainedBy 2022-01-03 23:21:59 +01:00
Bruce Weirdan
afa6497051
Dropped THtmlEscapedString 2022-01-03 22:48:59 +02:00
Bruce Weirdan
dbee118812
Moved getPsalmHelpText() to Cli\Psalm 2022-01-03 20:46:24 +02:00
Bruce Weirdan
401c2e9a83
Dropped deprecated TypeAnalyzer methods 2022-01-03 19:48:43 +02:00
Bruce Weirdan
2e24a16cbb
Dropped legacy plugin API 2022-01-03 18:18:44 +02:00
Bruce Weirdan
b924032850
Mark internal classes @internal 2022-01-03 09:33:22 +02:00
Bruce Weirdan
ab60d311c2
Merge pull request #7188 from vimeo/muglug-use-invalidscalarargument-less 2022-01-03 06:04:42 +02:00
Bruce Weirdan
966b6ae2b2
Merge pull request #6808 from orklah/exitFunctions3 2022-01-03 06:04:01 +02:00
Bruce Weirdan
f19e4cedc1
Merge pull request #6705 from orklah/phpstorm-generics-removal 2022-01-03 06:03:36 +02:00
Bruce Weirdan
13bb638b60
Drop remaining Type::getEmpty() references 2022-01-03 04:11:02 +02:00
orklah
d912663da4
remove isEmpty 2022-01-03 04:10:41 +02:00
Matthew Brown
83911c7408
Remove unnecessary references to empty in TypeCombiner 2022-01-03 04:10:41 +02:00
Matthew Brown
2358b96f54
Fix merge errors 2022-01-03 04:10:39 +02:00
orklah
0747b48d06
remove TEmpty 2022-01-03 04:09:59 +02:00
Bruce Weirdan
2f50070410
Merge pull request #6898 from orklah/php-version-consistency 2022-01-03 03:26:47 +02:00
orklah
33628cad51
Merge pull request #7239 from DeyV/master
Move from deprecated Composer 1 to Composer 2 runtime api
2022-01-02 18:35:54 +01:00
Dawid 'DeyV' Polak
7172f4bdbe missing default value for $version 2022-01-02 18:13:02 +01:00
orklah
b658b2738f
remove exitFunctions 2022-01-02 15:20:01 +02:00
orklah
48de574777
remove support for allowPhpstormGenerics 2022-01-02 15:07:46 +02:00
orklah
4f7c1d05c1
remove support for allowPhpstormGenerics 2022-01-02 15:06:04 +02:00
Matthew Brown
1e115da372
Add better docs to TypeComparisonResult 2022-01-02 14:56:18 +02:00
Matthew Brown
b419c299e3
Use InvalidScalarArgument only when we can be sure PHP attempts coercion 2022-01-02 14:56:18 +02:00
orklah
8d6b781b3e
use consistent way to compare php version 2022-01-02 13:35:43 +02:00
Bruce Weirdan
5362f3be91
Deprecate Codebase::$php_major_version and Codebase::$php_minor_version properties
Removed in #6898 (Psalm 5)
2022-01-02 13:22:37 +02:00
Bruce Weirdan
36d5a2a83c
Merge pull request #7019 from zoonru/no_ksort_list 2022-01-02 07:37:21 +02:00
Bruce Weirdan
697db76dc1
Merge pull request #7252 from AndrolGenhald/feature/allow-assertions-on-mutable-object-properties 2022-01-02 07:29:02 +02:00
Bruce Weirdan
047859b4a4
Merge pull request #7256 from tm1000/feature/remove-is-not-in-project-warnings 2022-01-02 07:15:20 +02:00
Bruce Weirdan
ab30a36803
Merge pull request #7255 from tm1000/feature/lang-server-code-actions 2022-01-02 05:38:06 +02:00
Bruce Weirdan
376d2a389e
Merge pull request #7259 from klimick/infer-this-context-for-psalm-if-this-is 2022-01-02 05:31:24 +02:00
orklah
6f4707aa41
Merge pull request #7263 from orklah/revert
revert #7054
2022-01-01 19:39:47 +01:00
orklah
de95fbdbf2 revert #7054 2022-01-01 19:34:17 +01:00
Matthew Brown
387f2664f7 Simplify isset reconciliation slightly 2022-01-01 16:01:27 +00:00
Matthew Brown
11f322c2fb Improve negated reconciliation logic 2022-01-01 13:10:28 +00:00
orklah
2a6f12296e
Merge pull request #7260 from orklah/6691
forbid calling impure callable in immutable context
2022-01-01 12:08:07 +01:00
adrew
0f69483cc1 Fix method storage fetching 2022-01-01 13:33:00 +03:00
orklah
8049438408 forbid calling impure callable in immutable context 2022-01-01 11:13:45 +01:00
adrew
79ea094433 Template resolving for psalm-if-this-is 2022-01-01 13:03:17 +03:00
adrew
878dfa2250 Variable types inference in method context when method marked with psalm-if-this-is 2022-01-01 13:03:17 +03:00
orklah
8dc1a31e11
Merge pull request #7247 from tm1000/bugfix/7246
Fixes #7246, wrap getTypeContextAtPosition in try/catch
2022-01-01 01:19:13 +01:00
Andrew Nagy
409910ce4c move conditional outside of try/catch 2021-12-31 23:30:29 +00:00
Andrew Nagy
e3116e0ab5 dont allow fallback functions 2021-12-31 23:17:27 +00:00
Andrew Nagy
f8f8f6bc41 fix SA and lint issues, prevent duplicate suppressions 2021-12-31 23:11:55 +00:00
Dawid 'DeyV' Polak
d43f2beed8 Fixed problems with test-with-real-projects 2021-12-31 15:15:04 +01:00
Andrew Nagy
6e32e9641f Remove "is not in project" warnings 2021-12-30 23:49:04 +00:00
Andrew Nagy
b2823ca034 fix psalm issues 2021-12-30 23:45:11 +00:00
orklah
51ba96c09d
Merge pull request #7253 from orklah/5874
allow calling mutation_free function inside a mutation_free context
2021-12-31 00:24:29 +01:00
Your Name
6c024b1d96 fix spaces 2021-12-30 15:13:01 -08:00
Your Name
6d14326375 Feat: Initial Support for Code Actions 2021-12-30 15:11:33 -08:00
AndrolGenhald
dd631c0c85 Skip reference tests, allow assertions on magic properties (fixes #6770). 2021-12-30 16:23:59 -06:00
orklah
392402cf6d allow calling mutation_free function inside a mutation_free context 2021-12-30 22:29:36 +01:00
AndrolGenhald
3ac497c811 Allow assertions on mutable object properties.
All of the functionality is already there, we just have to not prevent it.
2021-12-30 14:07:55 -06:00
adrew
2355f1bcdb Remove unused use 2021-12-30 22:46:18 +03:00
adrew
4a903c71a1 Checking psalm-if-this-is before applying psalm-this-out 2021-12-30 21:48:25 +03:00
Andrew Nagy
7379f516ae fix cs issues 2021-12-30 18:35:08 +00:00
Andrew Nagy
cb3cf887c4 Fixes #7246, wrap getTypeContextAtPosition in try/catch 2021-12-30 18:16:09 +00:00
7c24d33bb2
cs-fix 2021-12-30 11:36:56 +01:00
915ddcc620
Add new RedundantFunctionCall issues 2021-12-30 11:36:32 +01:00
82e24d5c1d
Disallow ksorting lists 2021-12-30 11:30:33 +01:00
Bruce Weirdan
03b7e94748
Merge pull request #7232 from trowski/issue-7196 2021-12-30 10:03:17 +02:00
Dawid 'DeyV' Polak
19c26f7263 Move from deprecated Composer 1 to Composer 2 runtime api 2021-12-29 16:20:14 +01:00
orklah
81ac645990 remove commented old code 2021-12-29 00:44:48 +01:00
orklah
f047d5bc53 allow suppressing unevaluatedCode 2021-12-29 00:44:48 +01:00
orklah
0b3e1299de overwritten properties 2021-12-27 23:46:23 +01:00
orklah
996def0d4d useless statements 2021-12-27 23:34:56 +01:00
orklah
ff62e71e0d immediately rewritten array index 2021-12-27 23:28:37 +01:00
orklah
bd1eb1611e immediately rewritten array index 2021-12-27 23:22:45 +01:00
orklah
ce1f992bcc remove useless statement 2021-12-27 23:11:40 +01:00
orklah
5f6bb39888 if with common parts 2021-12-27 23:08:19 +01:00
orklah
cb1e04b965 unnecessary statements 2021-12-27 23:02:01 +01:00
orklah
2baf3b560a unnecessary statements 2021-12-27 23:00:40 +01:00
Aaron Piotrowski
87160c8711
Handle first-class callable in yield types 2021-12-27 15:55:31 -06:00
orklah
926a56a97c
Merge pull request #7230 from orklah/cleanup6
code grooming
2021-12-27 22:54:39 +01:00
orklah
2bf5a71d46 fix CS 2021-12-27 22:37:30 +01:00
orklah
094ffb36f9 phpdoc issues 2021-12-27 22:30:10 +01:00
orklah
2499e02465 unnecessary array_push 2021-12-27 22:30:10 +01:00
orklah
65fffd2116 replace fully qualified names by imports 2021-12-27 22:30:10 +01:00
orklah
3828db52b9
Merge pull request #7229 from orklah/cleanup5
remove always true/false conditions
2021-12-27 22:08:06 +01:00
Aaron Piotrowski
e23a915bb1
Fix first-class callables when used with magic method, built-in, or undefined methods
Closes #7196.
2021-12-27 14:29:33 -06:00
orklah
3e29a3d961 unnecessary qualified names 2021-12-27 20:16:34 +01:00
orklah
3ae80983cc fix unused and CS 2021-12-27 20:10:39 +01:00
orklah
a9b1a42854 fix 2021-12-27 20:08:08 +01:00
orklah
9029e1d613 remove always true/false conditions 2021-12-27 19:59:11 +01:00
adrew
c0ca383020 Contextual inference for closure param types 2021-12-27 19:35:37 +03:00
sji
1c07813627
align handling of @psalm-internal 2021-12-27 02:31:14 +02:00
sji
a90456ed8b
trim whitespaces in namespaces specified at @psalm-internal 2021-12-27 02:31:11 +02:00
adrew
63a1c71c83
Remove trailing comma 2021-12-27 00:45:25 +02:00
adrew
d6d0fc6704
Remove undefined variables 2021-12-27 00:45:25 +02:00
adrew
2e4d75d6bd
Fix closure param type inference in generic context 2021-12-27 00:45:22 +02:00
Bruce Weirdan
fb56d5ce58
Merge pull request #7210 from vstm/improve-cli-utils-argv-handling 2021-12-27 00:35:32 +02:00
Bruce Weirdan
45c49b570a
Merge pull request #7211 from johnstevenson/xdebug-handler-3 2021-12-26 23:21:51 +02:00
Bruce Weirdan
13de27bb2f
Restore suppression for older XdebugHandler versions 2021-12-26 23:05:02 +02:00
John Stevenson
1cb58ad689
Keep XdebugHandler version 1 2021-12-26 23:00:53 +02:00
John Stevenson
015cc22fa7
Add XdebugHandler version 3 2021-12-26 23:00:50 +02:00
orklah
d4fcb7f61c handle literal equality with integer ranges 2021-12-26 21:09:27 +01:00
Bruce Weirdan
9387942463
Use strpos instead of str_contains
Fixes vimeo/psalm#7219 (str_contains was added in PHP 8)
2021-12-26 09:22:39 +02:00
Bruce Weirdan
08413d71bb
Restore attributes in ClassConstantStorage
This partially fixes BC break introduced in vimeo/psalm#7129
2021-12-26 02:24:01 +02:00
Matthew Brown
18c790eb99 Remove never-used equality flags 2021-12-24 14:05:44 +00:00
Matthew Brown
4dfc7ce6ee Prevent unnecessary construction of union types during truthiness checks 2021-12-24 13:31:09 +00:00
Matthew Brown
75e4e0b9a7 Revert "Inline possibly_undefined checks"
This reverts commit e2a01673b7.

This change was short-sighted
2021-12-24 13:15:30 +00:00
Matthew Brown
e2a01673b7 Inline possibly_undefined checks
These don’t really belong in truthiness methods, as possibly_undefined is a weird meta state
2021-12-24 13:10:19 +00:00
Stefan Vetsch
c3752b4a2b Fix psalm issues 2021-12-24 10:59:39 +01:00
Stefan Vetsch
5331091f5e Simplify argv handling, the first element is always the script name 2021-12-24 10:05:52 +01:00
orklah
2827c3e87b
Merge pull request #7203 from orklah/6389
flag the context as "inside_conditional" when analyzing leftover cases to prevent emitting unused error
2021-12-23 22:22:46 +01:00
orklah
79a97507d7
Merge pull request #7201 from dvz/early-file-filtering
Add early file filtering to `FileProvider::getFilesInDir()`
2021-12-23 22:19:39 +01:00
orklah
2c9541c1ed flag the context as "inside_conditional" when analyzing leftover cases to prevent emitting unused error 2021-12-23 22:18:27 +01:00
Matthew Brown
2a92db8fad Remove unused in-array assertions
These assertions cannot be parsed, since the `in-array` assertion handler always tries to convert assertions to a type
2021-12-22 19:47:20 +00:00
Tomasz Mlynski
c94364631b
Normalize variable name 2021-12-22 20:23:11 +01:00
Tomasz Mlynski
b3da242e78
Remove redundant projectDirs/extraDirs checks 2021-12-22 19:49:12 +01:00
Tomasz Mlynski
a514df2bb7
Use callable to filter files in FileProvider::getFilesInDir() 2021-12-22 19:47:57 +01:00
Philip Hofstetter
e8e968e8c2
recognize Deprecated attribute on enum cases
just like with properties, this recognizes both `Psalm\Deprecated` and
`JetBrains\PhpStorm\Deprecated`
2021-12-22 06:16:42 +01:00
Philip Hofstetter
d45cb64827
allow marking enum cases as @deprecated 2021-12-22 06:16:42 +01:00
orklah
cc9111ff48
Merge pull request #7161 from dvz/improve-project-files-discovery
Improve project files discovery performance
2021-12-21 22:31:39 +01:00
orklah
ca25b0f815 always unflag before leaving a analyzer 2021-12-21 18:30:29 +01:00
orklah
b1a1c65714 CS changes 2021-12-21 18:30:29 +01:00
orklah
56369a7ba6 fix wrong handling of flags in context 2021-12-21 18:30:29 +01:00
orklah
1eca2c32ae only emit PossiblyNullArrayAccess if there was no successful destructuring 2021-12-20 22:48:27 +01:00