danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-11 07:31:45 +01:00
Code Issues Projects Releases Wiki Activity
12,551 Commits 43 Branches 314 Tags 108 MiB
0cc770c947
Commit Graph

12551 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bitwise Operators
9f6ce3059d tests: added tests for bitwise-and, bitwise-xor, bitwise-not and boolean-not class constants 2022-08-04 08:52:43 +02:00
orklah
1ef3851580
Merge pull request #8364 from kkmuffme/add-but-to-differentiate-errors-invalidargument 
add ", but" for InvalidArgument error message where a type is provided
 2022-08-03 20:33:29 +02:00
kkmuffme
d2be169ce5 update tests 2022-08-03 20:12:18 +02:00
kkmuffme
0d32203f9a add ", but" for InvalidArgument error message where a type is provided 2022-08-03 19:40:30 +02:00
Bitwise Operators
a5c550cea4 Fix incorrect handling of null response 2022-08-03 18:27:32 +02:00
Bitwise Operators
f782313c45 Add BitwiseNot and BooleanNot operators to SimpleTypeInferer. Should fix #8307. 2022-08-03 15:48:54 +02:00
Marco Pivetta
68978b9e19 s/psalm-pure/psalm-mutation-free, since psalm-mutation-free is safer to use 
Ref: c205d652d1 (r934032422)

The idea is that `@psalm-pure` disallows `$this` usage in child classes,
which is not wanted, while `@psalm-mutation-free` allows it.

By using `@psalm-mutation-free`, we don't completely destroy inheritance
use-cases based on internal (immutable) state.
 2022-08-01 10:08:35 +02:00
Marco Pivetta
c205d652d1 DateTimeImmutable#sub() always returns another static instance, never false 2022-07-31 18:12:07 +02:00
Marco Pivetta
dcaf610b0a Removed @psalm-immutable marked from MyDate extending DateTimeImmutable 
`DateTimeImmutable` is not really immutable, therefore this marker was wrong upfront
 2022-07-31 18:08:01 +02:00
Marco Pivetta
b4b2bc66c7 Added better stubs for DateTimeImmutable, highlighting how the constructor is **NOT** immutable 
`DateTimeImmutable` is **almost** immutable: `DateTimeImmutable::__construct()` is in fact not a pure
method, since `new DateTimeImmutable('now')` produces a different value at each instantiation (by design).

This change makes sure that `DateTimeImmutable` loses its `@psalm-immutable` class-level marker,
preventing downstream misuse of the constructor inside otherwise referentially transparent code.

Note: only pure methods are stubbed here: all other methods declared by `DateTimeImmutable` (parent interface)
are NOT present here, and are either inferred from runtime reflection, or `CallMap*.php` definitions.

Methods are sorted in the order defined by reflection on PHP 8.1.8, at the time of writing this ( https://3v4l.org/3TGg8 ).

Following simplistic snippet was used to infer the current signature:

```php
<?php

$c = new \ReflectionClass(\DateTimeImmutable::class);

$methods = array_map(function ($m) {
    return $m->getName()
        . '(' . implode(',', array_map(function ($p) {
            return $p->getType()
                . ' $' . $p->getName()
                . ($p->isOptional() ? ' = ' . var_export($p->getDefaultValue(), true) : '');
        }, $m->getParameters())) . ')' . ($m->getReturnType() ? (': ' . $m->getReturnType()) : '');
}, $c->getMethods());

$properties = array_map(function ($m) {
    return $m->getName();
}, $c->getProperties());

var_dump($methods, $properties);
```
 2022-07-31 18:02:30 +02:00
orklah
6998fabb2b
Merge pull request #8349 from VincentLanglet/formatCurrency 
Fix formatCurrency return type
 2022-07-31 15:10:26 +02:00
Daniil Gentili
24f7920e9a
Fix if propagation (#8326) 
* Add failing unit test

* Fix test

* Revert "Add comment for skipped test"

This reverts commit e4f73beb08.

* Revert "Simplify context updates even more"

This reverts commit a32e63f131.

* Revert "Remove special handling for elseifs that breaks for else if"

This reverts commit d7d9ddc653.

* Fix test
 2022-07-30 19:20:05 -04:00
Vincent Langlet
90ac39d89f Fix formatCurrency return type 2022-07-30 23:31:21 +02:00
orklah
f5b7a569e2
Merge pull request #8345 from weirdan/rector-ArraySpreadInsteadOfArrayMergeRector-2 
Applied ArraySpreadInsteadOfArrayMergeRector (take 2)
 2022-07-30 09:18:15 +02:00
Bruce Weirdan
c9e6b54050
CS fix 2022-07-29 23:08:11 -04:00
Bruce Weirdan
7444ea8e2d
Simplify some methods to keep Psalm happy 2022-07-29 23:01:49 -04:00
Bruce Weirdan
238b54abf8
Revert one particular replacement that confuses Psalm 2022-07-29 22:00:21 -04:00
Bruce Weirdan
58e87fa5e0
Applied ArraySpreadInsteadOfArrayMergeRector (take 2) 2022-07-29 18:17:21 -04:00
orklah
dcc663625f
Merge pull request #8344 from mathroc/chore/update-ReflectionProperty-getValue-args-type 
ReflectionProperty::getValue $object is nullable since php 8.0
 2022-07-29 22:29:37 +02:00
Mathieu Rochette
14241d74b3
ReflectionProperty::getValue $object is nullable since php 8.0 
https://www.php.net/manual/en/reflectionproperty.getvalue.php
 2022-07-29 22:14:12 +02:00
AndrolGenhald
148264305f
Merge pull request #8341 from someniatko/issue-7731 
recognize `@psalm-allow-private-mutation` in PHP 8+ constructors
 2022-07-29 09:31:20 -05:00
someniatko
0abde258fa #7731 - recognize @psalm-allow-private-mutation in PHP 8+ constructors 2022-07-29 16:50:56 +03:00
AndrolGenhald
489706b92e
Merge pull request #8335 from someniatko/issue-8330 
#8330 - take into account that `static` type may have been unwrapped in `hasStaticInType()`
 2022-07-29 08:38:48 -05:00
someniatko
0c652f72f6 #8330 - take into account that static type may have been unwrapped in ExistingAtomicStaticCallAnalyzer#hasStaticInType() 2022-07-29 12:31:37 +03:00
orklah
7c4228fb56
Merge pull request #8324 from Nicelocal/fix_union_assertions 
Fix union assertions
 2022-07-28 19:06:14 +02:00
Daniil Gentili
7a7a7f6bc9
cs-fix 2022-07-28 12:05:13 +02:00
Daniil Gentili
33d8f3a62d
Fix unit tests 2022-07-28 12:03:12 +02:00
Daniil Gentili
abe58876a7
Fix 2022-07-27 20:32:44 +02:00
Daniil Gentili
6ce32a48d5
Fix 2022-07-27 20:24:24 +02:00
Daniil Gentili
68f3f246f5
Fix 2022-07-27 20:08:00 +02:00
Daniil Gentili
1a4d68e53b
Make private 2022-07-27 18:56:24 +02:00
Daniil Gentili
82e8c0dea8
Disable intersection of unrelated classes 2022-07-27 18:55:01 +02:00
Daniil Gentili
c409675e3e
Fix intersection of final classes 2022-07-27 18:46:07 +02:00
Daniil Gentili
c2a8d1bb06
cs 2022-07-27 18:00:24 +02:00
Daniil Gentili
e19589117d
Fix unit test 2022-07-27 17:56:41 +02:00
Daniil Gentili
37274b308f
Add temporary failing test 2022-07-27 17:51:55 +02:00
Daniil Gentili
09fb879428
Fix #8322, #8319 2022-07-27 17:42:48 +02:00
Daniil Gentili
18106af5e5
Refactor 2022-07-27 14:39:34 +02:00
orklah
63b389f54d
Merge pull request #8044 from AndrolGenhald/feature/improve-array-spreading 
Fix various array spread issues.
 2022-07-26 20:30:31 +02:00
AndrolGenhald
094621d5bb Fix array-shape value type being mixed instead of single key being mixed. 2022-07-26 12:00:05 -05:00
AndrolGenhald
ee68184527 Fix key comparison when unpacking Traversables. 2022-07-26 12:00:05 -05:00
AndrolGenhald
2b389df270 Use count instead of empty. 2022-07-26 12:00:05 -05:00
AndrolGenhald
d54eebfe02 Fix various array spread issues. 
- Correctly infer `array` and `list` instead of `non-empty-array` and `non-empty-list` (fixes #7296)
 - Add support for spreading string keys (fixes #7297).
 - Show issue when trying to unpack non-iterable
 - Show issue when trying to unpack iterable with non-array-key key
 - Re-added invalid PHP 8.0 tests removed in #6613
 - Unpacked lists with known keys will be inferred as eg `array{0: int, 1: int}<int<0, max>, int>` now but will still be treated as lists
 - Unpacked arrays with known keys will now be inferred as eg `array{a: string, b: string}<int, int>` instead of `array<int|string, int|string>`
 2022-07-26 12:00:03 -05:00
orklah
d7cd84c4eb
Merge pull request #8302 from kkmuffme/fix-cache-directory-race-conditions 
fix race conditions causing notices if directory does not exist
 2022-07-25 19:04:37 +02:00
AndrolGenhald
0b482ac020
Merge pull request #8312 from fluffycondor/dateperiod-stub 
Add stub for DatePeriod
 2022-07-25 09:27:40 -05:00
Semyon
b1295d6894 Code style 2022-07-25 17:15:28 +03:00
Semyon
462ce7138a Make DatePeriod implement Traversable oh PHP 7, rename constructor params 2022-07-25 17:11:36 +03:00
Semyon
9d3253482d Add stub for DatePeriod 2022-07-25 17:11:36 +03:00
orklah
4b2935f800
Merge pull request #8282 from drupol/stub/fix-cachingiterator 
Update `CachingIterator::getCache` stub.
 2022-07-22 19:38:06 +02:00
Pol Dellaiera
63b64532d6
Update CachingIterator, use int-mask-of. 2022-07-22 18:38:12 +02:00