1
0
mirror of https://github.com/danog/psalm.git synced 2024-11-27 04:45:20 +01:00
Commit Graph

554 Commits

Author SHA1 Message Date
Matthew Brown
6b4bd47ddb Fix #181 and #225 - resolve problems with self in comments/return statements 2017-10-07 10:22:52 -04:00
MacFJA
1c0bfc7e7a Fix call 2017-10-02 07:38:22 -04:00
MacFJA
e6e7462362 Add a test that validate code change (before modification fail / after modification work) 2017-10-02 07:38:22 -04:00
MacFJA
a38c36c597 Always generate report files, even if no errors and warnings 2017-10-02 07:38:22 -04:00
Matthew Brown
5bd6228708 Fix #220 - don’t worry about parent property access 2017-09-24 08:17:27 -04:00
Matthew Brown
3a8efec728 Add error for pass by reference 2017-09-16 13:16:21 -04:00
Matthew Brown
9a3cb742cb Refactor docblock manipulation and add tests for it 2017-09-16 12:45:20 -04:00
Matthew Brown
313e1c383c Fix edge-case issue with abstract class not fully implementing interface 2017-09-13 23:57:11 -04:00
Matt Brown
5b3531b5a5 Fix null coalescing on nullable output 2017-09-13 14:35:42 -04:00
Matt Brown
eee8442af6 Fix #199 - allow classes to suppress PropertyNotSetInConstructor warnings 2017-09-13 11:32:13 -04:00
Matt Brown
d1807cfb95 Improve checks for switch types 2017-09-11 11:58:11 -04:00
MacFJA
c4ce8bede9 Add XML as possible output format + add report generation (#206)
* Add XML as possible output format + add report generation

* Add missing xml root node

* Change XML generator (previous one don't escape '<' and '>')

* Change option (only one option) + unit test
2017-09-08 11:18:48 -04:00
Matthew Brown
e89a2929d5 Infer types from numeric operations 2017-09-06 21:44:26 -04:00
Matthew Brown
11aa3558b7 Make sure encapsulated strings can also coerce param types 2017-09-02 19:48:59 -04:00
Matthew Brown
a0c27cee4f Allow param types to be inferred from presence of concat ops 2017-09-02 19:23:00 -04:00
Matthew Brown
73694ab04e Suggest types when complaining of untype params
Ref #204
2017-09-02 18:15:52 -04:00
Matthew Brown
8aabcbce35 Introduce UntypedParam warnings when functions are missing param types 2017-09-02 11:18:56 -04:00
Matthew Brown
e4e6c2a6e6 Fix #201 - list/array assignment should invalidate clauses too 2017-08-18 23:14:38 -04:00
Matthew Brown
fbc6379275 Fix #202 - vars changed inside loops should invalidate clauses 2017-08-18 22:41:25 -04:00
Matt Brown
7f9529e8a3 Remove stray comma 2017-08-18 17:23:12 -04:00
Matt Brown
d65a777641 Fix test function declaration 2017-08-18 17:06:01 -04:00
Matt Brown
c626b7d68a Fix #200 - allow mapping of more callable strings, and callable arrays 2017-08-14 19:30:11 -04:00
Matt Brown
0b0e7aa662 Fix #197 - allow nested class and function definitions 2017-08-14 15:46:01 -04:00
Matt Brown
13d98b803d Check that callable string class exists first 2017-08-11 18:48:58 -04:00
Matt Brown
17a900ab54 Add ability to detect invalid callable functions 2017-08-11 18:30:58 -04:00
Matt Brown
4b5a5ead74 Fix paradox detection for multiple clauses 2017-08-07 18:38:38 -04:00
Matt Brown
69f494ccdc Add test for #169 2017-07-31 15:10:42 -04:00
Matthew Brown
4175295113 Isolate where we load static storage objects (#195)
* Move FileChecker::$storage calls to provider

* Add ClassLikeStorageProvider

* Use ClassLikeStorageProvider everywhere

* Move storage arrays into providers
2017-07-29 15:05:06 -04:00
Matthew Brown
c5952af6f0 Fix bug with trait implementing abstract method 2017-07-28 23:38:57 -04:00
Matt Brown
22b6dafe3c Fix #194 - carry over const definitions 2017-07-28 10:42:30 -04:00
Matthew Brown
22daecb8ad Fix phpcs error 2017-07-26 21:30:01 -04:00
Matt Brown
0e67565b2c Return null if path exists 2017-07-26 19:36:41 -04:00
Matthew Brown
df767e80a4 Move onto newline 2017-07-25 19:48:45 -04:00
Matt Brown
76ba419330 Group unused tests together 2017-07-25 17:04:58 -04:00
Matthew Brown
e29dd140e3 Refactor scanning and analysis, introducing multithreading (#191)
* Add failing test

* Add visitor to soup up classlike references

* Move a whole bunch of code into the visitor

* Move some methods back, move onto analysis stage

* Use the getAliases method everywhere

* Fix refs

* Fix more refs

* Fix some tests

* Fix more tests

* Fix include tests

* Shift config class finding to project checker and fix bugs

* Fix a few more tests

* transition test to new syntax

* Remove var_dump

* Delete a bunch of code and fix mutation test

* Remove unnecessary visitation

* Transition to better mocked out file provider, breaking some cached statement loading

* Use different scheme for naming anonymous classes

* Fix anonymous class issues

* Refactor file/statement loading

* Add specific property types

* Fix mapped property assignment

* Improve how we deal with traits

* Fix trait checking

* Pass Psalm checks

* Add multi-process support

* Delay console output until the end

* Remove PHP 7 syntax

* Update file storage with classes

* Fix scanning individual files and add reflection return types

* Always turn XDebug off

* Add quicker method of getting method mutations

* Queue return types for crawling

* Interpret all strings as possible classes once we see a `get_class` call

* Check invalid return types again

* Fix template namespacing issues

* Default to class-insensitive file names for includes

* Don’t overwrite existing issues data

* Add var docblocks for scanning

* Add null check

* Fix loading of external classes in templates

* Only try to populate class when we haven’t yet seen it’s not a class

* Fix trait property accessibility

* Only ever improve docblock param type

* Make param replacement more robust

* Fix static const missing inferred type

* Fix a few more tests

* Register constant definitions

* Fix trait aliasing

* Skip constant type tests for now

* Fix linting issues

* Make sure caching is off for tests

* Remove unnecessary return

* Use emulative parser if on PHP 5.6

* Cache parser for faster first-time parse

* Fix constant resolution when scanning classes

* Remove test that’s beyond a practical scope

* Add back --diff support

* Add --help for --threads

* Remove unused vars
2017-07-25 16:11:02 -04:00
Matthew Brown
b4542316fa Take out unnecessary analysis step 2017-07-16 15:41:45 -04:00
Matt Brown
592194e9f2 Fix #187 by splitting abs into int and float versions 2017-07-14 18:09:25 -04:00
Matt Brown
d163b28cbf Add skipped interface test for #175 2017-07-10 10:35:00 -04:00
Matthew Brown
e60f085741 Fix #178 - complain when encountering bad @return type 2017-07-09 20:32:35 -04:00
Matthew Brown
581cf5f7eb Don’t allow trait to override non-abstract method definition for parent class 2017-07-09 15:54:43 -04:00
Matthew Brown
32ff386b4a Fix #184 - prevent classes without reflected classes from breaking everything 2017-07-09 14:36:06 -04:00
Matthew Brown
67338c4bf5 Also detect non-inherited private constructors 2017-07-08 22:01:26 -04:00
Matthew Brown
c7b0f6685f Make Psalm a bit faster 2017-07-08 21:19:16 -04:00
Matthew Brown
91bdd65588 Fix #179 - check for abstract method instantiations 2017-06-30 10:24:47 -04:00
Matthew Brown
d8654b8389 Slow down Psalm by checking parent initialisations too 2017-06-30 01:24:45 -04:00
Matt Brown
3dceebc42f Make type combination less dependant on __toString 2017-06-29 17:40:25 -04:00
Matt Brown
fef589fb68 Fix issue with array access on property 2017-06-29 17:39:46 -04:00
Matt Brown
055e9768bd Fix typehints of testing trait 2017-06-29 10:25:41 -04:00
Matt Brown
ac70ea31b2 Change test assertion keying 2017-06-29 10:22:49 -04:00
Matthew Brown
8fd671bdc4 Fix #167 - prevent Empty type in assignment 2017-06-28 23:37:02 -04:00
Matthew Brown
bc35f88859 Fix issue with $this instanceof checks in traits 2017-06-23 00:39:37 -04:00
Matthew Brown
878696b72c Fix #173 - don’t emit MissingConstructor issues from trait constructor 2017-06-21 01:25:41 -04:00
Matt Brown
e5c25eae97 Fix #172 - make sure new coalesce vars escape brackets 2017-06-20 15:38:32 -04:00
Matt Brown
f0141cab4e Reproduce null coalesce issue 2017-06-20 14:38:58 -04:00
Matt Brown
10b511284a Improve null coalesce test and improve linting 2017-06-20 14:38:13 -04:00
Matt Brown
473040ca8f Fix #171 by supporting exit statements for fopen 2017-06-20 13:25:37 -04:00
Matt Brown
f4338c38e7 Fix #148 - suppress InvalidDocblock where appropriate 2017-06-13 14:00:41 -04:00
Matthew Brown
152d1512f1 Fix issue capturing method mutations in traits 2017-06-12 22:51:39 -04:00
Matthew Brown
72e1221a2f Fix #168 and add test case 2017-06-11 19:20:07 -04:00
Matt Brown
1745518c2c Fix #166 - prevent require loop 2017-06-06 10:11:34 -04:00
Matthew Brown
1fee30d065 Add trailing commas 2017-06-05 22:12:19 -04:00
Matthew Brown
81223c45e0 Fix #166 - return instead of looping infinitely 2017-06-05 21:46:04 +01:00
Matthew Brown
b79b9e9b8c Add breaking test 2017-06-05 15:21:03 +01:00
Matthew Brown
e99150b403 Refactor include tests to allow checking multiple files per test cc @ernunion 2017-06-01 23:16:45 -04:00
Matthew Brown
22a716f4da Improve formatting of phpdocs 2017-05-26 20:16:18 -04:00
Matthew Brown
d6909193ea Add additional formatting changes 2017-05-26 20:05:57 -04:00
Matthew Brown
688a72c794 Fix #36 - emit issues on deprecated properties 2017-05-25 01:32:34 -04:00
Matthew Brown
0fdf281896 Add support for @deprecated classes 2017-05-25 00:34:39 -04:00
Matthew Brown
44b4d04e0a Fix #95 - emit issue on private constructor calls 2017-05-24 23:55:54 -04:00
Matthew Brown
8f317cd8a2 Fix #133 - emit issue when calling no-constructor class with args 2017-05-24 23:11:40 -04:00
Matthew Brown
4fd46e1752 Improve formatting 2017-05-24 22:07:49 -04:00
Matthew Brown
42b435e23f Fix #134 - warn when docblock type is ill-formatted 2017-05-24 21:11:18 -04:00
Matthew Brown
92e184086f Fix #158 - prevent using resource in return type 2017-05-21 13:48:17 -04:00
Matthew Brown
4d020bcbdb Remove unnecessary imports in tests 2017-05-19 00:52:15 -04:00
Matt Brown
052624fa94 Fix issue calculating inherited parent property mutations 2017-05-12 19:15:08 -04:00
Matt Brown
39ece995b6 Add @psalm-ignore-nullable-return annotation 2017-05-10 12:36:11 -04:00
Matt Brown
a4bdca55e9 Fix sscanf test with new types 2017-05-05 19:56:45 -04:00
Matt Brown
77da5ca99e Fix #156 - allow objectlike arrays to be merged nicely 2017-05-05 18:53:45 -04:00
Matt Brown
df890fbfb0 Fix #155 - support @property declaration for classes with magic getters & setters 2017-05-04 18:35:05 -04:00
Matthew Brown
754a4d9950 Allow Psalm to be run outside of the directory it's installed in (#154)
* Add --root option when not running Psalm from root directory

* Add informative error when running Psalm outside of its project directory

* Add better message in help

* Fix autoloader precedence
2017-05-04 14:25:58 -04:00
Matt Brown
9cabf428c4 Only make isset $this->property mixed if not already defined 2017-04-28 16:41:54 -04:00
Jon Ursenbach
11bc153deb Rewriting and streamlining every unit test with data providers. (#147)
* Rewriting and streamlining every unit test with data providers.

All unit tests have been rewritten into PHPUnit data providers
to reduce the amount of unnecessary code-reuse through out the
test suite.
2017-04-24 23:45:02 -04:00
Matt Brown
dc26d2df04 Fix #144 - prevent innaccurate __toString warning 2017-04-21 14:23:09 -04:00
Matthew Brown
1a8cdc5da9 Allow two or more instanceof interface checks side by side 2017-04-15 21:25:53 -04:00
Matthew Brown
007442fdd0 Fix possibly-private error 2017-04-15 21:10:49 -04:00
Matthew Brown
f67e92023b Add support for intersection types
Fixes #140
2017-04-15 20:36:40 -04:00
Matthew Brown
eebaf5795d Fix regression dealing with union types from docblocks 2017-04-15 12:44:38 -04:00
Matthew Brown
a8bee2f843 Suggest missing property types for traits as well 2017-04-15 00:04:03 -04:00
Matthew Brown
0c4824b2cc Take property defaults into account when suggesting missing type 2017-04-14 23:46:55 -04:00
Matthew Brown
8d46c65815 Only make non-null if inside constructor 2017-04-14 23:26:58 -04:00
Matthew Brown
60be6f07a0 Delay checks for MissingPropertyType so we can give more useful messages 2017-04-14 23:09:34 -04:00
Matthew Brown
ce6ca58291 Fix #114 - add optional Hack-like checks calls 2017-04-14 21:32:14 -04:00
Vladimir Komissarov
818e3be00c Fix undefined global constant in closure 2017-04-14 17:03:09 +07:00
Matt Brown
7bcf7f13b1 Fix #137 - add for init in main scope 2017-04-11 17:43:46 -04:00
SignpostMarv
82c3a664a8 skip tests that extend SoapClient if SoapClient does not exist 2017-04-11 21:02:18 +01:00
Matt Brown
ed356bfbd0 Don’t mistake same-named functions for old-style constructors
Fixes #131
2017-04-10 11:03:19 -04:00
Matthew Brown
32efdfd0f7 Fix #129 - emit PossiblyNullFuntionCall when encountering such a thing 2017-04-08 11:38:06 -04:00
Matthew Brown
2d454d6e10 Fix #130 - check class exists before checking for __invoke 2017-04-08 11:15:17 -04:00
Matthew Brown
c663062816 Add PossiblyUndefinedArgument issue to cope with #126 2017-04-08 09:28:02 -04:00
Matthew Brown
7d17a07cd2 Fix #125 - allow abstract classes to reference methods only defined in interfaces 2017-04-07 19:16:25 -04:00
Matt Brown
f011197090 Fix #124 - don’t check array_filter closures when >2 args passed 2017-04-07 18:30:15 -04:00
Matthew Brown
40427839ea Get all variables possibly assigned in conditional 2017-04-06 22:56:37 -04:00
Matthew Brown
20b0460a33 Fix #123 - ternary byref vars now adjusted 2017-04-06 21:53:29 -04:00
Matt Brown
c09b0e459a Make is_numeric a proper type refinement 2017-04-06 18:06:24 -04:00
Matt Brown
e7aec27eae Prevent emitting issues when comparing mixed values 2017-04-06 17:40:15 -04:00
Matt Brown
da19b55db1 Add special TypeDoesNotContainNull issue as distinct from TypeDoesNotContainType 2017-04-06 15:36:22 -04:00
Matt Brown
14bb967c7d Warn when doing === comparisons on incompatible types 2017-04-06 14:53:45 -04:00
Matthew Brown
a63602ce45 change to trigger travis 2017-04-03 13:35:04 -04:00
Matthew Brown
89bf409537 Cast phpversion to string 2017-04-03 13:09:02 -04:00
Matthew Brown
431de10c5c Prevent array_filter test running on HHVM 2017-04-03 12:53:10 -04:00
Matt Brown
fe43c4e37f Fix #122 - allow multiple types of filtering 2017-04-03 12:36:49 -04:00
Matthew Brown
ce5b35169b Treat empty & !empty as special straddling types 2017-04-02 19:06:18 -04:00
Matthew Brown
a8220ba4f1 Fix bug where empty string could confuse 2017-04-02 18:28:06 -04:00
Matthew Brown
075cc5f50d Add by-reference clause removal 2017-04-02 17:37:56 -04:00
Matthew Brown
dcedd65215 Add check for paradoxical statements 2017-04-02 15:26:10 -04:00
Matthew Brown
83edf8c4db Complete the circle – fix remaining type algebra issue 2017-04-01 19:04:49 -04:00
Matt Brown
a4be86865d Skip Throwable in PHP < 7 2017-03-30 12:12:46 -04:00
Matt Brown
d06a199d25 Fix #121 - simplify all parameter types 2017-03-30 11:44:38 -04:00
Matthew Brown
a89018d9ae Only warn about issues in files that we’re trying to scan 2017-03-24 18:34:46 -04:00
Matthew Brown
7ed188fa52 Add support for conditional stubbed functions 2017-03-19 15:41:24 -04:00
Matthew Brown
cbd7a4520c Add support for namespaced function definitions 2017-03-19 15:37:07 -04:00
Matthew Brown
f096468536 Don’t forget where a type came from when combining 2017-03-19 14:39:05 -04:00
Matthew Brown
3452c7853f Add support for capturing clauses from elseifs 2017-03-18 14:04:26 -04:00
Matthew Brown
469cee1b80 Add a bunch of elseif tests to fix 2017-03-18 13:37:13 -04:00
Matthew Brown
c33e66813a Move type algebra functionality to separate checker 2017-03-18 13:37:00 -04:00
Matthew Brown
e687887ba3 Emit an InvalidReturnType when it should contain null, and introduct LessSpecificReturnType 2017-03-18 12:18:17 -04:00
Matthew Brown
9edae64ee2 Add a few more edge-casey tests 2017-03-18 01:34:29 -04:00
Matt Brown
30e8e1880d Add another easy calculation of clauses 2017-03-16 14:45:45 -04:00
Matt Brown
cecfe25df7 Update outer clauses in mic drop situation 2017-03-16 11:46:07 -04:00
Matt Brown
04363237c5 Fix #116 - be more lenient with static vars 2017-03-15 15:21:00 -04:00
Matt Brown
7fad81edac Fix issue with unset var in loop 2017-03-15 11:38:23 -04:00
Matthew Brown
c0a646bbc5 Add test for tail-set var 2017-03-14 20:16:41 -04:00
Matthew Brown
6cfe540c98 Fix issue evaluating elseif empty assertions 2017-03-14 15:48:52 -04:00
Matthew Brown
9dd94d099f Fix issue with possibly-redefined switch vars 2017-03-14 02:00:38 -04:00
Matthew Brown
50b629e88e Update context types after switch statement without default case 2017-03-13 21:17:21 -04:00
Matt Brown
b3bb8b72cc Add additional tests 2017-03-13 18:07:36 -04:00
Matt Brown
20791bfae6 Add third loop test 2017-03-13 11:53:16 -04:00
Matt Brown
7a652ee4bf Add tests for things we do not want to emit errors 2017-03-13 11:22:42 -04:00
Matthew Brown
a7da88bad3 Improve solution to allow for more user errors 2017-03-11 12:32:27 -05:00
Matthew Brown
39b9afcdac Fix issue running isset after empty array check 2017-03-11 12:05:23 -05:00
Matthew Brown
048d7f0142 Fix #110 - failure to eliminate false from array|false on isset 2017-03-05 23:47:53 -05:00
Matt Brown
f9f38f283e Emit issue when property type is not defined 2017-03-02 12:19:18 -05:00
Matt Brown
864d242f13 Improve labelling of referencing expressions 2017-03-01 11:56:36 -05:00
Matt Brown
7baf942eaa Prevent false positives after extract call 2017-02-27 10:52:43 -05:00
Matthew Brown
cd5f727d2e Collect explicit references to classes/methods 2017-02-26 23:09:18 -05:00
Matt Brown
182f715b62 Add dead code detection for possibly unused public methods 2017-02-23 19:52:23 -05:00
Matt Brown
0049e4deb4 Fix #105 and also the issues found in its wake 2017-02-23 19:36:51 -05:00
Matthew Brown
fa3b292fd4 Fix #101 - restrict the values of pass-by-ref variables 2017-02-23 00:25:28 -05:00
Matthew Brown
47de866601 Fix issue using abstract methods from traits 2017-02-22 01:25:51 -05:00
Matt Brown
2c7ffb6f4c Add support for negating some while assertions 2017-02-21 16:52:27 -05:00