danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-12-17 03:47:04 +01:00
Code Issues Projects Releases Wiki Activity
3,360 Commits 43 Branches 314 Tags 108 MiB
2162144234
Commit Graph

2778 Commits

Author SHA1 Message Date
Matthew Brown
8d488345ce Fix #1036 - at least the part I care about 2018-11-21 18:38:09 -05:00
Matthew Brown
9f79bdb86e Allow iteration over iteratoraggregate directly 2018-11-21 18:35:41 -05:00
Matthew Brown
ef7298c62c Improve treatment of getIterator calls 
Fixes #991
 2018-11-21 17:56:04 -05:00
Matthew Brown
116cbfd349 Fix #1090 - re-fix support for magic get properties 2018-11-21 16:57:54 -05:00
Matthew Brown
3ccd9f4c01 Fix arg type 2018-11-21 14:08:47 -05:00
Tyson Andre
6ab59209d6 Fix usage of substr_count($haystack, $needle) 
Detected via a check that literals and variables occur in the most
typical order for a global function.
 2018-11-21 13:59:22 -05:00
Matthew Brown
6ef79a0432 Improve handling of byref vars passed into functions 
Fixes #1066
 2018-11-21 12:38:51 -05:00
Vasily Kartashov
fe6713d561 Adding false to ftell result type, 
Adding properties to `stream_get_meta_data` result array
 2018-11-21 08:28:44 -05:00
Matthew Brown
f35a550774 Remove redundant clause 2018-11-20 22:24:53 -05:00
Matthew Brown
740aa895e9 Fix #1074 - allow switching from Phar analysis to regular analysis 2018-11-20 22:21:00 -05:00
Brown
b5f0159cdf Add backup hover analysis when file isn’t analysed 2018-11-20 16:32:40 -05:00
Brown
7df0361fb9 Remove unnecessary error log 2018-11-20 15:53:24 -05:00
Brown
ca602f8e17 Fix language server crash after editing trait method names 2018-11-20 15:51:47 -05:00
Matthew Brown
b982090e10 Add --tcp-server for creating language servers in tcp server mode 2018-11-19 22:57:59 -05:00
Matthew Brown
39310573d1 Use socket client mode by default when starting tcp language server 2018-11-19 22:53:11 -05:00
Matthew Brown
0f90309819 Do all normalisation on / before conversion to \ 2018-11-18 17:18:05 -05:00
Matthew Brown
fa2e7f1f70 More finagling of windows file names 2018-11-18 17:06:11 -05:00
Matthew Brown
2a3c3ed223 Fix #1071 - improve resolution of include paths 2018-11-18 16:53:46 -05:00
Matthew Brown
23ec0e037b Fix windows-only constant issue 2018-11-18 16:05:36 -05:00
Matthew
b52f9cbcd2 Fix windows file path includes 2018-11-18 20:56:56 +00:00
Matthew Brown
59b9b5d65b Move more classes into Internal namespace 2018-11-18 12:41:47 -05:00
Matthew Brown
37dedee7b6 Fix memory leak issues and disable garbage collection 2018-11-18 11:39:14 -05:00
Matthew Brown
c2e546facb Fix #531 
Well, it’s basically fixed already, but this adds @TysonAndre’s suggestions (and some of the relevant implementation from Phan)
 2018-11-17 18:01:27 -05:00
Brown
1ada15f6c6 Allow numeric-string to be identical to string 2018-11-16 13:31:53 -05:00
Brown
c8240cea77 Fix bug where int(0)|float was treated as float in some assertions 2018-11-16 12:26:55 -05:00
Brown
f3599a8b6c Allow assertSame(null, ...) 2018-11-16 11:50:07 -05:00
Brown
425b6321aa Add better understanding of when floats and ints can be equal 2018-11-16 11:04:45 -05:00
Brown
08d9940259 Change ^ to = when annotating assertions 2018-11-16 10:13:52 -05:00
Matthew Brown
e8716f636e Prevent templated assertions on union types with > 1 atomic 2018-11-16 00:56:57 -05:00
Brown
029b6e5ac4 Allow assertions to be made on template params 2018-11-15 18:50:08 -05:00
Brown
766f33d6e4 Fix add in missing property in LSP mode 2018-11-15 18:10:10 -05:00
Matthew Brown
50cb2bb92a Make compatible with PHP 7.0-1 2018-11-14 19:15:07 -05:00
Brown
cd1e1f40a0 Remove void return type 2018-11-14 18:23:20 -05:00
Brown
db6a9d5b6f Try to preserve more formatting in config file when adding plugin 
cc @weirdan - I searched in vain for a proper format-preserving XML parser - if I feel desperate I might make my own, but this is a good enough solution
 2018-11-14 18:10:45 -05:00
Brown
d9440c7bb0 Make sure assertions always have a $ in var id 2018-11-14 15:40:56 -05:00
Brown
f8ea3567d3 Include $ in asserted var id 2018-11-14 15:12:55 -05:00
Brown
9f523fab8b Only store really simple-looking code for assertions 2018-11-14 13:53:57 -05:00
Brown
254a14f621 Allow assertion redundant conditions to be suppressed 2018-11-14 13:44:20 -05:00
Brown
3ba2510096 Prevent bleeding of assert vars into context 2018-11-14 13:12:31 -05:00
Brown
4904ffe8ea Complain about redundant conditions on custom asserts 2018-11-14 12:25:17 -05:00
Bruce Weirdan
3fb0a2f336 reinstate extra.psalm "namespace" 
Existing plugins have been updated as well (skeleton, doctrine-collections)

Also fixed path to echo-checker plugin so that it's once again directly
installable from the psalm distribution.
 2018-11-14 08:31:02 -05:00
Matthew Brown
c86f8e1aef Fix redundant defs 2018-11-14 01:32:29 -05:00
Matthew Brown
dede120fde Remove Psalm prefix to match psalm plugin skeleton composer.json 
cc @weirdan - ran into this when trying to install a plugin
 2018-11-14 01:02:26 -05:00
Brown
06974221df Change DependencyFinderVisitor name to ReflectorVisitor and update docs 2018-11-13 14:09:43 -05:00
Matthew Brown
a4507b068e Fix #1081 - allow PDO::prepare to return false 2018-11-13 00:38:14 -05:00
Bruce Weirdan
7cc472c2f1 Don't choke on non-existing composer.lock 
It's useful to see enabled plugins and be able to disable them even if
no composer files are found.
 2018-11-12 17:43:31 -05:00
Bruce Weirdan
512d07c93a Re-enable plugin autoloading 
Plugins are supposed to be autoloaded when they are referenced by class
names.
 2018-11-12 17:42:36 -05:00
Brown
d0c245eff3 Fix #1077 - queue property types 2018-11-12 13:01:16 -05:00
Brown
dc834fdb01 Default allowStringToStandInForClass to true and fix errors found 2018-11-12 12:03:55 -05:00
Brown
f10714e6f8 Add a --no-reflection-cache option for plugin use 2018-11-12 11:20:59 -05:00
Brown
0254322bed Migrate Codebase-namespaced and FileManipulation-namespaced classes to internals 2018-11-12 11:20:59 -05:00
Bruce Weirdan
a338e76ef6 Plugin interface segregation (#1076) 
* Split Plugin into PluginApi\Hook\* interfaces

* dropped Psalm\Plugin

* updated docs

* s/PluginApi/Plugin/g
 2018-11-12 11:20:59 -05:00
Matthew Brown
9709263b8d Make many PropertyAnalyzer properties private 2018-11-12 11:20:59 -05:00
Matthew Brown
4d79b61e93 Change _checker to _analyzer 2018-11-12 11:20:59 -05:00
Matthew Brown
4688b25fd9 Move internal classes to own namespace 2018-11-12 11:20:59 -05:00
Matthew Brown
c7016d9232 Unset new var if it doesn’t appear in break vars 2018-11-11 22:03:08 -05:00
Bruce Weirdan
052d4f6217 Plugin loading (#855) 
* add ability to load plugins by class names

- Plugins need to implement `__invoke(PluginFacade $psalm):void` method
- Plugins are enabled by adding `<pluginClass
class="Qualified\Class\Name"/>`
- `PluginFacade` provides a single point of contact with Psalm, so that
plugins cannot become coupled to Psalm internals

* added `psalm-plugin` cli tool to manage plugins

Available commands:
 `psalm-plugin list` - lists available and enabled plugins
 `psalm-plugin enable 'Plugin\Class\Name'` - enables plugin (modifies `psalm.xml`)
 `psalm-plugin disable 'Plugin\Class\Name'` - disables plugin (modifies `psalm.xml`)

Plugin installation:
 `composer install plugin-vendor/plugin-package-name`

Plugin authoring:
 Plugins are identified by package `type` field, which should contain
 `psalm-plugin` string.
 `extra.pluginClass` should refer to the name of the class implementing
 `__invoke(PluginFacade $psalm):void` function

Todo:
 - better config file search
 - better output for `psalm-plugin`
 - better formatting for modified xml file
 - composer skeleton project for plugins
 - ability to refer to plugins by package name (cli only)
 - composer plugin to (optionally) enable plugin upon installation
 - documentation on plugin installation and authoring
 - interfaces for plugin dependencies
 - interface for plugin entry point
 - migration path for legacy plugins

* documented previously undocumented plugin methods

* split legacy plugin registration into a wrapper class

also added `PluginApi` namespace and `RegistrationInterface`

* reuse psalm's config search algorithm

* enable/disable plugins by composer package name

* allow specifying alternative config file name

* whitelist PluginApi namespace

three times, but well, it works now

* interface for plugin entry points

* psalm-plugin as a symfony console app

* fixed errors found by psalm

* suppressed false positive UnusedMethods

* cs fix

* better psalm-plugin output

* don't leave empty `plugins` node to avoid old schema violation

* removed junk file that shouldn't be there

* cs fix

* fixed phpunit failure (constant redefinition)

* work around missing docblock in on symfony console

* php 7.0 compatibility

* allow `pluginClass` child elements as plugin configuration

* decouple console commands from undelying implementation

- introduce PluginListFactory
- add `PluginList::enable(string $class)` and `PluginList::disable(string $class)`

* PluginList tests

* ComposerLock test

* droppped debugging statement

* added part of console command tests

* added tests for EnableCommand

* added DisableCommand tests

* ignore unused args

* ConfigFile test

* disable travis cache in attempt to fix builds

* nah, that didn't work

* update for upstream changes

* rebase fixes

* namespaced `extra` entry for entry point

* s/PluginFacade/PluginRegistrationSocket/g

* Added $config parameter to PluginEntryPointInterface::__invoke()

* cs fixes

* entry point interface php7.0 compatibility

* cleaned up old cruft

- dropped todos I'm not going to pursues
- locked entry point to be a class implementing entry point interface

* fixed legacy plugins docs

* Added RegistrationInterface::registerHooksFromClass()

It mimics the way old plugins were registered in Psalm\Config, so
handler classes extending Psalm\Plugin should be fully compatible with
it.

Since Psalm\Plugin-style plugin registration was moved to
RegistrationSocket, LegacyPlugin now only load file-based plugins, so it
was renamed to FileBasedPluginAdapter.

* Converted EchoChecker plugin to composer-based format

- Its subfolder is registered as a local composer package in the root
composer.json, so it's directly installable with
	```
	composer require psalm/echo-checker-plugin
	```
- Migration is trivial: drop the plugin into a separate folder, then add
simple composer.json and the entry point class.

* Updated docs

* Don't reject hook handlers that inherit handling methods

* strip void return type in stub file
 2018-11-10 23:23:36 -05:00
Matthew Brown
a3dde47374 Fix issues with build 2018-11-10 20:56:52 -05:00
Matthew Brown
fe25530cad Fix #1073 - relax constraints around missing reflected methods and PHP Parser version 2018-11-10 20:56:31 -05:00
Matthew Brown
e36d7c7d5e Fix $key overwriting 2018-11-10 20:40:34 -05:00
Matthew Brown
12e3ab11ad Improve handling of breaks in switch statements 2018-11-10 20:34:53 -05:00
Matthew Brown
9056353b7f Fix #1065 - allow interface methods to be used in abstract classes 2018-11-10 19:05:51 -05:00
Matthew Brown
2ea58e2c0f Better assertions about non-empty known numbers 2018-11-10 17:56:22 -05:00
Matthew Brown
c136974f4d Allow loop breaks to take precedence over case breaks 2018-11-10 17:29:59 -05:00
Matthew Brown
aa426aca03 Add better support for non-empty arrays when scanning constants 2018-11-10 17:15:37 -05:00
Matthew Brown
1d64f299e9 Make sure only immediate case breaks are detected 2018-11-10 16:29:40 -05:00
Matthew Brown
3664b0975c Make sure switch breaks don’t count as loop breaks 2018-11-10 16:26:03 -05:00
Matthew Brown
9f2fe748e8 Improve handling of vars set in always-entered for/foreach/while loops 2018-11-10 16:10:59 -05:00
Matthew Brown
03ea94e087 Improve handling of do blocks 2018-11-10 14:06:31 -05:00
Brown
ead7d62d48 Continue checking after method deprecation warning 2018-11-09 14:18:46 -05:00
Brown
71800770b1 Fix delimiter 2018-11-09 12:59:17 -05:00
Brown
ea62387cae Strip out leading slashes before reflecting 2018-11-09 12:34:52 -05:00
Brown
ecf9d8afd7 Fix calculation when sample has a newline 2018-11-09 11:38:40 -05:00
Brown
b7099aaf3f Make sure array changes are noticed 2018-11-09 11:19:44 -05:00
Brown
15b412b10e Add checks for non-empty arrays 2018-11-09 10:56:27 -05:00
Brown
f2c013e45f Improve API for setting temporary file contents 2018-11-09 10:42:55 -05:00
Brown
c9d7d63001 Exit earlier if not checking content at all 2018-11-09 10:42:55 -05:00
Matthew Brown
10a5271012
Remove blank line 2018-11-09 08:53:03 -05:00
Matthew Brown
e5c628f7df Fix 7.0-incompatible code 2018-11-09 08:43:17 -05:00
Matthew Brown
1e32354386 Improve accuracy of MissingPropertyType 2018-11-09 00:59:13 -05:00
Matthew Brown
f2f8edef20 Fix #1062 - improve handling of baseline messaging 2018-11-09 00:47:43 -05:00
Matthew Brown
10a0f19870 Delay loading stubs until after first scan; 2018-11-09 00:47:23 -05:00
Matthew Brown
2065e0129e Fix #1069 - module arithmetic always returns ints 2018-11-07 08:45:26 -05:00
Matthew Brown
6cf6d2cfda Add null check 2018-11-06 09:18:39 -05:00
Matthew Brown
8354b6e055 Fix #1063 with removal of unnecessary code 2018-11-06 08:53:22 -05:00
Vasily Kartashov
a3007266d0 add nullable bool result to mysql_stmt::fetch 2018-11-06 08:14:59 -05:00
Brown
1725bd466d Fix #1059 by reducing file path further 2018-11-05 18:22:18 -05:00
Erik Booij
f05d10ebe4 Automatically add reference to baseline to config file 2018-11-04 19:28:12 -05:00
Gabriel Caruso
62a1d0d12a Simplify return statment 2018-11-04 19:26:37 -05:00
Matthew Brown
98a5503260 Remove unused var 2018-11-04 19:26:17 -05:00
Brown
3fc67782a9 Fix #1055 - improve reconciliation of class-strings 2018-11-02 17:38:20 -04:00
Brown
07934b8333 Fix isString check for class strings 2018-11-02 17:03:49 -04:00
Brown
f7a37d05b9 Improve handling of generic params in intersection types 
Ref #1053
 2018-11-02 13:09:04 -04:00
Matthew Brown
f592e54a4e Add hover info for extends and implements 2018-11-01 23:40:36 -04:00
Matthew Brown
ccf5de0418 Improve array coercion checks 2018-11-01 23:31:40 -04:00
Matthew Brown
1152aa953f Fix #1026 - warn about bad docblock in @property annotation 2018-11-01 23:04:00 -04:00
Matthew Brown
b1c704da4d Fix #1050 - don’t check stubbed classes for property initialisation 2018-11-01 22:46:14 -04:00
Matthew Brown
7d12bfd2d1 Cache errors as well as info issues 2018-11-01 21:52:39 -04:00
Brown
ef671a14cc Fix issue in file diff offset 2018-11-01 19:11:00 -04:00
Brown
df8b0a1fc5 Bust cache when config changes, don’t rely on > modified time 2018-11-01 17:42:48 -04:00
Brown
f017599b3f Fix how InvalidDocblock is treated 
Fixes #1051 (hopefully)
 2018-11-01 17:03:08 -04:00
Brown
019404d198 Fix resolving of classes after change 2018-11-01 16:04:37 -04:00
Brown
bd3250f52b Bust caches when config changes 2018-11-01 16:02:44 -04:00
Brown
0ba8a51cbe Deduplicate issues from threads 2018-11-01 13:22:38 -04:00
Brown
1d7ea1292e Add Psalm\Config::locateConfigFile method for easier path fetching 2018-11-01 13:05:33 -04:00
Brown
5eca4a8b27 Properly escape slashes in issue text 2018-11-01 12:39:48 -04:00
Matthew Brown
9c1f15526d Remove erroneous =PATH 2018-11-01 11:16:08 -04:00
Erik Booij
635410ea41 Introduce issue baseline with --set-baseline and --with-baseline 2018-11-01 11:16:08 -04:00
Dave Liddament
14b99203d5 FIX #1047 
FIx for issue [CLI -i flag not being processed correctly](https://github.com/vimeo/psalm/issues/1047)
 2018-10-31 22:27:21 -04:00
Matthew Brown
1a08b69d9c Only do partial parsing if there are few changes 2018-10-30 22:25:31 -04:00
Matthew Brown
cd9e9321fd Remove error logging 2018-10-30 20:55:25 -04:00
Matthew Brown
8071465e8e Fix performance regression introduced with fix to #1039 2018-10-30 20:51:52 -04:00
Brown
71452923c9 Remove error_logs 2018-10-30 18:58:48 -04:00
Brown
727b0d3221 Add --disable-on-change option 2018-10-30 18:58:22 -04:00
Brown
6732c5f5c2 Add scanning of generic classes 2018-10-30 13:01:01 -04:00
Brown
aef9fecaa3 Fix #1045 - check intersection classes exist 2018-10-30 10:34:02 -04:00
Matthew Brown
d1baff4b92 Fix #1044 - allow templated params in assert 2018-10-30 09:20:34 -04:00
sji
2eb0122549 Fixed the type of 1st parameter in odbc_fetch_object() 2018-10-30 09:17:48 -04:00
Brown
55b29e71a8 Fix issue where diffs span multiple functions 2018-10-29 17:12:20 -04:00
Brown
0bebcd06ce Prevent possibly false return from enterNode 
Don’t quite understand how this could be false tbh
 2018-10-29 15:01:05 -04:00
Brown
d6392fbcba Added an HTML-escaped-string meta-type for functions to return 
And a sample echo checker
 2018-10-29 11:54:25 -04:00
Matthew Brown
0d7661dd3f Clone all comments, not just docs 2018-10-27 21:22:09 -04:00
Matthew Brown
750ef3e443 Rename OffsetMapCheckerVisitor to PartialParserVisitor and add description 2018-10-27 12:27:21 -04:00
Matthew Brown
aff6844c62 Fix #1035 - ignore issues where method is in a custom library 2018-10-27 11:47:27 -04:00
Matthew Brown
1d77b61ff9 Fix #1039 by invalidating all use users 2018-10-26 23:04:38 -04:00
Brown
00b51627cc Fix tests 2018-10-26 16:29:16 -04:00
Brown
e286089eaa Add onchange events and symbol lookup with disabled completion 2018-10-26 16:17:15 -04:00
Brown
303d3ee6a2 Fix issue adjusting offsets after multiple file changes 2018-10-26 13:22:41 -04:00
Brown
89e91f6ae2 Force a rescan if adding an extra method 2018-10-26 11:48:21 -04:00
Brown
dbb155f18d Shift all comments, not just docblocks 2018-10-26 11:22:43 -04:00
Matthew Brown
addaea2c1c Improve performance when parsing large files with few changes 2018-10-26 00:59:14 -04:00
François Kooman
a27ab52be7 DateTime*::getTimestamp can return false 
When the represented date is before 1970-01-01 00:00:00, or after
2038-01-19 03:14:07 on 32 bit systems
 2018-10-25 08:12:26 -04:00
Brown
dfda8c0760 Fix Ds\Set signatures cc @mleczakm 2018-10-24 13:14:19 -04:00
Brown
d9cf8cb1be Update callmap 2018-10-24 11:13:08 -04:00
Brown
496018f84a Fix #1024 - add support for filter_var 2018-10-23 14:38:36 -04:00
Brown
d3cd81078f Suppress UnusedParam again 2018-10-23 13:39:10 -04:00
Brown
6ac6aece89 Add coverage of differ, having fixed Psalm bug 2018-10-23 13:38:12 -04:00
Brown
85b64227f7 Be more lenient with objectlike array offset values 
Assume mixed key is accurate
 2018-10-23 13:14:14 -04:00
Brown
447739ede1 Fix #1033 - coerce -0 to a general int 2018-10-23 13:00:15 -04:00
Brown
d6a6e6a16c Remove error_logs 2018-10-19 13:13:55 -04:00
Brown
4da1fd0e40 Change psalm --server to psalm-language-server 2018-10-18 14:34:46 -04:00
Brown
2b6df3658c Only repopulate the storage we care about 
Big reduction on population time for single file edits
 2018-10-18 10:42:37 -04:00
Brown
a41c5c8a39 Fix code quality issues 2018-10-18 09:57:13 -04:00
Brown
4ed5c4bcc6 Speed up analysis phase 2018-10-18 09:51:28 -04:00
Brown
b7c438bf97 Fix slowness when invalidating heavily-used files 2018-10-17 18:11:02 -04:00
Brown
54fdda651b Add server mode support with error reporting only 2018-10-17 15:54:31 -04:00
Brown
47e987ccf8 Check to see if process is still running before killing 2018-10-17 15:53:54 -04:00
Brown
5938fd1bb9 Fix too-long-line 2018-10-17 14:37:32 -04:00
Brown
a38d2f809b Fix #1017 - add non-docblock return type as a referenced class 2018-10-17 14:10:16 -04:00
Brown
6a7148204b Add checks elsewhere too 2018-10-17 13:25:09 -04:00