7 Commits

Author	SHA1	Message	Date
Daniil Gentili	3b3065c881	Allow variable keys with array_key_exists (#5606) ... * Allow variable keys with array_key_exists * Switch to elseif	2021-04-09 11:29:45 -04:00
AndrolGenhald	d4590711d6	Fix object-like array keys when combining string and automatic keys (fixes #5427). (#5428) ... * Fix object-like array keys (fixes #5427). * Fix incorrect return types for tests. * Fix false positive list with literal int key.	2021-03-19 21:44:44 -04:00
Alberto Piai	144bb37f76	Fix array_key_exists() with all int literal keys (#5197) ... When checking code like the following: ``` <?php function checkNegated(string $key): void { $arr = [ 0 => "foo", 1 => "bar", ]; if (!array_key_exists($key, $arr)) { printf("not found\n"); } } function check(string $key): void { $arr = [ 0 => "foo", 1 => "bar", ]; if (array_key_exists($key, $arr)) { printf("found\n"); } } ``` the `if` in `checkNegated` would cause: ``` ERROR: RedundantCondition - 9:10 - Type string for $key is never =int(0) ``` This happens when the array keys are all int literals, but the "needle" is a string. `array_key_exists()` uses a loose equality comparison, but the generated assertions for this specific case (`AssertionFinder::getArrayKeyExistsAssertions`) was generating strict equality clauses. This commit fixes it by changing the generated clause from `=` to `~`.	2021-02-12 17:00:38 -05:00
Matt Brown	9423324d65	Fix #4791 - only generate special has-array-key assertions for unknown key types	2020-12-08 19:45:47 -05:00
Matt Brown	6f916553a8	Ref #4753 - allow int literals to inform key type	2020-12-02 17:13:45 -05:00
Matt Brown	e2bb02e93c	Don’t suggest a potential value that’s undefined ... Fixes #4754	2020-12-02 14:49:30 -05:00
Matt Brown	b64eb6d716	Break out array_key_exists tests	2020-12-02 14:42:16 -05:00