2073 Commits

Author	SHA1	Message	Date
Vincent	7b25ca75f4	Resolve generics of inherited pseudo methods (fix #7419)	2022-01-19 11:45:19 +01:00
adrew	7e623ed48e	Upcast invokable to callable during hof arg analysis	2022-01-19 00:37:05 +03:00
adrew	fca72ee151	Fix psalm issues	2022-01-18 22:05:32 +03:00
adrew	6e1957e40a	Support higher order func arg inference for static and instance calls	2022-01-18 18:45:28 +03:00
adrew	12648f4c9e	Comments for describe how works higher order func arg inference	2022-01-18 13:36:16 +03:00
adrew	ffdf97c44d	Remove unused function	2022-01-18 13:17:50 +03:00
adrew	a0bda8683a	Rename method	2022-01-18 13:13:17 +03:00
adrew	6f9b6f8538	Fix psalm issues	2022-01-18 12:53:39 +03:00
adrew	cce1f9a407	Some refactoring and doc for high order function argument handling	2022-01-18 12:44:36 +03:00
adrew	00ce1107d3	Infer partially applied closure arg by previous function arg	2022-01-18 03:02:21 +03:00
Vincent	09fc43a4d8	Add support of docblock method using parent keyword (fix #7411)	2022-01-17 19:26:42 +01:00
Ricardo Boss	26dd4c5b8f	Try to provide literal int types when possible (fixes #6966) (#7071) ... * Fixed vimeo/psalm#6966 * Only accept >= 0 values for mode argument in round() * Made round() only return float or literal float values and remove unneeded test * Registered RoundReturnTypeProvider * Updated cast analyzer to handle single string literal int values as literal ints * Fixed psalm errors * Fix invalid property accesses * Addressed comments * Added Tests * Marked RoundReturnTypeProvider as internal * Fixed CS	2022-01-16 21:33:04 +01:00
orklah	5b82082bbd	Merge remote-tracking branch 'upstream/4.x' into upstream-master2	2022-01-15 20:21:00 +01:00
orklah	9a9243e5fe	Merge pull request #7385 from b2pweb/handle-template-on-pseudo-method ... Add support of template for docblock methods	2022-01-15 11:26:03 +01:00
orklah	75947c97c6	Merge pull request #7391 from b2pweb/docblock-method-inheritance ... Handle inherited docblock method	2022-01-15 11:24:06 +01:00
orklah	d2faa5b94f	fix errors after merge	2022-01-14 21:13:34 +01:00
orklah	b633619a2c	Merge remote-tracking branch 'upstream/4.x' into upstream-master	2022-01-14 21:01:25 +01:00
orklah	4a85fed181	use Reconciler::RECONCILIATION_*	2022-01-14 19:39:18 +01:00
Vincent	a52362465b	Handle inherited docblock method (fix #7198)	2022-01-14 10:30:09 +01:00
Vincent Langlet	9f84da4d6f	Try another strategy	2022-01-13 23:57:02 +01:00
Vincent	fe7665aaaf	Add support of template for docblock methods (fix #7320)	2022-01-13 11:04:37 +01:00
Daniil Gentili	b9e3979c3f	Cs-fix	2022-01-10 10:22:51 +01:00
Daniil Gentili	a35ccfb0cb	Revert misguided changes	2022-01-10 10:19:12 +01:00
Daniil Gentili	b530f23acc	PHP 8.2: seal all properties by default, add configuration key for lower versions	2022-01-10 10:11:28 +01:00
Matthew Brown	72fd3de886	Simplify return type for TypeExpander::expandAtomic	2022-01-09 16:19:04 -05:00
Matthew Brown	a435bc57b9	Rename was_static property to is_static to be more accurate	2022-01-09 14:45:07 -05:00
orklah	c94e25fa7f	refactor the TooFewArguments check to start checking with named arguments	2022-01-09 00:37:16 +01:00
orklah	ce2c6cf438	set the is_list flag for the array inferred for hrtime	2022-01-08 22:48:05 +01:00
Bruce Weirdan	1a1b5a9e6a	Merge branch '4.x' into upstream-master	2022-01-08 23:38:29 +02:00
orklah	afc3a76bc0	Seal the array inferred for hrtime	2022-01-08 22:22:21 +01:00
orklah	9d225086e9	replace empty checks on Union with dedicated method	2022-01-07 21:27:45 +01:00
Bruce Weirdan	762ef8dab4	Merge branch '4.x' into upstream-master	2022-01-07 08:44:32 +02:00
Fabien Villepinte	b9d8dd9d3f	Fix analysis when __invoke() exists	2022-01-06 21:22:18 +01:00
Bruce Weirdan	3fb3db3516	Merge branch '4.x' into upstream-master	2022-01-06 10:05:53 +02:00
Bruce Weirdan	b6559dcefb	Merge pull request #7315 from weirdan/rector-ClosureToArrowFunctionRector	2022-01-06 02:04:10 +02:00
orklah	bf4bf92cb2	Merge pull request #7313 from orklah/empty-arrays ... replace `array<never, never>` as a way to detect empty arrays by a dedicated method	2022-01-05 23:58:45 +01:00
Bruce Weirdan	8726065d21	Applied ClosureToArrowFunctionRector	2022-01-06 00:48:04 +02:00
orklah	3c468b3eeb	replace array<never, never> as a way to detect empty arrays by a dedicated method	2022-01-05 23:14:54 +01:00
orklah	e7bc6f273a	don't crash when pushing a template to in_array	2022-01-05 22:33:20 +01:00
Bruce Weirdan	94395f18a4	Applied JsonThrowOnErrorRector	2022-01-05 19:32:43 +02:00
Bruce Weirdan	dd09450092	Applied NullCoalescingOperatorRector	2022-01-05 13:09:37 +02:00
Bruce Weirdan	5758d31161	Apply literal number separator rector ... I opted for customary 3-digit groups, except version id, where 2-digit groups are used to match the version id encoding.	2022-01-05 01:00:05 +02:00
Bruce Weirdan	b924032850	Mark internal classes @internal	2022-01-03 09:33:22 +02:00
Bruce Weirdan	ab60d311c2	Merge pull request #7188 from vimeo/muglug-use-invalidscalarargument-less	2022-01-03 06:04:42 +02:00
orklah	d912663da4	remove isEmpty	2022-01-03 04:10:41 +02:00
Matthew Brown	2358b96f54	Fix merge errors	2022-01-03 04:10:39 +02:00
orklah	0747b48d06	remove TEmpty	2022-01-03 04:09:59 +02:00
Matthew Brown	b419c299e3	Use InvalidScalarArgument only when we can be sure PHP attempts coercion	2022-01-02 14:56:18 +02:00
orklah	8d6b781b3e	use consistent way to compare php version	2022-01-02 13:35:43 +02:00
Bruce Weirdan	36d5a2a83c	Merge pull request #7019 from zoonru/no_ksort_list	2022-01-02 07:37:21 +02:00
Bruce Weirdan	697db76dc1	Merge pull request #7252 from AndrolGenhald/feature/allow-assertions-on-mutable-object-properties	2022-01-02 07:29:02 +02:00
Bruce Weirdan	376d2a389e	Merge pull request #7259 from klimick/infer-this-context-for-psalm-if-this-is	2022-01-02 05:31:24 +02:00
orklah	de95fbdbf2	revert #7054	2022-01-01 19:34:17 +01:00
orklah	2a6f12296e	Merge pull request #7260 from orklah/6691 ... forbid calling impure callable in immutable context	2022-01-01 12:08:07 +01:00
adrew	0f69483cc1	Fix method storage fetching	2022-01-01 13:33:00 +03:00
orklah	8049438408	forbid calling impure callable in immutable context	2022-01-01 11:13:45 +01:00
adrew	79ea094433	Template resolving for psalm-if-this-is	2022-01-01 13:03:17 +03:00
orklah	51ba96c09d	Merge pull request #7253 from orklah/5874 ... allow calling mutation_free function inside a mutation_free context	2021-12-31 00:24:29 +01:00
AndrolGenhald	dd631c0c85	Skip reference tests, allow assertions on magic properties (fixes #6770).	2021-12-30 16:23:59 -06:00
orklah	392402cf6d	allow calling mutation_free function inside a mutation_free context	2021-12-30 22:29:36 +01:00
AndrolGenhald	3ac497c811	Allow assertions on mutable object properties. ... All of the functionality is already there, we just have to not prevent it.	2021-12-30 14:07:55 -06:00
adrew	2355f1bcdb	Remove unused use	2021-12-30 22:46:18 +03:00
adrew	4a903c71a1	Checking psalm-if-this-is before applying psalm-this-out	2021-12-30 21:48:25 +03:00
Daniil Gentili	7c24d33bb2	cs-fix	2021-12-30 11:36:56 +01:00
Daniil Gentili	915ddcc620	Add new RedundantFunctionCall issues	2021-12-30 11:36:32 +01:00
Daniil Gentili	82e24d5c1d	Disallow ksorting lists	2021-12-30 11:30:33 +01:00
Bruce Weirdan	03b7e94748	Merge pull request #7232 from trowski/issue-7196	2021-12-30 10:03:17 +02:00
orklah	0b3e1299de	overwritten properties	2021-12-27 23:46:23 +01:00
orklah	5f6bb39888	if with common parts	2021-12-27 23:08:19 +01:00
orklah	2baf3b560a	unnecessary statements	2021-12-27 23:00:40 +01:00
orklah	926a56a97c	Merge pull request #7230 from orklah/cleanup6 ... code grooming	2021-12-27 22:54:39 +01:00
orklah	094ffb36f9	phpdoc issues	2021-12-27 22:30:10 +01:00
orklah	3828db52b9	Merge pull request #7229 from orklah/cleanup5 ... remove always true/false conditions	2021-12-27 22:08:06 +01:00
Aaron Piotrowski	e23a915bb1	Fix first-class callables when used with magic method, built-in, or undefined methods ... Closes #7196.	2021-12-27 14:29:33 -06:00
orklah	9029e1d613	remove always true/false conditions	2021-12-27 19:59:11 +01:00
adrew	c0ca383020	Contextual inference for closure param types	2021-12-27 19:35:37 +03:00
adrew	63a1c71c83	Remove trailing comma	2021-12-27 00:45:25 +02:00
adrew	d6d0fc6704	Remove undefined variables	2021-12-27 00:45:25 +02:00
adrew	2e4d75d6bd	Fix closure param type inference in generic context	2021-12-27 00:45:22 +02:00
Philip Hofstetter	d45cb64827	allow marking enum cases as @deprecated	2021-12-22 06:16:42 +01:00
orklah	ca25b0f815	always unflag before leaving a analyzer	2021-12-21 18:30:29 +01:00
orklah	b1a1c65714	CS changes	2021-12-21 18:30:29 +01:00
orklah	1eca2c32ae	only emit PossiblyNullArrayAccess if there was no successful destructuring	2021-12-20 22:48:27 +01:00
orklah	cc618bc916	allow successful destructuring to also be null if the source was nullable	2021-12-20 22:48:27 +01:00
rarila	97e6511fab	Set number of lines before and after namespace.	2021-12-15 04:58:32 +01:00
ralila	19b2a64ce8	Conversion of Psalm\Internal\Analyzer\**\*Analyzer	2021-12-14 02:31:26 +01:00
ralila	c0adde8f45	Conversion of Psalm\CodeLocation\DocblockTypeLocation|Raw	2021-12-14 02:31:26 +01:00
rarila	1c298c4605	Conversion of Psalm\Type	2021-12-14 02:31:22 +01:00
ralila	e32af3c05a	Conversion of Psalm\Type\Atomic	2021-12-14 02:26:28 +01:00
adrew	a8d23538b7	Fix closure param type inference with named params	2021-12-12 13:17:15 +03:00
Bruce Weirdan	41ca7f7f7a	Merge pull request #7136 from klimick/forbid-positional-args-after-named	2021-12-12 02:22:51 +02:00
Bruce Weirdan	e08a4f2a2a	Drop unused use	2021-12-12 01:58:45 +02:00
orklah	f79f857ded	Merge pull request #7133 from AndrolGenhald/remove-unused-suppressed ... Allow suppressing UnusedPsalmSuppress, remove unused suppressions.	2021-12-11 23:24:31 +01:00
orklah	6632ddf884	Merge pull request #7135 from klimick/fix-closure-param-type-inference ... Fix type inference of closure params	2021-12-11 23:10:32 +01:00
orklah	50cc629a43	fix cs	2021-12-11 23:03:10 +01:00
orklah	a1268d94d5	fix some more expressions that can be replaced by getSingleAtomic	2021-12-11 22:37:44 +01:00
adrew	6cf2e31c4a	Forbid positional arg after named arg	2021-12-11 23:37:15 +03:00
adrew	989c3ada2e	Fix type inference of closure params	2021-12-11 22:51:18 +03:00
AndrolGenhald	23b781163a	Use getSingleAtomic() instead of array_values(getAtomicTypes())[0].	2021-12-11 13:44:34 -06:00
AndrolGenhald	bfe7f96b56	Allow suppressing UnusedPsalmSuppress, remove unused suppressions.	2021-12-11 13:23:00 -06:00
Matthew Brown	b558748db2	Detect unused properties that are written to inside arrays	2021-12-11 11:42:05 -05:00
orklah	76bb8bc655	Merge pull request #7113 from trowski/first-class-callables ... Added support for first-class callables	2021-12-10 22:40:16 +01:00
Aaron Piotrowski	3c5e99ed1e	Revert reorder of getting method return type and checking args ... Skipping checking args for first-class callables, but fixes handling of other methods.	2021-12-09 19:02:58 -06:00
orklah	ae765dfba8	Merge pull request #7054 from orklah/6933 ... fix missing case for displaying varId	2021-12-09 23:54:37 +01:00
Aaron Piotrowski	d5519fc53a	Use $stmt->args directly instead of creating new VariadicPlaceholder	2021-12-09 15:51:48 -06:00
Aaron Piotrowski	1f3a37ff02	Add support for first-class callables	2021-12-09 10:54:49 -06:00
orklah	eefdb95765	Merge pull request #7093 from orklah/7090 ... don't stop analyzing array, even if we already have a type and we can't create an object like	2021-12-08 22:37:57 +01:00
AndrolGenhald	ba881c80bf	Use maybeAdd instead of accepts.	2021-12-08 12:15:32 -06:00
AndrolGenhald	b29fc6ad3c	Allow operator overloading for Decimal extension (fixes #3938).	2021-12-08 10:59:37 -06:00
orklah	c17af4128e	don't stop analyzing array, even if we already have a type and we can't create an object like	2021-12-07 19:38:52 +01:00
Bruce Weirdan	2530b33dbd	Merge pull request #7076 from klimick/fix-generic-assertion	2021-12-07 08:08:48 +02:00
orklah	257d237192	ignore ComplexMethod: didn't see any easy refactoring	2021-12-06 20:13:33 +01:00
orklah	75312d93b1	Don't crash when checking purity of __callStatic in a trait	2021-12-06 19:00:37 +01:00
Ricardo Boss	2ec77fe29c	Make name property of enum cases return non-empty-strings (vimeo/psalm#6964)	2021-12-06 00:33:57 +01:00
adrew	dee3fc4358	try to fix generic assertions for list and array	2021-12-06 02:25:40 +03:00
rarila	39402c233d	Return type hints (#7065) ... Co-authored-by: ralila <>	2021-12-05 19:51:26 +02:00
Ricardo Boss	8a230110e8	Fix vimeo/psalm#6968	2021-12-05 15:43:38 +01:00
Bruce Weirdan	e9d9481ea6	Merge pull request #7060 from rarila/codingstyle-convert-fqn	2021-12-05 02:46:03 +02:00
Matthew Brown	1956b85c41	Remove always-false args (#7056)	2021-12-04 10:40:52 -05:00
ralila	f833085a15	Fix fqn usage in php-doc	2021-12-04 03:37:19 +01:00
orklah	2612f5a5f1	fix missing case for displaying varId	2021-12-03 23:46:12 +01:00
ralila	30a65685a2	Import instead of using fqn classes	2021-12-03 21:40:18 +01:00
ralila	7c32325e03	Import instead of using fqn constants	2021-12-03 21:25:22 +01:00
ralila	2a956498bf	Import instead of using fqn functions	2021-12-03 21:07:25 +01:00
ralila	711be643c6	Import instead of using fqn exceptions	2021-12-03 20:29:06 +01:00
ralila	245920e53c	Import instead of using fqn	2021-12-03 20:11:20 +01:00
orklah	a7e9eea0ca	flag usage of get_class outside class without args (#7043)	2021-12-02 00:38:45 +02:00
Bruce Weirdan	28c4f86993	Merge pull request #7027 from rarila/issue-6914	2021-11-30 23:34:00 +02:00
orklah	466137a4c4	Merge pull request #7025 from orklah/6256 ... flag DeprecatedProperty on static fetch	2021-11-29 23:46:25 +01:00
orklah	328dcb093b	fix variable name	2021-11-29 23:41:47 +01:00
orklah	9de9c12851	flag DeprecatedProperty on static fetch	2021-11-29 23:32:27 +01:00
Matthew Brown	175ba83332	Migrate most IssueBuffer::accepts calls to IssueBuffer::maybeAdd (#7020)	2021-11-29 14:54:17 -05:00
ralila	15eb8127ee	Reverse parameter list vor preg_match	2021-11-29 14:23:33 +01:00
Bruce Weirdan	28a75652ac	Merge pull request #6997 from zoonru/list_values_paradox	2021-11-29 00:47:12 +02:00
Bruce Weirdan	97445b52f3	Correctly process constant references on enum-valued variables	2021-11-27 04:32:32 +02:00
Daniil Gentili	ee8c5c9c35	Remove some array_values	2021-11-26 21:47:17 +01:00
Daniil Gentili	1129ab1475	Raise RedundantCast when using array_values on a list	2021-11-26 21:47:14 +01:00
Bruce Weirdan	f215ed28d0	Drop special handling of constant references on enums ... Internally enum cases are constants, and they should be resolved as such. Fixes vimeo/psalm#6994	2021-11-26 06:00:01 +02:00
orklah	3bc06a8eab	Taint can't transmit through numerics nor bool	2021-11-25 22:40:01 +01:00
orklah	b42c2814a9	Merge pull request #6971 from orklah/empty-keys ... fix counting array properties when some are Never	2021-11-23 20:11:47 +01:00
orklah	eca56c0c1a	Merge pull request #6972 from orklah/unused-throws ... prevent Psalm from considering throwing methods as unused just because they're immutable	2021-11-22 22:00:55 +01:00
orklah	1c1e352e5f	prevent Psalm from considering throwing methods as unused just because they're immutable	2021-11-22 21:29:57 +01:00
orklah	0d47722195	fix counting array properties when some are Never	2021-11-22 21:13:25 +01:00
orklah	79fa7f5993	Merge pull request #6953 from orklah/callstatic-pure ... check __callStatic purity instead of the pseudoMethod purity	2021-11-21 23:02:07 +01:00
orklah	3e56e859a9	fix inheritance	2021-11-21 21:53:24 +01:00
orklah	41fd460db5	check __callStatic purity instead of the pseudoMethod purity	2021-11-21 13:51:19 +01:00
Bruce Weirdan	f5b71a3a5f	Infer mb_strtolower() result as string when encoding is specified ... `mb_strtolower()` may return characters we generally consider uppercase when it's given the encoding argument. This PR makes Psalm to err on the side of caution and treat the return type as `string` rather than `lowercase-string` in this case Refs vimeo/psalm#6908	2021-11-14 03:57:10 +02:00
Thomas Bley	ca2fe166ee	Added option to forbid eval() in codebase #6855	2021-11-07 21:06:22 +01:00
sasezaki	5a01c8d601	Added phpcs SelfMemberReference rule, and applied	2021-11-07 15:47:39 +09:00
Bruce Weirdan	9210bbcdd4	Forbid enum instantiation ... Fixes vimeo/psalm#6837	2021-11-07 00:14:37 +02:00