1
0
mirror of https://github.com/danog/psalm.git synced 2024-12-17 03:47:04 +01:00
Commit Graph

835 Commits

Author SHA1 Message Date
Matthew Brown
995e92a8c3 Remove empty if block 2017-09-14 00:36:38 -04:00
Matthew Brown
2a4a6fc490 Exit early if checking iterable for methods 2017-09-14 00:32:14 -04:00
Matt Brown
5b3531b5a5 Fix null coalescing on nullable output 2017-09-13 14:35:42 -04:00
Matt Brown
439a1ddc97 Exit early if a bad class is detected 2017-09-11 11:58:11 -04:00
Matt Brown
d1807cfb95 Improve checks for switch types 2017-09-11 11:58:11 -04:00
Matthew Brown
e89a2929d5 Infer types from numeric operations 2017-09-06 21:44:26 -04:00
Matthew Brown
9f9e8a1b30 Improve API for inference 2017-09-03 20:52:54 -04:00
Matthew Brown
11aa3558b7 Make sure encapsulated strings can also coerce param types 2017-09-02 19:48:59 -04:00
Matthew Brown
a0c27cee4f Allow param types to be inferred from presence of concat ops 2017-09-02 19:23:00 -04:00
Matthew Brown
6531e3bfb8 Throw exception if impossible state is reached 2017-09-02 18:22:44 -04:00
Matthew Brown
73694ab04e Suggest types when complaining of untype params
Ref #204
2017-09-02 18:15:52 -04:00
Matthew Brown
8aabcbce35 Introduce UntypedParam warnings when functions are missing param types 2017-09-02 11:18:56 -04:00
Matt Brown
1cc63fe718 Ignore leading slash in array_map methods 2017-08-30 13:45:41 -04:00
Matthew Brown
622217b708 Fix #205 - add file references at analysis stage too 2017-08-22 12:38:38 -04:00
Matthew Brown
e4e6c2a6e6 Fix #201 - list/array assignment should invalidate clauses too 2017-08-18 23:14:38 -04:00
Matt Brown
3075f16308 Ignore static, self and parent in callable class names 2017-08-18 17:02:15 -04:00
Matt Brown
c626b7d68a Fix #200 - allow mapping of more callable strings, and callable arrays 2017-08-14 19:30:11 -04:00
Matt Brown
d6e2e786db Ignore self calls as well 2017-08-11 19:09:15 -04:00
Matt Brown
a7baa7e928 Support callable checks on inline-defined functions 2017-08-11 19:05:04 -04:00
Matt Brown
13d98b803d Check that callable string class exists first 2017-08-11 18:48:58 -04:00
Matt Brown
17a900ab54 Add ability to detect invalid callable functions 2017-08-11 18:30:58 -04:00
Matt Brown
4b5a5ead74 Fix paradox detection for multiple clauses 2017-08-07 18:38:38 -04:00
Matthew Brown
4175295113 Isolate where we load static storage objects (#195)
* Move FileChecker::$storage calls to provider

* Add ClassLikeStorageProvider

* Use ClassLikeStorageProvider everywhere

* Move storage arrays into providers
2017-07-29 15:05:06 -04:00
Matt Brown
22b6dafe3c Fix #194 - carry over const definitions 2017-07-28 10:42:30 -04:00
Matthew Brown
e29dd140e3 Refactor scanning and analysis, introducing multithreading (#191)
* Add failing test

* Add visitor to soup up classlike references

* Move a whole bunch of code into the visitor

* Move some methods back, move onto analysis stage

* Use the getAliases method everywhere

* Fix refs

* Fix more refs

* Fix some tests

* Fix more tests

* Fix include tests

* Shift config class finding to project checker and fix bugs

* Fix a few more tests

* transition test to new syntax

* Remove var_dump

* Delete a bunch of code and fix mutation test

* Remove unnecessary visitation

* Transition to better mocked out file provider, breaking some cached statement loading

* Use different scheme for naming anonymous classes

* Fix anonymous class issues

* Refactor file/statement loading

* Add specific property types

* Fix mapped property assignment

* Improve how we deal with traits

* Fix trait checking

* Pass Psalm checks

* Add multi-process support

* Delay console output until the end

* Remove PHP 7 syntax

* Update file storage with classes

* Fix scanning individual files and add reflection return types

* Always turn XDebug off

* Add quicker method of getting method mutations

* Queue return types for crawling

* Interpret all strings as possible classes once we see a `get_class` call

* Check invalid return types again

* Fix template namespacing issues

* Default to class-insensitive file names for includes

* Don’t overwrite existing issues data

* Add var docblocks for scanning

* Add null check

* Fix loading of external classes in templates

* Only try to populate class when we haven’t yet seen it’s not a class

* Fix trait property accessibility

* Only ever improve docblock param type

* Make param replacement more robust

* Fix static const missing inferred type

* Fix a few more tests

* Register constant definitions

* Fix trait aliasing

* Skip constant type tests for now

* Fix linting issues

* Make sure caching is off for tests

* Remove unnecessary return

* Use emulative parser if on PHP 5.6

* Cache parser for faster first-time parse

* Fix constant resolution when scanning classes

* Remove test that’s beyond a practical scope

* Add back --diff support

* Add --help for --threads

* Remove unused vars
2017-07-25 16:11:02 -04:00
Matthew Brown
17205bc093 Be more strict about what properties we check 2017-07-10 20:20:40 -04:00
Matthew Brown
d8654b8389 Slow down Psalm by checking parent initialisations too 2017-06-30 01:24:45 -04:00
Matthew Brown
368b6670d7 Fix a few edgecases 2017-06-29 00:28:37 -04:00
Matthew Brown
8fd671bdc4 Fix #167 - prevent Empty type in assignment 2017-06-28 23:37:02 -04:00
Matthew Brown
bc35f88859 Fix issue with $this instanceof checks in traits 2017-06-23 00:39:37 -04:00
Matt Brown
f49d167a49 Add tracking from where a trait was included 2017-06-21 14:22:52 -04:00
Matt Brown
e5c25eae97 Fix #172 - make sure new coalesce vars escape brackets 2017-06-20 15:38:32 -04:00
Matt Brown
e1d5eab7a2 Fix long line 2017-06-20 14:07:54 -04:00
Matt Brown
473040ca8f Fix #171 by supporting exit statements for fopen 2017-06-20 13:25:37 -04:00
Matthew Brown
6b2b80d0bb Assign var to correct context 2017-06-13 00:09:15 -04:00
Matthew Brown
93e7486d5e Reduce line length 2017-05-26 20:17:56 -04:00
Matthew Brown
22a716f4da Improve formatting of phpdocs 2017-05-26 20:16:18 -04:00
Matthew Brown
d6909193ea Add additional formatting changes 2017-05-26 20:05:57 -04:00
Matthew Brown
688a72c794 Fix #36 - emit issues on deprecated properties 2017-05-25 01:32:34 -04:00
Matthew Brown
0fdf281896 Add support for @deprecated classes 2017-05-25 00:34:39 -04:00
Matthew Brown
44b4d04e0a Fix #95 - emit issue on private constructor calls 2017-05-24 23:55:54 -04:00
Matthew Brown
8f317cd8a2 Fix #133 - emit issue when calling no-constructor class with args 2017-05-24 23:11:40 -04:00
Matthew Brown
4fd46e1752 Improve formatting 2017-05-24 22:07:49 -04:00
muglug
77a44051c5 Fix issues with @psalm-ignore-nullable-return types 2017-05-22 14:50:03 -04:00
muglug
65d86d35ad Separate iterator issues 2017-05-22 11:59:58 -04:00
Matthew Brown
7532e32b9d Fixed spacing and use statement formatting 2017-05-19 00:48:26 -04:00
Matt Brown
cadaef14e6 Carry forward ignore_nullable_return in fleshOutType 2017-05-10 12:49:59 -04:00
github@muglug.com
9ff8736e53 Add the means to ignore PossiblyNull* errors from the type itself 2017-05-09 16:38:58 -04:00
Matt Brown
624bba0f5c Divid pseudo properties into get and set types 2017-05-05 11:20:05 -04:00
Matthew Brown
c9b9b29cf4 Fix all phpcs issues 2017-05-04 21:57:26 -04:00
Matt Brown
2bd1dfafe7 Make line smaller 2017-05-04 18:41:33 -04:00
Matt Brown
df890fbfb0 Fix #155 - support @property declaration for classes with magic getters & setters 2017-05-04 18:35:05 -04:00
Matt Brown
9cabf428c4 Only make isset $this->property mixed if not already defined 2017-04-28 16:41:54 -04:00
Jon Ursenbach
f65c618b2e PSR-2 adjustments and adding PHPCS checks into the Travis config. (#149)
* PSR-2 adjustments and adding PHPCS checks into the Travis config.

* Reverting some CallChecker changes and no longer casting vars to null.
2017-04-28 00:31:55 -04:00
Matt Brown
bd6a623bfd Fix possible empty type when inferredType not set 2017-04-21 16:33:18 -04:00
Matt Brown
f7daa6e768 Fix #143 by allowing scalar types to be passed through 2017-04-21 14:06:47 -04:00
Matthew Brown
007442fdd0 Fix possibly-private error 2017-04-15 21:10:49 -04:00
Matthew Brown
f67e92023b Add support for intersection types
Fixes #140
2017-04-15 20:36:40 -04:00
Matthew Brown
2bdd062400 Ternary else should ignore if expression context 2017-04-15 13:46:18 -04:00
Matthew Brown
8d46c65815 Only make non-null if inside constructor 2017-04-14 23:26:58 -04:00
Matthew Brown
60be6f07a0 Delay checks for MissingPropertyType so we can give more useful messages 2017-04-14 23:09:34 -04:00
Matthew Brown
ce6ca58291 Fix #114 - add optional Hack-like checks calls 2017-04-14 21:32:14 -04:00
Vladimir Komissarov
818e3be00c Fix undefined global constant in closure 2017-04-14 17:03:09 +07:00
Matt Brown
7bcf7f13b1 Fix #137 - add for init in main scope 2017-04-11 17:43:46 -04:00
SignpostMarv
46a0b03aac enable the exposure of the source line number when DocblockParseException is thrown 2017-04-11 22:14:15 +01:00
Matthew Brown
32efdfd0f7 Fix #129 - emit PossiblyNullFuntionCall when encountering such a thing 2017-04-08 11:38:06 -04:00
Matthew Brown
2d454d6e10 Fix #130 - check class exists before checking for __invoke 2017-04-08 11:15:17 -04:00
Matthew Brown
a985fd9324 Add PossiblyInvalidArgument for closure param type checks 2017-04-08 09:47:03 -04:00
Matthew Brown
64361ad2c3 Add more descriptive message to PossiblyInvalidArgument issue 2017-04-08 09:43:58 -04:00
Matthew Brown
c663062816 Add PossiblyUndefinedArgument issue to cope with #126 2017-04-08 09:28:02 -04:00
Matthew Brown
b3a454cf5b Create new InvalidMethodCall issue for calling methods on non-objects 2017-04-08 09:20:32 -04:00
Matt Brown
f011197090 Fix #124 - don’t check array_filter closures when >2 args passed 2017-04-07 18:30:15 -04:00
Matthew Brown
b20ddfec94 Add better way of checking two types can ever yield identical values 2017-04-07 09:02:09 -04:00
Matthew Brown
40427839ea Get all variables possibly assigned in conditional 2017-04-06 22:56:37 -04:00
Matthew Brown
20b0460a33 Fix #123 - ternary byref vars now adjusted 2017-04-06 21:53:29 -04:00
Matt Brown
8a20aca4cf Only compare non-null types 2017-04-06 18:11:09 -04:00
Matt Brown
da19b55db1 Add special TypeDoesNotContainNull issue as distinct from TypeDoesNotContainType 2017-04-06 15:36:22 -04:00
Matt Brown
cb3f6b14ba Fix AssertionFinder to trap the right null type 2017-04-06 15:05:23 -04:00
Matt Brown
e02999f2ba Prevent undefined property notices 2017-04-06 14:57:00 -04:00
Matt Brown
14bb967c7d Warn when doing === comparisons on incompatible types 2017-04-06 14:53:45 -04:00
Matt Brown
fe43c4e37f Fix #122 - allow multiple types of filtering 2017-04-03 12:36:49 -04:00
Matthew Brown
075cc5f50d Add by-reference clause removal 2017-04-02 17:37:56 -04:00
Matthew Brown
dcedd65215 Add check for paradoxical statements 2017-04-02 15:26:10 -04:00
Matthew Brown
83edf8c4db Complete the circle – fix remaining type algebra issue 2017-04-01 19:04:49 -04:00
Matt Brown
5b34163d8d Add ability to insert suppressed issues on functions 2017-03-31 11:21:34 -04:00
Matthew Brown
676c01ed2e Fix nullref 2017-03-20 02:23:54 -04:00
Matthew Brown
066b1e011e Prevent creating empty objectlike 2017-03-20 02:05:58 -04:00
Matthew Brown
2d88e237f4 Make method non-static 2017-03-19 13:23:19 -04:00
Matthew Brown
b1b7b0ae35 Only include vars asserted in where 2017-03-18 16:34:44 -04:00
Matthew Brown
9a3049b5bc Make sure switch contexts know their parents 2017-03-18 15:28:59 -04:00
Matthew Brown
cb2ed860fb Make sure to invalidate clauses in all parent contexts when asserting 2017-03-18 15:24:14 -04:00
Matthew Brown
18af05fbd9 Do not stop at magic setter when property referenced locally 2017-03-18 15:00:01 -04:00
Matthew Brown
3452c7853f Add support for capturing clauses from elseifs 2017-03-18 14:04:26 -04:00
Matthew Brown
c33e66813a Move type algebra functionality to separate checker 2017-03-18 13:37:00 -04:00
Matt Brown
30e8e1880d Add another easy calculation of clauses 2017-03-16 14:45:45 -04:00
Matt Brown
cecfe25df7 Update outer clauses in mic drop situation 2017-03-16 11:46:07 -04:00
Matthew Brown
9b41bc9b37 Add slower (but more accurate) loop checks 2017-03-14 20:14:25 -04:00
Matthew Brown
6cfe540c98 Fix issue evaluating elseif empty assertions 2017-03-14 15:48:52 -04:00
Matthew Brown
9dd94d099f Fix issue with possibly-redefined switch vars 2017-03-14 02:00:38 -04:00
Matthew Brown
50b629e88e Update context types after switch statement without default case 2017-03-13 21:17:21 -04:00
Matt Brown
3d2be3410e Infer loop types without @var comments 2017-03-13 18:06:56 -04:00
Matt Brown
ae0ca9553f Remove training wheels 2017-03-13 12:02:28 -04:00
Matt Brown
fa63afc27d Change property name 2017-03-13 11:23:26 -04:00
Matthew Brown
a7da88bad3 Improve solution to allow for more user errors 2017-03-11 12:32:27 -05:00
Matt Brown
f9f38f283e Emit issue when property type is not defined 2017-03-02 12:19:18 -05:00
Matthew Brown
18b5617443 Prevent duplicate lookup of functionstorage 2017-03-02 00:00:31 -05:00
Matthew Brown
5cd1b6735f Add even more references in docblocks 2017-03-01 22:27:52 -05:00
Matt Brown
864d242f13 Improve labelling of referencing expressions 2017-03-01 11:56:36 -05:00
Matt Brown
518184f388 Don’t do a full class check where not necessary 2017-02-28 11:00:32 -05:00
Matt Brown
4f597a4068 Fix references 2017-02-27 16:38:43 -05:00
github@muglug.com
07c9cfb848 Check template typeof class references 2017-02-27 16:35:24 -05:00
Matt Brown
729954573b Allow generics to work even if variables not checked 2017-02-27 11:07:44 -05:00
Matt Brown
ac1a45f129 Fix erroneous error message 2017-02-27 10:53:32 -05:00
Matt Brown
7baf942eaa Prevent false positives after extract call 2017-02-27 10:52:43 -05:00
Matthew Brown
d9433c9491 Add way to find all references to a given class or method in the codebase 2017-02-27 01:30:44 -05:00
Matthew Brown
cd5f727d2e Collect explicit references to classes/methods 2017-02-26 23:09:18 -05:00
Matthew Brown
8db6921f1c More graceful early exit if not checking variables 2017-02-24 21:27:52 -05:00
Matt Brown
0049e4deb4 Fix #105 and also the issues found in its wake 2017-02-23 19:36:51 -05:00
Matthew Brown
fa3b292fd4 Fix #101 - restrict the values of pass-by-ref variables 2017-02-23 00:25:28 -05:00
Matthew Brown
12cb72ae4b Prevent recursion when checking for initialisations 2017-02-22 00:51:34 -05:00
Matthew Brown
48335b6fee Fix potential invalid arg 2017-02-22 00:42:50 -05:00
Matt Brown
a56456a719 Add merging of vars_possibly_in_scope back 2017-02-21 17:41:54 -05:00
Matt Brown
fa35c0efa9 Remove changed vars from clauses in while loop to prevent re-application of logic 2017-02-21 17:19:15 -05:00
Matt Brown
2c7ffb6f4c Add support for negating some while assertions 2017-02-21 16:52:27 -05:00
Matthew Brown
9137727993 Fix #99 - treat null coalesce more respectfully 2017-02-17 20:50:47 -05:00
Matthew Brown
7cd1b27ff1 Add more support for logical and/or 2017-02-16 21:00:45 -05:00
Matthew Brown
9579460c59 Fix #97 - is_callable shouldn’t prevent evaluation of calls to existing functions 2017-02-16 20:51:53 -05:00
Matthew Brown
2d58531631 Fix #98 - add support for logical and/or 2017-02-16 20:43:23 -05:00
Matthew Brown
32dd5d5512 Be better about dealing with byref args when not checking functions 2017-02-15 01:47:03 -05:00
Matthew Brown
500044dac1 Make sure $argv and $argc are not globally available 2017-02-12 22:12:31 -05:00
Matthew Brown
1001e03f8a Prevent empty typeof types 2017-02-12 19:51:48 -05:00
Matthew Brown
4f43a7eccb Fix possible nullref 2017-02-12 19:31:35 -05:00
Matthew Brown
1d09616e9d Prevent template types from leaking when no generics are provided 2017-02-12 19:26:23 -05:00
Matthew Brown
a87ea78efc Fix variable-scoped byref issue 2017-02-12 19:07:25 -05:00
Matthew Brown
a4323359d3 Fix ternary/which/for conditionals 2017-02-12 18:47:02 -05:00
Matthew Brown
81e24de76f Fix invalid NullPropertyFetch warning 2017-02-12 18:06:18 -05:00
Matthew Brown
9061d36566 Don’t emit InvalidArrayAccess if ignoring null arrays 2017-02-12 17:13:03 -05:00
Matthew Brown
2635744f4e Simplify array inferred type 2017-02-12 16:58:04 -05:00
Matthew Brown
2f2b487236 Fix #96 2017-02-12 12:31:39 -05:00
Matthew Brown
8e7ab59e2b Add return types for core vars 2017-02-12 12:22:39 -05:00
Matthew Brown
7876c7ffb9 Allow mixed to override null in byref assignment 2017-02-12 11:34:07 -05:00
Matthew Brown
bb9221ba01 Analyze die/exit expressions 2017-02-11 19:42:12 -05:00
Matthew Brown
f32fabd798 Remove dead code 2017-02-11 19:30:06 -05:00
Matthew Brown
deb11c9402 Change some errors from InvalidReturnType to MoreSpecificReturnType 2017-02-11 18:25:44 -05:00
Matthew Brown
35e4b380cc Add collection of PossiblyNull* issues 2017-02-11 17:55:08 -05:00
Matthew Brown
dbddedb20b Don’t create objectlike if we some properties are untyped 2017-02-10 23:35:34 -05:00
Matthew Brown
14c487d3e6 Always supply default template params as return type 2017-02-10 22:51:47 -05:00
Matthew Brown
9b3b536254 Fix issue where self::$property_name doesn’t use Context self 2017-02-10 20:41:18 -05:00
Matt Brown
32d85e20da Remove unused vars 2017-02-10 19:10:13 -05:00
Matt Brown
2c1622e7de Find more unreferenced variables by ignoring mass context ops 2017-02-10 19:08:55 -05:00
Matt Brown
c0a6fc9125 Fix #90 - add genericised stubs for common array functions 2017-02-10 18:12:59 -05:00
Matthew Brown
8ffd45407c Add support for namespaced templates 2017-02-10 00:14:44 -05:00
Matthew Brown
4a82c0a09a Add support for nested types in templates 2017-02-09 22:57:23 -05:00
Matthew Brown
98b0ed280c Add support for templating 2017-02-09 20:35:17 -05:00
Matthew Brown
585cf91ef0 If using assertions for type, count as a soft type check 2017-02-08 22:17:16 -05:00
Matthew Brown
cedb70b0b4 Reduce false positives for unused variables 2017-02-08 01:59:49 -05:00
Matthew Brown
cdcacc395d Rename DeadCode to UnusedVariable, UnusedMethod and UnusedClass 2017-02-08 00:28:26 -05:00
Matt Brown
f4857eb0dd Make dead code check emit an issue 2017-02-07 18:18:33 -05:00
Matt Brown
6b2bb7d917 Store first code location for all variables in a statement list 2017-02-07 18:09:12 -05:00
Matthew Brown
01beb97413 Fix #87 - array types from docblocks can be reasoned about safely 2017-02-03 22:07:14 -05:00
Matthew Brown
11859e9cc0 Bump PhpParser version 2017-02-03 20:14:48 -05:00
Matthew Brown
0fbf8b5619 Remove more dead code 2017-02-02 00:45:23 -05:00
Matthew Brown
ec65f31aaa Improve dead code analysis and fix errors found 2017-02-02 00:20:58 -05:00
Matthew Brown
d3abc0011d Fix #80 - add dead code checks via command line 2017-01-31 23:24:33 -05:00
Matt Brown
004fd42062 Fix #83 - add support for stubbing 2017-01-31 19:21:33 -05:00
Matthew Brown
ce93c4ef2d Assert smart things when offset is variable 2017-01-31 01:35:44 -05:00
Matthew Brown
7f8a3d798e Improve clause resolution in while loops 2017-01-31 01:30:11 -05:00
Matthew Brown
965a79251d Fix #82 by updating how isset calls are handled 2017-01-31 00:34:06 -05:00
Matthew Brown
7d912fc214 Remove vars when they’ve been changed 2017-01-30 22:26:41 -05:00
Matthew Brown
1ece3071f9 Add reference counting for methods and remove dead code 2017-01-29 23:44:05 -05:00
Matthew Brown
d978966db4 Fix #37 - check parent calls for staticness 2017-01-29 22:13:53 -05:00
Matthew Brown
aaec895e15 Do not stop dead when a property cannot be evaluated 2017-01-28 16:12:04 -05:00
Matthew Brown
a9203b63f8 Allow phan-like use of assert 2017-01-28 15:17:14 -05:00
Matthew Brown
199686c4db Add back local vars when descending into method call 2017-01-28 03:55:19 -07:00
Matthew Brown
4c3dacbbed Prevent erroneous __toString conversion in method check 2017-01-27 18:06:11 -07:00
Matthew Brown
6bcc763414 Fix #3 by checking inside __constructor calls for initialisations 2017-01-26 23:23:12 -07:00
Matthew Brown
ff46487353 Be more discerning about unaryminus/plus inferred type 2017-01-25 21:50:34 -07:00
Matthew Brown
c14a19370f Improve UnaryPlus/Minus still more 2017-01-25 20:23:06 -07:00
Matthew Brown
f03807e7b7 Fix unaryplus/minus type inference 2017-01-25 20:02:19 -07:00
Matthew Brown
ea63fd7ae3 Fix #75 - allow inteeger offsets for object-like arrays 2017-01-25 00:11:24 -07:00
Matthew Brown
0da9c10d36 Don’t complain when adding array and object-like array 2017-01-23 15:40:55 -07:00
Matthew Brown
374dc65de1 Fix #39 by checking for ArrayAcces interface 2017-01-20 00:23:58 -05:00
Matthew Brown
894b25487f Fix #71 - prevent instantiation of abstract classes 2017-01-20 00:10:10 -05:00
Matt Brown
d0207b6098 Check that class exists before checking for ArrayAccess inheritors 2017-01-19 19:02:00 -05:00
Matt Brown
a67800cac7 Ignore cloning of mixed variables 2017-01-19 15:00:05 -05:00
Matt Brown
7116585e85 Be more robust when ignoring UndefinedClass errors 2017-01-19 11:45:25 -05:00
Matt Brown
a2750a92aa Evaluate loop part of for after body 2017-01-18 17:13:20 -05:00
Matthew Brown
e78e710eef Be more resilient in the face of class_exists checks 2017-01-17 23:34:17 -05:00
Matt Brown
dae7718ae8 Support array_combine types and introduce a MoreSpecificReturnType issue 2017-01-17 11:17:49 -05:00
Matthew Brown
e4769fd04a Don’t give up when faced with variadic type 2017-01-17 00:07:58 -05:00
Matthew Brown
3cdb1753d5 Update to the more accurate TypeChecker::isContainedBy 2017-01-16 20:00:51 -05:00
Matthew Brown
9220b958eb Fix phpcs errors 2017-01-16 19:06:39 -05:00
Matthew Brown
b3726c9de5 Use getcwd() for the project’s base, not the config file parent directory 2017-01-16 18:33:04 -05:00
Matthew Brown
e3a9cb98c3 Add extra issue for invalid clone and fix issue reporting; 2017-01-16 12:59:09 -05:00
Matthew Brown
4b283564ca Allow variadic params to be passed by reference 2017-01-16 12:39:38 -05:00
Matthew Brown
5315fd15ad Fix namespaced functions in regular use statements 2017-01-16 00:49:12 -05:00
Matthew Brown
ac92de181f Allow classes that use __invoke to be called 2017-01-16 00:29:18 -05:00
Matthew Brown
f614944b63 Add predefined functions to avoid throwing errors 2017-01-15 20:11:02 -05:00
Matthew Brown
ce89ac4986 Fix #50 - asserting about docblock types no longer causes error 2017-01-15 17:52:01 -05:00
Matthew Brown
9b06b672ba Fix #54 - register function constants when function is invoked 2017-01-15 16:43:49 -05:00
Matthew Brown
faccc73dc1 Fix #52 by analysing non-main parts of issets 2017-01-15 13:58:20 -05:00
Matthew Brown
8836f05027 Fix #56 - functions in root namespaces should not need slash 2017-01-15 12:34:23 -05:00
Matthew Brown
ad38a26524 Hoist class check above method check 2017-01-15 10:24:38 -05:00
Matthew Brown
03141e41c2 Move string-stored types into named classes 2017-01-15 10:22:05 -05:00
Matt Brown
35c06261b9 Fix #38 - emit issue for non-array on right too 2017-01-13 13:09:52 -05:00
Matt Brown
dc585ff22a Fix #47 - check closure param types properly 2017-01-13 12:40:01 -05:00
Matthew Brown
c20f31855c Fix namespaced function calls 2017-01-12 09:42:24 -05:00
Matthew Brown
5f54a9571c Fix deep project checks 2017-01-12 01:03:48 -05:00
Matthew Brown
56be346191 Add back mutation checks 2017-01-11 21:37:53 -05:00
Matthew Brown
380ae61b3c Don’t emit another error if we’re already ignoring TypeCoercion 2017-01-09 00:58:18 -05:00
Matthew Brown
bf76843d94 Fix foreach dependency errors 2017-01-09 00:58:05 -05:00
Matthew Brown
f318c52876 Improve function rechecking 2017-01-09 00:31:23 -05:00
Matthew Brown
03c5ea3cef Store all class keys lowercased 2017-01-09 00:14:39 -05:00
Matthew Brown
5cc97e380d Fix issue evaluating Foo::class 2017-01-07 17:24:43 -05:00
Matthew Brown
28cd8caca8 Change analyzeMethods to analyze 2017-01-07 15:57:25 -05:00
Matthew Brown
17329015dc Discriminate between checking, visiting and analyzing in method names 2017-01-07 15:09:47 -05:00
Matthew Brown
694da2cabd Simplify a lot of APIs 2017-01-07 14:35:07 -05:00
Matthew Brown
6ee69e547f Do more to separate out processing steps 2017-01-06 01:07:11 -05:00
Matthew Brown
7609ca02c0 Fix #32 by evaluating all class references in files lazily 2017-01-04 23:42:58 -05:00
Matthew Brown
882c8a8d0c Add better checking of property array assignments 2017-01-02 00:08:35 -05:00
Matthew Brown
d9bf89f72b Fix multiple possible method signature bug 2017-01-01 20:10:28 -05:00
Matthew Brown
30a39a0ee6 Do not emit issue when callable is called 2017-01-01 19:24:15 -05:00
Matthew Brown
883ca6a5db Fix #30 by consolidating properties into single storage array 2017-01-01 19:09:17 -05:00
Matthew Brown
8f7072c175 Fix change empty arrays to nulls 2017-01-01 17:39:39 -05:00
Matthew Brown
0b3b3f01f3 Fix support for traits returning self 2016-12-31 11:49:04 -05:00
Matthew Brown
846cc59d5f Add support for checking closure return types 2016-12-31 10:51:42 -05:00
Matthew Brown
34c238c1a7 Fall through when checking for static/deprecated 2016-12-31 09:25:04 -05:00
Matthew Brown
49f7817a2a Emit specific issue when calling instance method with self:: 2016-12-31 09:20:10 -05:00
Matthew Brown
a524ca8184 Suppress more notices 2016-12-30 20:39:12 -05:00
Matthew Brown
b068bd7858 Fix many bugs 2016-12-30 20:05:32 -05:00
Matthew Brown
4a10bdbc60 Fix suppressed warnings in tests 2016-12-30 19:36:35 -05:00
Matthew Brown
f515327f16 Fix file_name/file_path mixup 2016-12-30 19:06:45 -05:00
Matthew Brown
c65a0bf181 Move function static arrays into FileStorage 2016-12-30 18:08:07 -05:00
Matthew Brown
21816723c7 Make config schema more relaxed about ordering and fix trait bugs 2016-12-30 01:51:29 -05:00
Matthew Brown
3e78405836 # This is a combination of 4 commits.
# The first commit's message is:
Make cofig schema more relaxed about ordering

# This is the 2nd commit message:

Add tests for awkward case

# This is the 3rd commit message:

Fix static calls to class methods within traits

# This is the 4th commit message:

Repopulate fewer arrays
2016-12-30 01:50:33 -05:00
Matthew Brown
641ffc09c9 Add NullOperand issue for easy ignoring 2016-12-29 00:32:12 -05:00
Matthew Brown
18e7c65430 Emit more InvalidOperand issues 2016-12-29 00:14:06 -05:00
Matthew Brown
b6455a2566 Improve how we disable clauses 2016-12-28 18:55:16 -05:00
Matthew Brown
63a75108f5 Evaluate more expressions up front 2016-12-28 17:04:03 -05:00
Matthew Brown
992e7ae256 Fix #1 - add in support for !==false-negating assertions in ifs 2016-12-28 16:39:05 -05:00
Matthew Brown
797875ba9a Fix #10 - allow negated assignments 2016-12-28 16:29:50 -05:00
Matthew Brown
ea30af8a5a Move assertion checks into separate file 2016-12-28 15:52:44 -05:00
Matthew Brown
4919252260 Fix leaking ref in SwitchChecker 2016-12-28 14:38:16 -05:00
Matthew Brown
6972c45c14 Remove vars from parent clauses when they are reconciled with vars 2016-12-28 14:20:16 -05:00
Matthew Brown
05834a0db3 Fix #13 by revamping how we treat type assertions in if statements and ternary expressions 2016-12-28 13:12:06 -05:00
Matthew Brown
513fcea101 Only assign type when not null 2016-12-25 01:12:26 +00:00
Matthew Brown
1fe0eee8e4 Add generic type coercion checks 2016-12-25 01:08:58 +00:00
Matthew Brown
c51d8f5220 Implement MixedOperand and InvalidOperand issues 2016-12-24 18:29:11 +00:00
Matthew Brown
c55870e26c Allow generic TypeChecker::isContainedBy checks 2016-12-24 18:28:43 +00:00
Matthew Brown
9746c8972f Fix MixedAssignment errors 2016-12-17 00:48:31 -05:00
Matt Brown
d012510a41 Fix some mixed assignment issues 2016-12-16 19:22:30 -05:00
Matt Brown
6755c8724a Add tests for M* issues, fixing bugs along the way 2016-12-16 18:56:23 -05:00
Matthew Brown
dcec735d11 Fix generation of MixedArrayAccess issue 2016-12-15 01:28:36 -05:00
Matt Brown
1d804cde66 Expand scope of property checks 2016-12-14 19:19:25 -05:00
Matt Brown
1b8abc8f17 Change NullReference issue to NullArgument when in method call 2016-12-14 12:54:34 -05:00
Matt Brown
154d023a9d Add more robust config testing 2016-12-14 12:28:38 -05:00
Matthew Brown
592ee98efc Fix bugs discovered by adding more tests 2016-12-11 23:40:46 -05:00
Matthew Brown
a84ae58c32 Emit InaccessibleProperty issue where appropriate 2016-12-11 22:18:12 -05:00
Matthew Brown
144625f625 Add numeric check back, with caveats 2016-12-11 20:36:27 -05:00
Matthew Brown
1e8f986d8c Narrow down error lines for reconcileKeyedTypes 2016-12-11 13:59:36 -05:00
Matthew Brown
562f71b21f Add TypeDoesNotContainType issue and fix those issues in Psalm code 2016-12-11 13:48:11 -05:00
Matthew Brown
73b1ab1411 Support int offsets in dealing with type inference 2016-12-10 18:24:28 -05:00
Matthew Brown
327e3150a2 Fix erroneous self-check 2016-12-10 15:08:38 -05:00
Matthew Brown
c3df70e634 Allow int offsets to be treated as keys 2016-12-10 15:01:59 -05:00
Matt Brown
eff98bfe00 Ignore nullrefs when using echo 2016-12-09 18:53:26 -05:00
Matt Brown
30159d8f70 Ignore invalid scalar argument issue in echo 2016-12-09 12:53:22 -05:00
Matt Brown
b3106c68bb Fix #6 - raise error with erroneous __toString 2016-12-09 12:48:02 -05:00
Matt Brown
ce3b24bf5f Fix #8 - defer always to call map if function not user-defined 2016-12-09 12:07:47 -05:00
Matt Brown
e6ff24b8d2 Fix assignment in elseif 2016-12-09 12:06:14 -05:00
Matt Brown
28621485b0 Add support for parent-defined consts 2016-12-08 17:19:06 -05:00
Matt Brown
260a6d4df5 Make class errors more specific 2016-12-08 17:15:51 -05:00
Matt Brown
c9557d47ce Fix exponentiation and modulo type inference 2016-12-08 16:37:14 -05:00
Matt Brown
117645ac73 Account for off-by-one issue in PhpParser 2016-12-08 15:57:18 -05:00
Matt Brown
55a060b53a Add support for closure checks 2016-12-07 14:13:39 -05:00
Matt Brown
48e19fc7e5 Add support for closure docblocks 2016-12-06 19:41:52 -05:00
Matt Brown
af1a932655 Make code location more accurate 2016-12-06 18:27:22 -05:00
Matthew Brown
ef1049224d Add selection of return types in code preview 2016-12-06 16:33:47 -05:00
Matthew Brown
60e15c255b Add support for gettype switch statements too 2016-12-06 13:51:03 -05:00
Matthew Brown
37166a27b9 Set inferredType without needing string key offsets 2016-12-04 19:33:14 -05:00
Matthew Brown
35802ccaa6 Don't totally panic when encountering invalid argument error 2016-12-04 18:42:20 -05:00
Matthew Brown
dcb9e1af14 Be more lenient when computing result of addition/subtraction 2016-12-04 18:41:33 -05:00
Matthew Brown
03d8a4ab0b Add support for array destructuring with keys 2016-12-04 14:14:00 -05:00
Matthew Brown
b912dd2777 Add support for array destructuring 2016-12-04 13:35:38 -05:00
Matthew Brown
7cb6891a0b Add support for class constant visibility 2016-12-04 01:44:33 -05:00
Matthew Brown
0675e3364a Fix PHPParser 3.0.1 compatibility issues 2016-12-03 22:41:45 -05:00
Matthew Brown
a1acbfec07 Show code snippets when reporting errors
This also introduces a new method of identifying specific code locations when creating issues
2016-12-03 19:11:30 -05:00
Matthew Brown
134bc950fb Add specific NullArrayAccess error 2016-11-22 11:11:47 -05:00
Matthew Brown
4f95c67e1c Emit issues for null/mixed array access 2016-11-21 19:07:56 -05:00
Matthew Brown
cf0c0cdda2 Do not quit, just fall through 2016-11-21 18:38:56 -05:00
Matthew Brown
7b3ab79aab Treat empty as mixed 2016-11-21 17:49:07 -05:00
Matthew Brown
05a004c8bc Add check for array access on invalid type 2016-11-21 16:44:35 -05:00
Matthew Brown
5a9f99c24e Fix namespacing issues in PHP 5.6 2016-11-20 21:49:06 -05:00
Matthew Brown
d542b22322 Add belt & braces file checking 2016-11-18 16:13:59 -05:00
Matthew Brown
f2ce83c8e5 Fix minor boop 2016-11-13 15:55:06 -05:00
Matthew Brown
fa2209719b Fix nullref 2016-11-13 15:46:35 -05:00
Matthew Brown
409a7e4b9e Fix assignment checks 2016-11-13 15:39:16 -05:00
Matthew Brown
87bb4a2f52 Fix various issues with docblock updates 2016-11-13 01:43:51 -05:00
Matthew Brown
05ae7905d9 Refactor IfChecker to break apart massive method 2016-11-11 17:13:30 -05:00
Matthew Brown
264e77addd Change a few more words 2016-11-07 19:16:51 -05:00
Matthew Brown
36fc49965b Correct speling 2016-11-07 17:31:02 -05:00
Matthew Brown
622a0794c3 Swap in Fully-Qualified for Absolute terms 2016-11-07 17:29:51 -05:00
Matthew Brown
3b038db454 Avoid missing property 2016-11-07 15:29:47 -05:00
Matthew Brown
721e0d01e2 Get rid of var_dumps 2016-11-05 20:53:39 -04:00
Matthew Brown
7d6ac4719f Fix offset assignment creation 2016-11-05 20:17:22 -04:00
Matthew Brown
b3f3a20928 Correctly evaluate $this and self in property/return types 2016-11-05 18:31:09 -04:00
Matthew Brown
7c44353116 Add inferredType to InstanceOf_ 2016-11-05 17:57:14 -04:00
Matthew Brown
c5591adf10 Add support for global in functions and mixed inferred return errors 2016-11-05 17:54:34 -04:00
Matthew Brown
7df4d74a7b Fix Psalm errors 2016-11-04 21:14:04 -04:00
Jon Ursenbach
27c2db1d1d PSR-2 2016-11-02 17:50:54 -04:00
Matthew Brown
5cc5bd4ed4 Fix tests to all have property types 2016-11-01 14:32:19 -04:00
Matthew Brown
b78e83c4c0 Break out method 2016-11-01 14:20:01 -04:00
Matthew Brown
88eb43e9ca Break out ExpressionChecker 2016-11-01 14:14:41 -04:00
Matthew Brown
712752d587 Split out asssignment methods 2016-11-01 11:37:58 -04:00
Matthew Brown
34af24a2b4 Add all the properties 2016-11-01 00:39:41 -04:00
Matthew Brown
c2f63c392e Emit issue if property type is missing 2016-10-31 15:17:54 -04:00
Matthew Brown
8fefaecd9c Skip when encountering null list var 2016-10-30 19:59:26 -04:00
Matthew Brown
4d5b0abb74 Add explicit value tracking 2016-10-30 19:52:35 -04:00
Matthew Brown
b220ee51cc Correctly assign list values 2016-10-30 19:38:08 -04:00
Matthew Brown
53cef386a2 Do not error on mixed input 2016-10-30 12:53:56 -04:00
Matthew Brown
6cd63cc0f3 Fix nullref 2016-10-30 12:51:41 -04:00
Matthew Brown
604c875d0c Fix more errors caught by Psalm 2016-10-30 12:46:18 -04:00
Matthew Brown
722a7fba5c Don't squeal when autoloading classes 2016-10-30 01:13:33 -04:00
Matthew Brown
98437c52db Check closure params to see if they align with array_map/array_filter args 2016-10-29 22:17:46 -04:00
Matthew Brown
9f94add470 Update plugin interface to add $suppressed_issues 2016-10-28 16:49:42 -04:00
Matthew Brown
b31ac4a862 Removed object-like type descriptor in favour of array{} syntax 2016-10-28 13:24:06 -04:00
Matthew Brown
0b0a5ff0e8 Better check for bad static invocation 2016-10-28 10:22:45 -04:00
Matthew Brown
95f5a4603a Add property for poorly-reflected builtin classes 2016-10-27 16:05:27 -04:00
Matthew Brown
357cd8ad41 Add support for Closure::__invoke 2016-10-24 15:55:05 -04:00
Matthew Brown
ce95275878 Fix more Psalm bugs found by Psalm 2016-10-23 12:24:53 -04:00
Matthew Brown
d8b10a6c97 Fix errors caught by Psalm 2016-10-23 01:57:11 -04:00
Matthew Brown
fbdfc78546 Fix references to moved fucntionality 2016-10-22 18:25:14 -04:00
Matthew Brown
f3f1ba1caa Break out block checkers 2016-10-22 17:35:59 -04:00
Matthew Brown
2bea64ca52 Split out SwitchChecker 2016-10-22 13:37:06 -04:00
Matthew Brown
dda4c52e03 Fix ref 2016-10-22 13:29:32 -04:00
Matthew Brown
e4ba8b1abc Make StatementsChecker much smaller 2016-10-22 13:28:40 -04:00