danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-12-15 19:07:00 +01:00
Code Issues Projects Releases Wiki Activity
2,154 Commits 43 Branches 314 Tags 108 MiB
88ca7d2fa7
Commit Graph

1745 Commits

Author SHA1 Message Date
Matthew Brown
032cd3b897 Fix #254 - catch parse exception when improving function types 2017-10-22 01:04:35 -04:00
Matt Brown
3c6a8a0b24 Fix #251 - allow Psalm to analyse Wordpress 2017-10-19 19:19:29 -04:00
Matt Brown
c395930a06 Fix missing function issue ref #251 2017-10-19 18:23:18 -04:00
Matt Brown
dbcec1be38 Fix #249 - get out of nested class 2017-10-19 14:40:38 -04:00
Matthew Brown
2e00fb19ee Fix #246 - amend return type for DateTime::createFromFormat 2017-10-16 00:47:48 -04:00
Matthew Brown
295792d550 Fix #235 - add psalm.xml option to support igbinary serializer 2017-10-15 12:38:47 -04:00
Matthew Brown
657d154288 CacheProvider -> ParserCacheProvider 2017-10-15 11:57:44 -04:00
Matthew Brown
00aaa4adaf Fix #242 - add --no-cache option 2017-10-13 21:27:20 -04:00
Matthew Brown
8c4a3734a3 Revert serialisation changes 2017-10-12 20:27:33 -04:00
Matthew Brown
38c8a1d9cf Stop analysing statements if expression has errors 2017-10-12 20:24:22 -04:00
Matthew Brown
b7f6d15a24 Don’t freak out over incorrectly-cased classes 2017-10-12 19:53:12 -04:00
Matthew Brown
d455e24958 Make shallow type comparison case insensitive ref #240 2017-10-12 19:46:00 -04:00
Matt Brown
024bcbc371 Fix #239 - warn about bad brackets 2017-10-12 14:02:06 -04:00
Bruce Weirdan
ed3e429d2c s/'mixed'/''/g 2017-10-12 09:21:49 -04:00
Bruce Weirdan
52962db24c Adjusted Closure methods signatures 
This fixes the following false-positive:
```php
function a(): bool {
  $a = function(): bool { return true; }
  return $a->call(new stdClass);
}
```
where psalm previously complained about (wrongly) inferred type to be
Closure
 2017-10-12 09:21:49 -04:00
Matthew Brown
1b7a5c2944 Fix #236 - incorrect operand issue text 2017-10-12 08:51:57 -04:00
Bruce Weirdan
f080e32ef0 Corrected case of Traversable typehints 
Affected functions/methods:
* `iterator_apply()`
* `iterator_count()`
* `IteratorIterator::__construct()`
* `iterator_to_array()`

This fixes the following false-positive:
```php
class Iter extends IteratorIterator {
    public function __construct(Traversable $a) {
	parent::__construct($a);
    }
}
```
where psalm previously wanted `parent::__construct()` argument to be
`traversable` (all-lowercase).
 2017-10-12 08:49:24 -04:00
Matthew Brown
deb489e82d Fix #232 - discard clauses when evaluating catch block 2017-10-10 23:09:19 -04:00
Matthew Brown
862d22e83c Fix #230 - invalidate root vars on $arr[]= assignment 2017-10-10 23:01:52 -04:00
Matthew Brown
b43c2d5f0c Fix #231 - add special case for === false checks 2017-10-10 22:36:33 -04:00
Matthew Brown
7ebffbcd2d Bump parser version 2017-10-07 15:06:47 -04:00
Matthew Brown
beea51d7bf Fix property check 2017-10-07 15:05:05 -04:00
Matthew Brown
cbc889a498 Add cache-clearing mechanism 2017-10-07 14:41:16 -04:00
Matthew Brown
e47198b326 Add workaround for Psalm checking itself on PHP 5.6 2017-10-07 11:38:51 -04:00
Matthew Brown
6ab693ceeb Add missing class 2017-10-07 11:31:18 -04:00
Matthew Brown
9774131876 Fix #224 - explicit string casts fail when no __toString present 2017-10-07 11:27:54 -04:00
Matthew Brown
483b4c75f3 Fix #223 - array_map with too few args should have issue 2017-10-07 10:33:19 -04:00
Matthew Brown
6b4bd47ddb Fix #181 and #225 - resolve problems with self in comments/return statements 2017-10-07 10:22:52 -04:00
Matthew Brown
1cc13bdeeb Prevent TNamedObject from having a leading slash 2017-10-06 23:35:16 -04:00
MacFJA
a38c36c597 Always generate report files, even if no errors and warnings 2017-10-02 07:38:22 -04:00
Steffen Weber
4145119268 Fix case of ZipArchive properties 
The properties "numFiles" and "statusSys" use camelCase.

https://secure.php.net/manual/en/class.ziparchive.php
 2017-09-26 10:38:06 -04:00
Matthew Brown
5bd6228708 Fix #220 - don’t worry about parent property access 2017-09-24 08:17:27 -04:00
Matt Brown
ee655e6f33 Fix #218 - strings passed to format always return string 2017-09-22 10:18:44 -04:00
Bruce Weirdan
ed0e9702ae Adjusted signatures of DateTime and friends 
* __wakeup is void -> void, see http://php.net/manual/en/language.oop5.magic.php#object.wakeup
* DateTime::__construct() does not accept null as time
* DateTimeZone::getLocation() has no last $object parameter
* ditto for DateTimeZone::getName()
* ditto for DateTimeZone::getTransitions()
 2017-09-22 10:06:24 -04:00
Matt Brown
1012c23ff5 Fix assertion checks 2017-09-21 16:31:19 -04:00
Matt Brown
d949165eb6 Fix #217 - bad param count for DateTimeImmutable::getTimezone 2017-09-21 15:37:05 -04:00
Matt Brown
3bc497b18e Fix #217 - bad param count for DateTimeImmutable::getTimezone 2017-09-21 15:36:26 -04:00
Matt Brown
6f911c7386 Emit more specific operand issues 2017-09-20 11:22:17 -04:00
Matthew Brown
e42e590442 Add more descriptive exception messages 2017-09-20 08:43:54 -04:00
Matthew Brown
1a9592fc62 Fix #215 where ReflectionMethod implementing class is not a parent class or parent interface 2017-09-19 23:35:37 -04:00
François Kooman
eb79cb7172 fix running Psalm on itself due to its use of json_encode 2017-09-18 16:14:01 -04:00
François Kooman
8e35a72cc3 fix json_encode return values 
`json_encode` can also return `false`
 2017-09-18 16:14:01 -04:00
Matt Brown
d380bf3f19 Fix #209 - fix issue with file load order results change 2017-09-18 16:10:08 -04:00
Matthew Brown
e84586cfaa Fix return type space issue 2017-09-16 15:08:11 -04:00
Matthew Brown
7c261d7d1f Add return after every special type 2017-09-16 15:00:50 -04:00
Matthew Brown
391696bc83 Use a blacklist, not a whitelist 2017-09-16 13:28:33 -04:00
Matthew Brown
3a8efec728 Add error for pass by reference 2017-09-16 13:16:21 -04:00
Matthew Brown
fc6b663c8a Only write files if they’re changed 2017-09-16 12:52:46 -04:00
Matthew Brown
9a3cb742cb Refactor docblock manipulation and add tests for it 2017-09-16 12:45:20 -04:00
Matthew Brown
995e92a8c3 Remove empty if block 2017-09-14 00:36:38 -04:00
Matthew Brown
2a4a6fc490 Exit early if checking iterable for methods 2017-09-14 00:32:14 -04:00
Matthew Brown
313e1c383c Fix edge-case issue with abstract class not fully implementing interface 2017-09-13 23:57:11 -04:00
Matt Brown
5b3531b5a5 Fix null coalescing on nullable output 2017-09-13 14:35:42 -04:00
Matt Brown
eee8442af6 Fix #199 - allow classes to suppress PropertyNotSetInConstructor warnings 2017-09-13 11:32:13 -04:00
Matt Brown
439a1ddc97 Exit early if a bad class is detected 2017-09-11 11:58:11 -04:00
Matt Brown
d1807cfb95 Improve checks for switch types 2017-09-11 11:58:11 -04:00
François Kooman
8a28ab4b26 Fix some cURL function return values (#208) 
At least the functions referenced here can also return boolean
`false` according to the PHP manual. Add this information to the
CallMap file.
 2017-09-10 21:49:51 -04:00
MacFJA
c4ce8bede9 Add XML as possible output format + add report generation (#206) 
* Add XML as possible output format + add report generation

* Add missing xml root node

* Change XML generator (previous one don't escape '<' and '>')

* Change option (only one option) + unit test
 2017-09-08 11:18:48 -04:00
Matthew Brown
e89a2929d5 Infer types from numeric operations 2017-09-06 21:44:26 -04:00
Matthew Brown
9f9e8a1b30 Improve API for inference 2017-09-03 20:52:54 -04:00
Matthew Brown
11aa3558b7 Make sure encapsulated strings can also coerce param types 2017-09-02 19:48:59 -04:00
Matthew Brown
a0c27cee4f Allow param types to be inferred from presence of concat ops 2017-09-02 19:23:00 -04:00
Matthew Brown
a725009181 Only say we could not infer param type if we’re actively looking 2017-09-02 18:26:19 -04:00
Matthew Brown
6531e3bfb8 Throw exception if impossible state is reached 2017-09-02 18:22:44 -04:00
Matthew Brown
73694ab04e Suggest types when complaining of untype params 
Ref #204
 2017-09-02 18:15:52 -04:00
Matthew Brown
8aabcbce35 Introduce UntypedParam warnings when functions are missing param types 2017-09-02 11:18:56 -04:00
Matt Brown
1cc63fe718 Ignore leading slash in array_map methods 2017-08-30 13:45:41 -04:00
Matthew Brown
622217b708 Fix #205 - add file references at analysis stage too 2017-08-22 12:38:38 -04:00
Matthew Brown
fb656f3575 Fix #203 and detect invalid countable count calls 2017-08-19 13:30:33 -04:00
Matthew Brown
e4e6c2a6e6 Fix #201 - list/array assignment should invalidate clauses too 2017-08-18 23:14:38 -04:00
Matthew Brown
fbc6379275 Fix #202 - vars changed inside loops should invalidate clauses 2017-08-18 22:41:25 -04:00
Matt Brown
8c6835b928 Remove redundancy 2017-08-18 17:11:39 -04:00
Matt Brown
d106587737 Add better check for value 2017-08-18 17:10:57 -04:00
Matt Brown
3075f16308 Ignore static, self and parent in callable class names 2017-08-18 17:02:15 -04:00
Matt Brown
9a036cb4ab Fix resource signatures 2017-08-18 16:51:34 -04:00
Matt Brown
c626b7d68a Fix #200 - allow mapping of more callable strings, and callable arrays 2017-08-14 19:30:11 -04:00
Matt Brown
0b0e7aa662 Fix #197 - allow nested class and function definitions 2017-08-14 15:46:01 -04:00
Matt Brown
d6e2e786db Ignore self calls as well 2017-08-11 19:09:15 -04:00
Matt Brown
a7baa7e928 Support callable checks on inline-defined functions 2017-08-11 19:05:04 -04:00
Matt Brown
13d98b803d Check that callable string class exists first 2017-08-11 18:48:58 -04:00
Matt Brown
17a900ab54 Add ability to detect invalid callable functions 2017-08-11 18:30:58 -04:00
Matt Brown
396d214e3c Throw exception when function storage is missing 2017-08-08 14:45:47 -04:00
Matt Brown
8f9fdcb637 Create storage for plugins before scanning 2017-08-08 11:03:45 -04:00
Matt Brown
4b5a5ead74 Fix paradox detection for multiple clauses 2017-08-07 18:38:38 -04:00
Matt Brown
e9b50cd2f1 Fix #196 to prevent false positives 2017-08-07 17:52:09 -04:00
Matthew Brown
4175295113 Isolate where we load static storage objects (#195) 
* Move FileChecker::$storage calls to provider

* Add ClassLikeStorageProvider

* Use ClassLikeStorageProvider everywhere

* Move storage arrays into providers
 2017-07-29 15:05:06 -04:00
Matthew Brown
3859c3c3cf Narrow abstract check 2017-07-28 23:53:06 -04:00
Matthew Brown
c5952af6f0 Fix bug with trait implementing abstract method 2017-07-28 23:38:57 -04:00
Matt Brown
22b6dafe3c Fix #194 - carry over const definitions 2017-07-28 10:42:30 -04:00
Matt Brown
c8ec0dc650 Fix casing issue 2017-07-27 19:14:16 -04:00
Matt Brown
84f1993a2e Fix potential bug on case-sensitive OSes with badly-cased comment polluting code 2017-07-27 16:59:41 -04:00
Matt Brown
3e60b4b6ad Fix formatting 2017-07-27 16:15:17 -04:00
Matt Brown
aca295ef7d Build up file-class references on initial scan 2017-07-27 16:13:26 -04:00
Matthew Brown
2c1a0b197e Remove param typehint 2017-07-26 23:47:29 -04:00
Matthew Brown
0d88b4f2e7 Remove whitespace 2017-07-26 21:27:59 -04:00
Matt Brown
7b178a2b25 Add ability to stub constants 2017-07-26 19:54:22 -04:00
Matt Brown
0e67565b2c Return null if path exists 2017-07-26 19:36:41 -04:00
Matt Brown
b4a46429df Add FileChecker subclass analysis 2017-07-26 19:27:30 -04:00
Matt Brown
dbb1bf2e73 Add addSuppressedIssue API method back 2017-07-26 16:09:09 -04:00
Matt Brown
76ba419330 Group unused tests together 2017-07-25 17:04:58 -04:00
Matthew Brown
e29dd140e3 Refactor scanning and analysis, introducing multithreading (#191) 
* Add failing test

* Add visitor to soup up classlike references

* Move a whole bunch of code into the visitor

* Move some methods back, move onto analysis stage

* Use the getAliases method everywhere

* Fix refs

* Fix more refs

* Fix some tests

* Fix more tests

* Fix include tests

* Shift config class finding to project checker and fix bugs

* Fix a few more tests

* transition test to new syntax

* Remove var_dump

* Delete a bunch of code and fix mutation test

* Remove unnecessary visitation

* Transition to better mocked out file provider, breaking some cached statement loading

* Use different scheme for naming anonymous classes

* Fix anonymous class issues

* Refactor file/statement loading

* Add specific property types

* Fix mapped property assignment

* Improve how we deal with traits

* Fix trait checking

* Pass Psalm checks

* Add multi-process support

* Delay console output until the end

* Remove PHP 7 syntax

* Update file storage with classes

* Fix scanning individual files and add reflection return types

* Always turn XDebug off

* Add quicker method of getting method mutations

* Queue return types for crawling

* Interpret all strings as possible classes once we see a `get_class` call

* Check invalid return types again

* Fix template namespacing issues

* Default to class-insensitive file names for includes

* Don’t overwrite existing issues data

* Add var docblocks for scanning

* Add null check

* Fix loading of external classes in templates

* Only try to populate class when we haven’t yet seen it’s not a class

* Fix trait property accessibility

* Only ever improve docblock param type

* Make param replacement more robust

* Fix static const missing inferred type

* Fix a few more tests

* Register constant definitions

* Fix trait aliasing

* Skip constant type tests for now

* Fix linting issues

* Make sure caching is off for tests

* Remove unnecessary return

* Use emulative parser if on PHP 5.6

* Cache parser for faster first-time parse

* Fix constant resolution when scanning classes

* Remove test that’s beyond a practical scope

* Add back --diff support

* Add --help for --threads

* Remove unused vars
 2017-07-25 16:11:02 -04:00
Matt Brown
e83ea3a5fe Fix #192 - correct SessionHandlerInterface::gc signature 2017-07-24 17:58:38 -04:00
Matthew Brown
86f2a9981c Fix #190 by updating callmap 2017-07-19 08:54:01 -04:00
Matt Brown
592194e9f2 Fix #187 by splitting abs into int and float versions 2017-07-14 18:09:25 -04:00
Matthew Brown
e33d8dac2e Remove unnecessary check 2017-07-12 22:00:33 -04:00
Matthew Brown
17205bc093 Be more strict about what properties we check 2017-07-10 20:20:40 -04:00
Matt Brown
cfbf256593 Add version check for reflected function return type 2017-07-10 10:38:02 -04:00
Matthew Brown
b3c992d7aa Don’t suppress PHP fatal errors in debug mode 2017-07-09 23:34:16 -04:00
Matthew Brown
dcb6ecd3fd Fix reference errors 2017-07-09 23:26:16 -04:00
Matthew Brown
05674ef3bc Fix #182 by properly registering autoload file functions 2017-07-09 23:24:06 -04:00
Matthew Brown
e60f085741 Fix #178 - complain when encountering bad @return type 2017-07-09 20:32:35 -04:00
Matthew Brown
869c65b4fc Move property check to relevant position 2017-07-09 18:37:30 -04:00
Matthew Brown
cb6d9457ee Fix issue reporting on uninitialised properties in foreign classes 2017-07-09 18:33:56 -04:00
Matthew Brown
581cf5f7eb Don’t allow trait to override non-abstract method definition for parent class 2017-07-09 15:54:43 -04:00
Matthew Brown
90f3b88544 Correct casing 2017-07-09 15:27:07 -04:00
Matthew Brown
39a27f41b3 Prevent checking reflected methods for mutations 2017-07-09 15:19:05 -04:00
Matthew Brown
922b6640fa Avoid possible nullrefs 2017-07-09 14:50:57 -04:00
Matthew Brown
32ff386b4a Fix #184 - prevent classes without reflected classes from breaking everything 2017-07-09 14:36:06 -04:00
Matthew Brown
a2a86ef9b1 Fix psalm issue 2017-07-08 22:19:53 -04:00
Matthew Brown
23f41b4543 Narrow down the error location even further 2017-07-08 22:11:55 -04:00
Matthew Brown
83a6f914a7 Add start/end file offsets for better Psalm errors 2017-07-08 22:06:49 -04:00
Matthew Brown
67338c4bf5 Also detect non-inherited private constructors 2017-07-08 22:01:26 -04:00
Matthew Brown
c7b0f6685f Make Psalm a bit faster 2017-07-08 21:19:16 -04:00
Matthew Brown
95de80b7f1 Make signature nullable 2017-06-30 14:16:27 -04:00
Matthew Brown
91bdd65588 Fix #179 - check for abstract method instantiations 2017-06-30 10:24:47 -04:00
Matthew Brown
d8654b8389 Slow down Psalm by checking parent initialisations too 2017-06-30 01:24:45 -04:00
Matthew Brown
fe6f0c073b Exit early if var not defined 2017-06-29 20:34:43 -04:00
Matt Brown
3dceebc42f Make type combination less dependant on __toString 2017-06-29 17:40:25 -04:00
Matt Brown
fef589fb68 Fix issue with array access on property 2017-06-29 17:39:46 -04:00
Matt Brown
d39aeb9c3d Fix casing in dom* classes 2017-06-29 12:10:07 -04:00
Matt Brown
effdec6b1d Separate objectlike types into their own container 2017-06-29 11:48:00 -04:00
Matt Brown
3775b29e30 Move by-ref types into object 2017-06-29 11:18:02 -04:00
Matt Brown
5220df4837 Fix #177 - treat return type as nullable due to try 2017-06-29 10:33:54 -04:00
Matthew Brown
368b6670d7 Fix a few edgecases 2017-06-29 00:28:37 -04:00
Matthew Brown
8fd671bdc4 Fix #167 - prevent Empty type in assignment 2017-06-28 23:37:02 -04:00
Matthew Brown
4a590000a6 Fix whitespace issue 2017-06-26 20:14:58 -04:00
Matthew Brown
678b6113d5 Fix #127 - allow Psalm to analyse composer autloaded files 2017-06-26 20:13:10 -04:00
Matthew Brown
bc35f88859 Fix issue with $this instanceof checks in traits 2017-06-23 00:39:37 -04:00
Matt Brown
967b51d5fc Make sure that traits are listed as analyzable so issues can be shown 2017-06-21 16:36:45 -04:00
Matt Brown
f49d167a49 Add tracking from where a trait was included 2017-06-21 14:22:52 -04:00
Matthew Brown
878696b72c Fix #173 - don’t emit MissingConstructor issues from trait constructor 2017-06-21 01:25:41 -04:00
Matt Brown
e5c25eae97 Fix #172 - make sure new coalesce vars escape brackets 2017-06-20 15:38:32 -04:00
Matt Brown
e1d5eab7a2 Fix long line 2017-06-20 14:07:54 -04:00
Matt Brown
473040ca8f Fix #171 by supporting exit statements for fopen 2017-06-20 13:25:37 -04:00
Matt Brown
f4338c38e7 Fix #148 - suppress InvalidDocblock where appropriate 2017-06-13 14:00:41 -04:00
Matthew Brown
f9b16c9a2d Explicitly cast mock class to string 2017-06-13 00:51:16 -04:00
Matthew Brown
6b2b80d0bb Assign var to correct context 2017-06-13 00:09:15 -04:00
Matthew Brown
152d1512f1 Fix issue capturing method mutations in traits 2017-06-12 22:51:39 -04:00
Matthew Brown
72e1221a2f Fix #168 and add test case 2017-06-11 19:20:07 -04:00
Matt Brown
1745518c2c Fix #166 - prevent require loop 2017-06-06 10:11:34 -04:00
Matthew Brown
81223c45e0 Fix #166 - return instead of looping infinitely 2017-06-05 21:46:04 +01:00
Matthew Brown
fa4678912f Fix possible nullref 2017-05-29 23:21:46 -04:00
Matthew Brown
8c0aced195 Add specific check for return type parse issue ref #165 2017-05-29 20:58:49 -04:00
Matthew Brown
93e7486d5e Reduce line length 2017-05-26 20:17:56 -04:00
Matthew Brown
22a716f4da Improve formatting of phpdocs 2017-05-26 20:16:18 -04:00
Matthew Brown
d6909193ea Add additional formatting changes 2017-05-26 20:05:57 -04:00
SignpostMarv
adef59629a scrutinizer-ci (#152) 
* swapping phpcs for php-cs-fixer

* workaround for php-cs-fixer treating parenthesis following echo as the function call variant

* amending rules

* blank_line_before_return

* majority of files pass with these disabled, could remove later

* combine_consecutive_unsets

* concat_space

* placeholder for if vimeo/psalm ever goes php:^7.0

* function_to_constant

* disabling include

* linebreak_after_opening_tag, lowercase_cast, magic_constant_casing

* mb_str_functions disabled

* method_separation

* native_function_casing

* native_function_invocations

* new_with_braces disabled to match usage

* no_alias_functions

* no_blank_lines_after_class_opening

* no_blank_lines_after_phpdoc

* no_blank_lines_before_namespace

* no_empty_comment

* no_empty_phpdoc

* no_empty_statement

* no_extra_consecutive_blank_lines

* no_leading_import_slash to discuss

* no_leading_namespace_whitespace

* no_mixed_echo_print

* no_multiline_whitespace_around_double_arrow

* no_multiline_whitespace_before_semicolons

* no_php4_constructor

* no_short_bool_cast

* no_short_echo_tag

* no_singleline_whitespace_before_semicolons

* no_spaces_around_offset

* no_trailing_comma_in_list_call

* no_trailing_comma_in_singleline_array

* no_unneeded_control_parentheses to discuss

* no_unreachable_default_argument_value

* no_unused_imports to discuss

* no_useless_else to discuss

* no_useless_return

* no_whitespace_before_comma_in_array

* no_whitespace_in_blank_line

* non_printable_character

* normalize_index_brace

* ordered_class_elements to discuss

* ordered_imports to discss

* php_unit_construct

* php_unit_dedicate_assert

* php_unit_fqcn_annotation

* php_unit_strict to discuss

* php_unit_test_class_requires_covers to discuss

* phpdoc_add_missing_param_annotation

* phpdoc_align to discuss

* phpdoc_annotation_without_dot to discuss

* phpdoc_indent to discuss

* phpdoc_inline_tag

* phpdoc_no_access

* phpdoc_no_alias_tag

* phpdoc_no_empty_return

* phpdoc_no_package

* phpdoc_no_useless_inheritdoc

* phpdoc_order to discuss

* phpdoc_return_self_reference

* phpdoc_scalar to discuss

* phpdoc_separation to discuss

* phpdoc_single_line_var_spacing

* phpdoc_summary to discuss

* phpdoc_to_comment to discuss

* phpdoc_trim to discuss

* phpdoc_types

* phpdoc_var_without_name

* pow_to_exponentiation

* pre_increment to discuss

* protected_to_private

* psr0 turned off

* psr4 turned on

* random_api_migration

* return_type_declaration to discuss

* self_accessor to discuss

* semicolon_after_instruction

* short_scalar_cast

* silenced_deprecation_error turned off

* simplified_null_return to discuss

* single_quote

* space_after_semicolon

* standardize_not_equals

* strict_comparison to discuss

* strict_param to discuss

* ternary_operator_spaces

* ternary_to_null_coalescing should be set to true if vimeo/psalm ever goes php:^7.0

* trailing_comma_in_multiline_array to discuss

* trim_array_spaces

* unary_operator_spaces

* whitespace_after_comma_in_array to discuss

* multi-version scrutinizer to match travis

* binary_operator_space

* not the best solution, but it works to exclude the call map from php-cs-fixer

* reducing verbosity of config where defaults were used

* dry run php-cs-fixer as part of tests

* disabling rule pending FriendsOfPHP/PHP-CS-Fixer#2739

* enabling no_unused_imports

* enabling ordered_imports

* ignoring user-defined .php_cs

* using $TRAVIS_COMMIT_RANGE to only test modified files

* enabling no_leading_import_slash

* conditionally testing everything

* filter output then perform exact match

* restoring phpcs via partial cherry pick of f65c618
 2017-05-26 18:26:14 -04:00
Matthew Brown
688a72c794 Fix #36 - emit issues on deprecated properties 2017-05-25 01:32:34 -04:00
Matthew Brown
0fdf281896 Add support for @deprecated classes 2017-05-25 00:34:39 -04:00
Matthew Brown
44b4d04e0a Fix #95 - emit issue on private constructor calls 2017-05-24 23:55:54 -04:00
Matthew Brown
8f317cd8a2 Fix #133 - emit issue when calling no-constructor class with args 2017-05-24 23:11:40 -04:00
Matthew Brown
f5fc91a506 Remove stray docblock 2017-05-24 22:32:52 -04:00
Matthew Brown
4fd46e1752 Improve formatting 2017-05-24 22:07:49 -04:00
Matthew Brown
42b435e23f Fix #134 - warn when docblock type is ill-formatted 2017-05-24 21:11:18 -04:00
muglug
77a44051c5 Fix issues with @psalm-ignore-nullable-return types 2017-05-22 14:50:03 -04:00
muglug
65d86d35ad Separate iterator issues 2017-05-22 11:59:58 -04:00
Matthew Brown
96e3ad02fc Remove blank line 2017-05-21 13:52:06 -04:00
Matthew Brown
92e184086f Fix #158 - prevent using resource in return type 2017-05-21 13:48:17 -04:00
Matthew Brown
4d020bcbdb Remove unnecessary imports in tests 2017-05-19 00:52:15 -04:00
Matthew Brown
7532e32b9d Fixed spacing and use statement formatting 2017-05-19 00:48:26 -04:00
Matt Brown
052624fa94 Fix issue calculating inherited parent property mutations 2017-05-12 19:15:08 -04:00
Matt Brown
53b81ac2e1 Fix pass-by-ref 2017-05-10 14:05:26 -04:00
github@muglug.com
20d4831f67 Improve return type ignore_nullable inference 2017-05-10 14:03:51 -04:00
Matt Brown
d7e2c5ee3c Don’t emit InvalidReturnType when we don’t care about nullability 2017-05-10 13:52:24 -04:00
Matt Brown
f73fc7c6eb Carry over ignore_nullable_issues when combining/simplifying types 2017-05-10 13:36:05 -04:00
Matt Brown
cadaef14e6 Carry forward ignore_nullable_return in fleshOutType 2017-05-10 12:49:59 -04:00
Matt Brown
39ece995b6 Add @psalm-ignore-nullable-return annotation 2017-05-10 12:36:11 -04:00
github@muglug.com
9ff8736e53 Add the means to ignore PossiblyNull* errors from the type itself 2017-05-09 16:38:58 -04:00
Matt Brown
967e372e25 Update function signatures from Phan 2017-05-05 19:43:35 -04:00
Matt Brown
77da5ca99e Fix #156 - allow objectlike arrays to be merged nicely 2017-05-05 18:53:45 -04:00
Matt Brown
624bba0f5c Divid pseudo properties into get and set types 2017-05-05 11:20:05 -04:00
Matthew Brown
c4f45b0f1a Add more info for plugin 2017-05-05 00:06:46 -04:00
Matthew Brown
d2ae36296f Add plugin to improve storage after scanning classlike 2017-05-04 22:40:24 -04:00
Matthew Brown
c9b9b29cf4 Fix all phpcs issues 2017-05-04 21:57:26 -04:00
Matt Brown
2bd1dfafe7 Make line smaller 2017-05-04 18:41:33 -04:00
Matt Brown
df890fbfb0 Fix #155 - support @property declaration for classes with magic getters & setters 2017-05-04 18:35:05 -04:00
Matthew Brown
754a4d9950 Allow Psalm to be run outside of the directory it's installed in (#154) 
* Add --root option when not running Psalm from root directory

* Add informative error when running Psalm outside of its project directory

* Add better message in help

* Fix autoloader precedence
 2017-05-04 14:25:58 -04:00
Matt Brown
9cabf428c4 Only make isset $this->property mixed if not already defined 2017-04-28 16:41:54 -04:00
Jon Ursenbach
f65c618b2e PSR-2 adjustments and adding PHPCS checks into the Travis config. (#149) 
* PSR-2 adjustments and adding PHPCS checks into the Travis config.

* Reverting some CallChecker changes and no longer casting vars to null.
 2017-04-28 00:31:55 -04:00
SignpostMarv
f71b4601e0 added quick globbing support for includes, does not satisfy vimeo/psalm#84 but is sort of related (#150) 2017-04-26 15:33:50 -04:00
Jon Ursenbach
ecee8df753 SimpleXMLElement::asXML returns a string|boolean. #145 2017-04-22 18:13:18 -04:00
Matt Brown
bd6a623bfd Fix possible empty type when inferredType not set 2017-04-21 16:33:18 -04:00
Matt Brown
dc26d2df04 Fix #144 - prevent innaccurate __toString warning 2017-04-21 14:23:09 -04:00
Matt Brown
f7daa6e768 Fix #143 by allowing scalar types to be passed through 2017-04-21 14:06:47 -04:00
Matthew Brown
23401672c0 Fix issue parsing return types with brackets 2017-04-19 09:03:24 -04:00
Matthew Brown
1a8cdc5da9 Allow two or more instanceof interface checks side by side 2017-04-15 21:25:53 -04:00
Matthew Brown
007442fdd0 Fix possibly-private error 2017-04-15 21:10:49 -04:00
Matthew Brown
f67e92023b Add support for intersection types 
Fixes #140
 2017-04-15 20:36:40 -04:00
Matthew Brown
2bdd062400 Ternary else should ignore if expression context 2017-04-15 13:46:18 -04:00
Matthew Brown
eebaf5795d Fix regression dealing with union types from docblocks 2017-04-15 12:44:38 -04:00
Matthew Brown
bdfe2396ad Don’t suggest useless type information 2017-04-15 00:45:43 -04:00
Matthew Brown
a8bee2f843 Suggest missing property types for traits as well 2017-04-15 00:04:03 -04:00
Matthew Brown
0c4824b2cc Take property defaults into account when suggesting missing type 2017-04-14 23:46:55 -04:00
Matthew Brown
8d46c65815 Only make non-null if inside constructor 2017-04-14 23:26:58 -04:00
Matthew Brown
60be6f07a0 Delay checks for MissingPropertyType so we can give more useful messages 2017-04-14 23:09:34 -04:00
Matthew Brown
ce6ca58291 Fix #114 - add optional Hack-like checks calls 2017-04-14 21:32:14 -04:00
Vladimir Komissarov
818e3be00c Fix undefined global constant in closure 2017-04-14 17:03:09 +07:00
Matt Brown
7bcf7f13b1 Fix #137 - add for init in main scope 2017-04-11 17:43:46 -04:00
SignpostMarv
46a0b03aac enable the exposure of the source line number when DocblockParseException is thrown 2017-04-11 22:14:15 +01:00
Matt Brown
ed356bfbd0 Don’t mistake same-named functions for old-style constructors 
Fixes #131
 2017-04-10 11:03:19 -04:00
Matthew Brown
32efdfd0f7 Fix #129 - emit PossiblyNullFuntionCall when encountering such a thing 2017-04-08 11:38:06 -04:00
Matthew Brown
2d454d6e10 Fix #130 - check class exists before checking for __invoke 2017-04-08 11:15:17 -04:00
Matthew Brown
a985fd9324 Add PossiblyInvalidArgument for closure param type checks 2017-04-08 09:47:03 -04:00
Matthew Brown
64361ad2c3 Add more descriptive message to PossiblyInvalidArgument issue 2017-04-08 09:43:58 -04:00
Matthew Brown
c663062816 Add PossiblyUndefinedArgument issue to cope with #126 2017-04-08 09:28:02 -04:00
Matthew Brown
b3a454cf5b Create new InvalidMethodCall issue for calling methods on non-objects 2017-04-08 09:20:32 -04:00
Matthew Brown
7d17a07cd2 Fix #125 - allow abstract classes to reference methods only defined in interfaces 2017-04-07 19:16:25 -04:00
Matt Brown
f011197090 Fix #124 - don’t check array_filter closures when >2 args passed 2017-04-07 18:30:15 -04:00
Matthew Brown
b20ddfec94 Add better way of checking two types can ever yield identical values 2017-04-07 09:02:09 -04:00
Matthew Brown
8910e4226c Allow scalar type refinement 2017-04-07 00:19:55 -04:00
Matthew Brown
40427839ea Get all variables possibly assigned in conditional 2017-04-06 22:56:37 -04:00
Matthew Brown
b74b8d7a58 Prevent reconciling to empty 2017-04-06 22:38:12 -04:00
Matthew Brown
20b0460a33 Fix #123 - ternary byref vars now adjusted 2017-04-06 21:53:29 -04:00
Matt Brown
8a20aca4cf Only compare non-null types 2017-04-06 18:11:09 -04:00
Matt Brown
c09b0e459a Make is_numeric a proper type refinement 2017-04-06 18:06:24 -04:00
Matt Brown
e7aec27eae Prevent emitting issues when comparing mixed values 2017-04-06 17:40:15 -04:00
Matt Brown
1c6934bfa8 Fix a couple more return types 2017-04-06 16:41:44 -04:00
Matt Brown
20b148d2d5 Fix preg_match return types 2017-04-06 15:48:52 -04:00
Matt Brown
da19b55db1 Add special TypeDoesNotContainNull issue as distinct from TypeDoesNotContainType 2017-04-06 15:36:22 -04:00
Matt Brown
cb3f6b14ba Fix AssertionFinder to trap the right null type 2017-04-06 15:05:23 -04:00
Matt Brown
e02999f2ba Prevent undefined property notices 2017-04-06 14:57:00 -04:00
Matt Brown
14bb967c7d Warn when doing === comparisons on incompatible types 2017-04-06 14:53:45 -04:00
Matt Brown
d65221fbe4 Fix nested requires in different directories 2017-04-05 14:37:22 -04:00
Matt Brown
fe43c4e37f Fix #122 - allow multiple types of filtering 2017-04-03 12:36:49 -04:00
Matthew Brown
ce5b35169b Treat empty & !empty as special straddling types 2017-04-02 19:06:18 -04:00
Matthew Brown
a8220ba4f1 Fix bug where empty string could confuse 2017-04-02 18:28:06 -04:00
Matthew Brown
075cc5f50d Add by-reference clause removal 2017-04-02 17:37:56 -04:00
Matthew Brown
a09e668dbc Only allow before/after clause comparisons on non-mixed types 2017-04-02 17:25:21 -04:00
Matthew Brown
791be97b13 Undo changes to type simplification 2017-04-02 17:10:49 -04:00
Matthew Brown
fbda71f026 Ignore mixed vars when selectively removing clauses 2017-04-02 16:51:27 -04:00
Matthew Brown
dcedd65215 Add check for paradoxical statements 2017-04-02 15:26:10 -04:00
Matthew Brown
83edf8c4db Complete the circle – fix remaining type algebra issue 2017-04-01 19:04:49 -04:00
Matt Brown
5b34163d8d Add ability to insert suppressed issues on functions 2017-03-31 11:21:34 -04:00
Matt Brown
d06a199d25 Fix #121 - simplify all parameter types 2017-03-30 11:44:38 -04:00
Matt Brown
02726300dc Fix #120 - allow array_unique extra arg 2017-03-30 11:04:47 -04:00
Matt Brown
fe54318432 Fix #119 - strtotime can return false 2017-03-30 11:02:59 -04:00
Matthew Brown
a89018d9ae Only warn about issues in files that we’re trying to scan 2017-03-24 18:34:46 -04:00
Matthew Brown
7800d34b59 Add two args to array_keys 2017-03-24 10:13:20 -04:00
Matthew Brown
676c01ed2e Fix nullref 2017-03-20 02:23:54 -04:00
Matthew Brown
066b1e011e Prevent creating empty objectlike 2017-03-20 02:05:58 -04:00
Matthew Brown
73b5eb1530 Uncomplicate __toString method 2017-03-20 01:36:51 -04:00
Matthew Brown
caf72bda52 Shave off a little extra time by caching file_checker refs 2017-03-19 23:30:20 -04:00
Matthew Brown
5c7df08862 Add optimisations speed up heavily-used methods 2017-03-19 23:26:45 -04:00
Matthew Brown
fc4a72d905 Store reflected variadic function parameters 2017-03-19 18:31:19 -04:00
Matthew Brown
d69ff4e16e Remove var_dump 2017-03-19 18:25:30 -04:00
Matthew Brown
f2f944d4c0 Prevent trying to open invalid file paths 2017-03-19 18:20:48 -04:00
Matthew Brown
7ed188fa52 Add support for conditional stubbed functions 2017-03-19 15:41:24 -04:00
Matthew Brown
cbd7a4520c Add support for namespaced function definitions 2017-03-19 15:37:07 -04:00
Matthew Brown
f096468536 Don’t forget where a type came from when combining 2017-03-19 14:39:05 -04:00
Matthew Brown
2d88e237f4 Make method non-static 2017-03-19 13:23:19 -04:00
Matthew Brown
b1b7b0ae35 Only include vars asserted in where 2017-03-18 16:34:44 -04:00
Matthew Brown
9a3049b5bc Make sure switch contexts know their parents 2017-03-18 15:28:59 -04:00
Matthew Brown
cb2ed860fb Make sure to invalidate clauses in all parent contexts when asserting 2017-03-18 15:24:14 -04:00
Matthew Brown
18af05fbd9 Do not stop at magic setter when property referenced locally 2017-03-18 15:00:01 -04:00
Matthew Brown
3452c7853f Add support for capturing clauses from elseifs 2017-03-18 14:04:26 -04:00
Matthew Brown
c33e66813a Move type algebra functionality to separate checker 2017-03-18 13:37:00 -04:00
Matthew Brown
e687887ba3 Emit an InvalidReturnType when it should contain null, and introduct LessSpecificReturnType 2017-03-18 12:18:17 -04:00
Matt Brown
8c9cba5e75 Fix #117 - update filesystem callmap functions 2017-03-16 17:34:40 -04:00
Matt Brown
30e8e1880d Add another easy calculation of clauses 2017-03-16 14:45:45 -04:00
Matt Brown
cecfe25df7 Update outer clauses in mic drop situation 2017-03-16 11:46:07 -04:00
Matt Brown
0c0a30d6ea Make Psalm insensitive to case-sensitive filenames 2017-03-16 10:58:13 -04:00
Matt Brown
04363237c5 Fix #116 - be more lenient with static vars 2017-03-15 15:21:00 -04:00
Matt Brown
7fad81edac Fix issue with unset var in loop 2017-03-15 11:38:23 -04:00
Matthew Brown
9b41bc9b37 Add slower (but more accurate) loop checks 2017-03-14 20:14:25 -04:00
Matthew Brown
6cfe540c98 Fix issue evaluating elseif empty assertions 2017-03-14 15:48:52 -04:00
Matthew Brown
9dd94d099f Fix issue with possibly-redefined switch vars 2017-03-14 02:00:38 -04:00
Matthew Brown
50b629e88e Update context types after switch statement without default case 2017-03-13 21:17:21 -04:00
Matt Brown
3d2be3410e Infer loop types without @var comments 2017-03-13 18:06:56 -04:00
Matt Brown
6f00d05271 Add array_reverse stub 2017-03-13 16:50:25 -04:00
Matt Brown
ae0ca9553f Remove training wheels 2017-03-13 12:02:28 -04:00
Matt Brown
fa63afc27d Change property name 2017-03-13 11:23:26 -04:00
Matthew Brown
a7da88bad3 Improve solution to allow for more user errors 2017-03-11 12:32:27 -05:00
Matthew Brown
39b9afcdac Fix issue running isset after empty array check 2017-03-11 12:05:23 -05:00
Matthew Brown
f6066aaded Log references to parent classes 2017-03-10 19:36:17 -05:00
Matthew Brown
ce253ad5c3 Only get a single atomic type when checking mutations 2017-03-09 18:10:50 -05:00
Matthew Brown
048d7f0142 Fix #110 - failure to eliminate false from array|false on isset 2017-03-05 23:47:53 -05:00
Matt Brown
4619ef1390 Re-enable dead code detection 2017-03-03 15:54:08 -05:00
Nat Zimmermann
aac8b79863 Delete .DS_Store 2017-03-03 12:14:24 +00:00
Matt Brown
f9f38f283e Emit issue when property type is not defined 2017-03-02 12:19:18 -05:00
Matthew Brown
7f3a763303 Allow multiple references per row 2017-03-02 01:10:00 -05:00
Matthew Brown
18b5617443 Prevent duplicate lookup of functionstorage 2017-03-02 00:00:31 -05:00
Matthew Brown
5cd1b6735f Add even more references in docblocks 2017-03-01 22:27:52 -05:00
Scott
d1b0cdecd7 Add argument to apcu_add() definition 2017-03-01 19:39:19 -05:00
Matt Brown
6d1f557ca4 Add docblock type location 2017-03-01 18:36:04 -05:00
Matt Brown
864d242f13 Improve labelling of referencing expressions 2017-03-01 11:56:36 -05:00
Matt Brown
518184f388 Don’t do a full class check where not necessary 2017-02-28 11:00:32 -05:00
Matthew Brown
54026fc8f9 Touch up a couple of spots 2017-02-28 00:54:59 -05:00
Matthew Brown
2acfede1d2 Improve call map signatures from phan 2017-02-28 00:50:08 -05:00
Matthew Brown
9ffb9b64f1 Fix #106 - fix a few method signatures 2017-02-28 00:33:49 -05:00
Matthew Brown
f55c754eab Include use references to classes in reference collection 2017-02-28 00:29:28 -05:00
Matt Brown
b948198ca9 Also collect use path locations 2017-02-27 18:24:20 -05:00
Matt Brown
4f597a4068 Fix references 2017-02-27 16:38:43 -05:00
github@muglug.com
07c9cfb848 Check template typeof class references 2017-02-27 16:35:24 -05:00
Matt Brown
cbb8252125 Don’t be sensitive to casing differences in file paths 2017-02-27 12:02:13 -05:00
Matt Brown
729954573b Allow generics to work even if variables not checked 2017-02-27 11:07:44 -05:00
Matt Brown
ac1a45f129 Fix erroneous error message 2017-02-27 10:53:32 -05:00
Matt Brown
7baf942eaa Prevent false positives after extract call 2017-02-27 10:52:43 -05:00
Matthew Brown
d9433c9491 Add way to find all references to a given class or method in the codebase 2017-02-27 01:30:44 -05:00
Matthew Brown
cd5f727d2e Collect explicit references to classes/methods 2017-02-26 23:09:18 -05:00
Matthew Brown
8db6921f1c More graceful early exit if not checking variables 2017-02-24 21:27:52 -05:00
Matt Brown
182f715b62 Add dead code detection for possibly unused public methods 2017-02-23 19:52:23 -05:00
Matt Brown
0049e4deb4 Fix #105 and also the issues found in its wake 2017-02-23 19:36:51 -05:00
Matthew Brown
fa3b292fd4 Fix #101 - restrict the values of pass-by-ref variables 2017-02-23 00:25:28 -05:00
Matt Brown
444a56f4f5 Nest file class registration in conditional 2017-02-22 17:26:20 -05:00
Matthew Brown
47de866601 Fix issue using abstract methods from traits 2017-02-22 01:25:51 -05:00
Matthew Brown
12cb72ae4b Prevent recursion when checking for initialisations 2017-02-22 00:51:34 -05:00
Matthew Brown
48335b6fee Fix potential invalid arg 2017-02-22 00:42:50 -05:00
Matthew Brown
b2957ef4e4 Remove redundant property 2017-02-22 00:06:31 -05:00
Matt Brown
c85b6b376b Merge do vars in scope 2017-02-21 17:48:12 -05:00
Matt Brown
a56456a719 Add merging of vars_possibly_in_scope back 2017-02-21 17:41:54 -05:00
Matt Brown
fa35c0efa9 Remove changed vars from clauses in while loop to prevent re-application of logic 2017-02-21 17:19:15 -05:00
Matt Brown
2c7ffb6f4c Add support for negating some while assertions 2017-02-21 16:52:27 -05:00
Matt Brown
c6a625c16e Fix #102 - be more lenient about whether a type can be reconciled 2017-02-21 16:15:39 -05:00
Matthew Brown
59d1e63b5c Add possibly-false values to getFileName 2017-02-21 02:13:40 -05:00
Matthew Brown
45577f123c Don’t add Symony and Composer to predefined (Reflectable) classes 2017-02-21 02:07:43 -05:00
Matthew Brown
4348888b3e Prevent error when no params are given 2017-02-21 01:56:43 -05:00
Matthew Brown
30c5977825 Fix issue with do statement breaking 2017-02-18 17:49:34 -05:00
Matthew Brown
e61ea17db5 Move FileChecker functionality into separate, better-contained classes 2017-02-18 13:41:27 -05:00
Matthew Brown
9137727993 Fix #99 - treat null coalesce more respectfully 2017-02-17 20:50:47 -05:00
Matthew Brown
870a4486a8 Fix socket return types 2017-02-17 19:52:37 -05:00
Matthew Brown
7cd1b27ff1 Add more support for logical and/or 2017-02-16 21:00:45 -05:00
Matthew Brown
9579460c59 Fix #97 - is_callable shouldn’t prevent evaluation of calls to existing functions 2017-02-16 20:51:53 -05:00
Matthew Brown
2d58531631 Fix #98 - add support for logical and/or 2017-02-16 20:43:23 -05:00
Matthew Brown
32dd5d5512 Be better about dealing with byref args when not checking functions 2017-02-15 01:47:03 -05:00
Matthew Brown
8ae4bf6a18 Add initial support for server mode 2017-02-15 00:16:29 -05:00
Matt Brown
83a978ea80 Fix array_filter on string-keyed arrays 2017-02-13 19:16:25 -05:00
Matthew Brown
0277ca49ba Add config creation utility 2017-02-12 23:59:43 -05:00
Matthew Brown
500044dac1 Make sure $argv and $argc are not globally available 2017-02-12 22:12:31 -05:00
Matthew Brown
1001e03f8a Prevent empty typeof types 2017-02-12 19:51:48 -05:00
Matthew Brown
4f43a7eccb Fix possible nullref 2017-02-12 19:31:35 -05:00
Matthew Brown
1d09616e9d Prevent template types from leaking when no generics are provided 2017-02-12 19:26:23 -05:00
Matthew Brown
a87ea78efc Fix variable-scoped byref issue 2017-02-12 19:07:25 -05:00
Matthew Brown
a4323359d3 Fix ternary/which/for conditionals 2017-02-12 18:47:02 -05:00
Matthew Brown
81e24de76f Fix invalid NullPropertyFetch warning 2017-02-12 18:06:18 -05:00
Matthew Brown
9061d36566 Don’t emit InvalidArrayAccess if ignoring null arrays 2017-02-12 17:13:03 -05:00
Matthew Brown
2635744f4e Simplify array inferred type 2017-02-12 16:58:04 -05:00
Matthew Brown
e0e92785f8 Complain about unevaluated code in more concrete fashion 2017-02-12 16:49:32 -05:00
Matthew Brown
b80628b1c4 Convert all templated properties to most acceptable type 2017-02-12 14:10:34 -05:00
Matthew Brown
e75436fdc7 Fix reporting level grab 2017-02-12 13:38:41 -05:00
Matthew Brown
d6c25c90b3 Alert user if !object assertion has issues 2017-02-12 13:27:42 -05:00
Matthew Brown
d2e92131f5 Always set global vars, even when it might be an error 2017-02-12 13:27:02 -05:00
Matthew Brown
3f0a87f6fe Add more specific __toString error issue 2017-02-12 13:26:24 -05:00
Matthew Brown
a31ef0ae5f Always save property assignments for analysis 2017-02-12 13:25:59 -05:00
Matthew Brown
2ecffbdd6f Always check methods with global scope 2017-02-12 13:16:40 -05:00
Matthew Brown
2f2b487236 Fix #96 2017-02-12 12:31:39 -05:00
Matthew Brown
59fa0977f9 Do not panic when encountering errant global var 2017-02-12 12:23:05 -05:00
Matthew Brown
8e7ab59e2b Add return types for core vars 2017-02-12 12:22:39 -05:00
Matthew Brown
b1f7cfb08e Make file return type more specific 2017-02-12 12:22:10 -05:00
Matthew Brown
2a3c4ee63a Fix msg_receive byref params 2017-02-12 11:34:38 -05:00
Matthew Brown
7876c7ffb9 Allow mixed to override null in byref assignment 2017-02-12 11:34:07 -05:00
Matthew Brown
1029e68341 Allow TNamedObject to be coerced to TObject 2017-02-12 00:50:37 -05:00
Matthew Brown
bb9221ba01 Analyze die/exit expressions 2017-02-11 19:42:12 -05:00
Matthew Brown
f32fabd798 Remove dead code 2017-02-11 19:30:06 -05:00
Matthew Brown
8ff6634e7b Add issue for possibly unused variables in public/private methods 
also changed a lot of access
 2017-02-11 18:56:38 -05:00
Matthew Brown
deb11c9402 Change some errors from InvalidReturnType to MoreSpecificReturnType 2017-02-11 18:25:44 -05:00
Matthew Brown
35e4b380cc Add collection of PossiblyNull* issues 2017-02-11 17:55:08 -05:00
Matthew Brown
708f6e39de Fix array_slice implenentation 2017-02-11 00:34:07 -05:00
Matthew Brown
c05d5926f9 Add missing args to array_slice implementation 2017-02-11 00:25:23 -05:00
Matthew Brown
dbddedb20b Don’t create objectlike if we some properties are untyped 2017-02-10 23:35:34 -05:00
Matthew Brown
14c487d3e6 Always supply default template params as return type 2017-02-10 22:51:47 -05:00
Matthew Brown
1d6c441d16 Use a more fault-tolerant version of php-parser 2017-02-10 21:27:12 -05:00
Matthew Brown
9b3b536254 Fix issue where self::$property_name doesn’t use Context self 2017-02-10 20:41:18 -05:00
Matt Brown
32d85e20da Remove unused vars 2017-02-10 19:10:13 -05:00
Matt Brown
2c1622e7de Find more unreferenced variables by ignoring mass context ops 2017-02-10 19:08:55 -05:00
Matt Brown
0d2581f961 Fix possibility of break when getting property in quick evaluation 2017-02-10 18:45:11 -05:00
Matt Brown
c0a6fc9125 Fix #90 - add genericised stubs for common array functions 2017-02-10 18:12:59 -05:00
Matthew Brown
8ffd45407c Add support for namespaced templates 2017-02-10 00:14:44 -05:00
Matthew Brown
4a82c0a09a Add support for nested types in templates 2017-02-09 22:57:23 -05:00
Matthew Brown
04d9854ce0 Don’t check function return types if it has template types 2017-02-09 22:54:06 -05:00
Matthew Brown
5e8a40a5a1 Merge pull request #94 from vimeo/template-tags 
Add support for templating
 2017-02-09 20:51:23 -05:00
Matthew Brown
98b0ed280c Add support for templating 2017-02-09 20:35:17 -05:00
Matthew Brown
41f7dc4a52 Fix #93 - fix MethodSignatureMismatch checks on builtin class methods 2017-02-09 17:49:13 -05:00
Matthew Brown
66d98a023f Allow false return value 2017-02-08 22:45:18 -05:00
Matthew Brown
585cf91ef0 If using assertions for type, count as a soft type check 2017-02-08 22:17:16 -05:00
Matthew Brown
6934b8ee45 Do not emit signature error for constructors 2017-02-08 21:19:47 -05:00
Matthew Brown
5cbd25fccc Allow generator to be used as a traversable 2017-02-08 20:58:50 -05:00
Matt Brown
8cd83a581a Also unset possibly-in-scope vars 2017-02-08 11:27:06 -05:00
Matthew Brown
09ca483e7d Do not ignore object vars in hasVariable 2017-02-08 02:33:29 -05:00
Matthew Brown
64cbe005f3 Remove more false positives 2017-02-08 02:23:41 -05:00
Matthew Brown
cedb70b0b4 Reduce false positives for unused variables 2017-02-08 01:59:49 -05:00
Matthew Brown
ce63c07e42 Fix snippets on very long lines 2017-02-08 01:39:49 -05:00
Matthew Brown
89a5f109e8 Fix method reference 2017-02-08 00:42:53 -05:00
Matthew Brown
cdcacc395d Rename DeadCode to UnusedVariable, UnusedMethod and UnusedClass 2017-02-08 00:28:26 -05:00
Matthew Brown
65ef5ba8b7 Improve native understanding of docblock-less variadics 2017-02-07 22:02:46 -05:00
Matt Brown
34980fc718 Remove dead code and fix config.xsd 2017-02-07 18:27:28 -05:00
Matt Brown
f4857eb0dd Make dead code check emit an issue 2017-02-07 18:18:33 -05:00
Matt Brown
6b2bb7d917 Store first code location for all variables in a statement list 2017-02-07 18:09:12 -05:00
Matthew Brown
01beb97413 Fix #87 - array types from docblocks can be reasoned about safely 2017-02-03 22:07:14 -05:00
Matthew Brown
11859e9cc0 Bump PhpParser version 2017-02-03 20:14:48 -05:00
Matt Brown
ba4f47a41c Config for caching file hashes during run 2017-02-02 12:39:39 -05:00
Matthew Brown
0fbf8b5619 Remove more dead code 2017-02-02 00:45:23 -05:00
Matthew Brown
ec65f31aaa Improve dead code analysis and fix errors found 2017-02-02 00:20:58 -05:00
Matthew Brown
5ec2a9742b Fix union type simplification of float|int eradicating int 2017-02-01 19:39:40 -05:00
Matthew Brown
1051ba9fc1 Wait to evaluate property defaults until analysis 2017-02-01 18:27:24 -05:00
Matthew Brown
76b6bc9b3d Prevent Psalm from storing unnecessary checkers 2017-02-01 18:11:00 -05:00
Matthew Brown
bf042772bd Get config constants after autoload script 2017-02-01 14:56:10 -05:00
Matthew Brown
e925e8b4db Fix #86 - remove empty array from type on !empty check 2017-02-01 13:51:26 -05:00
Matthew Brown
a0711de023 Update config key to be more accurate ref #85 2017-02-01 10:13:37 -05:00
Matthew Brown
d3abc0011d Fix #80 - add dead code checks via command line 2017-01-31 23:24:33 -05:00
Matthew Brown
eeccf791ad Add unused method & unused class analysis ref #80 2017-01-31 20:47:16 -05:00
Matt Brown
004fd42062 Fix #83 - add support for stubbing 2017-01-31 19:21:33 -05:00
Matthew Brown
ce93c4ef2d Assert smart things when offset is variable 2017-01-31 01:35:44 -05:00
Matthew Brown
7f8a3d798e Improve clause resolution in while loops 2017-01-31 01:30:11 -05:00
Matthew Brown
965a79251d Fix #82 by updating how isset calls are handled 2017-01-31 00:34:06 -05:00
Matthew Brown
7d912fc214 Remove vars when they’ve been changed 2017-01-30 22:26:41 -05:00
Matthew Brown
95ebf5178a Add array_slice call to methods whose return types we can infer 2017-01-30 22:26:31 -05:00
Matt Brown
8c68861cc3 Fix #81 - interface inheritance checks were broken 2017-01-30 18:38:23 -05:00
Matthew Brown
4114456bf4 Key off lowercase classname and reduce dead code false positives 2017-01-30 00:26:17 -05:00
Matthew Brown
cc500e8228 Eliminate dead code 2017-01-30 00:25:16 -05:00
Matthew Brown
1ece3071f9 Add reference counting for methods and remove dead code 2017-01-29 23:44:05 -05:00
Matthew Brown
e9ba513250 Add classlike reference counts 2017-01-29 22:30:27 -05:00
Matthew Brown
d978966db4 Fix #37 - check parent calls for staticness 2017-01-29 22:13:53 -05:00
Matthew Brown
a45c47776b Fix #79 - check anonymous class statements 2017-01-29 13:20:12 -05:00
Jon Ursenbach
c66082897d Fixing a typo in the ClassLikeChecker exception message. 2017-01-29 00:34:42 -05:00
Matthew Brown
fe803129cf Fix #77 with correct range param 2017-01-29 00:24:55 -05:00
Matthew Brown
aaec895e15 Do not stop dead when a property cannot be evaluated 2017-01-28 16:12:04 -05:00
Matthew Brown
a9203b63f8 Allow phan-like use of assert 2017-01-28 15:17:14 -05:00
Matthew Brown
199686c4db Add back local vars when descending into method call 2017-01-28 03:55:19 -07:00
Matthew Brown
1bf0882bfc Allow commas at the end of @param lines 2017-01-28 00:37:52 -07:00
Matthew Brown
2e4aa3d3b1 Do not suggest mixed types 2017-01-27 22:44:52 -07:00
Matthew Brown
f8a70dc707 Limit size of preview snippet 2017-01-27 22:39:16 -07:00
Matthew Brown
c868781731 Fix multiline docblock issue reporting issue 2017-01-27 22:24:25 -07:00
Matthew Brown
6714e28f5d Fix line numbers for return typehints 2017-01-27 19:09:40 -07:00
Matthew Brown
a35f2e0792 Don’t unset $this when calculating scope changes 2017-01-27 18:54:27 -07:00
Matthew Brown
4c3dacbbed Prevent erroneous __toString conversion in method check 2017-01-27 18:06:11 -07:00
Matthew Brown
ea06f62d72 Fix registration of private trait properties 2017-01-27 17:57:59 -07:00
Matthew Brown
3c3d22164c Add private properties to context 2017-01-27 08:49:37 -07:00
Matthew Brown
e51763328c Shortcut for generator, which does not extend anything 2017-01-27 08:41:32 -07:00
Matthew Brown
c485a3d056 Check for not-set-in-constructor errors across traits too 2017-01-27 08:28:21 -07:00
Matthew Brown
98d4ced24f Make location of not-set-in-constructor errors more precise 2017-01-26 23:40:22 -07:00
Matthew Brown
63801c38c0 Make location of constructor error more specific 2017-01-26 23:32:03 -07:00
Matthew Brown
6bcc763414 Fix #3 by checking inside __constructor calls for initialisations 2017-01-26 23:23:12 -07:00
Matthew Brown
ff46487353 Be more discerning about unaryminus/plus inferred type 2017-01-25 21:50:34 -07:00
Matthew Brown
c14a19370f Improve UnaryPlus/Minus still more 2017-01-25 20:23:06 -07:00
Matthew Brown
f03807e7b7 Fix unaryplus/minus type inference 2017-01-25 20:02:19 -07:00
Matthew Brown
4fa0055092 Remove unnecessary var_dump 2017-01-25 17:09:31 -07:00
Matthew Brown
7e7743d6fb Do not complain about missing void return types if config set 2017-01-25 17:07:28 -07:00
Matthew Brown
15e8c1b904 Fix simplifyUnionType so classes with __toString aren’t confused with string 2017-01-25 17:01:01 -07:00
Matthew Brown
ea63fd7ae3 Fix #75 - allow inteeger offsets for object-like arrays 2017-01-25 00:11:24 -07:00
Matthew Brown
0da9c10d36 Don’t complain when adding array and object-like array 2017-01-23 15:40:55 -07:00
Matthew Brown
58aee6340d Remove var_dump (shame on me) 2017-01-23 15:17:35 -07:00
Matthew Brown
df1d6abd7c Make brand-new return types more accurate 2017-01-23 15:16:13 -07:00
Matthew Brown
daa923e243 Stop analysis if parent class cannot be located 2017-01-23 13:36:06 -07:00
Matthew Brown
3ad6ec2e34 Be more resilient if we ignore that parent class does not exist 2017-01-23 13:21:40 -07:00
Matthew Brown
374dc65de1 Fix #39 by checking for ArrayAcces interface 2017-01-20 00:23:58 -05:00
Matthew Brown
894b25487f Fix #71 - prevent instantiation of abstract classes 2017-01-20 00:10:10 -05:00
Matthew Brown
9d1b382820 Fix #48 by recording class definition line number & file path 2017-01-19 23:45:21 -05:00
Matt Brown
d0207b6098 Check that class exists before checking for ArrayAccess inheritors 2017-01-19 19:02:00 -05:00
Matt Brown
86201e71b2 Make arguments of SplFileObject::fputcsv optional 2017-01-19 17:58:34 -05:00
Matt Brown
c1e62a09e7 Merge suppressed issues with source’s issues 2017-01-19 17:58:08 -05:00
Matt Brown
d3a9452cde Make sure we don’t lose type information while reconciling 2017-01-19 17:45:42 -05:00
Matt Brown
a67800cac7 Ignore cloning of mixed variables 2017-01-19 15:00:05 -05:00
Matt Brown
2a8e51f544 Fix scalar assignment 2017-01-19 14:49:49 -05:00
Matt Brown
77ff99206e Inherit all parent properties when analyzing method 2017-01-19 13:11:45 -05:00
Matt Brown
8a21191ebd Prevent improperly emiting InvalidToStringCast 2017-01-19 12:16:19 -05:00
Matt Brown
fd290c41d4 Fix tests 2017-01-19 12:15:42 -05:00
Matt Brown
7116585e85 Be more robust when ignoring UndefinedClass errors 2017-01-19 11:45:25 -05:00
Matt Brown
0ba02f304f Make project checker always aware of file paths to classes 2017-01-19 10:55:58 -05:00
Matthew Brown
a14b03c057 Fix issue with array_merge, and then bugs revealed by that 2017-01-19 01:32:35 -05:00
Matthew Brown
27a018095b Fix invalid InvalidParamDefault error when comparing to false 2017-01-19 01:12:19 -05:00
Matthew Brown
3510757d89 Prevent potentially confusing output calculating array_keys 2017-01-19 00:52:02 -05:00
Matthew Brown
8acaaa2194 Fix checking whether mock objects are contained by any other 2017-01-18 23:52:43 -05:00
Matthew Brown
3b18f58cae Add missing param 2017-01-18 23:38:21 -05:00
Matthew Brown
77c9d1ecbd If extending FileChecker, inline included stmts 2017-01-18 23:35:23 -05:00
Matthew Brown
87871e61f2 Allow checking of folders not in project directories 2017-01-18 23:34:56 -05:00
Matthew Brown
de1ce36a5c Fix method mutation transference 2017-01-18 23:19:36 -05:00
Matt Brown
a2750a92aa Evaluate loop part of for after body 2017-01-18 17:13:20 -05:00
Matt Brown
b23c55e570 Fix #70 by allowing string to be a numeric 2017-01-18 11:07:38 -05:00
Matt Brown
686891f30f Make directory recursion robust and windows-safe 2017-01-18 09:36:16 -05:00
Matthew Brown
d7096df7a6 Don’t complain about non-user-defined class casing 2017-01-18 00:33:48 -05:00
Matthew Brown
b438e4c305 Revert "Don’t complain about incorrectly cased builtin classes" 
This reverts commit 20558c6039.
 2017-01-18 00:23:17 -05:00
Matthew Brown
20558c6039 Don’t complain about incorrectly cased builtin classes 
As they can never cause autoloader issues
 2017-01-18 00:20:24 -05:00
Matthew Brown
e3b9f0fd83 Fix multiple duplicate namespaces constant confusion 2017-01-17 23:55:08 -05:00
Matthew Brown
e78e710eef Be more resilient in the face of class_exists checks 2017-01-17 23:34:17 -05:00
Matt Brown
875717bb96 Fix #63 by adding directory separators 2017-01-17 22:10:21 -05:00
Matt Brown
c0898aa6e5 Fix issue where inferred return type contained subclasses 2017-01-17 12:51:09 -05:00
Matt Brown
6b47741528 Remove extraneous check 2017-01-17 11:20:28 -05:00
Matt Brown
dae7718ae8 Support array_combine types and introduce a MoreSpecificReturnType issue 2017-01-17 11:17:49 -05:00
Matthew Brown
bc668e2c7a Change variadic docblock param to match language syntax 2017-01-17 01:14:43 -05:00
Matthew Brown
693811abed Allow non-array docblock typehints for variadic params 2017-01-17 00:26:40 -05:00
Matthew Brown
e4769fd04a Don’t give up when faced with variadic type 2017-01-17 00:07:58 -05:00
Matthew Brown
b9bad01dbd Treat reflected interface parents correctly 2017-01-16 20:47:23 -05:00
Matthew Brown
0c40785660 Allow traversable to be given directly as iterable 2017-01-16 20:06:34 -05:00
Matthew Brown
3cdb1753d5 Update to the more accurate TypeChecker::isContainedBy 2017-01-16 20:00:51 -05:00
Matthew Brown
317eab8730 Add support for ?A types in docblock 2017-01-16 19:17:46 -05:00
Matthew Brown
9220b958eb Fix phpcs errors 2017-01-16 19:06:39 -05:00
Matthew Brown
4073986844 Merge pull request #65 from Fleshgrinder/feature/auto-creation-of-cache-directory 
Auto-create cache directory
 2017-01-16 18:39:48 -05:00
Matthew Brown
b3726c9de5 Use getcwd() for the project’s base, not the config file parent directory 2017-01-16 18:33:04 -05:00
Matthew Brown
37bdd7d024 Fix #64 - if type is from docblock, return mixed in error case 2017-01-16 16:02:46 -05:00
Richard Fussenegger
42fee8d3a6 Auto-create cache directory 
Signed-off-by: Richard Fussenegger <fleshgrinder@users.noreply.github.com>
 2017-01-16 21:58:35 +01:00
Matthew Brown
69e185eb17 Use absolute cache directory paths everywhere ref #63 2017-01-16 15:32:03 -05:00
Matthew Brown
98454f8644 Remove anti-windows exception 2017-01-16 14:17:47 -05:00
Matthew Brown
e3a9cb98c3 Add extra issue for invalid clone and fix issue reporting; 2017-01-16 12:59:09 -05:00
Matthew Brown
4b283564ca Allow variadic params to be passed by reference 2017-01-16 12:39:38 -05:00
Matthew Brown
315e7029fe Fix non-full-dir Psalm checks 2017-01-16 11:51:42 -05:00
Matthew Brown
856870cf37 Fix #62 - die quickly and explicitly if files cannot be located 2017-01-16 11:41:57 -05:00
Matthew Brown
2e2f2f4ffb Add new suppressable error for missing closure return types 2017-01-16 01:22:36 -05:00
Matthew Brown
5315fd15ad Fix namespaced functions in regular use statements 2017-01-16 00:49:12 -05:00
Matthew Brown
ac92de181f Allow classes that use __invoke to be called 2017-01-16 00:29:18 -05:00
Matthew Brown
d46282e13f Fix issue with constants defined inside interfaces 2017-01-16 00:13:08 -05:00
Matthew Brown
c78ce31e36 Be more lenient when type left out of docblock 2017-01-15 23:49:58 -05:00
Matthew Brown
0deccccdbb Add emacs-compatible report format 2017-01-15 22:39:26 -05:00
Matthew Brown
de9d282205 Be more robust in the case of missing parent class 2017-01-15 22:09:32 -05:00
Matthew Brown
f614944b63 Add predefined functions to avoid throwing errors 2017-01-15 20:11:02 -05:00
Matthew Brown
6b95b84577 Add DateTimeInterface methods 2017-01-15 20:08:13 -05:00
Matthew Brown
5845463dab Fix #61 - don’t warn about non-implementing abstract classes 2017-01-15 19:02:36 -05:00
Matthew Brown
ce89ac4986 Fix #50 - asserting about docblock types no longer causes error 2017-01-15 17:52:01 -05:00
Matthew Brown
f4676dae1d Fix #60 - use sys_get_temp_dir() for cache dir unless user-supplied 2017-01-15 17:20:54 -05:00
Matthew Brown
9b06b672ba Fix #54 - register function constants when function is invoked 2017-01-15 16:43:49 -05:00
Matthew Brown
4fd46fe2c8 Fix #59 - make functions aware of just-defined constants 2017-01-15 15:58:40 -05:00
Matthew Brown
faccc73dc1 Fix #52 by analysing non-main parts of issets 2017-01-15 13:58:20 -05:00
Matthew Brown
1bf2139149 Fix #58 - treat callmap args correctly when evaluating variadic 2017-01-15 13:17:11 -05:00
Matthew Brown
2e4996e562 Fix how we treat numeric strings 2017-01-15 12:55:07 -05:00
Matthew Brown
8836f05027 Fix #56 - functions in root namespaces should not need slash 2017-01-15 12:34:23 -05:00
Matthew Brown
d361f17203 Catch {int} types 2017-01-15 11:00:35 -05:00
Matthew Brown
ad38a26524 Hoist class check above method check 2017-01-15 10:24:38 -05:00
Matthew Brown
03141e41c2 Move string-stored types into named classes 2017-01-15 10:22:05 -05:00
Matthew Brown
dc592f7a6e Fix #55 - hiccup when negating strange expression 2017-01-15 01:16:50 -05:00
Matthew Brown
78c1138a94 Fix #53 - add back extends checks for reflected classes 2017-01-14 19:34:10 -05:00
Matthew Brown
804de9f215 Fix #51 - don't exit with non-zero code if no errors reported 2017-01-14 01:24:27 -05:00
Matthew Brown
e59dba3c70 Allow alt version of callmap variadic syntax 2017-01-13 18:01:07 -05:00
Matt Brown
37e8b4adfe Fix a few issues in tests 2017-01-13 14:14:24 -05:00
Matt Brown
93688dffe0 Fix update-docblocks command 2017-01-13 14:06:05 -05:00
Matt Brown
fda96660fe Fix #44 - support empty namespaces 2017-01-13 13:48:58 -05:00
Matt Brown
fbbef2c320 Fix #45 - add issue when optional param used before required 2017-01-13 13:40:20 -05:00
Matt Brown
35c06261b9 Fix #38 - emit issue for non-array on right too 2017-01-13 13:09:52 -05:00
Matt Brown
82af023d6f Fix #43 - do not emit issues when doing instanceof interface checks 2017-01-13 12:52:32 -05:00
Matt Brown
dc585ff22a Fix #47 - check closure param types properly 2017-01-13 12:40:01 -05:00
Matt Brown
c104736ead Fix #42 - detect false and null defaults 2017-01-13 12:26:10 -05:00
Matt Brown
c181f47364 Fix #35 and #40 by improving method signature checks 2017-01-13 12:03:22 -05:00
Matt Brown
d2c9c423c5 Fix #46 - fix type assignment of anonymous classes 2017-01-13 10:44:04 -05:00
Matt Brown
e300550209 Be less brittle when interface does not exist 2017-01-12 11:16:00 -05:00
Matthew Brown
c20f31855c Fix namespaced function calls 2017-01-12 09:42:24 -05:00
Matthew Brown
b4ca657ea2 Fix diff checking 2017-01-12 01:12:01 -05:00
Matthew Brown
5f54a9571c Fix deep project checks 2017-01-12 01:03:48 -05:00
Matthew Brown
107d8352fc Add back mutation checks 2017-01-12 00:38:15 -05:00
Matthew Brown
56be346191 Add back mutation checks 2017-01-11 21:37:53 -05:00
Matthew Brown
4e00ef51cd Do not check special terms 2017-01-09 01:50:24 -05:00
Matthew Brown
78e94ca66c Relax class requirement on coercion check 2017-01-09 01:45:13 -05:00
Matthew Brown
e7568f8400 Fix type coercion issues 2017-01-09 01:27:35 -05:00