danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-12-13 09:47:29 +01:00
Code Issues Projects Releases Wiki Activity
4,290 Commits 43 Branches 314 Tags 108 MiB
a1a9555f93
Commit Graph

3305 Commits

Author SHA1 Message Date
Matthew Brown
d18ef9c6e1 Add ideal stub return types 2019-02-06 16:08:41 -05:00
Aaron Piotrowski
b0d97843ce Update Amp usage 
Fixed a few errors and used byte-stream for reading and writing.
 2019-02-06 16:08:41 -05:00
Matthew Brown
263a4c8cf1 Use Amp for handling language server event loop 2019-02-06 16:08:41 -05:00
Matthew Brown
dfe45e7d26 Fix #1290 - improve handling of more specific template 2019-02-06 15:56:40 -05:00
Matthew Brown
d45326759f Fix #1287 - improve handling of templated intersection 2019-02-06 12:37:05 -05:00
Matthew Brown
822e840d0c Prevent union in function template as 2019-02-05 17:39:11 -05:00
Matthew Brown
899dd16e8f Be more strict about what can be a template as type 2019-02-05 17:26:34 -05:00
Matthew Brown
c83afc1af2 Fix element type inference for DOMNodeList 2019-02-05 13:34:59 -05:00
Matthew Brown
6d5c995458 Fix #1282 - allow generic self and static 2019-02-05 08:02:06 -05:00
Matthew Brown
6033345694 Fix #1281 - improve handling of mixed property array assignment 2019-02-05 00:36:57 -05:00
Brown
e8a157f8d7 Add missing second arg 2019-02-04 18:00:23 -05:00
Brown
27428b8743 Allow ArrayAccess::offsetGet to return null 2019-02-04 17:27:08 -05:00
Brown
bbf013bfb8 Fix #1279 - speed up analysis of large arrays 2019-02-04 16:06:14 -05:00
Matthew Brown
ab22634d23 Fix #1274 - fix parent:: call to templated method 2019-02-04 00:52:31 -05:00
Matthew Brown
f81f325c8e Fix #1275 - improve combination of class-string types 2019-02-03 17:32:44 -05:00
Matthew Brown
261c44504e Add more specific return type for #1275 2019-02-03 17:26:56 -05:00
Matthew Brown
d665f98fe7 Fix issue reconciling class strings 2019-02-03 17:25:22 -05:00
Matthew Brown
f06ed8bf84 Fix #1273 - don’t change type with unpacked var 2019-02-03 16:36:10 -05:00
Matthew Brown
e97d4f85ee Break large CallAnalyzer funtions apart 2019-02-03 16:21:37 -05:00
Matthew Brown
194bb31221 Fix #204 - allow missing param types to be added with Psalter 2019-02-02 14:16:49 -05:00
Matthew Brown
3a01afbe0a Refine inferred type when possible 2019-02-02 12:10:52 -05:00
Matthew Brown
db89b3cc3f Add initial support for fixing MissingParamType 2019-02-02 11:28:48 -05:00
Tim van Dijen
45d61fc861 Set proper return type for ldap methods 2019-02-01 14:15:34 -05:00
Brown
533b92e15a Fix #1269 - fill in object type 2019-02-01 14:13:21 -05:00
Brown
8b65acf15b Make return type mismatch more clear 2019-02-01 10:55:28 -05:00
Matthew Brown
509709d6bc Fix #1267 - flesh out self static property types 2019-02-01 08:59:01 -05:00
Andrii
21d383d6c6 🐛 #1225 Allow use lead asterisk wildcard in referenceClass 2019-02-01 07:59:44 -05:00
Matthew Brown
b8b1106d79 Fix #1265 - allow referencedClass/Property/Method to be warnings 2019-02-01 07:58:40 -05:00
Matthew Brown
79544eb289 Fix comment analysis for callable(): returntype 2019-02-01 07:50:48 -05:00
Tyson Andre
53756e7017 Remove redundant catching and rethrowing 
I assume these used to have additional logging,
but they're no-ops.
 2019-01-31 21:18:00 -05:00
Matthew Brown
ac79e9a311 Fix #1263 - return proper class string 2019-01-31 21:06:21 -05:00
Matthew Brown
0be6aac30c Fix #1262 - fix object check redundant condition 2019-01-31 20:31:40 -05:00
Brown
3f289731bb Add ability to check descendants in ignored exceptions 2019-01-31 18:40:40 -05:00
Brown
c5a0a3df86 Fix yielding from iterable 2019-01-31 17:58:53 -05:00
Brown
fd88f00526 Fix a few small bugs 2019-01-31 17:48:48 -05:00
Brown
74ebb0b2d5 Don’t copy context unnecessarily when checking methods had no effect 2019-01-31 12:55:48 -05:00
Brown
2054e3753f Fix #1260 - improve handling of ArrayAccess assignment 2019-01-31 12:45:47 -05:00
Brown
c195e8fd21 Add more nuanced analysis of array access fetch 2019-01-30 15:40:37 -05:00
Brown
900d5fa9db Fix ArrayIterator::unserialize return type 2019-01-30 14:56:10 -05:00
Brown
4bc2fcc2f8 Fix serialized interface usage and generic ArrayIterator offset methods 2019-01-30 14:32:08 -05:00
Brown
d52fd70fd6 Fix invalid inheritance for SplObjectStorage 2019-01-30 13:48:05 -05:00
Brown
8c27bd77f6 Fix #1259 - add support for SplObjectStorage type params 2019-01-30 13:03:22 -05:00
Brown
e060ec35de Fix #1258 - allow static method returns 2019-01-30 11:44:12 -05:00
Brown
661c7ee707 Fix #1256 - detect illegal closure use 2019-01-30 11:36:21 -05:00
Matthew Brown
bfb2a5c19e Fix #1257 - transform docblock types for magic methods to something more meaningful 2019-01-30 09:46:23 -05:00
Brown
0bb5143efd Fix #1254 - merge literal and class-strings types into string 2019-01-29 10:34:31 -05:00
Brown
9edbae2bdc Fix possible fatal when builtin function is called in array_filter 2019-01-28 17:54:50 -05:00
Brown
819489e68d Add method that reflection doesn’t know exists 2019-01-28 17:09:23 -05:00
Brown
3e4c63eb9a Fix template extension in grandchildren 2019-01-28 16:56:42 -05:00
Brown
a801923502 Add support for SplQueue templating 2019-01-28 12:27:04 -05:00
Brown
f33415827e Add checks for rounded values 2019-01-28 11:57:49 -05:00
Brown
b5059f45a0 Allow users to ignore missing ignorefiles 2019-01-28 11:50:18 -05:00
Matthew Brown
45058ea494 Fix possible crash when class-string class doesn’t exist 2019-01-28 01:12:41 -05:00
Matthew Brown
09ee6e3d13 Fix #1253 - prevent ints from coercing to literal floats 2019-01-27 23:21:54 -05:00
Matthew Brown
081ba4b204 Fix #1072 - add support for @use SomeTrait<T> 2019-01-27 23:12:40 -05:00
Matthew Brown
f67bab6d52 Restrict template-extends to actual extends 2019-01-27 21:00:27 -05:00
Matthew Brown
2d32e4b92a Remove 7.0-incompatible type 2019-01-27 18:43:36 -05:00
Matthew Brown
89999fd554 Add suppport for float enums 
Fixes #1099
 2019-01-27 18:34:13 -05:00
Matthew Brown
0574e06a42 Remove 7.0-incompatible type 2019-01-27 18:31:40 -05:00
Matthew Brown
45cf35350c Add non-internal endpoint for parsing types 2019-01-27 17:26:32 -05:00
Matthew Brown
d8783c277f Add support for getPsalmTypeFromReflectionType 2019-01-27 17:16:22 -05:00
Matthew Brown
00e95cbd6b Understand that template class string transforms back to templated class 
Fixes #1250
 2019-01-27 15:08:17 -05:00
Matthew Brown
cd4d2027d0 Fix #1249 - allow iterator_to_array to respect getIterator method 2019-01-27 14:50:05 -05:00
Matthew Brown
60e7587c2d Replace template types in object-like arrays 2019-01-27 14:20:41 -05:00
Matthew Brown
be06393b9c Fix #1251 - allow instanceof comparisons to class strings 2019-01-27 14:10:33 -05:00
Matthew Brown
16c2a0f899 Fix #1246 - check @var annotations 2019-01-26 17:30:44 -05:00
Matthew Brown
22ee72808a Remove a bunch of hacks around generic offsets 
Also fixes #1245
 2019-01-26 16:58:49 -05:00
Brown
fcc9d1a979 Fix #1244 and fix #1243 - add template-extends checks 2019-01-25 15:31:17 -05:00
Brown
55913699d3 Allow iterable to subsume array and traversable 
Fixes #1242
 2019-01-25 14:43:16 -05:00
Brown
c9e1df510e Fix #1241 - allow negative string offsets on a string 2019-01-25 10:23:50 -05:00
Brown
bed1f15e09 Fix #1240 - reconcile array to iterable in template replacement 2019-01-25 10:17:41 -05:00
Brown
c0f3197790 Fix #1238 - only emit MissingTemplateParam on direct interface implementers 2019-01-25 10:10:22 -05:00
Brown
cd0a7441d9 Add warnings for extended template param counts off 2019-01-24 17:55:03 -05:00
Brown
650c2b70f8 Fix #1236 - forbid bad class names in @extends 2019-01-24 16:43:22 -05:00
Brown
5352084188 Fix #1234 - apply @template-extends to inherited method signatures 2019-01-24 16:09:04 -05:00
Brown
0d52dc4e00 Fix #1232 - allow checking of extended templated function returns 2019-01-24 15:03:13 -05:00
Brown
006801f661 Fix #1233 - inherit docblock return types from interfaces and classes when signature exists 2019-01-24 11:55:59 -05:00
Brown
67a14cefde Still complain about less specific types when signature type is present 
Ref #1233
 2019-01-24 10:58:59 -05:00
Brown
184ee76176 Remove erroneous regular namespace check 
Fixes #1235
 2019-01-24 10:41:06 -05:00
Brown
8a97e32e16 Add code to make handling interfaces with magic get/set 
Ref #1228
 2019-01-23 16:58:50 -05:00
Brown
60e9d4f245 Don’t give up after method_exists if static method exists 2019-01-23 15:50:12 -05:00
Brown
59baa53b3d Fix #1229 - only check for inheritance if class exists 2019-01-23 13:02:07 -05:00
Matthew Brown
8bc17e47be Fix #1227 - allow genric params in @psalm-assert 2019-01-22 23:42:54 -05:00
Brown
51c6621925 Add property lookup 2019-01-22 11:10:37 -05:00
Matthew Brown
1c5f6963a6 Skip callable tests for PHP 7 2019-01-21 18:01:15 -05:00
Matthew Brown
ea137fc20c Don’t complain about mixed after unpacking arg 2019-01-21 17:42:25 -05:00
Matthew Brown
e0067e53c5 Fix param chosen to be expected 2019-01-21 17:35:55 -05:00
Matthew Brown
1b0c426c52 Improve error message when type cannot be inferred, fixes #1110 2019-01-21 17:29:12 -05:00
Matthew Brown
5cc3fe6b67 Fix #760 - coerce __invoke method to closure 2019-01-21 17:08:12 -05:00
Matthew Brown
99569e8ee3 Fix #1173 - transform const X = true to a true type 2019-01-21 16:55:50 -05:00
Matthew Brown
930a8b2689 Fix #1225 - ignore classes using patterns 2019-01-21 16:48:12 -05:00
Matthew Brown
075446e7df Fix #1223 - MissingClosureParamType should use all known suppressed issues 2019-01-21 12:36:17 -05:00
Andrii Dembitskyi
9b6b79728e Fixes #1222 - incorrect config value used for allowStringToStandInForClass 
Please make attention, that `allowCoercionFromStringToClassConst` are mentioned in docs, but not used now in config
 2019-01-21 09:00:57 -05:00
Matthew Brown
5eb0bb8126 Make foreach var annotation use more cautious 2019-01-20 11:49:13 -05:00
Matthew Brown
af19ca4bd5 Only worry if the alias is different to the intended one 2019-01-20 11:29:25 -05:00
Matthew Brown
03c5823051 Fix #1217 - allow protected property to be se by parent constructor 2019-01-20 11:20:39 -05:00
Matthew Brown
60088b1189 Fix #1215 - prevent bad code from crashing Psalm 2019-01-20 11:10:12 -05:00
Matthew Brown
6fe9e525df Fix #1219 - allow generation of intersections inside class-string 2019-01-20 10:39:08 -05:00
Matthew Brown
681391f970 Fix #1220 - improve constant resolution 2019-01-20 09:52:26 -05:00
Matthew Brown
0ac7d106a3 Fix #1221 - no TypeDoesNotContainType in catch or finally 2019-01-20 09:27:46 -05:00
Matthew Brown
7fa05abb5a Remove unused vars 2019-01-20 01:52:58 -05:00
Matthew Brown
7dfcefd35d Support intersections on LHS of static calls 2019-01-19 23:25:23 -05:00
Matthew Brown
394d6509c6 Restrict class-string types to named objects (and intersections) 2019-01-19 22:46:06 -05:00
Matthew Brown
1c17d2e2f2 Extract template params from string/array callables cc @weirdan 
The culmination of what you were getting at
 2019-01-19 20:18:45 -05:00
Matthew Brown
590bea305d Fix #1218 - find issues with bad callables 2019-01-19 19:49:58 -05:00
Matthew Brown
e3df0ec5e2 Apply same rules that Hack uses for bottom types 2019-01-19 18:51:18 -05:00
Matthew Brown
1d2a0f8b39 Add more robust template constraint checks 2019-01-19 18:35:53 -05:00
Matthew Brown
ed68cb973d Fix #1109 - add bad usort protection 2019-01-19 18:11:49 -05:00
Matthew Brown
e28bf1a29b Fix null ref 2019-01-19 16:01:43 -05:00
Matthew Brown
44b51cdf8e Support @inherits and @extends keywords too 2019-01-19 15:12:13 -05:00
Matthew Brown
9c5ef33997 Allow @property to override parent class property type 
Fixes #1214
 2019-01-19 14:26:27 -05:00
Matthew Brown
ee2b06ac43 Add initial support for @param-out 2019-01-19 13:32:43 -05:00
Matthew Brown
e2db6a77a6 Allow mixed param overrides for @inheritdoc 2019-01-19 12:46:39 -05:00
Matthew Brown
4f3d7fca0d Fix issue where @inheritdoc could override local param types 2019-01-19 12:42:46 -05:00
Matthew Brown
11dc78fd76 Don’t override local docblocks when inheritdoc is present 2019-01-19 12:30:14 -05:00
Matthew Brown
bf13ff2e7d Detect bad interface types 2019-01-19 12:19:51 -05:00
Matthew Brown
9bd5f06c7d Allow inheritdoc to propogate param types 2019-01-19 12:19:07 -05:00
Matthew Brown
545c7e3cba Fix #1211 - allow docblocks to override foreach type earlier 2019-01-19 11:31:51 -05:00
Matthew Brown
94af3b6c51 Add automatic inheritance to properties 
Fixes #1210
 2019-01-19 10:09:26 -05:00
Matthew Brown
b313971935 Remove unused code 2019-01-18 11:57:52 -05:00
Matthew Brown
eddaaea01b Add support for static @method annotations 2019-01-18 11:37:52 -05:00
Matthew Brown
22ec7e537c Fix #1208 - respect inheritance when combining in boolean operation 
Also fixes issue reconciling inside trait
 2019-01-18 10:08:16 -05:00
Matthew Brown
4ec7903e8b Fix #390 - add support for object{foo:int, bar:string} annotation 2019-01-18 00:56:24 -05:00
Bruce Weirdan
0358719037 Added DateTime::createFromImmutable() 
It's available in PHP 7.3, see [FR 74668](https://bugs.php.net/bug.php?id=74668) and php/php-src#2484
 2019-01-17 18:53:57 -05:00
Brown
d78c70d521 Add better messaging for MixedMethodCall 2019-01-17 14:04:40 -05:00
Brown
d068f1535d Fix issue with implemented class interface in subclass 2019-01-16 15:08:11 -05:00
Brown
1ac51fcea6 Allow binding params of extended templates 
Fixes #1207
 2019-01-16 12:07:30 -05:00
Brown
ee366015f7 Fix #1205 - allow traits to override inheritance checks 2019-01-16 10:59:06 -05:00
Matthew Brown
ee97c9dbaf Add support for T of Foo 2019-01-16 09:23:25 -05:00
Roland Franssen
9a827c48ae Tweak error message 2019-01-16 09:02:45 -05:00
Matthew Brown
90dc39c296 Don’t preserve old storages when receiving worker data 
This bug was found when running Psalm in threaded execution mode
 2019-01-15 23:24:29 -05:00
Matthew Brown
37aef674a1 Remove unused library 2019-01-15 22:17:45 -05:00
Matthew Brown
c43734f3ab Don’t localise PropertyNotSetInConstructor issues 2019-01-15 21:34:18 -05:00
Brown
8d61cb4816 Fix #1200 - no fatal error in array_map when not checking functions 2019-01-15 17:53:23 -05:00
Brown
f5a81249e0 Fix #1202 - don’t allow undefined constants in enums 2019-01-15 11:31:13 -05:00
Brown
773be5ceb2 Remove blank line 2019-01-14 17:13:55 -05:00
Brown
496bd97714 Make sure we’re not flipping the wrong constraint 2019-01-14 16:07:57 -05:00
Brown
ee004a91ac Fix #1068 by restricting template types to passed called closure returns 2019-01-14 15:50:25 -05:00
Matthew Brown
3ca5ec9281 Fix templated class conversion allowing child class 2019-01-13 14:40:21 -05:00
Matthew Brown
2c55e7aabb Support template-typeof in class again 2019-01-13 14:29:04 -05:00
Matthew Brown
1de0e35545 Add checks for Psalm reserved words in assertions 2019-01-13 14:06:30 -05:00
Matthew Brown
94aa51ba6d abstract trait method return type override should not be MethodSignatureMistmatch 2019-01-13 13:27:07 -05:00
Matthew Brown
bd9f2ec546 Add separate issue type for undefined interface method 2019-01-13 13:07:53 -05:00
Matthew Brown
0cca0d76cb Fix #813 - allow constant array to be refined with isset 2019-01-13 11:54:39 -05:00
Matthew Brown
6d462fcb64 Fix #909 - support private trait aliasing 2019-01-13 10:19:27 -05:00
Matthew Brown
7e0928d775 Fix #833 - warn on some invalid operands 2019-01-13 10:15:15 -05:00
Matthew Brown
e9b7c9e08b Fix #1129 - mock class method arguments should be evaluated 2019-01-13 09:49:34 -05:00
Matthew Brown
9ef1ce1535 Make @template-extends more robust 2019-01-12 18:18:23 -05:00
Matthew Brown
a7005014c2 Fix #987 - namespace asserted classes 2019-01-12 11:40:19 -05:00
Matthew Brown
b43a6a31f1 Enable casing plugin and fix issues it found 2019-01-12 10:52:23 -05:00
Matthew Brown
a49b5af3e9 Refactor the method call analyzer a little 2019-01-12 09:13:54 -05:00
Matthew Brown
cfcb65aaac Fix #1113 - treat class_alias as always global 2019-01-12 07:28:01 -05:00
Brown
2195caaeae Check type var 2019-01-11 17:28:57 -05:00
Brown
1fddc19172 Add initial support for property types 2019-01-11 17:21:50 -05:00
Brown
cdbc63c99a Fix #1195 - check assignments in byref 2019-01-11 14:57:21 -05:00
Brown
bf327f4933 Prevent echo removing all types 2019-01-11 14:46:03 -05:00
Brown
eb7fc96ac1 Make param type checks use template_extends too 2019-01-11 11:18:51 -05:00
Brown
4ec8d1a8dd Fix #1198 - add support for template param extends checks 2019-01-11 10:55:44 -05:00
Matthew Brown
d891c068b4 Fix #1197 - add support for method templating without override 2019-01-11 09:35:32 -05:00
Matthew Brown
ff958ef643 Fix inheritance of method params 2019-01-11 08:54:10 -05:00
Brown
9947bc56f6 Fix Psalm errors and improve error output 2019-01-10 19:18:02 -05:00
Brown
0d28d5d82b Add check for @template-extends return types 2019-01-10 19:01:30 -05:00
Brown
ddc2637fc5 Add support for @template-extends Foo<SomeClass> 2019-01-10 17:58:32 -05:00
Brown
f108badd03 Fix #1067 - add support for @template-extends 2019-01-10 16:59:44 -05:00
Brown
3533339884 Remove nullable arg 2019-01-10 13:07:22 -05:00
Brown
b8d822cd26 Prohibit leaking of template params across class boundaries 2019-01-10 12:13:49 -05:00
Brown
1e20cbfa79 Prevent template params leaking when extended 2019-01-10 10:27:40 -05:00
Matthew Brown
e23d5a9e79 Only use one thread for language server if there’s no pcntl extension 2019-01-10 00:15:59 -05:00
Matthew Brown
5936415b09 Exit if trying to use --threads without pcntl extension 2019-01-10 00:14:40 -05:00
Matthew Brown
27687244f0 Normalise baseline file slashes 
Fixes #1192
 2019-01-10 00:10:16 -05:00
Bruce Weirdan
32377d6751 fixed password_hash signature 
fixes vimeo/psalm#1188
 2019-01-09 12:32:06 -05:00
Brown
d1654b9bf4 Ignore @return with a newline after @return 2019-01-09 11:51:29 -05:00
Matthew Brown
d3324b42fa Remove slashes from is_a and is_subclass_of string classes, and scan them 2019-01-09 08:49:02 -05:00
Matthew Brown
01e41951e7 Support backslash in is_a/is_subclass_of string name 2019-01-09 08:42:27 -05:00
Matthew Brown
11bfaaa5f7 Prevent crash in constructor checks 2019-01-09 08:35:53 -05:00
Matthew Brown
6e585008f2 Fix #1183 - add hook for class analysis 2019-01-09 08:28:12 -05:00
Matthew Brown
5b2d796c30 Fix up callmap 2019-01-08 21:57:22 -05:00
Matthew Brown
dc2f4929d4 Add changes from PHPStan, thanks @voku 2019-01-08 21:44:50 -05:00
Matthew Brown
2f30132d94 Add Phan updates to callmap 2019-01-08 21:19:11 -05:00
Brown
2201380c52 Fix type transformation issues in templated class strings 2019-01-08 17:34:58 -05:00
Brown
43bbd739a2 Fix generic param fetches 2019-01-08 16:55:53 -05:00
Brown
546919a515 Allow reconciliation with nullable type string 2019-01-08 15:26:54 -05:00
Brown
73770c085e Prevent crash when @template as type is missing 2019-01-08 15:11:57 -05:00
Brown
f3133aac84 Prevent more crashes 2019-01-08 14:50:45 -05:00
Brown
8e26d639de Fix #1181 - improve handling of complicated conditionals 2019-01-08 12:33:44 -05:00
Matthew Brown
b6865b130b Catch exception in more places 2019-01-08 09:57:14 -05:00
Matthew Brown
a89a201c71 Fix #1180 - array key maths was wrong 2019-01-08 09:56:54 -05:00
Matthew Brown
dfba6e0dec Fix #1181 - prevent allowed memory errors with large conditionals 2019-01-08 09:19:33 -05:00
Matthew Brown
fb83da94bd Exit early when encountering complicated conditionals 2019-01-08 09:02:41 -05:00
Matthew Brown
370874d9b6 Make diff map more verbose so it can serve as a list of safe zones 
Outside them all issues must be removed
 2019-01-08 00:54:48 -05:00
Matthew Brown
a2ee2f12a4 Allow scalar to contain numeric 2019-01-07 21:52:58 -05:00
Brown
9ec8690825 Fix #1177 - prevent redundant condition leaking 2019-01-07 18:22:42 -05:00
Brown
be337a03cf Simplify output of method call complaints 2019-01-07 16:38:37 -05:00
Brown
5d5fbb1e9c Only add linked directories 2019-01-07 15:49:05 -05:00
Brown
14f456e160 Fix #1176 - always evaluate assignments in unknown function calls 2019-01-07 12:24:44 -05:00
Brown
4d959626d5 Fix #1175 - support trait method visibility changes 2019-01-07 11:53:22 -05:00
Matthew Brown
195cb289ed Add float-checking plugin, and support for custom plugin issues 2019-01-07 08:38:56 -05:00
Matthew Brown
bcbede07ba Fix issue with do analysis while loops 2019-01-07 01:15:30 -05:00
Matthew Brown
36a1fe07da Allow plugins to have more than one class 
Ref #536
 2019-01-06 17:32:19 -05:00
Matthew Brown
5691c37ece Use reflection to figure out where dupe function was defined 2019-01-06 17:24:46 -05:00
Matthew Brown
a6357b413c Don’t complain when rescanning file with function in 2019-01-06 17:03:13 -05:00
Matthew Brown
214fd7d461 Add DuplicateFunction issue 
Fixes #49
 2019-01-06 16:40:44 -05:00
Matthew Brown
43b4c1c0a3 Fix #1168 - better return type for range 2019-01-06 13:02:46 -05:00
Matthew Brown
9c9e57cf6b Fix #1153 - ignore redundant conditions in finally block 2019-01-06 12:39:18 -05:00
Matthew Brown
b19dd25881 Fix #742 - infer template type from closure 2019-01-06 12:16:09 -05:00
Matthew Brown
cc26ce682e Don’t crash when encountering empty @throws 2019-01-06 10:01:35 -05:00
Matthew Brown
90e1648d5b Fix #979 - be more conservative about method_exists handling 2019-01-06 09:36:25 -05:00
Matthew Brown
8783a33a3f Fix #1136 - support __halt_compiler 2019-01-06 09:18:41 -05:00
Matthew Brown
07b29e4a2f Fix #1141 - add symlinked symlinked repos to directory list 2019-01-06 09:14:35 -05:00
Matthew Brown
e3f2cee2d6 Fix thing that doesn’t work quite right 2019-01-05 17:10:29 -05:00
Matthew Brown
4d6031b39b Fix #1172 - treat is_subclass_of similarly to is_a 2019-01-05 16:58:34 -05:00
Matthew Brown
3a405f4951 Remove public from const 2019-01-05 16:34:09 -05:00
Matthew Brown
c7723df8ff Allow gettype vars to be compared to strings 2019-01-05 16:23:18 -05:00
Matthew Brown
9e2dacc9e4 Remove blank lines 2019-01-05 15:54:21 -05:00
Matthew Brown
355ed831e1 Add support for get_parent_class() with arg 2019-01-05 15:49:56 -05:00
Matthew Brown
58acaefe70 Add support for get_parent_class() with no args 2019-01-05 15:49:56 -05:00
Tyson Andre
d85c9d8aa2 Remove an unused closure use variable 
This looks like debugging code added in
37dedee7b6
 2019-01-05 15:48:48 -05:00
Matthew Brown
8024b4e275 Add support for $a::class 2019-01-05 15:12:42 -05:00
Matthew Brown
f5378bdca8 Improve function call resolution 2019-01-05 14:50:11 -05:00
Matthew Brown
632f613ba0 Numeric is not expressible in PHP 2019-01-05 13:17:44 -05:00
Matthew Brown
bf8f76671b Don’t crash when suppressing UndefinedClass with bad params 2019-01-05 12:59:12 -05:00
Matthew Brown
8dbee1c1d9 Allow iterable to be output in PHP 7.1 too 2019-01-05 11:05:26 -05:00
Matthew Brown
6f1d56a80f Upcast iterables to traversables when used in a templated class string 2019-01-05 10:32:39 -05:00
Matthew Brown
9f16ab9cb5 Fix issue where documented self param confuses 2019-01-05 08:45:12 -05:00
ADmad
407e4473f7 Improve callmap possibly false value. 
Similar to #1147.
 2019-01-05 08:28:13 -05:00
Matthew Brown
9d8c2792e2 Add array-key type and improve general type handling 
Fixes #1144
 2019-01-05 00:15:53 -05:00
Matthew Brown
2dc3d9651f Separate iterable into its own type 
Fixes #1151
 2019-01-04 14:54:40 -05:00
Matthew Brown
87052537cf Fix #1167 - don’t worry about AbstractInstantiation when it could be a descendant 2019-01-04 12:28:00 -05:00
Matthew Brown
602d8a5ade Fix issue inheriting grandparent signature 2019-01-04 08:37:54 -05:00
Matthew Brown
75e0684854 Callable can be fully expressed if its uncomplicated 2019-01-04 08:36:44 -05:00
Matthew Brown
e5559e3012 Allow callables to be plain objects, and vice versa 
Previously Psalm required they be *known* objects
 2019-01-04 08:04:26 -05:00
Matthew Brown
bfb1eb9be2 Properly namespace TClassString output 2019-01-02 20:25:42 -05:00
Brown
53749bd5c5 Do better at finding things that exit 2019-01-02 18:14:47 -05:00
Brown
6a744c0f07 Add no-returns et al to list of psalm-reserved words 2019-01-02 17:26:05 -05:00
Brown
cca0070d38 Allow function calls that exit to act themselves like exit 2019-01-02 17:16:04 -05:00
Brown
2b4b55fd33 Add support for @return no-return 
Fixes #1155
 2019-01-02 17:05:39 -05:00
Brown
c39446330e Make class-string rules more strict 2019-01-02 14:24:45 -05:00
Brown
9fdf29c468 Fix #1165 - default inherited unresolved constants to mixed 2019-01-02 13:46:46 -05:00
Matthew Brown
6fc79e3534 Fix Psalm issues 2019-01-02 13:27:53 -05:00
Matthew Brown
93e3d66ce5 Move filter_var handler function into its own method 2019-01-02 13:27:53 -05:00
Andrii
36f6930e0c 🐛 #1163 Fix handling for default option in filter_var 2019-01-02 13:27:53 -05:00
Brown
2d22db4cb7 Clear up use of reloadFiles 2019-01-02 12:10:52 -05:00
Brown
69d9fd7e28 Fix regression when reasoning about class strings 2019-01-02 11:35:49 -05:00
Brown
1d300ec342 Fix #1150 2019-01-02 11:18:22 -05:00
Matthew Brown
c4d024a72d Check variable static calls 
Fixes #1142 and #1160
 2019-01-02 09:00:45 -05:00
Matthew Brown
df9ea9e3b6 Potential fix for #1156 2019-01-02 08:03:24 -05:00
Matthew Brown
901596281c Fix #1143 - check some variable new calls 2019-01-02 06:58:49 -05:00
Matthew Brown
34cbe70e6f Fix templated @return T::class output 2019-01-02 06:46:10 -05:00
Matthew Brown
6fbf395f70 Fix #1152 - don’t complain about trait class-string comparisons 2019-01-01 21:00:34 -05:00
Matthew Brown
0f6ce983f4 Fix #1154 - parent::foo() calls should not cause exception when parent does not exist 2018-12-30 18:28:15 +01:00
Matthew Brown
b0534cc498 Fix #1149 - allow empty check on iterable 2018-12-26 11:52:37 +01:00
Matthew Brown
571c1d7413 Improve callmap possibly false value 
Fixes #1147
 2018-12-26 11:25:10 +01:00
Matthew Brown
e844fb6491 Add wider return type to Exception::getCode and Throwable::getCode 
Fixes #1148
 2018-12-26 11:21:56 +01:00
Matthew Brown
8cc7f6a4cf Improve reporting of iterable type 2018-12-23 01:26:26 -05:00
Matthew Brown
d70f853055 Fix display of class constants in types 2018-12-22 21:05:07 -05:00
Matthew Brown
3024ea1ef1 Improve handling of class constants in types 2018-12-22 12:12:35 -05:00
Matthew Brown
f01b462d75 Add better output for class strings 2018-12-22 12:08:35 -05:00
Matthew Brown
10a36def96 Fix issue with by-ref args 2018-12-21 13:53:22 -05:00
Matthew Brown
fab4d135b2 Fix static calls on class_aliased classes 2018-12-21 11:39:28 -05:00
Matthew Brown
947e3bf0f1 Fix crashes when analysing aliased class instances 2018-12-21 11:32:44 -05:00
Matthew Brown
e89425ad68 Inherit parameters via @inheritdoc 2018-12-21 11:01:24 -05:00
Matthew Brown
e744e71946 Fix class_alias treatment for interfaces and others 2018-12-21 09:29:23 -05:00
Matthew Brown
02003d9996 Understand class_alias calls better 
Ref #1135
 2018-12-21 01:21:00 -05:00
Brown
974476dc87 Fix var used to assert length 2018-12-20 17:34:56 -05:00
Brown
abdf646050 Only diff files if lengths are not very different 2018-12-20 17:33:35 -05:00
Brown
2e30d7b4a0 Improve handling of unset 2018-12-20 16:03:21 -05:00
Brown
5842ac1517 Fix internal error with property fetches on undefined classes 2018-12-20 14:26:55 -05:00
Matthew Brown
c3a1e77a53 Fix errors in doctrine/dbal 2018-12-20 01:06:43 -05:00
Brown
09ea7ba7a8 Allow combination of mixed-from-isset and empty 2018-12-19 19:43:07 -05:00
Brown
f02fdeddf3 Fix spelling 2018-12-19 18:03:02 -05:00
Brown
87993bad3b Fix attribute names 2018-12-19 17:56:29 -05:00
Brown
fb848d62e9 Add checks for if (count($a)) and if (count($a) [operator] [number]) 2018-12-19 16:15:19 -05:00
Brown
8e5e3564bc Fix erroneous redundant condition warning 2018-12-19 16:10:09 -05:00
Matthew Brown
ea89a6ba29 Revert "First pass" 
This reverts commit 9ed047234f.
 2018-12-19 08:45:14 -05:00
Matthew Brown
20f7147af1 Revert "Maybe bad idea" 
This reverts commit 03c817be08.
 2018-12-19 08:44:56 -05:00
Matthew Brown
03c817be08 Maybe bad idea 2018-12-19 01:59:26 -05:00
Matthew Brown
9ed047234f First pass 2018-12-19 01:59:14 -05:00
Matthew Brown
13e14b3162 Remove code that was breaking things 2018-12-19 00:28:11 -05:00
Matthew Brown
4cd7d923df Initialise output to string 2018-12-18 17:47:28 -05:00
Dave Liddament
0655e1c19c UPDATE add issue type to text output 
Adds issue type to text output. Leaves .emacs output as before.
 2018-12-18 17:25:28 -05:00
Matthew Brown
e75d8d00bb Improve result of "static" type-to-string 2018-12-18 01:14:19 -05:00
Matthew Brown
885a6a605e Add better namespaced string representation for generic param class 2018-12-18 00:21:55 -05:00
Matthew Brown
ca6149ed17 Improve treatment of templated params within function analysis 2018-12-17 23:29:27 -05:00
Brown
7b03e0159c Prevent invalid static invocation 
Fixes #1134
 2018-12-17 17:48:13 -05:00
Brown
ca1a615026 Don’t call reconciliation on empty vars 2018-12-17 15:23:56 -05:00
Brown
699d763cc1 Make isset($a[foo]) imply $a is not a string 2018-12-14 18:52:29 -05:00
Brown
b7d4db892c Fix #1130 - improve handling of invalid array offsets 2018-12-14 15:10:10 -05:00
Brown
15320430db Don’t combine empty array with mixed 
Ref #1126
 2018-12-14 12:30:13 -05:00
Brown
7855683271 Convert @return Promise<...> to @psalm-return Promise<...> 2018-12-14 10:27:39 -05:00
Brown
341cb0c82c Fix #1125 - check protected method overridden ids for use 2018-12-13 17:20:29 -05:00
Matthew Brown
fa9a04369b Don’t propagate internal to methods/properties of traits and interfaces 2018-12-13 09:28:30 -05:00
Matthew Brown
a8851ff425 Improve handling of T::class when mixed is passed 2018-12-13 01:54:15 -05:00
Matthew Brown
8b5e8402a1 Add support for @param T:class $foo 2018-12-13 00:09:01 -05:00
Matthew Brown
9911ffc9cd Fix type 2018-12-13 00:08:37 -05:00
Matthew Brown
4b9ea5472d Fix #1117 - enforce argument counts on interface __constructors 2018-12-12 22:35:27 -05:00
Brown
970ea48b25 Fix checks around array empty checks 2018-12-11 13:50:26 -05:00
Matthew Brown
b052e211a0 Improve internal typing for sabre/event promises 2018-12-10 23:18:53 -05:00
Brown
d9945a0ced Fix issue re-asserting non-empty-mixed 2018-12-10 18:33:26 -05:00
Brown
fb19e510a7 Allow calls on non-empty-mixed too 2018-12-10 11:36:00 -05:00
Brown
ed4077f589 Be more lenient with mixed union calls 2018-12-10 11:28:05 -05:00
Brown
bd59153ddb Fix issue with empty mixed analysis with union 2018-12-10 11:17:35 -05:00
Jon Ursenbach
cb36c67f6c Replacing setColumnMaxWidth with similar functionality. 
setColumnMaxWidth is only available in symfony/console >=4.2
 2018-12-09 17:34:47 -05:00
Jon Ursenbach
c6a8b53a4d Refactoring output formats and creating a new "compact" format. 
The new compact format generates your report within a table
structure that is similar to PHPCS.

Resolves #967
 2018-12-09 17:34:47 -05:00
Matthew Brown
c6f451a8b7 Fix #1119 - prevent interesections on generic params from breaking stuff 2018-12-08 15:17:43 -05:00
Matthew Brown
825e0355c9 Add even more info 2018-12-08 14:37:09 -05:00
Matthew Brown
0acad241ed Improve return analysis messaging 2018-12-08 14:33:41 -05:00
Matthew Brown
29aff6e088 Add more specific return type better messages 2018-12-08 14:26:16 -05:00
Matthew Brown
f0969cb3bb Fix getId calls on callable return types 
Ref #1119
 2018-12-08 14:10:06 -05:00
Matthew Brown
fd0ab47b80 Fix #1118 - detect possible issues with unions of mixed 2018-12-08 13:18:55 -05:00
Matthew Brown
5f34f6c478 Fix #1115 - allow a parent @throws to capture children 2018-12-05 22:50:16 -05:00
Matthew Brown
b7710f7cb9 Fix #1107 - be more lenient with possibly undefined array access when suppressed 2018-12-05 22:35:08 -05:00
Matthew Brown
f54a50ec7d Fix #1116 - provide slightly clearer message when comparing a class string to a string 2018-12-05 22:29:06 -05:00
Brown
4e183abdc6 Add better message when reconciling fails with bad result 
Ref #1114
 2018-12-05 10:36:42 -05:00
Matthew Brown
830ee873dc Throw exception before notice is emitted 2018-12-05 09:33:13 -05:00
Matthew Brown
93662abf8d Shift iterable arg by one if only one is given 2018-12-02 14:59:08 -05:00
Matthew Brown
9203b9d865 Make more mockable classes non-@internal 2018-12-01 19:45:38 -05:00
Matthew Brown
aee5639a4c Remove @internal annotation from FileProvider because PHPUnit 6 can’t deal 2018-12-01 19:06:24 -05:00
Matthew Brown
b32000fa05 Fix #689 - add checks for @internal annotations 2018-12-01 18:37:49 -05:00
Matthew Brown
bbdd20bfd6 Fix #490 - warm about unknown @psalm- annotations 2018-12-01 15:29:14 -05:00
Brown
ef49e3984b Fix #945 - allow ...$foo in docblock for non-user files to inform variadic 2018-11-30 19:21:14 -05:00
Brown
9e4765663d Fix #999 - respect @method annotations to redefine parent methods 2018-11-30 15:13:25 -05:00
Brown
1b740aebb5 Fix #1104 - allow multiple trait method aliases to map to same method 2018-11-30 13:45:49 -05:00
Brown
b6446824be Fix #1107 - emit PossiblyUndefinedArrayOffset where applicable 2018-11-30 13:27:21 -05:00
Matthew Brown
9efd40e321 Fix #1095 - prevent complex assertion redundant condition 2018-11-29 23:25:30 -05:00
Matthew Brown
21f29e7385 Fix #1108 - add support for referencedFunction to UndefinedFunction 2018-11-29 23:19:33 -05:00
Bruce Weirdan
f84224b7e9 fixed collator method return types 2018-11-29 09:45:02 -05:00
Matthew Brown
21f4a2c7f2 Save referenced classlike for cache 2018-11-29 01:46:12 -05:00
Matthew Brown
1eb11a43b0 Fix #1102 by supporting class_alias properly 2018-11-29 00:46:34 -05:00
Matthew Brown
26947888f6 Add some basic support for class_alias 2018-11-29 00:05:56 -05:00
Matthew Brown
47f5f309ad Remove support for get_class($a) === "somestring" 
But it works with class constants
 2018-11-28 23:59:43 -05:00
Matthew Brown
4040626853 Add support for special *::someMethod syntax for referencedMethod 
Fixes #1105
 2018-11-28 20:09:20 -05:00
Brown
c378079db8 Make the length of possible string unions unlimited in conditionals 
Fixes #1103
 2018-11-28 15:12:08 -05:00
Brown
04b3fd2bb5 Fall through after more Possibly* issues 2018-11-28 11:45:54 -05:00
Brown
e7b63a86a6 Differentiate between types merged in a write context vs types merged in return 2018-11-28 10:41:49 -05:00
Brown
f5e788ec1f Increase limits of literal strings to 50 characters 2018-11-27 17:48:23 -05:00
Brown
2e7a75ba0a Prevent Psalm-specific types leaking into PHPDoc 2018-11-27 12:20:06 -05:00
Matthew Brown
a83387b187 Fall through after RawObjectIteration 2018-11-27 09:34:54 -05:00
Brown
3bcbd9d659 Don’t emit errors when iterating over array|iterator 2018-11-26 16:50:47 -05:00
Brown
97c0a94b42 Prevent type coercion from get_class output 2018-11-26 16:39:59 -05:00
Matthew Brown
af041abdcb Fix #1093 - add exception type to list of scanned classes 2018-11-25 16:14:50 -05:00
Matthew Brown
d90cff8f10 Add support for overriding method visibility too 2018-11-25 11:11:33 -05:00
Matthew Brown
8eca864e98 Use composer class loader for source project to avoid plugin overwriting 
cc @weirdan
 2018-11-25 10:41:22 -05:00
Matthew Brown
047b096227 Add better support for intersection properties and mocks 2018-11-24 18:31:08 -05:00
Matthew Brown
e811ff5498 Allow generic types to be included in static return type 2018-11-23 13:24:35 -05:00
Matthew Brown
786ac6c4eb Allow static to carry intersection types 2018-11-22 01:03:32 -05:00
Matthew Brown
1f3fab4cad Make sure method call return type is passed by ref 2018-11-22 00:40:22 -05:00
Matthew Brown
68af217892 Add missing arg to static call hook 2018-11-22 00:25:38 -05:00
Matthew Brown
8d488345ce Fix #1036 - at least the part I care about 2018-11-21 18:38:09 -05:00
Matthew Brown
9f79bdb86e Allow iteration over iteratoraggregate directly 2018-11-21 18:35:41 -05:00
Matthew Brown
ef7298c62c Improve treatment of getIterator calls 
Fixes #991
 2018-11-21 17:56:04 -05:00
Matthew Brown
116cbfd349 Fix #1090 - re-fix support for magic get properties 2018-11-21 16:57:54 -05:00
Matthew Brown
3ccd9f4c01 Fix arg type 2018-11-21 14:08:47 -05:00
Tyson Andre
6ab59209d6 Fix usage of substr_count($haystack, $needle) 
Detected via a check that literals and variables occur in the most
typical order for a global function.
 2018-11-21 13:59:22 -05:00
Matthew Brown
6ef79a0432 Improve handling of byref vars passed into functions 
Fixes #1066
 2018-11-21 12:38:51 -05:00
Vasily Kartashov
fe6713d561 Adding false to ftell result type, 
Adding properties to `stream_get_meta_data` result array
 2018-11-21 08:28:44 -05:00
Matthew Brown
f35a550774 Remove redundant clause 2018-11-20 22:24:53 -05:00
Matthew Brown
740aa895e9 Fix #1074 - allow switching from Phar analysis to regular analysis 2018-11-20 22:21:00 -05:00
Brown
b5f0159cdf Add backup hover analysis when file isn’t analysed 2018-11-20 16:32:40 -05:00
Brown
7df0361fb9 Remove unnecessary error log 2018-11-20 15:53:24 -05:00
Brown
ca602f8e17 Fix language server crash after editing trait method names 2018-11-20 15:51:47 -05:00
Matthew Brown
39310573d1 Use socket client mode by default when starting tcp language server 2018-11-19 22:53:11 -05:00
Matthew Brown
0f90309819 Do all normalisation on / before conversion to \ 2018-11-18 17:18:05 -05:00
Matthew Brown
fa2e7f1f70 More finagling of windows file names 2018-11-18 17:06:11 -05:00
Matthew Brown
2a3c3ed223 Fix #1071 - improve resolution of include paths 2018-11-18 16:53:46 -05:00
Matthew Brown
23ec0e037b Fix windows-only constant issue 2018-11-18 16:05:36 -05:00
Matthew
b52f9cbcd2 Fix windows file path includes 2018-11-18 20:56:56 +00:00
Matthew Brown
59b9b5d65b Move more classes into Internal namespace 2018-11-18 12:41:47 -05:00
Matthew Brown
37dedee7b6 Fix memory leak issues and disable garbage collection 2018-11-18 11:39:14 -05:00
Matthew Brown
c2e546facb Fix #531 
Well, it’s basically fixed already, but this adds @TysonAndre’s suggestions (and some of the relevant implementation from Phan)
 2018-11-17 18:01:27 -05:00
Brown
1ada15f6c6 Allow numeric-string to be identical to string 2018-11-16 13:31:53 -05:00
Brown
c8240cea77 Fix bug where int(0)|float was treated as float in some assertions 2018-11-16 12:26:55 -05:00
Brown
f3599a8b6c Allow assertSame(null, ...) 2018-11-16 11:50:07 -05:00
Brown
425b6321aa Add better understanding of when floats and ints can be equal 2018-11-16 11:04:45 -05:00
Brown
08d9940259 Change ^ to = when annotating assertions 2018-11-16 10:13:52 -05:00
Matthew Brown
e8716f636e Prevent templated assertions on union types with > 1 atomic 2018-11-16 00:56:57 -05:00
Brown
029b6e5ac4 Allow assertions to be made on template params 2018-11-15 18:50:08 -05:00
Brown
766f33d6e4 Fix add in missing property in LSP mode 2018-11-15 18:10:10 -05:00
Matthew Brown
50cb2bb92a Make compatible with PHP 7.0-1 2018-11-14 19:15:07 -05:00
Brown
cd1e1f40a0 Remove void return type 2018-11-14 18:23:20 -05:00
Brown
db6a9d5b6f Try to preserve more formatting in config file when adding plugin 
cc @weirdan - I searched in vain for a proper format-preserving XML parser - if I feel desperate I might make my own, but this is a good enough solution
 2018-11-14 18:10:45 -05:00
Brown
d9440c7bb0 Make sure assertions always have a $ in var id 2018-11-14 15:40:56 -05:00
Brown
f8ea3567d3 Include $ in asserted var id 2018-11-14 15:12:55 -05:00
Brown
9f523fab8b Only store really simple-looking code for assertions 2018-11-14 13:53:57 -05:00
Brown
254a14f621 Allow assertion redundant conditions to be suppressed 2018-11-14 13:44:20 -05:00
Brown
3ba2510096 Prevent bleeding of assert vars into context 2018-11-14 13:12:31 -05:00
Brown
4904ffe8ea Complain about redundant conditions on custom asserts 2018-11-14 12:25:17 -05:00
Bruce Weirdan
3fb0a2f336 reinstate extra.psalm "namespace" 
Existing plugins have been updated as well (skeleton, doctrine-collections)

Also fixed path to echo-checker plugin so that it's once again directly
installable from the psalm distribution.
 2018-11-14 08:31:02 -05:00
Matthew Brown
c86f8e1aef Fix redundant defs 2018-11-14 01:32:29 -05:00
Matthew Brown
dede120fde Remove Psalm prefix to match psalm plugin skeleton composer.json 
cc @weirdan - ran into this when trying to install a plugin
 2018-11-14 01:02:26 -05:00
Brown
06974221df Change DependencyFinderVisitor name to ReflectorVisitor and update docs 2018-11-13 14:09:43 -05:00
Matthew Brown
a4507b068e Fix #1081 - allow PDO::prepare to return false 2018-11-13 00:38:14 -05:00
Bruce Weirdan
7cc472c2f1 Don't choke on non-existing composer.lock 
It's useful to see enabled plugins and be able to disable them even if
no composer files are found.
 2018-11-12 17:43:31 -05:00
Bruce Weirdan
512d07c93a Re-enable plugin autoloading 
Plugins are supposed to be autoloaded when they are referenced by class
names.
 2018-11-12 17:42:36 -05:00
Brown
d0c245eff3 Fix #1077 - queue property types 2018-11-12 13:01:16 -05:00
Brown
dc834fdb01 Default allowStringToStandInForClass to true and fix errors found 2018-11-12 12:03:55 -05:00
Brown
0254322bed Migrate Codebase-namespaced and FileManipulation-namespaced classes to internals 2018-11-12 11:20:59 -05:00
Bruce Weirdan
a338e76ef6 Plugin interface segregation (#1076) 
* Split Plugin into PluginApi\Hook\* interfaces

* dropped Psalm\Plugin

* updated docs

* s/PluginApi/Plugin/g
 2018-11-12 11:20:59 -05:00
Matthew Brown
9709263b8d Make many PropertyAnalyzer properties private 2018-11-12 11:20:59 -05:00
Matthew Brown
4d79b61e93 Change _checker to _analyzer 2018-11-12 11:20:59 -05:00
Matthew Brown
4688b25fd9 Move internal classes to own namespace 2018-11-12 11:20:59 -05:00
Matthew Brown
c7016d9232 Unset new var if it doesn’t appear in break vars 2018-11-11 22:03:08 -05:00
Bruce Weirdan
052d4f6217 Plugin loading (#855) 
* add ability to load plugins by class names

- Plugins need to implement `__invoke(PluginFacade $psalm):void` method
- Plugins are enabled by adding `<pluginClass
class="Qualified\Class\Name"/>`
- `PluginFacade` provides a single point of contact with Psalm, so that
plugins cannot become coupled to Psalm internals

* added `psalm-plugin` cli tool to manage plugins

Available commands:
 `psalm-plugin list` - lists available and enabled plugins
 `psalm-plugin enable 'Plugin\Class\Name'` - enables plugin (modifies `psalm.xml`)
 `psalm-plugin disable 'Plugin\Class\Name'` - disables plugin (modifies `psalm.xml`)

Plugin installation:
 `composer install plugin-vendor/plugin-package-name`

Plugin authoring:
 Plugins are identified by package `type` field, which should contain
 `psalm-plugin` string.
 `extra.pluginClass` should refer to the name of the class implementing
 `__invoke(PluginFacade $psalm):void` function

Todo:
 - better config file search
 - better output for `psalm-plugin`
 - better formatting for modified xml file
 - composer skeleton project for plugins
 - ability to refer to plugins by package name (cli only)
 - composer plugin to (optionally) enable plugin upon installation
 - documentation on plugin installation and authoring
 - interfaces for plugin dependencies
 - interface for plugin entry point
 - migration path for legacy plugins

* documented previously undocumented plugin methods

* split legacy plugin registration into a wrapper class

also added `PluginApi` namespace and `RegistrationInterface`

* reuse psalm's config search algorithm

* enable/disable plugins by composer package name

* allow specifying alternative config file name

* whitelist PluginApi namespace

three times, but well, it works now

* interface for plugin entry points

* psalm-plugin as a symfony console app

* fixed errors found by psalm

* suppressed false positive UnusedMethods

* cs fix

* better psalm-plugin output

* don't leave empty `plugins` node to avoid old schema violation

* removed junk file that shouldn't be there

* cs fix

* fixed phpunit failure (constant redefinition)

* work around missing docblock in on symfony console

* php 7.0 compatibility

* allow `pluginClass` child elements as plugin configuration

* decouple console commands from undelying implementation

- introduce PluginListFactory
- add `PluginList::enable(string $class)` and `PluginList::disable(string $class)`

* PluginList tests

* ComposerLock test

* droppped debugging statement

* added part of console command tests

* added tests for EnableCommand

* added DisableCommand tests

* ignore unused args

* ConfigFile test

* disable travis cache in attempt to fix builds

* nah, that didn't work

* update for upstream changes

* rebase fixes

* namespaced `extra` entry for entry point

* s/PluginFacade/PluginRegistrationSocket/g

* Added $config parameter to PluginEntryPointInterface::__invoke()

* cs fixes

* entry point interface php7.0 compatibility

* cleaned up old cruft

- dropped todos I'm not going to pursues
- locked entry point to be a class implementing entry point interface

* fixed legacy plugins docs

* Added RegistrationInterface::registerHooksFromClass()

It mimics the way old plugins were registered in Psalm\Config, so
handler classes extending Psalm\Plugin should be fully compatible with
it.

Since Psalm\Plugin-style plugin registration was moved to
RegistrationSocket, LegacyPlugin now only load file-based plugins, so it
was renamed to FileBasedPluginAdapter.

* Converted EchoChecker plugin to composer-based format

- Its subfolder is registered as a local composer package in the root
composer.json, so it's directly installable with
	```
	composer require psalm/echo-checker-plugin
	```
- Migration is trivial: drop the plugin into a separate folder, then add
simple composer.json and the entry point class.

* Updated docs

* Don't reject hook handlers that inherit handling methods

* strip void return type in stub file
 2018-11-10 23:23:36 -05:00
Matthew Brown
a3dde47374 Fix issues with build 2018-11-10 20:56:52 -05:00
Matthew Brown
fe25530cad Fix #1073 - relax constraints around missing reflected methods and PHP Parser version 2018-11-10 20:56:31 -05:00
Matthew Brown
e36d7c7d5e Fix $key overwriting 2018-11-10 20:40:34 -05:00
Matthew Brown
12e3ab11ad Improve handling of breaks in switch statements 2018-11-10 20:34:53 -05:00
Matthew Brown
9056353b7f Fix #1065 - allow interface methods to be used in abstract classes 2018-11-10 19:05:51 -05:00
Matthew Brown
2ea58e2c0f Better assertions about non-empty known numbers 2018-11-10 17:56:22 -05:00
Matthew Brown
c136974f4d Allow loop breaks to take precedence over case breaks 2018-11-10 17:29:59 -05:00
Matthew Brown
aa426aca03 Add better support for non-empty arrays when scanning constants 2018-11-10 17:15:37 -05:00
Matthew Brown
1d64f299e9 Make sure only immediate case breaks are detected 2018-11-10 16:29:40 -05:00
Matthew Brown
3664b0975c Make sure switch breaks don’t count as loop breaks 2018-11-10 16:26:03 -05:00
Matthew Brown
9f2fe748e8 Improve handling of vars set in always-entered for/foreach/while loops 2018-11-10 16:10:59 -05:00
Matthew Brown
03ea94e087 Improve handling of do blocks 2018-11-10 14:06:31 -05:00
Brown
ead7d62d48 Continue checking after method deprecation warning 2018-11-09 14:18:46 -05:00
Brown
71800770b1 Fix delimiter 2018-11-09 12:59:17 -05:00
Brown
ea62387cae Strip out leading slashes before reflecting 2018-11-09 12:34:52 -05:00
Brown
ecf9d8afd7 Fix calculation when sample has a newline 2018-11-09 11:38:40 -05:00
Brown
b7099aaf3f Make sure array changes are noticed 2018-11-09 11:19:44 -05:00
Brown
15b412b10e Add checks for non-empty arrays 2018-11-09 10:56:27 -05:00
Brown
f2c013e45f Improve API for setting temporary file contents 2018-11-09 10:42:55 -05:00
Brown
c9d7d63001 Exit earlier if not checking content at all 2018-11-09 10:42:55 -05:00
Matthew Brown
10a5271012
Remove blank line 2018-11-09 08:53:03 -05:00
Matthew Brown
e5c628f7df Fix 7.0-incompatible code 2018-11-09 08:43:17 -05:00
Matthew Brown
1e32354386 Improve accuracy of MissingPropertyType 2018-11-09 00:59:13 -05:00
Matthew Brown
f2f8edef20 Fix #1062 - improve handling of baseline messaging 2018-11-09 00:47:43 -05:00
Matthew Brown
10a0f19870 Delay loading stubs until after first scan; 2018-11-09 00:47:23 -05:00
Matthew Brown
2065e0129e Fix #1069 - module arithmetic always returns ints 2018-11-07 08:45:26 -05:00
Matthew Brown
6cf6d2cfda Add null check 2018-11-06 09:18:39 -05:00
Matthew Brown
8354b6e055 Fix #1063 with removal of unnecessary code 2018-11-06 08:53:22 -05:00
Vasily Kartashov
a3007266d0 add nullable bool result to mysql_stmt::fetch 2018-11-06 08:14:59 -05:00
Brown
1725bd466d Fix #1059 by reducing file path further 2018-11-05 18:22:18 -05:00
Gabriel Caruso
62a1d0d12a Simplify return statment 2018-11-04 19:26:37 -05:00
Matthew Brown
98a5503260 Remove unused var 2018-11-04 19:26:17 -05:00
Brown
3fc67782a9 Fix #1055 - improve reconciliation of class-strings 2018-11-02 17:38:20 -04:00
Brown
07934b8333 Fix isString check for class strings 2018-11-02 17:03:49 -04:00
Brown
f7a37d05b9 Improve handling of generic params in intersection types 
Ref #1053
 2018-11-02 13:09:04 -04:00
Matthew Brown
f592e54a4e Add hover info for extends and implements 2018-11-01 23:40:36 -04:00
Matthew Brown
ccf5de0418 Improve array coercion checks 2018-11-01 23:31:40 -04:00
Matthew Brown
1152aa953f Fix #1026 - warn about bad docblock in @property annotation 2018-11-01 23:04:00 -04:00
Matthew Brown
b1c704da4d Fix #1050 - don’t check stubbed classes for property initialisation 2018-11-01 22:46:14 -04:00
Matthew Brown
7d12bfd2d1 Cache errors as well as info issues 2018-11-01 21:52:39 -04:00
Brown
ef671a14cc Fix issue in file diff offset 2018-11-01 19:11:00 -04:00
Brown
df8b0a1fc5 Bust cache when config changes, don’t rely on > modified time 2018-11-01 17:42:48 -04:00
Brown
f017599b3f Fix how InvalidDocblock is treated 
Fixes #1051 (hopefully)
 2018-11-01 17:03:08 -04:00
Brown
019404d198 Fix resolving of classes after change 2018-11-01 16:04:37 -04:00
Brown
bd3250f52b Bust caches when config changes 2018-11-01 16:02:44 -04:00
Brown
0ba8a51cbe Deduplicate issues from threads 2018-11-01 13:22:38 -04:00
Brown
1d7ea1292e Add Psalm\Config::locateConfigFile method for easier path fetching 2018-11-01 13:05:33 -04:00
Brown
5eca4a8b27 Properly escape slashes in issue text 2018-11-01 12:39:48 -04:00
Erik Booij
635410ea41 Introduce issue baseline with --set-baseline and --with-baseline 2018-11-01 11:16:08 -04:00
Matthew Brown
1a08b69d9c Only do partial parsing if there are few changes 2018-10-30 22:25:31 -04:00
Matthew Brown
cd9e9321fd Remove error logging 2018-10-30 20:55:25 -04:00
Matthew Brown
8071465e8e Fix performance regression introduced with fix to #1039 2018-10-30 20:51:52 -04:00
Brown
727b0d3221 Add --disable-on-change option 2018-10-30 18:58:22 -04:00
Brown
6732c5f5c2 Add scanning of generic classes 2018-10-30 13:01:01 -04:00
Brown
aef9fecaa3 Fix #1045 - check intersection classes exist 2018-10-30 10:34:02 -04:00
Matthew Brown
d1baff4b92 Fix #1044 - allow templated params in assert 2018-10-30 09:20:34 -04:00
sji
2eb0122549 Fixed the type of 1st parameter in odbc_fetch_object() 2018-10-30 09:17:48 -04:00
Brown
55b29e71a8 Fix issue where diffs span multiple functions 2018-10-29 17:12:20 -04:00
Brown
0bebcd06ce Prevent possibly false return from enterNode 
Don’t quite understand how this could be false tbh
 2018-10-29 15:01:05 -04:00
Brown
d6392fbcba Added an HTML-escaped-string meta-type for functions to return 
And a sample echo checker
 2018-10-29 11:54:25 -04:00
Matthew Brown
0d7661dd3f Clone all comments, not just docs 2018-10-27 21:22:09 -04:00
Matthew Brown
750ef3e443 Rename OffsetMapCheckerVisitor to PartialParserVisitor and add description 2018-10-27 12:27:21 -04:00
Matthew Brown
aff6844c62 Fix #1035 - ignore issues where method is in a custom library 2018-10-27 11:47:27 -04:00
Matthew Brown
1d77b61ff9 Fix #1039 by invalidating all use users 2018-10-26 23:04:38 -04:00
Brown
00b51627cc Fix tests 2018-10-26 16:29:16 -04:00
Brown
e286089eaa Add onchange events and symbol lookup with disabled completion 2018-10-26 16:17:15 -04:00
Brown
303d3ee6a2 Fix issue adjusting offsets after multiple file changes 2018-10-26 13:22:41 -04:00
Brown
89e91f6ae2 Force a rescan if adding an extra method 2018-10-26 11:48:21 -04:00
Brown
dbb155f18d Shift all comments, not just docblocks 2018-10-26 11:22:43 -04:00
Matthew Brown
addaea2c1c Improve performance when parsing large files with few changes 2018-10-26 00:59:14 -04:00
François Kooman
a27ab52be7 DateTime*::getTimestamp can return false 
When the represented date is before 1970-01-01 00:00:00, or after
2038-01-19 03:14:07 on 32 bit systems
 2018-10-25 08:12:26 -04:00
Brown
dfda8c0760 Fix Ds\Set signatures cc @mleczakm 2018-10-24 13:14:19 -04:00
Brown
d9cf8cb1be Update callmap 2018-10-24 11:13:08 -04:00
Brown
496018f84a Fix #1024 - add support for filter_var 2018-10-23 14:38:36 -04:00
Brown
d3cd81078f Suppress UnusedParam again 2018-10-23 13:39:10 -04:00
Brown
6ac6aece89 Add coverage of differ, having fixed Psalm bug 2018-10-23 13:38:12 -04:00
Brown
85b64227f7 Be more lenient with objectlike array offset values 
Assume mixed key is accurate
 2018-10-23 13:14:14 -04:00
Brown
447739ede1 Fix #1033 - coerce -0 to a general int 2018-10-23 13:00:15 -04:00
Brown
d6a6e6a16c Remove error_logs 2018-10-19 13:13:55 -04:00
Brown
4da1fd0e40 Change psalm --server to psalm-language-server 2018-10-18 14:34:46 -04:00
Brown
2b6df3658c Only repopulate the storage we care about 
Big reduction on population time for single file edits
 2018-10-18 10:42:37 -04:00
Brown
a41c5c8a39 Fix code quality issues 2018-10-18 09:57:13 -04:00
Brown
4ed5c4bcc6 Speed up analysis phase 2018-10-18 09:51:28 -04:00
Brown
b7c438bf97 Fix slowness when invalidating heavily-used files 2018-10-17 18:11:02 -04:00
Brown
54fdda651b Add server mode support with error reporting only 2018-10-17 15:54:31 -04:00
Brown
47e987ccf8 Check to see if process is still running before killing 2018-10-17 15:53:54 -04:00
Brown
5938fd1bb9 Fix too-long-line 2018-10-17 14:37:32 -04:00
Brown
a38d2f809b Fix #1017 - add non-docblock return type as a referenced class 2018-10-17 14:10:16 -04:00
Brown
6a7148204b Add checks elsewhere too 2018-10-17 13:25:09 -04:00
Brown
e6cf9e96df Add support for class concats when checking for callables 2018-10-17 13:22:57 -04:00
Brown
1d5759a35c Improve test coverage of ProjectChecker 2018-10-17 11:03:32 -04:00
Brown
5a484901cd Improve the way that files are reloaded (server only) 2018-10-16 15:59:11 -04:00
Tyson Andre
f53c4fa978 Fix some call map signatures (postgres, etc.) 2018-10-15 18:40:25 -04:00
Brown
6990914f1b Assume missing classes are traits and treat related methods accordingly 2018-10-15 18:35:57 -04:00
Brown
93a422d2d9 Add alarms for recalcitrant processes 2018-10-15 17:41:10 -04:00
Brown
13cc3b4751 Improve file hash reloading 2018-10-15 11:34:51 -04:00
Brown
67b114f3f7 Skip test broken by new scanning system 2018-10-15 09:16:11 -04:00
Brown
f9cca5e597 Add support for forking at the scanning step 2018-10-15 09:16:11 -04:00
Matthew Brown
edc219facb Add test for #1017 2018-10-11 23:00:32 -04:00
Brown
d6e1c95aff Simplify file scanner filtering 2018-10-11 13:58:04 -04:00
Matthew Brown
03ed1a5135 Fix #1016 - load stdClass info when an object cast comes along 2018-10-11 09:14:34 -04:00
Brown
7278feb811 Split up scanning into specific steps 2018-10-10 16:59:03 -04:00
Brown
ccc92d7709 Fix microtime types 2018-10-10 16:05:06 -04:00
Brown
a2e7a65f3a Add better types for microtime 2018-10-10 16:03:00 -04:00
Brown
792144def4 Fix a couple of callmap issues 2018-10-10 14:22:06 -04:00
Brown
f56c76a8be Fix #1015 with maybe slightly hacky solution? It’s an edge case, though 2018-10-10 11:45:56 -04:00
Brown
8e73b34469 Fix #1009 - improve handling of print_r 2018-10-10 10:58:47 -04:00
Matthew Brown
96768ffd48 Fix wrong redundant condition converting scalar to string 2018-10-10 01:57:11 -04:00
Matthew Brown
2564abde85 Remove unused var 2018-10-10 01:02:02 -04:00
Matthew Brown
3b8e82cca1 Fix hydration of property types in property map 2018-10-10 00:54:50 -04:00
Greg Roach
3050e9eccb Update signature for various xml functions 
FYI, I made the same change to phan https://github.com/phan/phan/pull/2031
 2018-10-09 22:43:23 -04:00
Brown
13b6868ab0 Add references to $this-> properties for method invalidation 2018-10-09 14:24:55 -04:00
Matthew Brown
43c5e9dd4c Fix unnecessary file reparsing 2018-10-08 22:42:45 -04:00
Brown
55bb896868 Fix bugs Psalm found 2018-10-08 20:04:05 -04:00
Brown
e4e92ebd32 Don’t complain when encountering string templated builtin type 2018-10-08 19:57:18 -04:00
Brown
d0840b04b5 Improve debug output for diff runs 2018-10-08 19:42:24 -04:00
Brown
6a2add9398 Don’t skip correct methods in non-diff mode 2018-10-08 19:41:32 -04:00
Brown
99eb903b0d Don’t do last-minute checks for classes 2018-10-08 19:39:36 -04:00
Brown
29e78c5df1 Avoid not checking classes where possible 2018-10-08 13:08:03 -04:00
Brown
540f22de40 Only substitute param types in function analysis if none present 2018-10-08 13:07:28 -04:00
Matthew Brown
afebefba19 Switch from --cache-results to --diff-methods flag 2018-10-07 00:42:25 -04:00
Matthew Brown
7e01576653 Fix #1011 - don’t re-analyse constructors if we can help it 2018-10-06 22:58:21 -04:00
Matthew Brown
92e11fd51b Port over cleanup from server branch 2018-10-06 20:11:19 -04:00
Matthew Brown
99c9be34e1 Type according to parent param types, if no type is given 2018-10-06 14:00:45 -04:00
Matthew Brown
08d8ff5d70 Allow automatic inheritance from overriding param type definitions 2018-10-06 13:46:35 -04:00
Brown
289f5046b2 Don’t disable class checks if extension is loaded 2018-10-04 16:58:11 -04:00
Brown
9ea2009cd2 Add a closure in scope just in time for analysis 2018-10-04 16:42:40 -04:00
Brown
0352babece Fix buggy handling of class with __toString being passed to string|object 2018-10-04 15:29:01 -04:00
Matthew Brown
ea3eada2d6 Still invalidate methods whose bodies have changed 2018-10-03 23:52:09 -04:00
Brown
80bfc168df Skip if storage cannot be found 2018-10-03 18:26:36 -04:00
Brown
6707672528 Improve handling of traits further 2018-10-03 18:16:33 -04:00
Brown
f2cea0325f Slightly improve trait handling 2018-10-03 17:11:08 -04:00
Brown
33254c43cc Fix #1010 - track changes to traits and trait uses 2018-10-03 13:58:32 -04:00
Brown
d6952b5f46 Remove unused var 2018-10-02 17:22:30 -04:00
Brown
4ff851f536 Add test for re-analysis after no change 2018-10-02 15:49:27 -04:00
Brown
14fb95ae97 Fix invalidly inferred return type 2018-10-01 15:14:39 -04:00
Brown
f1bfde5dd7 Improve resolution of include paths 2018-10-01 13:50:55 -04:00
Matthew Brown
80d56cde15 Respect property flag changes 2018-09-30 11:34:51 -04:00
Matthew Brown
e9070b7c4a Improve file updating in same thread 2018-09-30 11:34:51 -04:00
Matthew Brown
890412b557 Add support back for parser errors 2018-09-30 11:34:51 -04:00
Brown
d0bd10d143 Improve provider architecture, upping test coverage 2018-09-30 11:34:51 -04:00
Brown
05a0bdc93b Remove PHP7 types 2018-09-30 11:34:51 -04:00
Brown
7bf63e09f5 Don’t delete issues when ignoring them in command line 2018-09-30 11:34:51 -04:00
Brown
1d26332d77 Track more changes and invalidate more methods 2018-09-30 11:34:51 -04:00
Brown
89c04ec1ae Cache issue data and adjust issue offsets where applicable 2018-09-30 11:34:51 -04:00
Brown
67c90edadf Don’t check methods we’ve already checked 2018-09-30 11:34:51 -04:00
Brown
71b7c70eb1 Add way of getting changes in a given file 2018-09-30 11:34:51 -04:00
Brown
ff893a3fb2 Fix #1005 - resolve /./ to / 2018-09-27 17:59:46 -04:00