2011 Commits

Author	SHA1	Message	Date
adrew	4a903c71a1	Checking psalm-if-this-is before applying psalm-this-out	2021-12-30 21:48:25 +03:00
Daniil Gentili	7c24d33bb2	cs-fix	2021-12-30 11:36:56 +01:00
Daniil Gentili	915ddcc620	Add new RedundantFunctionCall issues	2021-12-30 11:36:32 +01:00
Daniil Gentili	82e24d5c1d	Disallow ksorting lists	2021-12-30 11:30:33 +01:00
Bruce Weirdan	03b7e94748	Merge pull request #7232 from trowski/issue-7196	2021-12-30 10:03:17 +02:00
orklah	0b3e1299de	overwritten properties	2021-12-27 23:46:23 +01:00
orklah	5f6bb39888	if with common parts	2021-12-27 23:08:19 +01:00
orklah	2baf3b560a	unnecessary statements	2021-12-27 23:00:40 +01:00
orklah	926a56a97c	Merge pull request #7230 from orklah/cleanup6 ... code grooming	2021-12-27 22:54:39 +01:00
orklah	094ffb36f9	phpdoc issues	2021-12-27 22:30:10 +01:00
orklah	3828db52b9	Merge pull request #7229 from orklah/cleanup5 ... remove always true/false conditions	2021-12-27 22:08:06 +01:00
Aaron Piotrowski	e23a915bb1	Fix first-class callables when used with magic method, built-in, or undefined methods ... Closes #7196.	2021-12-27 14:29:33 -06:00
orklah	9029e1d613	remove always true/false conditions	2021-12-27 19:59:11 +01:00
adrew	c0ca383020	Contextual inference for closure param types	2021-12-27 19:35:37 +03:00
adrew	63a1c71c83	Remove trailing comma	2021-12-27 00:45:25 +02:00
adrew	d6d0fc6704	Remove undefined variables	2021-12-27 00:45:25 +02:00
adrew	2e4d75d6bd	Fix closure param type inference in generic context	2021-12-27 00:45:22 +02:00
Philip Hofstetter	d45cb64827	allow marking enum cases as @deprecated	2021-12-22 06:16:42 +01:00
orklah	ca25b0f815	always unflag before leaving a analyzer	2021-12-21 18:30:29 +01:00
orklah	b1a1c65714	CS changes	2021-12-21 18:30:29 +01:00
orklah	1eca2c32ae	only emit PossiblyNullArrayAccess if there was no successful destructuring	2021-12-20 22:48:27 +01:00
orklah	cc618bc916	allow successful destructuring to also be null if the source was nullable	2021-12-20 22:48:27 +01:00
rarila	97e6511fab	Set number of lines before and after namespace.	2021-12-15 04:58:32 +01:00
ralila	19b2a64ce8	Conversion of Psalm\Internal\Analyzer\**\*Analyzer	2021-12-14 02:31:26 +01:00
ralila	c0adde8f45	Conversion of Psalm\CodeLocation\DocblockTypeLocation|Raw	2021-12-14 02:31:26 +01:00
rarila	1c298c4605	Conversion of Psalm\Type	2021-12-14 02:31:22 +01:00
ralila	e32af3c05a	Conversion of Psalm\Type\Atomic	2021-12-14 02:26:28 +01:00
adrew	a8d23538b7	Fix closure param type inference with named params	2021-12-12 13:17:15 +03:00
Bruce Weirdan	41ca7f7f7a	Merge pull request #7136 from klimick/forbid-positional-args-after-named	2021-12-12 02:22:51 +02:00
Bruce Weirdan	e08a4f2a2a	Drop unused use	2021-12-12 01:58:45 +02:00
orklah	f79f857ded	Merge pull request #7133 from AndrolGenhald/remove-unused-suppressed ... Allow suppressing UnusedPsalmSuppress, remove unused suppressions.	2021-12-11 23:24:31 +01:00
orklah	6632ddf884	Merge pull request #7135 from klimick/fix-closure-param-type-inference ... Fix type inference of closure params	2021-12-11 23:10:32 +01:00
orklah	50cc629a43	fix cs	2021-12-11 23:03:10 +01:00
orklah	a1268d94d5	fix some more expressions that can be replaced by getSingleAtomic	2021-12-11 22:37:44 +01:00
adrew	6cf2e31c4a	Forbid positional arg after named arg	2021-12-11 23:37:15 +03:00
adrew	989c3ada2e	Fix type inference of closure params	2021-12-11 22:51:18 +03:00
AndrolGenhald	23b781163a	Use getSingleAtomic() instead of array_values(getAtomicTypes())[0].	2021-12-11 13:44:34 -06:00
AndrolGenhald	bfe7f96b56	Allow suppressing UnusedPsalmSuppress, remove unused suppressions.	2021-12-11 13:23:00 -06:00
Matthew Brown	b558748db2	Detect unused properties that are written to inside arrays	2021-12-11 11:42:05 -05:00
orklah	76bb8bc655	Merge pull request #7113 from trowski/first-class-callables ... Added support for first-class callables	2021-12-10 22:40:16 +01:00
Aaron Piotrowski	3c5e99ed1e	Revert reorder of getting method return type and checking args ... Skipping checking args for first-class callables, but fixes handling of other methods.	2021-12-09 19:02:58 -06:00
orklah	ae765dfba8	Merge pull request #7054 from orklah/6933 ... fix missing case for displaying varId	2021-12-09 23:54:37 +01:00
Aaron Piotrowski	d5519fc53a	Use $stmt->args directly instead of creating new VariadicPlaceholder	2021-12-09 15:51:48 -06:00
Aaron Piotrowski	1f3a37ff02	Add support for first-class callables	2021-12-09 10:54:49 -06:00
orklah	eefdb95765	Merge pull request #7093 from orklah/7090 ... don't stop analyzing array, even if we already have a type and we can't create an object like	2021-12-08 22:37:57 +01:00
AndrolGenhald	ba881c80bf	Use maybeAdd instead of accepts.	2021-12-08 12:15:32 -06:00
AndrolGenhald	b29fc6ad3c	Allow operator overloading for Decimal extension (fixes #3938).	2021-12-08 10:59:37 -06:00
orklah	c17af4128e	don't stop analyzing array, even if we already have a type and we can't create an object like	2021-12-07 19:38:52 +01:00
Bruce Weirdan	2530b33dbd	Merge pull request #7076 from klimick/fix-generic-assertion	2021-12-07 08:08:48 +02:00
orklah	257d237192	ignore ComplexMethod: didn't see any easy refactoring	2021-12-06 20:13:33 +01:00
orklah	75312d93b1	Don't crash when checking purity of __callStatic in a trait	2021-12-06 19:00:37 +01:00
Ricardo Boss	2ec77fe29c	Make name property of enum cases return non-empty-strings (vimeo/psalm#6964)	2021-12-06 00:33:57 +01:00
adrew	dee3fc4358	try to fix generic assertions for list and array	2021-12-06 02:25:40 +03:00
rarila	39402c233d	Return type hints (#7065) ... Co-authored-by: ralila <>	2021-12-05 19:51:26 +02:00
Ricardo Boss	8a230110e8	Fix vimeo/psalm#6968	2021-12-05 15:43:38 +01:00
Bruce Weirdan	e9d9481ea6	Merge pull request #7060 from rarila/codingstyle-convert-fqn	2021-12-05 02:46:03 +02:00
Matthew Brown	1956b85c41	Remove always-false args (#7056)	2021-12-04 10:40:52 -05:00
ralila	f833085a15	Fix fqn usage in php-doc	2021-12-04 03:37:19 +01:00
orklah	2612f5a5f1	fix missing case for displaying varId	2021-12-03 23:46:12 +01:00
ralila	30a65685a2	Import instead of using fqn classes	2021-12-03 21:40:18 +01:00
ralila	7c32325e03	Import instead of using fqn constants	2021-12-03 21:25:22 +01:00
ralila	2a956498bf	Import instead of using fqn functions	2021-12-03 21:07:25 +01:00
ralila	711be643c6	Import instead of using fqn exceptions	2021-12-03 20:29:06 +01:00
ralila	245920e53c	Import instead of using fqn	2021-12-03 20:11:20 +01:00
orklah	a7e9eea0ca	flag usage of get_class outside class without args (#7043)	2021-12-02 00:38:45 +02:00
Bruce Weirdan	28c4f86993	Merge pull request #7027 from rarila/issue-6914	2021-11-30 23:34:00 +02:00
orklah	466137a4c4	Merge pull request #7025 from orklah/6256 ... flag DeprecatedProperty on static fetch	2021-11-29 23:46:25 +01:00
orklah	328dcb093b	fix variable name	2021-11-29 23:41:47 +01:00
orklah	9de9c12851	flag DeprecatedProperty on static fetch	2021-11-29 23:32:27 +01:00
Matthew Brown	175ba83332	Migrate most IssueBuffer::accepts calls to IssueBuffer::maybeAdd (#7020)	2021-11-29 14:54:17 -05:00
ralila	15eb8127ee	Reverse parameter list vor preg_match	2021-11-29 14:23:33 +01:00
Bruce Weirdan	28a75652ac	Merge pull request #6997 from zoonru/list_values_paradox	2021-11-29 00:47:12 +02:00
Bruce Weirdan	97445b52f3	Correctly process constant references on enum-valued variables	2021-11-27 04:32:32 +02:00
Daniil Gentili	ee8c5c9c35	Remove some array_values	2021-11-26 21:47:17 +01:00
Daniil Gentili	1129ab1475	Raise RedundantCast when using array_values on a list	2021-11-26 21:47:14 +01:00
Bruce Weirdan	f215ed28d0	Drop special handling of constant references on enums ... Internally enum cases are constants, and they should be resolved as such. Fixes vimeo/psalm#6994	2021-11-26 06:00:01 +02:00
orklah	3bc06a8eab	Taint can't transmit through numerics nor bool	2021-11-25 22:40:01 +01:00
orklah	b42c2814a9	Merge pull request #6971 from orklah/empty-keys ... fix counting array properties when some are Never	2021-11-23 20:11:47 +01:00
orklah	eca56c0c1a	Merge pull request #6972 from orklah/unused-throws ... prevent Psalm from considering throwing methods as unused just because they're immutable	2021-11-22 22:00:55 +01:00
orklah	1c1e352e5f	prevent Psalm from considering throwing methods as unused just because they're immutable	2021-11-22 21:29:57 +01:00
orklah	0d47722195	fix counting array properties when some are Never	2021-11-22 21:13:25 +01:00
orklah	79fa7f5993	Merge pull request #6953 from orklah/callstatic-pure ... check __callStatic purity instead of the pseudoMethod purity	2021-11-21 23:02:07 +01:00
orklah	3e56e859a9	fix inheritance	2021-11-21 21:53:24 +01:00
orklah	41fd460db5	check __callStatic purity instead of the pseudoMethod purity	2021-11-21 13:51:19 +01:00
Bruce Weirdan	f5b71a3a5f	Infer mb_strtolower() result as string when encoding is specified ... `mb_strtolower()` may return characters we generally consider uppercase when it's given the encoding argument. This PR makes Psalm to err on the side of caution and treat the return type as `string` rather than `lowercase-string` in this case Refs vimeo/psalm#6908	2021-11-14 03:57:10 +02:00
Thomas Bley	ca2fe166ee	Added option to forbid eval() in codebase #6855	2021-11-07 21:06:22 +01:00
sasezaki	5a01c8d601	Added phpcs SelfMemberReference rule, and applied	2021-11-07 15:47:39 +09:00
Bruce Weirdan	9210bbcdd4	Forbid enum instantiation ... Fixes vimeo/psalm#6837	2021-11-07 00:14:37 +02:00
orklah	b08d39e567	Merge pull request #6834 from orklah/unused-in-assert ... don't consider calls to methods with assertions as Unused	2021-11-06 22:05:34 +01:00
orklah	18677bb108	better understands value and name properties for enum	2021-11-06 21:49:42 +01:00
orklah	9c9669ea44	don't consider calls to methods with assertions as Unused	2021-11-06 19:54:17 +01:00
orklah	ad57516765	create a temporary var for coalescing ternaries	2021-11-05 20:07:35 +01:00
orklah	6e5f3db06c	makes $_SESSION possibly undefined	2021-11-04 22:45:46 +01:00
orklah	fffef80ec1	makes $_SESSION possibly undefined	2021-11-04 22:38:31 +01:00
orklah	915278e253	Merge pull request #6823 from orklah/variable_class ... allow assertion to work on $var::class	2021-11-04 20:54:59 +01:00
orklah	834d831915	allow assertion to work on $var::class	2021-11-04 20:44:42 +01:00
orklah	5282e4728b	allow assertion to work on $var::class	2021-11-04 20:33:30 +01:00
orklah	cd74f665dc	Merge pull request #6813 from orklah/intTaint ... don't register taints for numeric variables	2021-11-04 15:30:52 +01:00
orklah	e6dccaa07c	Merge pull request #6809 from orklah/binaryOpTaint ... don't taint the result of most binary operations	2021-11-04 13:18:07 +01:00
orklah	6e49c61fd0	fix comment	2021-11-04 00:31:22 +01:00
orklah	9fb74a4f28	exclude Plus on arrays too	2021-11-04 00:30:09 +01:00
orklah	3b01713257	don't taint the result of most binary operations	2021-11-04 00:30:09 +01:00
orklah	24137bdbad	Array cast pass taints	2021-11-04 00:29:36 +01:00
orklah	eca530d792	don't register taints for numeric variables	2021-11-04 00:29:07 +01:00
sasezaki	e3c6464a91	accept ::class constant strings for literal argument	2021-11-03 13:44:14 +09:00
Bruce Weirdan	0cdb0dc04a	Merge pull request #6768 from zoonru/psalm-self-out-templates	2021-11-02 21:41:16 +02:00
orklah	96ae8e7600	Merge pull request #6793 from orklah/unevaluatedCode ... emit UnevaluatedCode after exit or never returning functionlike	2021-11-01 23:41:36 +01:00
orklah	68a4f9e930	emit UnevaluatedCode after exit or never returning functionlike	2021-11-01 22:13:29 +01:00
Bruce Weirdan	ac098a52da	Allow to forbid exit() and die()	2021-10-31 03:02:16 +03:00
Alexey Borzov	91ec5712ad	Add a means to switch return types based on PHP_VERSION_ID ... As suggested in vimeo/psalm#6755	2021-10-29 22:19:38 +03:00
orklah	b9effdb28a	Merge pull request #6742 from zoonru/fix_fewer_template_parameters ... Fix template parameter collection for child classes with fewer parameters (fixes #6734)	2021-10-28 20:06:11 +02:00
Daniil Gentili	597487c4c9	Assert that $lhs_var_id is defined	2021-10-28 10:50:43 +02:00
Daniil Gentili	5fae548e62	Add template support to @psalm-self-out	2021-10-28 10:44:37 +02:00
Daniil Gentili	9c59550e15	Fully fix recursive template parameter resolution	2021-10-27 10:58:33 +02:00
orklah	70175d8fd2	Merge pull request #6744 from orklah/dont_assert_mixed ... Don't assert mixed type	2021-10-26 19:23:13 +02:00
orklah	e8e2624c5f	Don't assert mixed type	2021-10-26 19:12:13 +02:00
Daniil Gentili	c0e6f93deb	Fix template parameter collection for child classes with fewer parameters	2021-10-26 13:06:45 +02:00
orklah	9fb959150a	Merge pull request #6730 from orklah/int-template-arithmetics ... don't emit issues when doing arithmetics on int templates	2021-10-24 20:39:54 +02:00
orklah	0161dedcdb	fix	2021-10-24 19:53:22 +02:00
orklah	2c5cec4a05	fix	2021-10-24 19:48:28 +02:00
orklah	af918a95a2	don't emit issues when doing arithmetics on int templates	2021-10-24 19:30:39 +02:00
orklah	d99f300043	fix concat	2021-10-24 19:15:18 +02:00
orklah	68528985d6	Merge pull request #6724 from orklah/impure_callstatic ... flag impure calls made through __callstatic	2021-10-24 10:30:56 +02:00
orklah	a0681a4498	flag impure calls made through __callstatic	2021-10-24 09:55:40 +02:00
orklah	0339815070	fix type leaking when using ternaries	2021-10-23 18:58:05 +02:00
orklah	2cc5c555c2	fix literal string access on a non empty array	2021-10-22 18:17:08 +02:00
Aleksandr Zhuravlev	b664850cdc	Added support of asserting properties of objects out of scope	2021-10-17 21:29:25 +13:00
orklah	64df00baba	Merge pull request #6660 from orklah/cleanup4 ... Code trimming	2021-10-14 00:12:21 +02:00
orklah	ae193ca4da	replace elvis operator by coalesce operator when applicable	2021-10-13 20:16:06 +02:00
orklah	dbc6f503b1	use of strtolower only once	2021-10-13 20:16:06 +02:00
orklah	e17290a9bc	Merge pull request #6613 from orklah/string-unpacking ... String unpacking	2021-10-13 15:18:11 +02:00
orklah	91c3d788f6	Merge pull request #6656 from orklah/setAttribute ... use Attribute feature of PHP-Parser to avoid dealing with dynamic properties	2021-10-13 14:46:22 +02:00
orklah	bee5b69f7f	use Attribute feature of PHP-Parser to avoid dealing with dynamic properties	2021-10-13 13:27:56 +02:00
orklah	9bb731182a	reintroduce errors for older versions	2021-10-13 11:22:40 +02:00
orklah	6e7aafe9b8	better behaviour in SimpleTypeInferer	2021-10-13 11:22:40 +02:00
orklah	66bbcc212c	remove unneeded argument	2021-10-13 11:22:40 +02:00
orklah	690c24f824	array unpacking with strings	2021-10-13 11:22:40 +02:00
orklah	e7cd2eac0a	Merge pull request #6641 from orklah/weird-assertion-count ... Union::getAssertionString with multiple types	2021-10-13 08:15:28 +02:00
orklah	af414ffe59	Merge pull request #6642 from orklah/inside-conditional ... Inside conditional	2021-10-11 20:45:14 +02:00
orklah	911076939c	Merge pull request #6628 from orklah/phpparser2 ... Php-Parser 4.13	2021-10-11 20:42:32 +02:00
orklah	c4ebc34695	suppress or use the return type	2021-10-11 17:27:52 +02:00
orklah	2e64854a6c	don't allow getAssertionString to return a part of the Union	2021-10-11 16:07:57 +02:00
orklah	3aee938910	Merge pull request #6636 from orklah/possibly-undefined-satisfy-nullable ... Allow sending possibly_undefined inputs to optional params	2021-10-10 23:12:38 +02:00
orklah	cc82e6cf41	suppress warning	2021-10-10 13:58:09 +02:00
orklah	1b24b0309c	reduce complexity	2021-10-10 13:52:14 +02:00
orklah	69d412bfcb	fix error message when input is possibly undefined	2021-10-10 13:42:28 +02:00
orklah	fb8b07613d	Allow sending possibly_undefined inputs to optional params	2021-10-10 12:44:04 +02:00
orklah	f159ca76de	Merge pull request #6624 from orklah/float-always-float ... invert the meaning of the errors	2021-10-10 10:42:37 +02:00
orklah	870ee4ff93	->args to ->getArgs	2021-10-09 23:37:04 +02:00
orklah	bac0217890	add "!" to invert the meaning of the errors	2021-10-09 21:15:27 +02:00