danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-12-16 19:36:59 +01:00
Code Issues Projects Releases Wiki Activity
2,603 Commits 43 Branches 314 Tags 108 MiB
ad94761e15
Commit Graph

755 Commits

Author SHA1 Message Date
Matt Brown
6c84fecce9 Always update the parent context from the loop context 
Fixes #377
 2017-12-06 19:20:24 -05:00
Matthew Brown
e08b11b144 Improve TemplateChecker 2017-12-06 01:05:51 -05:00
Matthew Brown
0eedad4f6a Add UndefinedGlobalVariable issue and asssociated Possibly... one 2017-12-06 00:56:00 -05:00
Matthew Brown
a87a1f0dc9 Make sure undeclared array offset vars have type mixed 
Fixes #360
 2017-12-06 00:35:41 -05:00
Matthew Brown
59b50bdcdd Add proper types for magic constants 
Fixes #362
 2017-12-06 00:05:01 -05:00
Matthew Brown
52fc81e4ab Remove need for a __toString return type 
Fixes #364
 2017-12-05 23:47:50 -05:00
Matt Brown
e2b1b24dbf Fix empty checks, make them more like isset checks 
Fixes #372
 2017-12-05 12:14:10 -05:00
Matt Brown
98085b2267 Fix #371 - improve handling of do statements broken in loop refactor 2017-12-05 11:05:10 -05:00
Matthew Brown
a8a1489a8f Fix closure naming convention so it doesn’t confuse method id checks 2017-12-05 01:47:49 -05:00
Matt Brown
1f57881310 Break out PossiblyNullArrayOffset and NullArrayOffset from InvalidArrayOffset 2017-12-04 11:20:31 -05:00
Gerrit Addiks
de09bd846c Fixes #367; Added missing declaration for var_comment variable in ForEachChecker (#368) 2017-12-04 08:50:59 -05:00
Matthew Brown
8abd77c70f Revert to from_docbblock status of outer loop 2017-12-04 00:13:46 -05:00
Matthew Brown
0134d7bf5c Keep track of referenced loop vvars 2017-12-03 23:50:51 -05:00
Matthew Brown
69ca6bd0a0 Get LHS clauses of && expression after evaluation 2017-12-03 18:33:54 -05:00
Matthew Brown
02dcb2be95 Get or LHS clauses after evaluating statements 2017-12-03 18:22:25 -05:00
Matthew Brown
f5ca4b1c52 Also remove var from clauses when updating 2017-12-03 17:36:50 -05:00
Matthew Brown
6843dfb7fc Remove from_docblock status if we make a successful method call 2017-12-03 17:21:20 -05:00
Matthew Brown
7d003c5bc1 Fix erroneous treatment of or clauses in if statements 2017-12-03 16:25:52 -05:00
Matthew Brown
cb4691fb44 Always set templated types as being from docblocks 2017-12-03 13:22:06 -05:00
Matthew Brown
cff7f35d00 Change __toString type conversions to more precise getId checks 2017-12-03 12:44:08 -05:00
Matthew Brown
cb9079ca88 Improve generic param replacement 2017-12-03 11:23:40 -05:00
Matthew Brown
be3212eb42 Remove conflicting clauses from switch assertions 2017-12-03 00:58:24 -05:00
Matthew Brown
9a83990053 Clear clauses made redundant by pre-loop assignments 2017-12-02 20:02:29 -05:00
Matthew Brown
d20b8d3034
Improve loop analysis (#365) 2017-12-02 18:28:18 -05:00
Matthew Brown
ed626db553 Widen switch redefined vars if defined in each case 2017-12-02 18:06:21 -05:00
Matthew Brown
cfeb4c2586 Simplify vars_possibly_in_scope types 2017-12-02 13:32:20 -05:00
Matt Brown
062d46c132 Update to latest php-cs-fixer 2017-11-30 19:00:09 -05:00
Matthew Brown
888b5dae00 Move LoopChecker into its own file 2017-11-30 01:07:20 -05:00
Matthew Brown
0ea6540018 Fix #358, don’t emit PropertyNotSetInConstructor on public final classes/methods 2017-11-29 23:46:56 -05:00
Matthew Brown
f4212d897c Fix erroneous empty array creation in SwitchChecker 
Fixes #354
 2017-11-28 22:33:37 -05:00
Matthew Brown
6c9d90850a Don’t complain when there are duplicate clauses if due to an assignment 
Fixes #356
 2017-11-28 22:17:03 -05:00
Matt Brown
1173dcc6a2 Don’t stop reconciling types when encountering problem 2017-11-28 17:42:00 -05:00
Matt Brown
33f003f427 Don’t complain about repeat isset calls on array keys 
Fixes #347
 2017-11-28 16:52:52 -05:00
Matthew Brown
f27bd50abe
Add RedundantCondition issue, replacing FailedTypeResolution (#344) 
* Group changes

* Don’t worry about vars defined before exiting

* Fix issues with vars defined in conditionals

* Add failing test

* Only add failed reconciliation flag if nothing could be salvaged

* Avoid notice when removing clauses

* Improve handling of loops

* Fix evaluation of binary op expressions

* Remove unset vars from outer context after loop

* Ignore RedundantCondition in some more configs
 2017-11-28 00:46:41 -05:00
Matthew Brown
f16642dad2
Better switch analysis (#343) 
* Experiment with good switch analysis

* Improve switch accuracy at expense of some processor cycles

* Evaluate switch case expression in case context
 2017-11-28 00:25:21 -05:00
Matt Brown
a6f3781452 Fix #340 - give up with mixed type when accessing unknown key on objectlike 2017-11-27 12:01:23 -05:00
Matthew Brown
18cf05e087 Always keep track of assigned var ids 2017-11-25 11:21:45 -05:00
Matthew Brown
18e68a60de Fix #334 by allowing interfaces as foreach args to be correctly interpreted 2017-11-24 12:57:00 -05:00
Matthew Brown
c86e73ddb6 Always keep track of referenced var ids 
which we can use for analysis elsewhere
 2017-11-24 12:17:28 -05:00
Matthew Brown
4312ef380b Fix issues found by improved Psalm checks 
cc @TysonAndre, found with RedundantCondition checks
 2017-11-24 12:10:30 -05:00
Matthew Brown
fd3de443b2 Update loop with union of existing types 2017-11-21 22:13:46 -05:00
Matthew Brown
ad74563327 Improve handling of switch statements with default cases 2017-11-20 20:39:27 -05:00
Matt Brown
60c9f1ca96 Ignore socket_select when assigning byref params 2017-11-20 17:34:32 -05:00
Matt Brown
a069cf4ea9 Don‘t turn a string into an array|string by accident 2017-11-20 17:10:05 -05:00
Matt Brown
0c2ea418e3 Fix #327 - prevent null array value from killing assignment 2017-11-20 16:19:40 -05:00
Matt Brown
f46fd0b79f Fix array access on objects 2017-11-20 11:49:26 -05:00
Matthew Brown
957600623c Fix issue with byref template params leaking 2017-11-20 00:12:17 -05:00
Matthew Brown
ccc0583bf8 Fix issue with bad assign after array_pop/array_shift 2017-11-19 23:46:32 -05:00
Matthew Brown
ae799da8d0 Add root array var when updating array key type in if 2017-11-19 23:25:14 -05:00
Matthew Brown
5698b2d363 Update root var with more accurate object-like type 2017-11-19 22:28:52 -05:00
Matthew Brown
90bcd99eab Fix issue where array_shift/array_pop didn’t mark array as modified 2017-11-19 21:36:09 -05:00
Matthew Brown
8b2df09f0f Fix issue with object-like reassignment 2017-11-19 21:24:29 -05:00
Matthew Brown
3418eb494a Always set a fallback mixed type on a mixed property fetch 2017-11-19 14:58:48 -05:00
Matthew Brown
8d62fc8ad1 Only update array type if it doesn’t have an object 2017-11-19 14:38:00 -05:00
Matthew Brown
f18616b2f9 Provide fallback if array keys not found 2017-11-19 14:23:39 -05:00
Matthew Brown
95429b7037 Fix invalid assignment to Union 2017-11-19 14:09:20 -05:00
Matthew Brown
942bc0a663 Add new MixedTypeCoercion issue, fixes #320 2017-11-19 13:42:48 -05:00
Matthew Brown
5ff4badf33
Refactor array analysis to improve reliability and accuracy (#325) 2017-11-19 12:33:43 -05:00
Matt Brown
39baa00fd3 Fix issue with nested object-like array updating 2017-11-17 16:33:36 -05:00
Tyson Andre
1c25ca1a0c Fix false positives, add tests of @psalm-seal-properties (#318) 2017-11-17 16:19:48 -05:00
Matt Brown
2a96e323e7 Fix assignment to arrays after object-like 2017-11-17 12:27:16 -05:00
Matt Brown
3f324141ef Fix error message when changing keys 2017-11-17 11:43:06 -05:00
Matt Brown
6710fd4231 Fix double mixed issue with array offsets 2017-11-17 11:32:12 -05:00
Matthew Brown
a08306973a Fix #302 - add a way to seal objects with magic properties 2017-11-16 20:47:58 -05:00
Matthew Brown
440db3be89 Fix #313 - correctly analyse closure self return types 2017-11-16 20:06:00 -05:00
Matthew Brown
7d33db0d19 Fix issue with array unification after scanning 2017-11-16 01:11:46 -05:00
Matthew Brown
36a760657d Fix #311 and introduce PossiblyInvalidArrayOffset 2017-11-16 00:27:11 -05:00
Matthew Brown
6c9cdd896b Separate InvalidArrayAccess and InvalidArrayOffset 2017-11-15 21:10:07 -05:00
Matthew Brown
abe7c003ab Fix #309 - borrowing fix from @TysonAndre 2017-11-15 20:45:53 -05:00
Matt Brown
bce8bdb46e Ignore traversable, iterable etc for RawObjectIteration 2017-11-15 12:09:13 -05:00
Matt Brown
4ff9ec2853 Don’t warn about traversable objects 2017-11-15 11:58:46 -05:00
Matt Brown
a99135c4d0 Fix #300 - add PossiblyInvalidPropertyFetch 2017-11-15 11:44:13 -05:00
Matt Brown
c5faa2d06a Fix #299 - add PossiblyInvalidMethodCall 2017-11-15 11:34:40 -05:00
Matt Brown
9111b1c725 Fix #301 - add PossiblyInvalidPropertyAssignment 2017-11-15 11:15:03 -05:00
Matthew Brown
f96f3a467d Fix #296 - add issue for raw object iteration 2017-11-14 22:55:48 -05:00
Matthew Brown
2e6b93e4d0 Fix #289, make inferred type of yield from expressions mixed 2017-11-14 22:29:15 -05:00
Matthew Brown
3ade4b9559 Fix #293, be case invariant to self & static 2017-11-14 21:56:29 -05:00
Matthew Brown
b2ae9a2892 Fix #291, #292 and #297 by improving docblock parsing 2017-11-14 21:43:31 -05:00
Tyson Andre
d9a142ac7d Fix incorrect strpos argument order (#287) 
Detected via static analysis
 2017-11-11 21:48:43 -05:00
Matthew Brown
a0a9128375 Fix #285 - add PossiblyInvalidArrayAccess 2017-11-11 21:22:11 -05:00
Matthew Brown
4f2a200b45 Fix #283 - add more refined PossiblyUndefinedMethod check 2017-11-11 14:53:35 -05:00
Matthew Brown
2f1e3652b7 Fix #274 - improve array addition inference for objectlike arrays 2017-11-11 14:19:57 -05:00
Matthew Brown
0ea48752d1 Fix #284 - allow __get calls inside class if property undefined 2017-11-11 01:17:10 -05:00
Matt Brown
59265ef2bf Fix #276 - fix false positive in magic call 2017-11-10 18:08:26 -05:00
Matt Brown
e49573e7f6 Fix #279 - make sure referenced vars updated always in or 2017-11-09 16:42:39 -05:00
Matt Brown
ff5ea32ea3 Fix #277 - infer stdClass from object cast 2017-11-09 15:58:09 -05:00
Matthew Brown
765d82548d Remove more dead code 2017-11-08 23:27:51 -05:00
Tyson Andre
b3505cfbef Get rid of unused variables in psalm's codebase (#272) 
* Remove unused variables

* Fix more unused variables

* Fix remaining detected undefined variables

Other 20 detected undefined variable warnings were false positives.
 2017-11-08 23:14:27 -05:00
Matt Brown
750d18d20a Fix #266 - do better analysis of array_rand 
And also have better fallback when accessing string key on object-like array
 2017-11-07 17:38:54 -05:00
Matt Brown
e0371aed62 Introduce file manipulation concept to plugins 2017-11-07 14:46:53 -05:00
Matt Brown
490e78e136 Add isset check for safety 2017-11-06 15:42:39 -05:00
Matt Brown
97de8f7684 Allow Psalm to check static call LHS vars 2017-11-06 15:37:49 -05:00
Matt Brown
4b573bde1f Fix get_class($e) !== checks 2017-11-06 12:04:38 -05:00
Matt Brown
81493a639e Add more robust property assignment when property not defined 2017-11-03 12:27:01 -04:00
Matt Brown
b163c296ff Fix templated return types in traits 2017-11-02 15:07:39 -04:00
Matthew Brown
aeb9882281 Add back support for TObject property fetch 2017-10-29 17:44:13 -04:00
Matthew Brown
afc8cb4068 Check for property fetch mocks 2017-10-29 17:33:26 -04:00
Matthew Brown
51280c1670 Allow byref args of socket_select to pass through unchanged 2017-10-28 16:26:45 -04:00
Matthew Brown
24980cd7d7 Constrain user-defined functions and methods 2017-10-28 16:05:35 -04:00
Matthew Brown
45df0292b1 Never constrain by-ref array variables 2017-10-28 15:33:29 -04:00
Matthew Brown
bee14d184f Add better check for property 2017-10-28 15:17:32 -04:00
Matthew Brown
30acb9e3b7 Improve array function byref understanding by hard-coding rules 2017-10-28 13:56:29 -04:00
Matt Brown
897c70f8f5 Add back support for switch-getclass ::class constants 2017-10-26 15:07:36 -04:00
Matt Brown
c850ef644d Add PossiblyFalseReference and PossiblyFalseArgument issues 
Useful for catching error cases
 2017-10-23 11:47:00 -04:00
Matthew Brown
a85cd1db8a Add support for get_class and get_type negation checks 2017-10-22 20:17:04 -04:00
Matthew Brown
4d32c72ef8 Fix #250 and fix #255 - handle switch statements like PHP does 2017-10-22 19:53:53 -04:00
Matthew Brown
c7d55bf6de Improve aseertion finding by digging deeper into trivial comparisons 2017-10-22 19:11:28 -04:00
Matthew Brown
f9032924e6 Allow == true comparisons to be evaluated to !falsy 2017-10-22 12:09:22 -04:00
Matthew Brown
f6e01b5925 Change empty type assertions to "falsy" 
As empty has a special meaning
 2017-10-22 11:57:41 -04:00
Matthew Brown
1b7a5c2944 Fix #236 - incorrect operand issue text 2017-10-12 08:51:57 -04:00
Matthew Brown
deb489e82d Fix #232 - discard clauses when evaluating catch block 2017-10-10 23:09:19 -04:00
Matthew Brown
862d22e83c Fix #230 - invalidate root vars on $arr[]= assignment 2017-10-10 23:01:52 -04:00
Matthew Brown
beea51d7bf Fix property check 2017-10-07 15:05:05 -04:00
Matthew Brown
9774131876 Fix #224 - explicit string casts fail when no __toString present 2017-10-07 11:27:54 -04:00
Matthew Brown
483b4c75f3 Fix #223 - array_map with too few args should have issue 2017-10-07 10:33:19 -04:00
Matthew Brown
6b4bd47ddb Fix #181 and #225 - resolve problems with self in comments/return statements 2017-10-07 10:22:52 -04:00
Matthew Brown
5bd6228708 Fix #220 - don’t worry about parent property access 2017-09-24 08:17:27 -04:00
Matt Brown
6f911c7386 Emit more specific operand issues 2017-09-20 11:22:17 -04:00
Matthew Brown
391696bc83 Use a blacklist, not a whitelist 2017-09-16 13:28:33 -04:00
Matthew Brown
3a8efec728 Add error for pass by reference 2017-09-16 13:16:21 -04:00
Matthew Brown
995e92a8c3 Remove empty if block 2017-09-14 00:36:38 -04:00
Matthew Brown
2a4a6fc490 Exit early if checking iterable for methods 2017-09-14 00:32:14 -04:00
Matt Brown
5b3531b5a5 Fix null coalescing on nullable output 2017-09-13 14:35:42 -04:00
Matt Brown
439a1ddc97 Exit early if a bad class is detected 2017-09-11 11:58:11 -04:00
Matt Brown
d1807cfb95 Improve checks for switch types 2017-09-11 11:58:11 -04:00
Matthew Brown
e89a2929d5 Infer types from numeric operations 2017-09-06 21:44:26 -04:00
Matthew Brown
9f9e8a1b30 Improve API for inference 2017-09-03 20:52:54 -04:00
Matthew Brown
11aa3558b7 Make sure encapsulated strings can also coerce param types 2017-09-02 19:48:59 -04:00
Matthew Brown
a0c27cee4f Allow param types to be inferred from presence of concat ops 2017-09-02 19:23:00 -04:00
Matthew Brown
6531e3bfb8 Throw exception if impossible state is reached 2017-09-02 18:22:44 -04:00
Matthew Brown
73694ab04e Suggest types when complaining of untype params 
Ref #204
 2017-09-02 18:15:52 -04:00
Matthew Brown
8aabcbce35 Introduce UntypedParam warnings when functions are missing param types 2017-09-02 11:18:56 -04:00
Matt Brown
1cc63fe718 Ignore leading slash in array_map methods 2017-08-30 13:45:41 -04:00
Matthew Brown
622217b708 Fix #205 - add file references at analysis stage too 2017-08-22 12:38:38 -04:00
Matthew Brown
e4e6c2a6e6 Fix #201 - list/array assignment should invalidate clauses too 2017-08-18 23:14:38 -04:00
Matt Brown
3075f16308 Ignore static, self and parent in callable class names 2017-08-18 17:02:15 -04:00
Matt Brown
c626b7d68a Fix #200 - allow mapping of more callable strings, and callable arrays 2017-08-14 19:30:11 -04:00
Matt Brown
d6e2e786db Ignore self calls as well 2017-08-11 19:09:15 -04:00
Matt Brown
a7baa7e928 Support callable checks on inline-defined functions 2017-08-11 19:05:04 -04:00
Matt Brown
13d98b803d Check that callable string class exists first 2017-08-11 18:48:58 -04:00
Matt Brown
17a900ab54 Add ability to detect invalid callable functions 2017-08-11 18:30:58 -04:00
Matt Brown
4b5a5ead74 Fix paradox detection for multiple clauses 2017-08-07 18:38:38 -04:00
Matthew Brown
4175295113 Isolate where we load static storage objects (#195) 
* Move FileChecker::$storage calls to provider

* Add ClassLikeStorageProvider

* Use ClassLikeStorageProvider everywhere

* Move storage arrays into providers
 2017-07-29 15:05:06 -04:00
Matt Brown
22b6dafe3c Fix #194 - carry over const definitions 2017-07-28 10:42:30 -04:00
Matthew Brown
e29dd140e3 Refactor scanning and analysis, introducing multithreading (#191) 
* Add failing test

* Add visitor to soup up classlike references

* Move a whole bunch of code into the visitor

* Move some methods back, move onto analysis stage

* Use the getAliases method everywhere

* Fix refs

* Fix more refs

* Fix some tests

* Fix more tests

* Fix include tests

* Shift config class finding to project checker and fix bugs

* Fix a few more tests

* transition test to new syntax

* Remove var_dump

* Delete a bunch of code and fix mutation test

* Remove unnecessary visitation

* Transition to better mocked out file provider, breaking some cached statement loading

* Use different scheme for naming anonymous classes

* Fix anonymous class issues

* Refactor file/statement loading

* Add specific property types

* Fix mapped property assignment

* Improve how we deal with traits

* Fix trait checking

* Pass Psalm checks

* Add multi-process support

* Delay console output until the end

* Remove PHP 7 syntax

* Update file storage with classes

* Fix scanning individual files and add reflection return types

* Always turn XDebug off

* Add quicker method of getting method mutations

* Queue return types for crawling

* Interpret all strings as possible classes once we see a `get_class` call

* Check invalid return types again

* Fix template namespacing issues

* Default to class-insensitive file names for includes

* Don’t overwrite existing issues data

* Add var docblocks for scanning

* Add null check

* Fix loading of external classes in templates

* Only try to populate class when we haven’t yet seen it’s not a class

* Fix trait property accessibility

* Only ever improve docblock param type

* Make param replacement more robust

* Fix static const missing inferred type

* Fix a few more tests

* Register constant definitions

* Fix trait aliasing

* Skip constant type tests for now

* Fix linting issues

* Make sure caching is off for tests

* Remove unnecessary return

* Use emulative parser if on PHP 5.6

* Cache parser for faster first-time parse

* Fix constant resolution when scanning classes

* Remove test that’s beyond a practical scope

* Add back --diff support

* Add --help for --threads

* Remove unused vars
 2017-07-25 16:11:02 -04:00
Matthew Brown
17205bc093 Be more strict about what properties we check 2017-07-10 20:20:40 -04:00
Matthew Brown
d8654b8389 Slow down Psalm by checking parent initialisations too 2017-06-30 01:24:45 -04:00
Matthew Brown
368b6670d7 Fix a few edgecases 2017-06-29 00:28:37 -04:00
Matthew Brown
8fd671bdc4 Fix #167 - prevent Empty type in assignment 2017-06-28 23:37:02 -04:00
Matthew Brown
bc35f88859 Fix issue with $this instanceof checks in traits 2017-06-23 00:39:37 -04:00
Matt Brown
f49d167a49 Add tracking from where a trait was included 2017-06-21 14:22:52 -04:00
Matt Brown
e5c25eae97 Fix #172 - make sure new coalesce vars escape brackets 2017-06-20 15:38:32 -04:00
Matt Brown
e1d5eab7a2 Fix long line 2017-06-20 14:07:54 -04:00
Matt Brown
473040ca8f Fix #171 by supporting exit statements for fopen 2017-06-20 13:25:37 -04:00
Matthew Brown
6b2b80d0bb Assign var to correct context 2017-06-13 00:09:15 -04:00
Matthew Brown
93e7486d5e Reduce line length 2017-05-26 20:17:56 -04:00
Matthew Brown
22a716f4da Improve formatting of phpdocs 2017-05-26 20:16:18 -04:00
Matthew Brown
d6909193ea Add additional formatting changes 2017-05-26 20:05:57 -04:00
Matthew Brown
688a72c794 Fix #36 - emit issues on deprecated properties 2017-05-25 01:32:34 -04:00
Matthew Brown
0fdf281896 Add support for @deprecated classes 2017-05-25 00:34:39 -04:00
Matthew Brown
44b4d04e0a Fix #95 - emit issue on private constructor calls 2017-05-24 23:55:54 -04:00
Matthew Brown
8f317cd8a2 Fix #133 - emit issue when calling no-constructor class with args 2017-05-24 23:11:40 -04:00
Matthew Brown
4fd46e1752 Improve formatting 2017-05-24 22:07:49 -04:00
muglug
77a44051c5 Fix issues with @psalm-ignore-nullable-return types 2017-05-22 14:50:03 -04:00
muglug
65d86d35ad Separate iterator issues 2017-05-22 11:59:58 -04:00
Matthew Brown
7532e32b9d Fixed spacing and use statement formatting 2017-05-19 00:48:26 -04:00
Matt Brown
cadaef14e6 Carry forward ignore_nullable_return in fleshOutType 2017-05-10 12:49:59 -04:00
github@muglug.com
9ff8736e53 Add the means to ignore PossiblyNull* errors from the type itself 2017-05-09 16:38:58 -04:00
Matt Brown
624bba0f5c Divid pseudo properties into get and set types 2017-05-05 11:20:05 -04:00
Matthew Brown
c9b9b29cf4 Fix all phpcs issues 2017-05-04 21:57:26 -04:00
Matt Brown
2bd1dfafe7 Make line smaller 2017-05-04 18:41:33 -04:00
Matt Brown
df890fbfb0 Fix #155 - support @property declaration for classes with magic getters & setters 2017-05-04 18:35:05 -04:00
Matt Brown
9cabf428c4 Only make isset $this->property mixed if not already defined 2017-04-28 16:41:54 -04:00
Jon Ursenbach
f65c618b2e PSR-2 adjustments and adding PHPCS checks into the Travis config. (#149) 
* PSR-2 adjustments and adding PHPCS checks into the Travis config.

* Reverting some CallChecker changes and no longer casting vars to null.
 2017-04-28 00:31:55 -04:00
Matt Brown
bd6a623bfd Fix possible empty type when inferredType not set 2017-04-21 16:33:18 -04:00
Matt Brown
f7daa6e768 Fix #143 by allowing scalar types to be passed through 2017-04-21 14:06:47 -04:00
Matthew Brown
007442fdd0 Fix possibly-private error 2017-04-15 21:10:49 -04:00
Matthew Brown
f67e92023b Add support for intersection types 
Fixes #140
 2017-04-15 20:36:40 -04:00
Matthew Brown
2bdd062400 Ternary else should ignore if expression context 2017-04-15 13:46:18 -04:00
Matthew Brown
8d46c65815 Only make non-null if inside constructor 2017-04-14 23:26:58 -04:00
Matthew Brown
60be6f07a0 Delay checks for MissingPropertyType so we can give more useful messages 2017-04-14 23:09:34 -04:00
Matthew Brown
ce6ca58291 Fix #114 - add optional Hack-like checks calls 2017-04-14 21:32:14 -04:00
Vladimir Komissarov
818e3be00c Fix undefined global constant in closure 2017-04-14 17:03:09 +07:00
Matt Brown
7bcf7f13b1 Fix #137 - add for init in main scope 2017-04-11 17:43:46 -04:00
SignpostMarv
46a0b03aac enable the exposure of the source line number when DocblockParseException is thrown 2017-04-11 22:14:15 +01:00
Matthew Brown
32efdfd0f7 Fix #129 - emit PossiblyNullFuntionCall when encountering such a thing 2017-04-08 11:38:06 -04:00
Matthew Brown
2d454d6e10 Fix #130 - check class exists before checking for __invoke 2017-04-08 11:15:17 -04:00
Matthew Brown
a985fd9324 Add PossiblyInvalidArgument for closure param type checks 2017-04-08 09:47:03 -04:00
Matthew Brown
64361ad2c3 Add more descriptive message to PossiblyInvalidArgument issue 2017-04-08 09:43:58 -04:00
Matthew Brown
c663062816 Add PossiblyUndefinedArgument issue to cope with #126 2017-04-08 09:28:02 -04:00
Matthew Brown
b3a454cf5b Create new InvalidMethodCall issue for calling methods on non-objects 2017-04-08 09:20:32 -04:00
Matt Brown
f011197090 Fix #124 - don’t check array_filter closures when >2 args passed 2017-04-07 18:30:15 -04:00
Matthew Brown
b20ddfec94 Add better way of checking two types can ever yield identical values 2017-04-07 09:02:09 -04:00
Matthew Brown
40427839ea Get all variables possibly assigned in conditional 2017-04-06 22:56:37 -04:00
Matthew Brown
20b0460a33 Fix #123 - ternary byref vars now adjusted 2017-04-06 21:53:29 -04:00
Matt Brown
8a20aca4cf Only compare non-null types 2017-04-06 18:11:09 -04:00
Matt Brown
da19b55db1 Add special TypeDoesNotContainNull issue as distinct from TypeDoesNotContainType 2017-04-06 15:36:22 -04:00
Matt Brown
cb3f6b14ba Fix AssertionFinder to trap the right null type 2017-04-06 15:05:23 -04:00
Matt Brown
e02999f2ba Prevent undefined property notices 2017-04-06 14:57:00 -04:00
Matt Brown
14bb967c7d Warn when doing === comparisons on incompatible types 2017-04-06 14:53:45 -04:00
Matt Brown
fe43c4e37f Fix #122 - allow multiple types of filtering 2017-04-03 12:36:49 -04:00
Matthew Brown
075cc5f50d Add by-reference clause removal 2017-04-02 17:37:56 -04:00
Matthew Brown
dcedd65215 Add check for paradoxical statements 2017-04-02 15:26:10 -04:00
Matthew Brown
83edf8c4db Complete the circle – fix remaining type algebra issue 2017-04-01 19:04:49 -04:00
Matt Brown
5b34163d8d Add ability to insert suppressed issues on functions 2017-03-31 11:21:34 -04:00
Matthew Brown
676c01ed2e Fix nullref 2017-03-20 02:23:54 -04:00
Matthew Brown
066b1e011e Prevent creating empty objectlike 2017-03-20 02:05:58 -04:00
Matthew Brown
2d88e237f4 Make method non-static 2017-03-19 13:23:19 -04:00
Matthew Brown
b1b7b0ae35 Only include vars asserted in where 2017-03-18 16:34:44 -04:00
Matthew Brown
9a3049b5bc Make sure switch contexts know their parents 2017-03-18 15:28:59 -04:00
Matthew Brown
cb2ed860fb Make sure to invalidate clauses in all parent contexts when asserting 2017-03-18 15:24:14 -04:00
Matthew Brown
18af05fbd9 Do not stop at magic setter when property referenced locally 2017-03-18 15:00:01 -04:00
Matthew Brown
3452c7853f Add support for capturing clauses from elseifs 2017-03-18 14:04:26 -04:00
Matthew Brown
c33e66813a Move type algebra functionality to separate checker 2017-03-18 13:37:00 -04:00
Matt Brown
30e8e1880d Add another easy calculation of clauses 2017-03-16 14:45:45 -04:00
Matt Brown
cecfe25df7 Update outer clauses in mic drop situation 2017-03-16 11:46:07 -04:00
Matthew Brown
9b41bc9b37 Add slower (but more accurate) loop checks 2017-03-14 20:14:25 -04:00
Matthew Brown
6cfe540c98 Fix issue evaluating elseif empty assertions 2017-03-14 15:48:52 -04:00
Matthew Brown
9dd94d099f Fix issue with possibly-redefined switch vars 2017-03-14 02:00:38 -04:00
Matthew Brown
50b629e88e Update context types after switch statement without default case 2017-03-13 21:17:21 -04:00
Matt Brown
3d2be3410e Infer loop types without @var comments 2017-03-13 18:06:56 -04:00
Matt Brown
ae0ca9553f Remove training wheels 2017-03-13 12:02:28 -04:00
Matt Brown
fa63afc27d Change property name 2017-03-13 11:23:26 -04:00
Matthew Brown
a7da88bad3 Improve solution to allow for more user errors 2017-03-11 12:32:27 -05:00
Matt Brown
f9f38f283e Emit issue when property type is not defined 2017-03-02 12:19:18 -05:00
Matthew Brown
18b5617443 Prevent duplicate lookup of functionstorage 2017-03-02 00:00:31 -05:00
Matthew Brown
5cd1b6735f Add even more references in docblocks 2017-03-01 22:27:52 -05:00
Matt Brown
864d242f13 Improve labelling of referencing expressions 2017-03-01 11:56:36 -05:00
Matt Brown
518184f388 Don’t do a full class check where not necessary 2017-02-28 11:00:32 -05:00
Matt Brown
4f597a4068 Fix references 2017-02-27 16:38:43 -05:00
github@muglug.com
07c9cfb848 Check template typeof class references 2017-02-27 16:35:24 -05:00
Matt Brown
729954573b Allow generics to work even if variables not checked 2017-02-27 11:07:44 -05:00
Matt Brown
ac1a45f129 Fix erroneous error message 2017-02-27 10:53:32 -05:00
Matt Brown
7baf942eaa Prevent false positives after extract call 2017-02-27 10:52:43 -05:00
Matthew Brown
d9433c9491 Add way to find all references to a given class or method in the codebase 2017-02-27 01:30:44 -05:00
Matthew Brown
cd5f727d2e Collect explicit references to classes/methods 2017-02-26 23:09:18 -05:00
Matthew Brown
8db6921f1c More graceful early exit if not checking variables 2017-02-24 21:27:52 -05:00
Matt Brown
0049e4deb4 Fix #105 and also the issues found in its wake 2017-02-23 19:36:51 -05:00
Matthew Brown
fa3b292fd4 Fix #101 - restrict the values of pass-by-ref variables 2017-02-23 00:25:28 -05:00
Matthew Brown
12cb72ae4b Prevent recursion when checking for initialisations 2017-02-22 00:51:34 -05:00
Matthew Brown
48335b6fee Fix potential invalid arg 2017-02-22 00:42:50 -05:00
Matt Brown
a56456a719 Add merging of vars_possibly_in_scope back 2017-02-21 17:41:54 -05:00
Matt Brown
fa35c0efa9 Remove changed vars from clauses in while loop to prevent re-application of logic 2017-02-21 17:19:15 -05:00
Matt Brown
2c7ffb6f4c Add support for negating some while assertions 2017-02-21 16:52:27 -05:00
Matthew Brown
9137727993 Fix #99 - treat null coalesce more respectfully 2017-02-17 20:50:47 -05:00
Matthew Brown
7cd1b27ff1 Add more support for logical and/or 2017-02-16 21:00:45 -05:00
Matthew Brown
9579460c59 Fix #97 - is_callable shouldn’t prevent evaluation of calls to existing functions 2017-02-16 20:51:53 -05:00
Matthew Brown
2d58531631 Fix #98 - add support for logical and/or 2017-02-16 20:43:23 -05:00
Matthew Brown
32dd5d5512 Be better about dealing with byref args when not checking functions 2017-02-15 01:47:03 -05:00
Matthew Brown
500044dac1 Make sure $argv and $argc are not globally available 2017-02-12 22:12:31 -05:00
Matthew Brown
1001e03f8a Prevent empty typeof types 2017-02-12 19:51:48 -05:00
Matthew Brown
4f43a7eccb Fix possible nullref 2017-02-12 19:31:35 -05:00
Matthew Brown
1d09616e9d Prevent template types from leaking when no generics are provided 2017-02-12 19:26:23 -05:00
Matthew Brown
a87ea78efc Fix variable-scoped byref issue 2017-02-12 19:07:25 -05:00
Matthew Brown
a4323359d3 Fix ternary/which/for conditionals 2017-02-12 18:47:02 -05:00
Matthew Brown
81e24de76f Fix invalid NullPropertyFetch warning 2017-02-12 18:06:18 -05:00
Matthew Brown
9061d36566 Don’t emit InvalidArrayAccess if ignoring null arrays 2017-02-12 17:13:03 -05:00
Matthew Brown
2635744f4e Simplify array inferred type 2017-02-12 16:58:04 -05:00
Matthew Brown
2f2b487236 Fix #96 2017-02-12 12:31:39 -05:00
Matthew Brown
8e7ab59e2b Add return types for core vars 2017-02-12 12:22:39 -05:00
Matthew Brown
7876c7ffb9 Allow mixed to override null in byref assignment 2017-02-12 11:34:07 -05:00
Matthew Brown
bb9221ba01 Analyze die/exit expressions 2017-02-11 19:42:12 -05:00
Matthew Brown
f32fabd798 Remove dead code 2017-02-11 19:30:06 -05:00
Matthew Brown
deb11c9402 Change some errors from InvalidReturnType to MoreSpecificReturnType 2017-02-11 18:25:44 -05:00
Matthew Brown
35e4b380cc Add collection of PossiblyNull* issues 2017-02-11 17:55:08 -05:00
Matthew Brown
dbddedb20b Don’t create objectlike if we some properties are untyped 2017-02-10 23:35:34 -05:00
Matthew Brown
14c487d3e6 Always supply default template params as return type 2017-02-10 22:51:47 -05:00
Matthew Brown
9b3b536254 Fix issue where self::$property_name doesn’t use Context self 2017-02-10 20:41:18 -05:00
Matt Brown
32d85e20da Remove unused vars 2017-02-10 19:10:13 -05:00
Matt Brown
2c1622e7de Find more unreferenced variables by ignoring mass context ops 2017-02-10 19:08:55 -05:00
Matt Brown
c0a6fc9125 Fix #90 - add genericised stubs for common array functions 2017-02-10 18:12:59 -05:00
Matthew Brown
8ffd45407c Add support for namespaced templates 2017-02-10 00:14:44 -05:00
Matthew Brown
4a82c0a09a Add support for nested types in templates 2017-02-09 22:57:23 -05:00
Matthew Brown
98b0ed280c Add support for templating 2017-02-09 20:35:17 -05:00
Matthew Brown
585cf91ef0 If using assertions for type, count as a soft type check 2017-02-08 22:17:16 -05:00
Matthew Brown
cedb70b0b4 Reduce false positives for unused variables 2017-02-08 01:59:49 -05:00
Matthew Brown
cdcacc395d Rename DeadCode to UnusedVariable, UnusedMethod and UnusedClass 2017-02-08 00:28:26 -05:00
Matt Brown
f4857eb0dd Make dead code check emit an issue 2017-02-07 18:18:33 -05:00
Matt Brown
6b2bb7d917 Store first code location for all variables in a statement list 2017-02-07 18:09:12 -05:00
Matthew Brown
01beb97413 Fix #87 - array types from docblocks can be reasoned about safely 2017-02-03 22:07:14 -05:00
Matthew Brown
11859e9cc0 Bump PhpParser version 2017-02-03 20:14:48 -05:00
Matthew Brown
0fbf8b5619 Remove more dead code 2017-02-02 00:45:23 -05:00
Matthew Brown
ec65f31aaa Improve dead code analysis and fix errors found 2017-02-02 00:20:58 -05:00
Matthew Brown
d3abc0011d Fix #80 - add dead code checks via command line 2017-01-31 23:24:33 -05:00
Matt Brown
004fd42062 Fix #83 - add support for stubbing 2017-01-31 19:21:33 -05:00
Matthew Brown
ce93c4ef2d Assert smart things when offset is variable 2017-01-31 01:35:44 -05:00
Matthew Brown
7f8a3d798e Improve clause resolution in while loops 2017-01-31 01:30:11 -05:00
Matthew Brown
965a79251d Fix #82 by updating how isset calls are handled 2017-01-31 00:34:06 -05:00
Matthew Brown
7d912fc214 Remove vars when they’ve been changed 2017-01-30 22:26:41 -05:00
Matthew Brown
1ece3071f9 Add reference counting for methods and remove dead code 2017-01-29 23:44:05 -05:00
Matthew Brown
d978966db4 Fix #37 - check parent calls for staticness 2017-01-29 22:13:53 -05:00
Matthew Brown
aaec895e15 Do not stop dead when a property cannot be evaluated 2017-01-28 16:12:04 -05:00
Matthew Brown
a9203b63f8 Allow phan-like use of assert 2017-01-28 15:17:14 -05:00
Matthew Brown
199686c4db Add back local vars when descending into method call 2017-01-28 03:55:19 -07:00
Matthew Brown
4c3dacbbed Prevent erroneous __toString conversion in method check 2017-01-27 18:06:11 -07:00
Matthew Brown
6bcc763414 Fix #3 by checking inside __constructor calls for initialisations 2017-01-26 23:23:12 -07:00
Matthew Brown
ff46487353 Be more discerning about unaryminus/plus inferred type 2017-01-25 21:50:34 -07:00
Matthew Brown
c14a19370f Improve UnaryPlus/Minus still more 2017-01-25 20:23:06 -07:00
Matthew Brown
f03807e7b7 Fix unaryplus/minus type inference 2017-01-25 20:02:19 -07:00
Matthew Brown
ea63fd7ae3 Fix #75 - allow inteeger offsets for object-like arrays 2017-01-25 00:11:24 -07:00
Matthew Brown
0da9c10d36 Don’t complain when adding array and object-like array 2017-01-23 15:40:55 -07:00
Matthew Brown
374dc65de1 Fix #39 by checking for ArrayAcces interface 2017-01-20 00:23:58 -05:00
Matthew Brown
894b25487f Fix #71 - prevent instantiation of abstract classes 2017-01-20 00:10:10 -05:00
Matt Brown
d0207b6098 Check that class exists before checking for ArrayAccess inheritors 2017-01-19 19:02:00 -05:00
Matt Brown
a67800cac7 Ignore cloning of mixed variables 2017-01-19 15:00:05 -05:00
Matt Brown
7116585e85 Be more robust when ignoring UndefinedClass errors 2017-01-19 11:45:25 -05:00
Matt Brown
a2750a92aa Evaluate loop part of for after body 2017-01-18 17:13:20 -05:00
Matthew Brown
e78e710eef Be more resilient in the face of class_exists checks 2017-01-17 23:34:17 -05:00
Matt Brown
dae7718ae8 Support array_combine types and introduce a MoreSpecificReturnType issue 2017-01-17 11:17:49 -05:00
Matthew Brown
e4769fd04a Don’t give up when faced with variadic type 2017-01-17 00:07:58 -05:00
Matthew Brown
3cdb1753d5 Update to the more accurate TypeChecker::isContainedBy 2017-01-16 20:00:51 -05:00
Matthew Brown
9220b958eb Fix phpcs errors 2017-01-16 19:06:39 -05:00
Matthew Brown
b3726c9de5 Use getcwd() for the project’s base, not the config file parent directory 2017-01-16 18:33:04 -05:00
Matthew Brown
e3a9cb98c3 Add extra issue for invalid clone and fix issue reporting; 2017-01-16 12:59:09 -05:00
Matthew Brown
4b283564ca Allow variadic params to be passed by reference 2017-01-16 12:39:38 -05:00
Matthew Brown
5315fd15ad Fix namespaced functions in regular use statements 2017-01-16 00:49:12 -05:00
Matthew Brown
ac92de181f Allow classes that use __invoke to be called 2017-01-16 00:29:18 -05:00
Matthew Brown
f614944b63 Add predefined functions to avoid throwing errors 2017-01-15 20:11:02 -05:00
Matthew Brown
ce89ac4986 Fix #50 - asserting about docblock types no longer causes error 2017-01-15 17:52:01 -05:00
Matthew Brown
9b06b672ba Fix #54 - register function constants when function is invoked 2017-01-15 16:43:49 -05:00
Matthew Brown
faccc73dc1 Fix #52 by analysing non-main parts of issets 2017-01-15 13:58:20 -05:00
Matthew Brown
8836f05027 Fix #56 - functions in root namespaces should not need slash 2017-01-15 12:34:23 -05:00
Matthew Brown
ad38a26524 Hoist class check above method check 2017-01-15 10:24:38 -05:00
Matthew Brown
03141e41c2 Move string-stored types into named classes 2017-01-15 10:22:05 -05:00
Matt Brown
35c06261b9 Fix #38 - emit issue for non-array on right too 2017-01-13 13:09:52 -05:00
Matt Brown
dc585ff22a Fix #47 - check closure param types properly 2017-01-13 12:40:01 -05:00
Matthew Brown
c20f31855c Fix namespaced function calls 2017-01-12 09:42:24 -05:00
Matthew Brown
5f54a9571c Fix deep project checks 2017-01-12 01:03:48 -05:00
Matthew Brown
56be346191 Add back mutation checks 2017-01-11 21:37:53 -05:00
Matthew Brown
380ae61b3c Don’t emit another error if we’re already ignoring TypeCoercion 2017-01-09 00:58:18 -05:00
Matthew Brown
bf76843d94 Fix foreach dependency errors 2017-01-09 00:58:05 -05:00
Matthew Brown
f318c52876 Improve function rechecking 2017-01-09 00:31:23 -05:00
Matthew Brown
03c5ea3cef Store all class keys lowercased 2017-01-09 00:14:39 -05:00
Matthew Brown
5cc97e380d Fix issue evaluating Foo::class 2017-01-07 17:24:43 -05:00
Matthew Brown
28cd8caca8 Change analyzeMethods to analyze 2017-01-07 15:57:25 -05:00
Matthew Brown
17329015dc Discriminate between checking, visiting and analyzing in method names 2017-01-07 15:09:47 -05:00
Matthew Brown
694da2cabd Simplify a lot of APIs 2017-01-07 14:35:07 -05:00
Matthew Brown
6ee69e547f Do more to separate out processing steps 2017-01-06 01:07:11 -05:00
Matthew Brown
7609ca02c0 Fix #32 by evaluating all class references in files lazily 2017-01-04 23:42:58 -05:00
Matthew Brown
882c8a8d0c Add better checking of property array assignments 2017-01-02 00:08:35 -05:00
Matthew Brown
d9bf89f72b Fix multiple possible method signature bug 2017-01-01 20:10:28 -05:00
Matthew Brown
30a39a0ee6 Do not emit issue when callable is called 2017-01-01 19:24:15 -05:00
Matthew Brown
883ca6a5db Fix #30 by consolidating properties into single storage array 2017-01-01 19:09:17 -05:00
Matthew Brown
8f7072c175 Fix change empty arrays to nulls 2017-01-01 17:39:39 -05:00
Matthew Brown
0b3b3f01f3 Fix support for traits returning self 2016-12-31 11:49:04 -05:00
Matthew Brown
846cc59d5f Add support for checking closure return types 2016-12-31 10:51:42 -05:00
Matthew Brown
34c238c1a7 Fall through when checking for static/deprecated 2016-12-31 09:25:04 -05:00
Matthew Brown
49f7817a2a Emit specific issue when calling instance method with self:: 2016-12-31 09:20:10 -05:00
Matthew Brown
a524ca8184 Suppress more notices 2016-12-30 20:39:12 -05:00
Matthew Brown
b068bd7858 Fix many bugs 2016-12-30 20:05:32 -05:00