danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-12-11 16:59:45 +01:00
Code Issues Projects Releases Wiki Activity
14,024 Commits 43 Branches 314 Tags 108 MiB
af9649b42e
Commit Graph

5929 Commits

Author SHA1 Message Date
kkmuffme
08d515d7af don't autoload AllowDynamicProperties 2023-06-07 08:41:44 +02:00
kkmuffme
ed9fbab1c4 don't autoload Mockery/Closure 2023-06-07 08:31:53 +02:00
kkmuffme
40679e9a82 fix failing mock tests 2023-06-07 08:12:31 +02:00
Yannick Gottschalk
a130e2f06c Fixes #9820 2023-06-06 17:02:28 +02:00
orklah
9d1c2c4596
Merge pull request #9866 from klimick/fix-generic-type-params-mapping 
Fix generic type params mapping
 2023-06-04 23:05:04 +02:00
orklah
43df1dc9ba
Merge pull request #9865 from klimick/intersection-with-template 
Intersect template types during inheritance check
 2023-06-04 23:01:28 +02:00
orklah
c15860508b
Merge pull request #9853 from kkmuffme/multiple-psalm-assert-if-for-array-list 
Allow if/false assert for same variable to allow array/list distinction
 2023-06-04 22:59:37 +02:00
andrew
02addbe79c Fix generic type params mapping 2023-06-02 17:36:13 +03:00
andrew
38bd4d8c0d Intersect template 2023-06-02 14:48:20 +03:00
orklah
75baaf7889
Merge pull request #9844 from kkmuffme/property-no-set-in-constructor-abstract-false-positive 
PropertyNotSetInConstructor should not report for abstract constructors
 2023-06-01 07:21:23 +02:00
kkmuffme
103e7b343c PropertyNotSetInConstructor should not report for abstract constructors 
since they do not have any code

Fix https://github.com/vimeo/psalm/issues/9830
 2023-06-01 01:38:33 +02:00
kkmuffme
1f2db5f31c Allow if/false assert for same variable to allow array/list distinction 
Fix https://github.com/vimeo/psalm/issues/9037
 2023-06-01 01:08:06 +02:00
orklah
a762b6c3bb
Merge pull request #9841 from kkmuffme/sprintf-basic-return-type-provider 
sprintf basic non-empty-string return type provider
 2023-05-31 23:36:03 +02:00
Alies Lapatsin
174cd5c0fe Introduce and use IssueData constants for severity 
they are not the same as Config::REPORT_* constants
 2023-05-31 12:38:15 +02:00
kkmuffme
8606d5585f sprintf basic non-empty-string return type provider 
Fix https://github.com/vimeo/psalm/issues/9819
This PR is a starting point for improving the sprintf return type and eventually validate the format, param types and param count.
(see https://github.com/vimeo/psalm/issues/9817, https://github.com/vimeo/psalm/issues/9818)
 2023-05-30 22:11:17 +02:00
orklah
88aae91e55
Merge pull request #9835 from staabm/patch-5 
Fixed typo in ConstantTest
 2023-05-30 21:08:47 +02:00
kkmuffme
e3e7373e99 fix test string format 2023-05-30 16:55:13 +02:00
kkmuffme
c185437955 fix string format in test 2023-05-30 16:49:10 +02:00
kkmuffme
9d7d4bff28 non-empty-string always returs non-empty-string, fix tests 2023-05-30 16:44:23 +02:00
kkmuffme
25c7f37a44 add test, fix wrong test and fix shepherd 2023-05-30 16:29:47 +02:00
Markus Staab
9af897f328
Fixed typo in ConstantTest 2023-05-30 08:43:54 +02:00
orklah
2bbfca6d9f
Merge pull request #9829 from klimick/map-closed-inheritance-to-union 
Mapping closed inheritance to union during assertion
 2023-05-29 20:14:31 +02:00
Yannick Gottschalk
a41eb35b24 Fix #9824 2023-05-28 17:37:16 +02:00
klimick
38c93db889 More closed inheritance assertion tests 2023-05-27 18:55:27 +03:00
klimick
b7b20771c0 Add closed inheritance assertion tests 2023-05-27 13:40:23 +03:00
Jack Worman
f279c39503 GH-9825 2023-05-26 18:03:05 -04:00
Demmie
cab10721e6 Add a support for multilevel glob wildcards 
This works just like in Python with "**".
 2023-05-24 01:13:26 -04:00
orklah
f90118cdea
Merge pull request #9805 from orklah/memory-psalter 
allow using more than 8G of memory in psalter
 2023-05-22 23:19:03 +02:00
orklah
d23616cafa allow using more than 8G of memory in psalter 2023-05-22 23:06:02 +02:00
orklah
ed94de5146 fix offset for type param changes 2023-05-21 18:56:54 +02:00
orklah
22fd6fb9db
Merge pull request #9788 from robchett/strpos_stripos_assert_non_empty 
Narrow the type of $haystack when strpos(...) !== false
 2023-05-21 11:42:18 +02:00
RobChett
bd0ba6ee95 Narrow the type of haystack when strpos != false 2023-05-21 10:35:19 +01:00
RobChett
100907b61f Improve return types of pow() 2023-05-15 01:22:45 +01:00
Jack Worman
f41da745d1 UnsupportedPropertyReferenceUsage 2023-05-12 14:12:12 -05:00
Valentin Vion
3d122a745f Removed return type false from date and gmdate 2023-05-09 12:02:44 +08:00
orklah
d4c5f85eb0
Merge pull request #9687 from robchett/limit_inheritance 
WIP - Limit inheritance to a subset of classes #1450
 2023-05-07 22:46:05 +02:00
RobChett
aa85669645 Change the Issue type and add documentation 2023-05-07 11:34:33 +01:00
RobChett
cad5288484 Support interfaces 2023-05-07 11:33:39 +01:00
RobChett
de877f1dcf Add support for @psalm-inheritors 2023-05-07 11:33:38 +01:00
kkmuffme
ad7be63c0b fix tests/internal code 
@var comments needed due to https://github.com/vimeo/psalm/issues/9754 and https://github.com/vimeo/psalm/issues/9753
 2023-05-06 19:18:27 +02:00
orklah
0ea2a6a567
Merge pull request #9742 from fluffycondor/allow-phpdoc-dynamic-properties 
Allow dynamic properties from PHPDoc
 2023-05-06 15:56:16 +02:00
andrew
cfd0f062f7 Fix union argument types check against templated param 2023-05-06 16:01:16 +03:00
orklah
8d15fa1d79
Merge pull request #9735 from tscni/fix/missing-global-override-file-storage 
Fix missing global class type when scanning cached files
 2023-05-05 22:08:21 +02:00
fluffycondor
86fd504965 Allow dynamic properties from PHPDoc 2023-05-04 18:49:41 +02:00
orklah
7483f4d809
Merge pull request #9740 from edsrzf/better-property-error 
Fix OverriddenPropertyAccess error message
 2023-05-04 18:49:00 +02:00
orklah
f8895edf4d
Merge pull request #9738 from klimick/fix-invalid-cast-for-templated-class-string 
Fix invalid cast for templated class-string
 2023-05-04 18:43:41 +02:00
orklah
32bd8f66e6
Merge pull request #9739 from klimick/match-paradoxical-condition-with-complex-expr 
Fix ParadoxicalCondition with complex match expression
 2023-05-04 18:39:17 +02:00
andrew
a18eb447e0 Test match on class const fetch 2023-05-04 17:21:50 +03:00
andrew
948ece9dea Fix string negation to never 2023-05-04 15:34:18 +03:00
Tinjo Schöni
595388b7d7
Add test case for FileScanner adding class reference for configured global 2023-05-04 12:05:32 +02:00
Evan Shaw
d2f0f6ce30 Fix OverriddenPropertyAccess error message 
The message previously didn't mention the base class, which made it
confusing.
 2023-05-04 21:51:16 +12:00
klimick
ac8d489413 Fix ParadoxicalCondition with complex match expression 2023-05-04 11:58:39 +03:00
andrew
57b3876796 Fix invalid cast for templated class-string 2023-05-04 11:25:52 +03:00
orklah
a5effd2d2d
Merge pull request #9681 from robchett/no-seal-methods_and_no-seal-propeties 
Add support for @psalm-no-seal-properties and @psalm-no-seal-methods
 2023-05-02 19:20:34 +02:00
orklah
4843a350a0
Merge pull request #9720 from Jean85/fix-ambiguous-constant-inheritance 
Fix ambiguous constant inheritance false positive
 2023-04-28 23:22:31 +02:00
Alessandro Lai
54531a1d31
Add regression test for non-ambiguous constant inheritance 2023-04-27 22:39:52 +02:00
Daniil Gentili
481a5bd61d Fix date return type provider 2023-04-25 11:41:39 +02:00
orklah
720f3f1dc2
Merge pull request #9704 from Nicelocal/fix_new_template_object 
Allow running new on template objects
 2023-04-24 16:29:34 +02:00
Daniil Gentili
f6e0c5b6ac Fix 2023-04-24 14:29:45 +02:00
Daniil Gentili
7a2a68bb46 Update 2023-04-24 13:40:19 +02:00
Daniil Gentili
bff2154b23 cs-fix 2023-04-24 13:16:11 +02:00
Daniil Gentili
8288b00ef9 Allow running new on template objects 2023-04-24 13:08:12 +02:00
orklah
2b68046115
Merge pull request #9694 from Nicelocal/unsealed_array_generic_syntax 
Implement unsealed array generic syntax
 2023-04-24 12:50:57 +02:00
orklah
eae04f25f6
Merge pull request #9693 from Nicelocal/fix_9692 
Fix #9692
 2023-04-24 12:48:20 +02:00
orklah
41796e324a
Merge pull request #9700 from klimick/method-contextual-closure-arg-inference 
Contextual closure arg inference for class methods
 2023-04-24 12:47:38 +02:00
Evan Shaw
82090f58c5 Handle included directory paths without crashing 
If an include or require resolves to a directory, this now raises a
MissingFile error rather than throwing an unhandled UnexpectedValueException.
 2023-04-24 11:09:48 +12:00
klimick
cf0ca8b57a Test contextual closure arg inference for class methods 2023-04-24 00:00:15 +03:00
Daniil Gentili
8078b6dcbf Fixes 2023-04-21 15:58:05 +02:00
Daniil Gentili
b77ed37d45 Rewrite 2023-04-21 15:49:37 +02:00
Daniil Gentili
d8b85f1c04 Implement unsealed array generic syntax 2023-04-21 14:05:05 +02:00
Daniil Gentili
b8672949ec Fix #9692 2023-04-21 12:33:08 +02:00
orklah
a97b6b8a5e
Merge pull request #9685 from Nicelocal/avoid_wrong_assertions 
Avoid wrong assertions when working with objects returned by methods
 2023-04-21 11:34:15 +02:00
orklah
40d4e560bc
Merge pull request #9691 from robchett/date_gmdate_return_type 
Add return type provider for date/gmdate
 2023-04-21 11:33:02 +02:00
orklah
1dcc4c4fe0
Merge pull request #9686 from Nicelocal/fix_is_object 
Fix is_object assertions on final classes
 2023-04-21 11:32:25 +02:00
RobChett
1a1d9c9bf5 Add return type provider for date/gmdate 2023-04-21 08:12:49 +01:00
orklah
b781bd922e
Merge pull request #9679 from robchett/mixedAssignment_from_template_var 
Don't throw UnnecesseryVarAnnotation when hinting a mixed template var
 2023-04-20 23:52:52 +02:00
orklah
0dcaf1c706
Merge pull request #9678 from robchett/mb_strtolower_maintain_non_empty 
Return a non-empty-(lowercase-)string from mb_strtolower
 2023-04-20 23:44:21 +02:00
RobChett
74c1576b9c Return a non-empty-(lowercase-)string from mb_strtolower 2023-04-20 15:54:13 +01:00
Daniil Gentili
baff6fb36a fix is_object assertions 2023-04-20 14:03:35 +02:00
Daniil Gentili
efb5aed879 Avoid wrong assertions when working with objects returned by methods 2023-04-20 13:00:28 +02:00
RobChett
4d9d7cebd9 Add support for @psalm-no-seal-properties and @psalm-no-seal-methods 2023-04-20 07:47:50 +01:00
RobChett
0a40286830 Don't throw UnnecesseryVarAnnotation when hinting a mixed template var 2023-04-19 21:23:40 +01:00
orklah
5efddb4201
Merge pull request #9675 from robchett/master 
Valid array access on a non-empty-string yields a non-empty-string
 2023-04-19 21:12:29 +02:00
RobChett
836953eb7d Switch TSingleLetter to extend TNonEmptyString instead of TString as it is more precise 2023-04-19 19:27:25 +01:00
orklah
76ebf54262
Merge pull request #9676 from Nicelocal/fix_callable_union_comparison 
Fix comparison of unions of multiple callables
 2023-04-19 13:02:01 +02:00
Daniil Gentili
42fb38403d Update 2023-04-19 12:37:06 +02:00
Daniil Gentili
e16037ecaf Fix tests 2023-04-19 11:56:04 +02:00
Daniil Gentili
19fab7a805 Fix comparison of unions of multiple callables 2023-04-19 11:37:04 +02:00
WhizSid
782735e8b2 Fixed crash issue when using multiple literals for array_splice 2023-04-19 00:38:35 +05:30
adrew
aa3b2f2e1d Test anonymous object template replacement 2023-04-17 23:18:03 +03:00
orklah
542d627994
Merge pull request #9393 from ygottschalk/fix/9373-using-enum-property-as-const-array-key 
Fix/9373 using enum property as const array key
 2023-04-17 12:56:42 +02:00
andrew
b0e5df570d Fix iterable template replacement 2023-04-17 11:03:39 +03:00
orklah
a9bc87e729
Merge pull request #9656 from boesing/bugfix/issue-8981 
(re-)implement object-shape assertions
 2023-04-16 21:17:53 +02:00
orklah
6c7db9e0ec
Merge pull request #9655 from boesing/bugfix/issue-9145 
Provide support for templated `value-of` enum values
 2023-04-16 21:15:59 +02:00
orklah
24dc5d49b2
Merge pull request #9638 from boesing/bugfix/intersection-type-type-alias 
Allow to intersect type alias with non-type-aliases
 2023-04-16 21:14:21 +02:00
adrew
f0153721a4 Fix list template replacement 2023-04-15 18:46:22 +03:00
Maximilian Bösing
66afbb1c33
feature: (re-)implement object-shape assertions 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-04-15 02:36:10 +02:00
Maximilian Bösing
ad5631497d
feature: provide support for templated value-of enum values 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-04-15 00:38:12 +02:00
orklah
3e50f68794
Merge pull request #9623 from klimick/contextual-inference-for-const-callable 
Contextual inference for const callable
 2023-04-14 16:22:53 +02:00
andrew
1f282fe7ba Fix ClassTemplateTest.templateStaticWithParam test 2023-04-14 15:00:03 +03:00
orklah
6834f5dca1
Merge pull request #9651 from tuqqu/array-flip-non-empty-fix 
Fix `array_flip` to preserve non-empty array type
 2023-04-13 22:54:12 +02:00
tuqqu
d3a21acc24 Fix array_flip to preserve non-empty array type 2023-04-13 22:19:44 +02:00
orklah
cee88f2c4b
Merge pull request #9643 from whizsid/array_splice 
Fixed non empty arg issue in array_splice function
 2023-04-13 19:24:16 +02:00
WhizSid
02f8f11736 Handle empty array possibilities from array_splice 2023-04-13 14:37:09 +05:30
tuqqu
ed2285f50a Flatten match arm conditions to check conditions independently 2023-04-13 01:30:14 +02:00
WhizSid
9e5266d6fe Add issue snippet 2023-04-13 01:15:09 +05:30
WhizSid
b19c263fe5 Fixed non empty arg issue in array_splice function 2023-04-13 00:34:29 +05:30
Maximilian Bösing
6ea4b56551
qa: introduce failing test for type-aliased intersection string 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-04-11 20:29:08 +02:00
Corey Taylor
282e3d3d72 Fix various db callmaps 2023-04-10 09:06:29 -05:00
orklah
2aaa577346
Merge pull request #9629 from boesing/bugfix/unused-closure-param-for-required-argument 
Do not report required closure arguments as unused
 2023-04-10 13:25:29 +02:00
Maximilian Bösing
10e7299501
qa: add failing test for issue #8787 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-04-10 02:43:31 +02:00
Maximilian Bösing
e5ae26d1e6
qa: raise php_version in ValidCodeAnalysisTestTrait and 
`InvalidCodeAnalysisTestTrait`  to 7.4

This synchronizes with the minimum of the supported PHP versions via `composer.json` requirements.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-04-10 02:03:44 +02:00
Maximilian Bösing
707a0bac6c
qa: add another test to verify required arguments are not being reported 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-04-10 01:53:45 +02:00
Maximilian Bösing
3a9817aa74
qa: introduce failing test for #8095 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-04-10 00:53:50 +02:00
Maximilian Bösing
803786e44e
qa: restructure UnusedVariableTest 
This aligns with most recent tests which do consume `InvalidCodeAnalysisTestTrait` and `ValidCodeAnalysisTestTrait`.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-04-10 00:53:33 +02:00
orklah
763116fab3
Merge pull request #9599 from boesing/feature/callable-object-intersection 
Introduce callable object intersection
 2023-04-09 11:48:45 +02:00
ADmad
a584314c62 Allow enabling mixed issues reporting for error levels > 2. 
Refs #9619.
 2023-04-08 06:17:00 +05:30
andrew
8c09d1678b Try to fix test ClassTemplateTest.templateStaticWithParam 2023-04-07 14:56:58 +03:00
andrew
2f7a7178ca Docs for HighOrderFunctionArgHandler::remapLowerBounds 2023-04-06 18:23:50 +03:00
Maximilian Bösing
a8ed8a7b5c
revert: class-string should not allow callable only 
As per discussion with Ondřej, `class-string` should explicitly target objects.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-04-05 14:51:50 +02:00
adrew
a3aed2fc61 Analyse const callable like first-class-callable 2023-04-04 22:17:17 +03:00
Johannes Boost
865e183fa0 fix: fix phpcs errors 2023-04-04 17:59:50 +02:00
Maximilian Bösing
0621ca6e70
qa: add additional test for class-string<callable-object> 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-04-04 17:43:35 +02:00
Maximilian Bösing
6c58d98d67
feature: treat class-string<callable> as callable-object 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-04-04 17:28:58 +02:00
Johannes
37976aa117 fix: treat includes starting with '.' and '..' correct 2023-04-04 17:28:45 +02:00
orklah
610d660cb0 add test 2023-04-04 12:22:41 +02:00
orklah
06e085cf3f fix coercion detection between two keyed arrays 2023-04-04 12:05:48 +02:00
Maximilian Bösing
b18fb9691b
qa: allow error_levels notation which is compatible with named arguments 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-04-03 23:23:28 +02:00
Maximilian Bösing
ee68f16bb6
feature: introduce callable-object intersection type object&callable 
This allows devs to annotate that they expect a callable object.
In addition to this, it can also verify return and argument types.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-04-03 23:23:28 +02:00
orklah
eb7be110ec fix level of error when comparing lists of mixed 2023-04-03 11:52:55 +02:00
orklah
87d0854a97
Merge pull request #9586 from boesing/feature/value-of-enum-assertions 
Introduce `value-of` with backed enum cases in assertions
 2023-04-02 18:51:25 +02:00
Corey Taylor
5fa01d8947 Fix remaining intl, reflection. xml and zip callmaps 2023-04-02 06:34:17 -05:00
Maximilian Bösing
3f6f91f0ef
qa: re-order error message to match recent changes 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-04-01 14:57:21 +02:00
Maximilian Bösing
1d4f496d0d
feature: introduce value-of in assertions 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-04-01 14:57:20 +02:00
orklah
8b9ad1eb9e
Merge pull request #9566 from DnwK98/handle-different-line-endings 
Handle different line endings from baseline.
 2023-03-29 23:38:21 +02:00
orklah
e2abc3e554
Merge pull request #9509 from ptomulik/issue-9506 
Fixed #9506
 2023-03-28 21:18:51 +02:00
orklah
f78bf32417
Merge pull request #9570 from klimick/first-class-callable-contextual-inference 
Contextual inference for first-class-callable
 2023-03-28 20:40:04 +02:00
orklah
94f32e9718
Merge pull request #9323 from othercorey/fix-array-unique 
Fix array_unique callmap
 2023-03-28 20:27:18 +02:00
orklah
88f7ca0269
Merge pull request #9576 from othercorey/skip-gnupg 
Skip gnupg extension in callmap tests
 2023-03-28 20:25:25 +02:00
Damian Wójcik
793b8d34d8 Add baseline ignoring carriage return test. 2023-03-28 14:40:11 +02:00
Corey Taylor
528bbe3757 Skip gnupg extension in callmap tests 2023-03-28 04:20:39 -05:00
Corey Taylor
730bc221e9 Re-add array_unique() stub which preserved array type 2023-03-28 04:09:50 -05:00
orklah
6ca2f090d6
Merge pull request #9534 from fluffycondor/php8-str-function-signatures 
Improve PHP8 str_* function signatures
 2023-03-27 21:00:33 +02:00
andrew
72e5709ef2 Handle partially templated first-class-callables 2023-03-27 18:29:22 +03:00
adrew
62a79eeff3 Test with invalid first-class-callable 2023-03-26 22:47:17 +03:00
adrew
f26c16d2ab Contextually resolve templates of first-class-callable arg during call 2023-03-26 19:07:20 +03:00
Damian Wójcik
350687dcb7 Handle different line endings from baseline. 2023-03-24 10:48:03 +01:00
orklah
ef9a06c467
Merge pull request #9526 from othercorey/cleanup-unreflectable 
Clean up unreflectable callmap methods
 2023-03-24 07:13:19 +01:00
orklah
dfd7ffc459 always combine the result of expansions 2023-03-23 20:51:34 +01:00
Yannick Gottschalk
85a1c83591 Added to documentation and tests that api can be used instead of psalm-api 2023-03-20 13:34:44 +01:00
Bruce Weirdan
b25f2e6921
Fixed coercion of mixed into non-empty-mixed 
Fixes vimeo/psalm#9540
 2023-03-19 00:49:15 -04:00
Bruce Weirdan
963dd5d43d
Additional test 
This was actually fixed previously
 2023-03-18 03:45:09 -04:00
Bruce Weirdan
5a14f84fc7
Clarify testsss 2023-03-18 02:17:36 -04:00
Bruce Weirdan
2a84a63483
Prevent assertion leaks from else 
Fixes vimeo/psalm#9395
 2023-03-18 02:09:56 -04:00
fluffycondor
9730f2c073 Don't report InvalidLiteralArgument for paths 2023-03-18 00:05:44 +06:00
Paweł Tomulik
c60b3ae3de
add more tests for #9506 2023-03-17 15:56:33 +01:00
Paweł Tomulik
3b4eb518a9
add tests for #9506 2023-03-17 15:56:30 +01:00
fluffycondor
f3e950bac7 str_* functions assert for non-empty-string 2023-03-17 17:58:44 +06:00
fluffycondor
723e40840e Add InvalidLiteralArgument tests 2023-03-17 16:41:36 +06:00
fluffycondor
c2dae0e43f Add php8 str_* functions signatures 2023-03-17 16:39:04 +06:00
orklah
531eec6df8
Merge pull request #9497 from ptomulik/issue-9496 
Fixed #9496
 2023-03-16 19:25:17 +01:00
orklah
c4f6b0cd15
Merge pull request #9528 from paoloconi96/master 
Fix MissingThrowsDocblock when documented interface is extended by thrown exception interface
 2023-03-16 19:01:42 +01:00
Paolo Conizzoli
3ccb1eaffe
Fix MissingThrowsDocblock when documented interface is extended by thrown exception interface 2023-03-16 12:01:16 +01:00
Corey Taylor
6dfaafde78 Clean up unreflectable callmap methods 2023-03-16 03:34:45 -05:00
fluffycondor
cfe8651bdd Add tests for falsable return 2023-03-16 12:42:36 +06:00
fluffycondor
0c3fa5b5d0 Add depth range 
According to
https://www.php.net/manual/en/function.json-decode.php#:~:text=The%20value%20must%20be%20greater%20than%200%2C%20and%20less%20than%20or%20equal%20to%202147483647
 2023-03-16 12:08:48 +06:00
fluffycondor
d11c7cdb8e Add JSON_THROW_ON_ERROR full support 2023-03-16 12:08:07 +06:00
Evan Shaw
ce3f7fccd6 Set inside_call for eval expressions 2023-03-15 22:06:36 +13:00
Bruce Weirdan
c272be1e04
Merge pull request #9499 from weirdan/fix-integer-overflow-in-array-keys 2023-03-14 22:43:11 -04:00
Bruce Weirdan
9b00049d05
Merge pull request #9491 from weirdan/support-numeric-literal-separators-in-docblocks 2023-03-14 22:20:24 -04:00
Bruce Weirdan
c7c0b79903
Merge branch 'master' into fix-integer-overflow-in-array-keys 2023-03-14 22:17:04 -04:00
orklah
293b7281f9
Merge pull request #8960 from tm1000/feature/upgrade-lsp-v5 
WIP: Performance/Feature Improvements to the Language Server
 2023-03-14 07:31:35 +01:00
Bruce Weirdan
1a5a9d2242
Fix asserted property mangling 
Fixes vimeo/psalm#9505
 2023-03-13 02:15:21 -04:00
Paweł Tomulik
24ddf9e739
revised tests for #9496 2023-03-13 06:07:19 +01:00
Paweł Tomulik
f61ffe4e27
Merge branch 'pvandommelen-issue-9496' into issue-9494-merged 2023-03-13 05:56:37 +01:00
Paweł Tomulik
1dfeaf8c06
add test for #9496 2023-03-13 05:43:18 +01:00
Bruce Weirdan
30369e826a
Correctly handle near-overflowing keys and flag autoincrement overflows 
Co-authored-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-12 19:57:14 -04:00
Peter van Dommelen
6bbcfb2429 Reuse the normal docblock-type parser when parsing type aliases instead of doing regex magic. 
Fixes #9496.
Also resolves an additional issue with comments after a type which does not contain brackets.
Includes a test for multiline types which did not yet exist.
 2023-03-12 22:58:20 +01:00
Bruce Weirdan
0e9085f3e0
Handle overflow in SimpleTypeInferer as well 2023-03-12 17:47:42 -04:00
Bruce Weirdan
103aa019da
Fix integer overflow in array keys 
Fixes vimeo/psalm#9498
 2023-03-12 16:20:13 -04:00
orklah
47c482188d
Merge pull request #9474 from othercorey/missing-callmap-types 
Add missing array, float, int and bool types to callmaps
 2023-03-12 18:58:42 +01:00
Paweł Tomulik
b12ed07793
add test for #9496 2023-03-12 18:34:41 +01:00
Paweł Tomulik
388efaf85c
append commas to array items 2023-03-12 18:23:10 +01:00
Paweł Tomulik
fc402b1c95
add tests for #9433 2023-03-12 18:23:07 +01:00
Bruce Weirdan
b37c56613b
Support int separators in docblocks 
PHP understands `1_000` to be `1000`, so there's no reason why it
shouldn't be recognized in docblocks as well.
 2023-03-11 23:14:40 -04:00
Bruce Weirdan
d6daaa842e
Merge pull request #9479 from fluffycondor/json_throw_with_unescaped_unicode 2023-03-11 22:04:09 -04:00
Bruce Weirdan
46493ab358
Compare list generic params 
So that `list<int>` does not accept `list{1, new stdClass}`

Fixes vimeo/psalm#9485
 2023-03-11 05:23:49 -04:00
fluffycondor
7ba0f9798c Fix test 2023-03-10 11:44:53 +06:00
fluffycondor
2abefb9618 Return a non-empty-string with JSON_THROW_ON_ERROR | JSON_UNESCAPED_UNICODE 2023-03-10 11:34:23 +06:00
Corey Taylor
e71e2edd3c Add missing array, float, int and bool types to callmaps 2023-03-09 13:04:03 -06:00
Corey Taylor
ee77ca63e8 Fix remaining intl callmaps 2023-03-08 20:59:14 -06:00
Bruce Weirdan
193a0dbe0e
Don't crash on unary minus overflow 
Fixes vimeo/psalm#9464
 2023-03-07 12:29:40 -04:00
Corey Taylor
8bd2267060 Fix DOM callmaps 2023-03-06 04:33:59 -06:00
Peter van Dommelen
c72edefc9e Do not strip the last ) bracket when parsing phpdoc type aliases. 
Fixes https://github.com/vimeo/psalm/issues/6782

Reworked the regex logic to not check each grouping character separately. Removed the `^` character from the character list, which was likely unintended.
 2023-03-05 22:28:22 +01:00
Bruce Weirdan
f801561ea7
Improce enum case reconciliation 
Fixes vimeo/psalm#9456
 2023-03-05 16:34:51 -04:00
Bruce Weirdan
9abd4285df
Use 8.2 in tests for 8.2 attributes 2023-03-03 04:39:04 -04:00
Bruce Weirdan
468dd1be4c
PHP 8.2 attributes moved to 8.2 stub 2023-03-03 04:28:37 -04:00
Bruce Weirdan
36913b13d5
Support for readonly classes 2023-03-03 04:04:12 -04:00
Bruce Weirdan
7b8a0a61b9
Require <?php tag in tests 
This had me puzzled for some time on several occasions
 2023-03-03 02:50:11 -04:00
Bruce Weirdan
98d96fbe9c
Forbid private final methods 
Fixes vimeo/psalm#8374
 2023-03-03 02:00:09 -04:00
Andrew Boyton
e8bd52eba6 Merge param descriptions when adding or updating types 2023-03-03 08:32:24 +11:00
Andrew Nagy
7e9638b729 Merge branch 'master' of https://github.com/vimeo/psalm into feature/upgrade-lsp-v5 2023-03-02 18:10:13 +00:00
Andrew Nagy
5eed370fa5 fix outstanding CI issues 2023-03-02 18:02:23 +00:00
Andrew Nagy
6e109aadce Merge tag '5.7.7' of https://github.com/vimeo/psalm into feature/upgrade-lsp-v5 2023-03-02 17:04:33 +00:00
Bruce Weirdan
839dc10da2
Merge pull request #9435 from vimeo/revert-9434-array_pop-is-impure 2023-03-01 01:48:26 -04:00
orklah
83051cfe87
Merge pull request #9291 from lptn/disableExtensions-hides-warnings 
Do not display ext deprecation note when `disableExtensions` used
 2023-03-01 00:06:59 +01:00
Bruce Weirdan
5130563d9f
Revert "array_pop is impure" 2023-02-28 19:06:07 -04:00
Bruce Weirdan
007ffaecd8
array_pop is impure 
Fixes vimeo/psalm#9429
 2023-02-28 18:53:36 -04:00
Alies Lapatsin
feb0cb8598 Merge branch 'master' into disableExtensions-hides-warnings 
# Conflicts:
#	src/Psalm/Config.php
 2023-02-28 22:51:43 +01:00
Paweł Tomulik
68fc72e139
add unit test for #4460 2023-02-28 11:38:44 +01:00
orklah
e212b06970
Merge pull request #9420 from othercorey/iterator-spl-callmap 
Fix remaining spl and iterator callmaps
 2023-02-27 22:32:32 +01:00
Corey Taylor
879d9cd788 Fix remaining spl and iterator callmaps 2023-02-27 15:23:48 -06:00
orklah
99b598716d
Merge pull request #9422 from EgorBakulin/#9411/concat-should-never-remove-non-empty-non-falsy-from-string 
concat should never remove non empty non falsy from string #9411
 2023-02-27 18:49:24 +01:00
ebakulin
a9b9d386a9 added testcases with undefined constant concatination 2023-02-27 22:00:36 +07:00
Paweł Tomulik
ee032d4ca9
add unit tests for #9401 2023-02-27 00:07:00 +01:00
Evan Shaw
f7eaa5daec Preserve PossiblyUndefinedVariable when fixing UnusedVariable 2023-02-25 20:08:01 +13:00
Yannick Gottschalk
ad5bf62094 Fixes #9373 2023-02-24 13:32:04 +01:00
Yannick Gottschalk
98d3514197 Refs #9373, partial fix 2023-02-24 10:17:27 +01:00
Bruce Weirdan
caac14c4a4
Consistently report docblock issues on all classlikes 
Fixes vimeo/psalm#9365
 2023-02-24 03:31:00 -04:00
Bruce Weirdan
5f59f07163
Allow array as magic method name 
Fixes vimeo/psalm#9321
 2023-02-24 02:23:09 -04:00
Bruce Weirdan
3f52ded9c3
Correctly process use aliases in @psalm-scope-this 
Fixes vimeo/psalm#9386
 2023-02-24 00:53:36 -04:00
Corey Taylor
74a67a0416 Update Phar callmaps 2023-02-23 21:02:24 -06:00
Bruce Weirdan
2315c98a73
Merge pull request #9381 from weirdan/enforce-literal-string-length-limit 2023-02-23 16:47:53 -04:00
Yannick Gottschalk
f026226aa3 Fixes #9384 2023-02-23 17:23:46 +01:00
Bruce Weirdan
f4e66a0fbf
Add test 2023-02-23 04:01:29 -04:00
Bruce Weirdan
e96a929451
Merge pull request #9383 from weirdan/process-psalm-api-on-methods 2023-02-23 04:00:42 -04:00
Bruce Weirdan
2e90cb6c6a
Process @psalm-api tags on methods 2023-02-23 03:52:10 -04:00
Bruce Weirdan
d0a14005a8
Merge pull request #9380 from weirdan/array-in-foreach-is-not-empty 2023-02-23 02:20:46 -04:00
Bruce Weirdan
1769f8b9a4
Refine arrays in foreach loops to non-empty-array 
Fixes vimeo/psalm#9378
 2023-02-22 20:44:50 -04:00
Javier Sanahuja
4f83324a91 Support sizeof alias of count 2023-02-22 23:11:10 +01:00
Ulrich Eckhardt
4596301290 FFI Stubs: Define a set of tests. 
Mostly, those are derived from examples from the documentation.
 2023-02-21 23:08:58 +01:00
Bruce Weirdan
c46eccda76
Merge pull request #9358 from weirdan/revert-8761 2023-02-21 02:57:53 -04:00
Corey Taylor
c62465ceef Fix several spl callmap methods 2023-02-20 22:30:21 -06:00
Bruce Weirdan
01c19d94ba
Added a bunch of tests from referenced issues 2023-02-20 23:45:01 -04:00
Bruce Weirdan
ac86981a79
Revert "#7387 Add asserting non-empty-string by strlen" 
This reverts commit 0ef7ec100a.
 2023-02-20 23:07:22 -04:00
Evan Shaw
a03299f3d0 Include setrawcookie as an impure function 2023-02-21 14:24:05 +13:00
Ismail Turan
bec8ddf525 fix (DateTime|DateTimeImmutable)::modify() return types 
vimeo#9042 caused issues to any called method on an instance
of DateTime|DateTimeImmutable after calling the modify
method.

This fixes vimeo#9171
 2023-02-20 08:47:05 +01:00
Bruce Weirdan
38cc316ce9
Update tests/TypeReconciliation/ConditionalTest.php 2023-02-19 06:02:12 -04:00
Evan Shaw
a25fe35584 Negated is_numeric narrows scalar type 2023-02-19 22:38:34 +13:00
Bruce Weirdan
863f15ab15
Merge pull request #9337 from weirdan/validate-test-environment 2023-02-19 04:35:11 -04:00
Bruce Weirdan
73bad8967d
Forbid first-class callables in new 
It's an invalid construct in PHP, not rejected by PHPParser for some
reaason.

Fixes vimeo/psalm#9335
 2023-02-19 04:18:32 -04:00
Bruce Weirdan
236c1a8ae5
Added the test to validate test environment itself 
We should make sure that the environment the tests are run is as strict
as possible. For example, zend.assertions should be enabled.
 2023-02-19 03:52:12 -04:00
Evan Shaw
d4a57c863c Enable store_node_types for all test cases 2023-02-19 19:52:45 +13:00
Evan Shaw
c8393bd50d Fix language server first-class callable crashes 2023-02-19 14:18:17 +13:00
Bruce Weirdan
4f22c2e7c6
Propagate phantom classes to closure context 
Fixes vimeo/psalm#9317
 2023-02-18 01:52:10 -04:00
Corey Taylor
e813a54d03 Skip verifying memcache extension callmap 2023-02-17 01:27:37 -06:00
Alies Lapatsin
2ddc54331d Merge branch 'master' into disableExtensions-hides-warnings 2023-02-16 10:55:38 +01:00
Bruce Weirdan
1c2bc49838
Forbid non-null defaults for callable parameters 
Fixes vimeo/psalm#3284
 2023-02-16 01:36:06 -04:00
Bruce Weirdan
f70f6517a7
Merge pull request #9314 from weirdan/flag-unused-docblock-params 
Flag docblock parameters that have no counterparts in function signature
 2023-02-15 22:31:41 -04:00
Bruce Weirdan
1e71da3799
Merge pull request #9309 from othercorey/fix-memcached-callmap 2023-02-15 22:24:39 -04:00
Bruce Weirdan
0e9f04c55d
Merge pull request #9313 from othercorey/allow-ignored-callmap 2023-02-15 22:23:02 -04:00
Bruce Weirdan
e6aa63731d
Flag docblock parameters that have no counterparts in function signature 
Fixes vimeo/psalm#3166
 2023-02-15 22:04:26 -04:00
Corey Taylor
0598402620 Skip verifying callmaps based on name pattern 2023-02-15 20:00:04 -06:00
Bruce Weirdan
ee823619b8
Flag direct constructor calls 
Fixes vimeo/psalm#2975
 2023-02-15 20:14:00 -04:00
Corey Taylor
ab77cfd490 Fix memcached extension callmap 2023-02-15 17:26:58 -06:00
Alies Lapatsin
4da3252886
Merge branch 'master' into disableExtensions-hides-warnings 2023-02-15 22:01:38 +01:00
Bruce Weirdan
d6b75057a4
Fix test 2023-02-15 03:02:34 -04:00
Bruce Weirdan
8c491e93e8
Flag class constant references where LHS is ordinary string 
Fixes vimeo/psalm#2185
 2023-02-15 02:57:00 -04:00
Bruce Weirdan
3f2ecaec7e
Allow @var annotations on global vars 
The actual code was extracted from `StaticAnalyzer`

Fixes vimeo/psalm#1111
 2023-02-15 01:20:03 -04:00
Bruce Weirdan
a538439a87
Add option to skip callmap test 
With this change, callmap tests can be skipped with
`--exclude-group=callmap`:

```console
$ php-noxdebug vendor/bin/paratest --passthru-php="-dmemory_limit=-1" --exclude-group=callmap
```
 2023-02-15 00:30:45 -04:00
Bruce Weirdan
840250c534
Update expectations formatting 
It's easier to read with consistent indentation
 2023-02-14 21:59:01 -04:00
Bruce Weirdan
1ab02125b0
Added issue type and psalm.dev link to Emacs report 
Fixes vimeo/psalm#8331
 2023-02-14 21:19:29 -04:00
Alies Lapatsin
766d1487a9
Merge branch 'master' into disableExtensions-hides-warnings 2023-02-14 20:53:54 +01:00
Alies Lapatsin
cfa4450394 Do not display ext deprecation note when disableExtensions used 
Fixes #8958
 2023-02-14 12:34:49 +01:00
Bruce Weirdan
39c992c255
Emit issues for calls to is_a(string, class-string, false) 
Fixes vimeo/psalm#4092
 2023-02-14 02:25:46 -04:00
Bruce Weirdan
cee90fc071
Compare enum cases thoroughly 
Fixes vimeo/psalm#7814
 2023-02-13 22:39:33 -04:00
orklah
9921625691
Merge pull request #9278 from othercorey/fix-func-callmap 
Fix remaining callmap functions
 2023-02-13 07:10:43 +01:00
Corey Taylor
8fb290eb0d Fix remaining callmap functions 2023-02-12 23:10:09 -06:00
Bruce Weirdan
873d79c5d7
Forbid overriding built-in enum methods 
Fixes vimeo/psalm#9274
 2023-02-13 00:37:59 -04:00
orklah
5d1fe88d3f
Merge pull request #9272 from weirdan/forbid-extending-some-interfaces 
Forbid implementing some interfaces
 2023-02-12 08:38:54 +01:00
Corey Taylor
42e301cf84 Update callmap types for php 8.2 2023-02-12 01:24:43 -06:00
Bruce Weirdan
085e8f6fb2
Forbid implementing some interfaces 
- `Throwable` can only be implemented when classes extend one of
  `Exception` or `Error`
- `UnitEnum` and `BackedEnum` cannot be implemented by user-defined
  classes

Refs vimeo/psalm#7722
 2023-02-12 02:48:50 -04:00
Corey Taylor
9547a5cba5 Fix several callmap function signatures 2023-02-11 04:53:11 -06:00
Bruce Weirdan
85d4acf3b3
Fix crash when int range boundary is overflown 
Fixes vimeo/psalm#9114
 2023-02-09 22:57:57 -04:00
Bruce Weirdan
954136679a
Fix crashes with invalid @psalm-check-type syntax 
Fixes vimeo/psalm#9201
 2023-02-09 17:49:49 -04:00
Bruce Weirdan
1ee0f1bcb8
Merge pull request #9256 from othercorey/spoofchecker-callmap 
fixes https://github.com/vimeo/psalm/issues/9254
 2023-02-09 12:53:42 -04:00
Corey Taylor
b467a0a74e Fix Spoofchecker callmaps 2023-02-09 10:38:39 -06:00
Bruce Weirdan
250d4d593e
Don't crash on unknown exceptions in @throws docblock 
Fixes vimeo/psalm#9248
 2023-02-09 02:56:01 -04:00
Bruce Weirdan
3c4a829f71
Fixed more CS issues 2023-02-07 11:20:02 -04:00
Corey Taylor
e8ae1ec084 Convert callmaps resource types 2023-02-06 01:12:14 -06:00
Matthew Brown
d450b40da8
Remove some logic that didn't need to be there (#9209) 
* Remove check to see what breaks

* Simplify following logic

* Add tests from @kkmuffme‘s branch

* Reduce scope of fix

* Clean up logic a little

* Add failing test

* Improvements

* Fix for non-Paradoxical Condition result
 2023-02-03 21:08:16 -05:00
orklah
54cd529642
Merge pull request #9170 from mmcev106/filter-var-pure 
Added @psalm-pure to filter_var()
 2023-02-02 23:39:06 +01:00
Corey Taylor
f922e576c8 Fix xmlrpc callmap functions that were dropped in PHP 8.0 2023-02-02 12:21:31 -06:00
Bruce Weirdan
5d930a438a
Fix invalid test cases 2023-02-02 12:27:57 -04:00
Bruce Weirdan
fb65c79079
Fix newly discovered CS issues 2023-02-02 12:19:22 -04:00
Mark McEver
b5781c34e8 Fixed a case where the conditional taint, specialize, & flow features were not playing nicely together 2023-02-01 15:41:52 -06:00
Leo Viezens
7966fd574a
Merge branch 'master' into master 2023-01-30 15:38:29 +01:00
Alies Lapatsin
c55d297d0a Fix coding style issue 2023-01-29 18:52:09 +01:00
Alies Lapatsin
c75e4bdb28 Merge remote-tracking branch 'origin/unify-deprecation-messages' into unify-deprecation-messages 2023-01-29 18:32:55 +01:00
Alies Lapatsin
7526d60f2a Update assertion to reflect a new output 
It reverts 588d9e08bc (diff-1ef46093f20172c4dc1cbe5a54e5b60c255082acd3f7c382dae621d8d23df404R172)
 2023-01-29 18:32:31 +01:00
orklah
aec0edc618
Merge pull request #9177 from Nicelocal/duplicate_keys 
Detect duplicate keys in array shapes
 2023-01-25 18:37:22 +01:00
Andrew Nagy
b14ed73c0b Merge tag '5.6.0' into feature/upgrade-lsp-v5 2023-01-25 17:08:24 +00:00
Daniil Gentili
247d30f74c Detect duplicate keys in array shapes 2023-01-25 10:42:05 +01:00
shvlv
6227943bfb
Allow to scan private constants 2023-01-24 13:31:58 +02:00
shvlv
d6aff3ed20
Parse class constant for PhpStorm Meta override 2023-01-24 12:24:52 +02:00
Bruce Weirdan
70f2fb7d1b
Check $this in static closures 
Fixes vimeo/psalm#9148
Fixes vimeo/psalm#2813
 2023-01-23 05:16:12 -04:00
Bruce Weirdan
2af7f51394
Suppress warnings when --no-output is specified 2023-01-22 20:40:21 -04:00
Anner Visser
d86fcf4a85
Narrow ->value of enum case(s) to only the possible values 
Using $stmt_var_type to determine if we're dealing with a subset of the
enum cases. If so, we only consider those cases for the possible values.

Fixes #8568
Fixes #8812
 2023-01-21 12:05:24 +01:00
orklah
9e34de59cb
Merge pull request #9156 from vimeo/indent-docblocks-in-tests 
Indent docblocks in DocComment test
 2023-01-21 00:09:43 +01:00
Bruce Weirdan
bf99b76798
Indent docblocks in DocComment test 
Since heredocs in PHP 7.3+ automatically strip leading whitespace we can
fix the formatting for this test.
 2023-01-20 18:15:07 -04:00