Matthew Brown
869c65b4fc
Move property check to relevant position
2017-07-09 18:37:30 -04:00
Matthew Brown
cb6d9457ee
Fix issue reporting on uninitialised properties in foreign classes
2017-07-09 18:33:56 -04:00
Matthew Brown
581cf5f7eb
Don’t allow trait to override non-abstract method definition for parent class
2017-07-09 15:54:43 -04:00
Matthew Brown
90f3b88544
Correct casing
2017-07-09 15:27:07 -04:00
Matthew Brown
39a27f41b3
Prevent checking reflected methods for mutations
2017-07-09 15:19:05 -04:00
Matthew Brown
922b6640fa
Avoid possible nullrefs
2017-07-09 14:50:57 -04:00
Matthew Brown
32ff386b4a
Fix #184 - prevent classes without reflected classes from breaking everything
2017-07-09 14:36:06 -04:00
Matthew Brown
a2a86ef9b1
Fix psalm issue
2017-07-08 22:19:53 -04:00
Matthew Brown
23f41b4543
Narrow down the error location even further
2017-07-08 22:11:55 -04:00
Matthew Brown
83a6f914a7
Add start/end file offsets for better Psalm errors
2017-07-08 22:06:49 -04:00
Matthew Brown
67338c4bf5
Also detect non-inherited private constructors
2017-07-08 22:01:26 -04:00
Matthew Brown
c7b0f6685f
Make Psalm a bit faster
2017-07-08 21:19:16 -04:00
Matthew Brown
91bdd65588
Fix #179 - check for abstract method instantiations
2017-06-30 10:24:47 -04:00
Matthew Brown
d8654b8389
Slow down Psalm by checking parent initialisations too
2017-06-30 01:24:45 -04:00
Matthew Brown
fe6f0c073b
Exit early if var not defined
2017-06-29 20:34:43 -04:00
Matt Brown
fef589fb68
Fix issue with array access on property
2017-06-29 17:39:46 -04:00
Matt Brown
5220df4837
Fix #177 - treat return type as nullable due to try
2017-06-29 10:33:54 -04:00
Matthew Brown
368b6670d7
Fix a few edgecases
2017-06-29 00:28:37 -04:00
Matthew Brown
8fd671bdc4
Fix #167 - prevent Empty type in assignment
2017-06-28 23:37:02 -04:00
Matthew Brown
bc35f88859
Fix issue with $this instanceof checks in traits
2017-06-23 00:39:37 -04:00
Matt Brown
967b51d5fc
Make sure that traits are listed as analyzable so issues can be shown
2017-06-21 16:36:45 -04:00
Matt Brown
f49d167a49
Add tracking from where a trait was included
2017-06-21 14:22:52 -04:00
Matthew Brown
878696b72c
Fix #173 - don’t emit MissingConstructor issues from trait constructor
2017-06-21 01:25:41 -04:00
Matt Brown
e5c25eae97
Fix #172 - make sure new coalesce vars escape brackets
2017-06-20 15:38:32 -04:00
Matt Brown
e1d5eab7a2
Fix long line
2017-06-20 14:07:54 -04:00
Matt Brown
473040ca8f
Fix #171 by supporting exit statements for fopen
2017-06-20 13:25:37 -04:00
Matt Brown
f4338c38e7
Fix #148 - suppress InvalidDocblock where appropriate
2017-06-13 14:00:41 -04:00
Matthew Brown
6b2b80d0bb
Assign var to correct context
2017-06-13 00:09:15 -04:00
Matthew Brown
152d1512f1
Fix issue capturing method mutations in traits
2017-06-12 22:51:39 -04:00
Matthew Brown
72e1221a2f
Fix #168 and add test case
2017-06-11 19:20:07 -04:00
Matt Brown
1745518c2c
Fix #166 - prevent require loop
2017-06-06 10:11:34 -04:00
Matthew Brown
81223c45e0
Fix #166 - return instead of looping infinitely
2017-06-05 21:46:04 +01:00
Matthew Brown
fa4678912f
Fix possible nullref
2017-05-29 23:21:46 -04:00
Matthew Brown
8c0aced195
Add specific check for return type parse issue ref #165
2017-05-29 20:58:49 -04:00
Matthew Brown
93e7486d5e
Reduce line length
2017-05-26 20:17:56 -04:00
Matthew Brown
22a716f4da
Improve formatting of phpdocs
2017-05-26 20:16:18 -04:00
Matthew Brown
d6909193ea
Add additional formatting changes
2017-05-26 20:05:57 -04:00
SignpostMarv
adef59629a
scrutinizer-ci ( #152 )
...
* swapping phpcs for php-cs-fixer
* workaround for php-cs-fixer treating parenthesis following echo as the function call variant
* amending rules
* blank_line_before_return
* majority of files pass with these disabled, could remove later
* combine_consecutive_unsets
* concat_space
* placeholder for if vimeo/psalm ever goes php:^7.0
* function_to_constant
* disabling include
* linebreak_after_opening_tag, lowercase_cast, magic_constant_casing
* mb_str_functions disabled
* method_separation
* native_function_casing
* native_function_invocations
* new_with_braces disabled to match usage
* no_alias_functions
* no_blank_lines_after_class_opening
* no_blank_lines_after_phpdoc
* no_blank_lines_before_namespace
* no_empty_comment
* no_empty_phpdoc
* no_empty_statement
* no_extra_consecutive_blank_lines
* no_leading_import_slash to discuss
* no_leading_namespace_whitespace
* no_mixed_echo_print
* no_multiline_whitespace_around_double_arrow
* no_multiline_whitespace_before_semicolons
* no_php4_constructor
* no_short_bool_cast
* no_short_echo_tag
* no_singleline_whitespace_before_semicolons
* no_spaces_around_offset
* no_trailing_comma_in_list_call
* no_trailing_comma_in_singleline_array
* no_unneeded_control_parentheses to discuss
* no_unreachable_default_argument_value
* no_unused_imports to discuss
* no_useless_else to discuss
* no_useless_return
* no_whitespace_before_comma_in_array
* no_whitespace_in_blank_line
* non_printable_character
* normalize_index_brace
* ordered_class_elements to discuss
* ordered_imports to discss
* php_unit_construct
* php_unit_dedicate_assert
* php_unit_fqcn_annotation
* php_unit_strict to discuss
* php_unit_test_class_requires_covers to discuss
* phpdoc_add_missing_param_annotation
* phpdoc_align to discuss
* phpdoc_annotation_without_dot to discuss
* phpdoc_indent to discuss
* phpdoc_inline_tag
* phpdoc_no_access
* phpdoc_no_alias_tag
* phpdoc_no_empty_return
* phpdoc_no_package
* phpdoc_no_useless_inheritdoc
* phpdoc_order to discuss
* phpdoc_return_self_reference
* phpdoc_scalar to discuss
* phpdoc_separation to discuss
* phpdoc_single_line_var_spacing
* phpdoc_summary to discuss
* phpdoc_to_comment to discuss
* phpdoc_trim to discuss
* phpdoc_types
* phpdoc_var_without_name
* pow_to_exponentiation
* pre_increment to discuss
* protected_to_private
* psr0 turned off
* psr4 turned on
* random_api_migration
* return_type_declaration to discuss
* self_accessor to discuss
* semicolon_after_instruction
* short_scalar_cast
* silenced_deprecation_error turned off
* simplified_null_return to discuss
* single_quote
* space_after_semicolon
* standardize_not_equals
* strict_comparison to discuss
* strict_param to discuss
* ternary_operator_spaces
* ternary_to_null_coalescing should be set to true if vimeo/psalm ever goes php:^7.0
* trailing_comma_in_multiline_array to discuss
* trim_array_spaces
* unary_operator_spaces
* whitespace_after_comma_in_array to discuss
* multi-version scrutinizer to match travis
* binary_operator_space
* not the best solution, but it works to exclude the call map from php-cs-fixer
* reducing verbosity of config where defaults were used
* dry run php-cs-fixer as part of tests
* disabling rule pending FriendsOfPHP/PHP-CS-Fixer#2739
* enabling no_unused_imports
* enabling ordered_imports
* ignoring user-defined .php_cs
* using $TRAVIS_COMMIT_RANGE to only test modified files
* enabling no_leading_import_slash
* conditionally testing everything
* filter output then perform exact match
* restoring phpcs via partial cherry pick of f65c618
2017-05-26 18:26:14 -04:00
Matthew Brown
688a72c794
Fix #36 - emit issues on deprecated properties
2017-05-25 01:32:34 -04:00
Matthew Brown
0fdf281896
Add support for @deprecated classes
2017-05-25 00:34:39 -04:00
Matthew Brown
44b4d04e0a
Fix #95 - emit issue on private constructor calls
2017-05-24 23:55:54 -04:00
Matthew Brown
8f317cd8a2
Fix #133 - emit issue when calling no-constructor class with args
2017-05-24 23:11:40 -04:00
Matthew Brown
f5fc91a506
Remove stray docblock
2017-05-24 22:32:52 -04:00
Matthew Brown
4fd46e1752
Improve formatting
2017-05-24 22:07:49 -04:00
Matthew Brown
42b435e23f
Fix #134 - warn when docblock type is ill-formatted
2017-05-24 21:11:18 -04:00
muglug
77a44051c5
Fix issues with @psalm-ignore-nullable-return types
2017-05-22 14:50:03 -04:00
muglug
65d86d35ad
Separate iterator issues
2017-05-22 11:59:58 -04:00
Matthew Brown
96e3ad02fc
Remove blank line
2017-05-21 13:52:06 -04:00
Matthew Brown
92e184086f
Fix #158 - prevent using resource in return type
2017-05-21 13:48:17 -04:00
Matthew Brown
7532e32b9d
Fixed spacing and use statement formatting
2017-05-19 00:48:26 -04:00
Matt Brown
052624fa94
Fix issue calculating inherited parent property mutations
2017-05-12 19:15:08 -04:00
Matt Brown
53b81ac2e1
Fix pass-by-ref
2017-05-10 14:05:26 -04:00
github@muglug.com
20d4831f67
Improve return type ignore_nullable inference
2017-05-10 14:03:51 -04:00
Matt Brown
d7e2c5ee3c
Don’t emit InvalidReturnType when we don’t care about nullability
2017-05-10 13:52:24 -04:00
Matt Brown
f73fc7c6eb
Carry over ignore_nullable_issues when combining/simplifying types
2017-05-10 13:36:05 -04:00
Matt Brown
cadaef14e6
Carry forward ignore_nullable_return in fleshOutType
2017-05-10 12:49:59 -04:00
Matt Brown
39ece995b6
Add @psalm-ignore-nullable-return annotation
2017-05-10 12:36:11 -04:00
github@muglug.com
9ff8736e53
Add the means to ignore PossiblyNull* errors from the type itself
2017-05-09 16:38:58 -04:00
Matt Brown
77da5ca99e
Fix #156 - allow objectlike arrays to be merged nicely
2017-05-05 18:53:45 -04:00
Matt Brown
624bba0f5c
Divid pseudo properties into get and set types
2017-05-05 11:20:05 -04:00
Matthew Brown
c4f45b0f1a
Add more info for plugin
2017-05-05 00:06:46 -04:00
Matthew Brown
d2ae36296f
Add plugin to improve storage after scanning classlike
2017-05-04 22:40:24 -04:00
Matthew Brown
c9b9b29cf4
Fix all phpcs issues
2017-05-04 21:57:26 -04:00
Matt Brown
2bd1dfafe7
Make line smaller
2017-05-04 18:41:33 -04:00
Matt Brown
df890fbfb0
Fix #155 - support @property declaration for classes with magic getters & setters
2017-05-04 18:35:05 -04:00
Matthew Brown
754a4d9950
Allow Psalm to be run outside of the directory it's installed in ( #154 )
...
* Add --root option when not running Psalm from root directory
* Add informative error when running Psalm outside of its project directory
* Add better message in help
* Fix autoloader precedence
2017-05-04 14:25:58 -04:00
Matt Brown
9cabf428c4
Only make isset $this->property mixed if not already defined
2017-04-28 16:41:54 -04:00
Jon Ursenbach
f65c618b2e
PSR-2 adjustments and adding PHPCS checks into the Travis config. ( #149 )
...
* PSR-2 adjustments and adding PHPCS checks into the Travis config.
* Reverting some CallChecker changes and no longer casting vars to null.
2017-04-28 00:31:55 -04:00
Matt Brown
bd6a623bfd
Fix possible empty type when inferredType not set
2017-04-21 16:33:18 -04:00
Matt Brown
dc26d2df04
Fix #144 - prevent innaccurate __toString warning
2017-04-21 14:23:09 -04:00
Matt Brown
f7daa6e768
Fix #143 by allowing scalar types to be passed through
2017-04-21 14:06:47 -04:00
Matthew Brown
23401672c0
Fix issue parsing return types with brackets
2017-04-19 09:03:24 -04:00
Matthew Brown
1a8cdc5da9
Allow two or more instanceof interface checks side by side
2017-04-15 21:25:53 -04:00
Matthew Brown
007442fdd0
Fix possibly-private error
2017-04-15 21:10:49 -04:00
Matthew Brown
f67e92023b
Add support for intersection types
...
Fixes #140
2017-04-15 20:36:40 -04:00
Matthew Brown
2bdd062400
Ternary else should ignore if expression context
2017-04-15 13:46:18 -04:00
Matthew Brown
eebaf5795d
Fix regression dealing with union types from docblocks
2017-04-15 12:44:38 -04:00
Matthew Brown
bdfe2396ad
Don’t suggest useless type information
2017-04-15 00:45:43 -04:00
Matthew Brown
a8bee2f843
Suggest missing property types for traits as well
2017-04-15 00:04:03 -04:00
Matthew Brown
0c4824b2cc
Take property defaults into account when suggesting missing type
2017-04-14 23:46:55 -04:00
Matthew Brown
8d46c65815
Only make non-null if inside constructor
2017-04-14 23:26:58 -04:00
Matthew Brown
60be6f07a0
Delay checks for MissingPropertyType so we can give more useful messages
2017-04-14 23:09:34 -04:00
Matthew Brown
ce6ca58291
Fix #114 - add optional Hack-like checks calls
2017-04-14 21:32:14 -04:00
Vladimir Komissarov
818e3be00c
Fix undefined global constant in closure
2017-04-14 17:03:09 +07:00
Matt Brown
7bcf7f13b1
Fix #137 - add for init in main scope
2017-04-11 17:43:46 -04:00
SignpostMarv
46a0b03aac
enable the exposure of the source line number when DocblockParseException is thrown
2017-04-11 22:14:15 +01:00
Matt Brown
ed356bfbd0
Don’t mistake same-named functions for old-style constructors
...
Fixes #131
2017-04-10 11:03:19 -04:00
Matthew Brown
32efdfd0f7
Fix #129 - emit PossiblyNullFuntionCall when encountering such a thing
2017-04-08 11:38:06 -04:00
Matthew Brown
2d454d6e10
Fix #130 - check class exists before checking for __invoke
2017-04-08 11:15:17 -04:00
Matthew Brown
a985fd9324
Add PossiblyInvalidArgument for closure param type checks
2017-04-08 09:47:03 -04:00
Matthew Brown
64361ad2c3
Add more descriptive message to PossiblyInvalidArgument issue
2017-04-08 09:43:58 -04:00
Matthew Brown
c663062816
Add PossiblyUndefinedArgument issue to cope with #126
2017-04-08 09:28:02 -04:00
Matthew Brown
b3a454cf5b
Create new InvalidMethodCall issue for calling methods on non-objects
2017-04-08 09:20:32 -04:00
Matthew Brown
7d17a07cd2
Fix #125 - allow abstract classes to reference methods only defined in interfaces
2017-04-07 19:16:25 -04:00
Matt Brown
f011197090
Fix #124 - don’t check array_filter closures when >2 args passed
2017-04-07 18:30:15 -04:00
Matthew Brown
b20ddfec94
Add better way of checking two types can ever yield identical values
2017-04-07 09:02:09 -04:00
Matthew Brown
8910e4226c
Allow scalar type refinement
2017-04-07 00:19:55 -04:00
Matthew Brown
40427839ea
Get all variables possibly assigned in conditional
2017-04-06 22:56:37 -04:00
Matthew Brown
b74b8d7a58
Prevent reconciling to empty
2017-04-06 22:38:12 -04:00
Matthew Brown
20b0460a33
Fix #123 - ternary byref vars now adjusted
2017-04-06 21:53:29 -04:00
Matt Brown
8a20aca4cf
Only compare non-null types
2017-04-06 18:11:09 -04:00
Matt Brown
c09b0e459a
Make is_numeric a proper type refinement
2017-04-06 18:06:24 -04:00
Matt Brown
e7aec27eae
Prevent emitting issues when comparing mixed values
2017-04-06 17:40:15 -04:00
Matt Brown
da19b55db1
Add special TypeDoesNotContainNull issue as distinct from TypeDoesNotContainType
2017-04-06 15:36:22 -04:00
Matt Brown
cb3f6b14ba
Fix AssertionFinder to trap the right null type
2017-04-06 15:05:23 -04:00
Matt Brown
e02999f2ba
Prevent undefined property notices
2017-04-06 14:57:00 -04:00
Matt Brown
14bb967c7d
Warn when doing === comparisons on incompatible types
2017-04-06 14:53:45 -04:00
Matt Brown
d65221fbe4
Fix nested requires in different directories
2017-04-05 14:37:22 -04:00
Matt Brown
fe43c4e37f
Fix #122 - allow multiple types of filtering
2017-04-03 12:36:49 -04:00
Matthew Brown
075cc5f50d
Add by-reference clause removal
2017-04-02 17:37:56 -04:00
Matthew Brown
791be97b13
Undo changes to type simplification
2017-04-02 17:10:49 -04:00
Matthew Brown
dcedd65215
Add check for paradoxical statements
2017-04-02 15:26:10 -04:00
Matthew Brown
83edf8c4db
Complete the circle – fix remaining type algebra issue
2017-04-01 19:04:49 -04:00
Matt Brown
5b34163d8d
Add ability to insert suppressed issues on functions
2017-03-31 11:21:34 -04:00
Matt Brown
d06a199d25
Fix #121 - simplify all parameter types
2017-03-30 11:44:38 -04:00
Matthew Brown
a89018d9ae
Only warn about issues in files that we’re trying to scan
2017-03-24 18:34:46 -04:00
Matthew Brown
676c01ed2e
Fix nullref
2017-03-20 02:23:54 -04:00
Matthew Brown
066b1e011e
Prevent creating empty objectlike
2017-03-20 02:05:58 -04:00
Matthew Brown
caf72bda52
Shave off a little extra time by caching file_checker refs
2017-03-19 23:30:20 -04:00
Matthew Brown
fc4a72d905
Store reflected variadic function parameters
2017-03-19 18:31:19 -04:00
Matthew Brown
d69ff4e16e
Remove var_dump
2017-03-19 18:25:30 -04:00
Matthew Brown
f2f944d4c0
Prevent trying to open invalid file paths
2017-03-19 18:20:48 -04:00
Matthew Brown
7ed188fa52
Add support for conditional stubbed functions
2017-03-19 15:41:24 -04:00
Matthew Brown
cbd7a4520c
Add support for namespaced function definitions
2017-03-19 15:37:07 -04:00
Matthew Brown
2d88e237f4
Make method non-static
2017-03-19 13:23:19 -04:00
Matthew Brown
b1b7b0ae35
Only include vars asserted in where
2017-03-18 16:34:44 -04:00
Matthew Brown
9a3049b5bc
Make sure switch contexts know their parents
2017-03-18 15:28:59 -04:00
Matthew Brown
cb2ed860fb
Make sure to invalidate clauses in all parent contexts when asserting
2017-03-18 15:24:14 -04:00
Matthew Brown
18af05fbd9
Do not stop at magic setter when property referenced locally
2017-03-18 15:00:01 -04:00
Matthew Brown
3452c7853f
Add support for capturing clauses from elseifs
2017-03-18 14:04:26 -04:00
Matthew Brown
c33e66813a
Move type algebra functionality to separate checker
2017-03-18 13:37:00 -04:00
Matthew Brown
e687887ba3
Emit an InvalidReturnType when it should contain null, and introduct LessSpecificReturnType
2017-03-18 12:18:17 -04:00
Matt Brown
30e8e1880d
Add another easy calculation of clauses
2017-03-16 14:45:45 -04:00
Matt Brown
cecfe25df7
Update outer clauses in mic drop situation
2017-03-16 11:46:07 -04:00
Matt Brown
0c0a30d6ea
Make Psalm insensitive to case-sensitive filenames
2017-03-16 10:58:13 -04:00
Matt Brown
04363237c5
Fix #116 - be more lenient with static vars
2017-03-15 15:21:00 -04:00
Matt Brown
7fad81edac
Fix issue with unset var in loop
2017-03-15 11:38:23 -04:00
Matthew Brown
9b41bc9b37
Add slower (but more accurate) loop checks
2017-03-14 20:14:25 -04:00
Matthew Brown
6cfe540c98
Fix issue evaluating elseif empty assertions
2017-03-14 15:48:52 -04:00
Matthew Brown
9dd94d099f
Fix issue with possibly-redefined switch vars
2017-03-14 02:00:38 -04:00
Matthew Brown
50b629e88e
Update context types after switch statement without default case
2017-03-13 21:17:21 -04:00
Matt Brown
3d2be3410e
Infer loop types without @var comments
2017-03-13 18:06:56 -04:00
Matt Brown
ae0ca9553f
Remove training wheels
2017-03-13 12:02:28 -04:00
Matt Brown
fa63afc27d
Change property name
2017-03-13 11:23:26 -04:00
Matthew Brown
a7da88bad3
Improve solution to allow for more user errors
2017-03-11 12:32:27 -05:00
Matthew Brown
f6066aaded
Log references to parent classes
2017-03-10 19:36:17 -05:00
Matthew Brown
ce253ad5c3
Only get a single atomic type when checking mutations
2017-03-09 18:10:50 -05:00
Matthew Brown
048d7f0142
Fix #110 - failure to eliminate false from array|false on isset
2017-03-05 23:47:53 -05:00
Matt Brown
4619ef1390
Re-enable dead code detection
2017-03-03 15:54:08 -05:00
Matt Brown
f9f38f283e
Emit issue when property type is not defined
2017-03-02 12:19:18 -05:00