1
0
mirror of https://github.com/danog/psalm.git synced 2024-12-13 17:57:37 +01:00
Commit Graph

483 Commits

Author SHA1 Message Date
bugreportuser
57a4522ee7 Flesh out callable arg types 2019-03-07 23:24:50 -05:00
bugreportuser
d120e582ac Use config globals for invalid global scope 2019-03-07 23:21:56 -05:00
Matthew Brown
85f0fa6e7d Add support for literal templated defaults 2019-03-07 22:32:38 -05:00
Brown
5beb26659e Add special type for SQL select strings for plugins to consume 2019-03-07 14:56:18 -05:00
Brown
0b74c6a6e7 Fix interface name ref 2019-03-07 11:30:05 -05:00
Brown
b3a59d2638 Fix #1435 - prevent classes extending interfaces 2019-03-07 11:16:40 -05:00
Matthew Brown
e84eec7275 Fix #1434 - allow local suppression of return type checks 2019-03-07 09:21:03 -05:00
bugreportuser
b34dbe26e2 Allow setting superglobal types 2019-03-06 15:59:41 -05:00
bugreportuser
056e5a5b1e Allow setting globals in config 2019-03-06 15:59:41 -05:00
Brown
9442805763 Mutation checks should not care about return type 2019-03-06 11:12:36 -05:00
Brown
ae69695f89 Prevent tests in PHP 7.1 2019-03-05 18:27:25 -05:00
Brown
cece1def30 Fix #1427 - allow extended methods to be used as callables 2019-03-05 18:02:42 -05:00
Brown
bd372e93af Add config flags for findUnusedVariables and findUnusedCode 2019-03-05 15:45:09 -05:00
Matthew Brown
aeab6e292b Prevent bugs when checking for initialisation 2019-03-04 00:17:45 -05:00
Tyson Andre
6f7295ed13 Remove unused use statements 2019-03-03 22:22:36 -05:00
Matthew Brown
48b39a15b9 Don’t change value of $this by reference 2019-03-03 20:16:11 -05:00
Matthew Brown
17801362f5 Ignore all potentially mixed issues 2019-03-03 18:28:12 -05:00
Matthew Brown
74246c1cf7 Remove errant space 2019-03-03 18:25:14 -05:00
Matthew Brown
a31420be5b Fix checks for existing vars used in by-ref assignments 2019-03-03 18:21:12 -05:00
Matthew Brown
9e8c3b8c6e Only check interfaces for static matchup 2019-03-03 18:13:15 -05:00
Matthew Brown
5b38082454 Complain about non-static comparison
Fixes #1383
2019-03-03 17:41:15 -05:00
Matthew Brown
b7320e2778 Remove unnnecessary param 2019-03-03 16:45:35 -05:00
Matthew Brown
fb9e9bea32 Fix const reference in current context 2019-03-03 16:43:24 -05:00
Matthew Brown
472cdf6bea Fix #1379 - allow @param-out to change type 2019-03-03 15:11:09 -05:00
Matthew Brown
82e6876011 Fix #1397 - fix get_class behaviour for new instances 2019-03-02 18:02:11 -05:00
Matthew Brown
ef0abf1c30 Fix #1411 - allow covariance on extended templates 2019-03-02 16:31:34 -05:00
Matthew Brown
4757c2fe8e Fix messaging 2019-03-02 15:19:59 -05:00
Matthew Brown
5e61f198e1 Fix #1419 - allow checks against empty arrays 2019-03-02 15:18:29 -05:00
Matthew Brown
efbcf7dc5b Fix #1417 - store root file path when scanning for manipulations 2019-03-02 15:07:26 -05:00
Matthew Brown
4ba15ec18d Flip abstract trait analysis implementation checks
Fix #1414
2019-03-02 14:17:26 -05:00
Matthew Brown
5c76ab35c8 Allow properties to be set regardless of visibility 2019-03-01 17:30:55 -05:00
Matthew Brown
619590aa71 Fix parsing of template of type with spaces
Fixes #1406
2019-03-01 09:20:59 -05:00
Matthew Brown
4cc93644e5 Added more descriptive type for callables
Ref #1408
2019-03-01 09:06:37 -05:00
Matthew Brown
317f790bde
New plugin hooks (#1405)
* Add a bunch of new hooks

* Add more integrations

* Add some broken tests

* Add more things

* Fix remaining interfaces

* Suppress proper issue

* UndefinedMethod should not stop analysis

* Add handlers for two custom method return types
2019-03-01 08:57:10 -05:00
Matthew Brown
d1cf9d61ba Fix #1398 - improve casting rules for resource 2019-03-01 00:50:22 -05:00
Matthew Brown
55e125f495 Check method args before returning 2019-02-28 23:59:17 -05:00
Matthew Brown
b8b752ed01 Fix #1402 - don’t halt after suppressing static UndefinedMethod 2019-02-28 23:46:11 -05:00
Brown
815bf845dc Improve handling of method/function return types 2019-02-27 17:06:44 -05:00
Brown
601f303de2 Fix position of invalid param 2019-02-27 16:00:44 -05:00
Brown
119687f934 Fix redundant condition message when negating a docblock type 2019-02-27 14:02:02 -05:00
Matthew Brown
6af222f36a Fix #1393 - support analysing non-empty-array calls 2019-02-27 09:08:27 -05:00
Matthew Brown
b310cc07b5 Array access on objects should always be treated as method call 2019-02-26 21:24:30 -05:00
Bruce Weirdan
24a71be425 Added Hook\AfterCodebasePopulatedInterface 2019-02-26 01:16:22 -05:00
Matthew Brown
8650f9eb1a Fix #1356 - improve assertion system to work better on function calls 2019-02-26 01:03:33 -05:00
bugreportuser
7f7125f334 Fix crash for empty string array access 2019-02-25 08:26:12 -05:00
Matthew Brown
4f770d356e Fix #1384 - evaluate array fetches even when we don’t know function 2019-02-24 09:58:11 -05:00
Matthew Brown
3ad1abece4 Add generation of json artifacts 2019-02-24 01:33:25 -05:00
Matthew Brown
cdae79b9fe Fix unnecessary params in Psalm codebase 2019-02-23 11:31:33 -05:00
bugreportuser
68a135f434 Allow @psalm-property and @psalm-method 2019-02-23 11:04:08 -05:00
Matthew Brown
6420a5605b Put nullable in docblock for PHP 7.0 2019-02-22 01:05:35 -05:00
Matthew Brown
3d4710c9d3 Add better checks for invalid array_map/array_filter args 2019-02-22 00:50:41 -05:00
Matthew Brown
ce4f2e6334 Fix #1364 - use proper types for extended getIterator calls 2019-02-21 23:01:34 -05:00
Matthew Brown
f87827e812 Fix #1288 - prevent template names from clashing with real-world classes 2019-02-21 21:54:00 -05:00
Matthew Brown
1c8a573b5f Change TGenericParam to TTemplateParam 2019-02-21 21:40:06 -05:00
Brown
154e1fa38b Fix #1375 - improve treatment of dynamically-declared namespaces 2019-02-21 18:19:12 -05:00
Brown
653555a8cc Remove unused var 2019-02-21 17:49:33 -05:00
Brown
41b133178a Improve handling of count comparisons 2019-02-21 17:17:10 -05:00
Brown
b7a0950aea Prevent passing casts to byref vars 2019-02-21 13:26:37 -05:00
Brown
1e2c29041f @param-out should not override @param byref type def
when checking for unuitialised vars
2019-02-20 18:53:42 -05:00
Brown
079ac44263 Prevent pass by ref when type type is given 2019-02-20 17:43:12 -05:00
bugreportuser
024488c1d6 Use helper methods 2019-02-20 10:55:36 -05:00
bugreportuser
c097c59f33 Remove wrong condition 2019-02-20 10:55:36 -05:00
bugreportuser
14ee221075 Fix errors 2019-02-20 10:55:36 -05:00
bugreportuser
cd23a19931 Allow concat for define first arg 2019-02-20 10:55:36 -05:00
bugreportuser
f603449745 Infer literal string for __namespace__ 2019-02-20 10:55:36 -05:00
Brown
348b8eef1f Fix #1366 - don’t complain about invalid array offset when possibly mixed 2019-02-19 11:42:24 -05:00
bugreportuser
61e086ac7b Ignore more redundant issues 2019-02-18 22:44:26 -05:00
Matthew Brown
f49be31aeb Fix #1332 - use the correct identifier for trait property resolution 2019-02-18 16:52:09 -05:00
Matthew Brown
41255b42c6 Fix #1325 - allow MissingThrowsDocblock to be suppressed 2019-02-18 16:41:06 -05:00
Matthew Brown
75104f4712 Fix #1359 - error on bad iterable args 2019-02-18 16:35:23 -05:00
Matthew Brown
6b419452af Fix #1337 - don’t crash when examining __call methods in initialisation checks 2019-02-18 16:04:27 -05:00
Matthew Brown
709a5c31da Allow bitwise or ops to change type
Ref #1340
2019-02-18 12:53:55 -05:00
Matthew Brown
12f1ffca11 Fix issue reconciling mixed vars inside loop 2019-02-18 11:39:05 -05:00
Matthew Brown
5777e008c0 Remove var_dump 2019-02-17 13:18:23 -05:00
Bruce Weirdan
8408effe57 Dropped unused uses 2019-02-17 13:17:45 -05:00
Matthew Brown
40a91eab6e Fix #1339 - no crash when using self/static/parent in closure 2019-02-17 13:14:59 -05:00
Matthew Brown
a428b34a1a Fix #1338 - ignore redundant issues when collecting initialisations 2019-02-16 20:27:42 -05:00
Matthew Brown
0739d017ac Use information from .phpstorm.meta.php files in stubs 2019-02-16 11:16:52 -05:00
Matthew Brown
d76459e138 Move to a PHPStan-like return type provider class model 2019-02-15 18:00:40 -05:00
Brown
dca8bf9d36 Fix #1329 - improve handling arrays with string offsets 2019-02-15 14:42:17 -05:00
Brown
d70e29508f Don’t fatal error when callable class does not exist 2019-02-15 12:02:44 -05:00
Brown
27c99aed2f Improve recovery from InvalidScalarArgument issue 2019-02-14 16:55:54 -05:00
Brown
50421b297a Don’t report undefined properties when collecting initialisations 2019-02-13 14:04:10 -05:00
Brown
3deea3980d Add checks for unitialized properties
Fixes #1328
2019-02-13 13:32:19 -05:00
Matthew Brown
c6b3fc512f Don’t throw exception when ignoring trait absence 2019-02-10 16:32:30 -05:00
Matthew Brown
c58100e3af Fix #1313 - don’t allow mixed function calls 2019-02-10 16:15:52 -05:00
Matthew Brown
62fb8035bf Fix #1309 - no PropertyNotSetInConstructor warnings for grandchild of class 2019-02-10 15:01:10 -05:00
Matthew Brown
c765d0e969 Fix #1307 - improve generator array type 2019-02-09 15:48:15 -05:00
Matthew Brown
83e22a10f8 Fix #1299 - vars defined in catches before throw are possibly-defined for finally 2019-02-09 15:39:30 -05:00
bugreportuser
6c7819b438 Allow @psalm-template for classes 2019-02-09 11:15:25 -05:00
Matthew Brown
e6f3948f7b Fix #1297 - prevent false positive TypeDoesNotContainType for class const array offset 2019-02-07 16:24:31 -05:00
Matthew Brown
ed4ed957c8 Use more specific templated argument 2019-02-07 15:21:34 -05:00
Matthew Brown
17541b415f Fix #1191 - allow Psalm to check against different versions of PHP 2019-02-07 12:25:57 -05:00
Matthew Brown
f8f5ddfb04 Add support for string range 2019-02-07 10:50:42 -05:00
Matthew Brown
c758678022 Fix remaining issues 2019-02-06 16:08:41 -05:00
Matthew Brown
263a4c8cf1 Use Amp for handling language server event loop 2019-02-06 16:08:41 -05:00
Matthew Brown
dfe45e7d26 Fix #1290 - improve handling of more specific template 2019-02-06 15:56:40 -05:00
Matthew Brown
d45326759f Fix #1287 - improve handling of templated intersection 2019-02-06 12:37:05 -05:00
Matthew Brown
c83afc1af2 Fix element type inference for DOMNodeList 2019-02-05 13:34:59 -05:00
Matthew Brown
6033345694 Fix #1281 - improve handling of mixed property array assignment 2019-02-05 00:36:57 -05:00
Brown
bbf013bfb8 Fix #1279 - speed up analysis of large arrays 2019-02-04 16:06:14 -05:00
Matthew Brown
ab22634d23 Fix #1274 - fix parent:: call to templated method 2019-02-04 00:52:31 -05:00
Matthew Brown
f06ed8bf84 Fix #1273 - don’t change type with unpacked var 2019-02-03 16:36:10 -05:00
Matthew Brown
e97d4f85ee Break large CallAnalyzer funtions apart 2019-02-03 16:21:37 -05:00
Matthew Brown
194bb31221 Fix #204 - allow missing param types to be added with Psalter 2019-02-02 14:16:49 -05:00
Matthew Brown
3a01afbe0a Refine inferred type when possible 2019-02-02 12:10:52 -05:00
Matthew Brown
db89b3cc3f Add initial support for fixing MissingParamType 2019-02-02 11:28:48 -05:00
Brown
8b65acf15b Make return type mismatch more clear 2019-02-01 10:55:28 -05:00
Matthew Brown
509709d6bc Fix #1267 - flesh out self static property types 2019-02-01 08:59:01 -05:00
Matthew Brown
79544eb289 Fix comment analysis for callable(): returntype 2019-02-01 07:50:48 -05:00
Tyson Andre
53756e7017 Remove redundant catching and rethrowing
I assume these used to have additional logging,
but they're no-ops.
2019-01-31 21:18:00 -05:00
Brown
3f289731bb Add ability to check descendants in ignored exceptions 2019-01-31 18:40:40 -05:00
Brown
c5a0a3df86 Fix yielding from iterable 2019-01-31 17:58:53 -05:00
Brown
fd88f00526 Fix a few small bugs 2019-01-31 17:48:48 -05:00
Brown
74ebb0b2d5 Don’t copy context unnecessarily when checking methods had no effect 2019-01-31 12:55:48 -05:00
Brown
2054e3753f Fix #1260 - improve handling of ArrayAccess assignment 2019-01-31 12:45:47 -05:00
Brown
c195e8fd21 Add more nuanced analysis of array access fetch 2019-01-30 15:40:37 -05:00
Brown
e060ec35de Fix #1258 - allow static method returns 2019-01-30 11:44:12 -05:00
Brown
661c7ee707 Fix #1256 - detect illegal closure use 2019-01-30 11:36:21 -05:00
Matthew Brown
bfb2a5c19e Fix #1257 - transform docblock types for magic methods to something more meaningful 2019-01-30 09:46:23 -05:00
Brown
9edbae2bdc Fix possible fatal when builtin function is called in array_filter 2019-01-28 17:54:50 -05:00
Brown
a801923502 Add support for SplQueue templating 2019-01-28 12:27:04 -05:00
Brown
f33415827e Add checks for rounded values 2019-01-28 11:57:49 -05:00
Matthew Brown
45058ea494 Fix possible crash when class-string class doesn’t exist 2019-01-28 01:12:41 -05:00
Matthew Brown
09ee6e3d13 Fix #1253 - prevent ints from coercing to literal floats 2019-01-27 23:21:54 -05:00
Matthew Brown
081ba4b204 Fix #1072 - add support for @use SomeTrait<T> 2019-01-27 23:12:40 -05:00
Matthew Brown
f67bab6d52 Restrict template-extends to actual extends 2019-01-27 21:00:27 -05:00
Matthew Brown
cd4d2027d0 Fix #1249 - allow iterator_to_array to respect getIterator method 2019-01-27 14:50:05 -05:00
Matthew Brown
be06393b9c Fix #1251 - allow instanceof comparisons to class strings 2019-01-27 14:10:33 -05:00
Matthew Brown
16c2a0f899 Fix #1246 - check @var annotations 2019-01-26 17:30:44 -05:00
Matthew Brown
22ee72808a Remove a bunch of hacks around generic offsets
Also fixes #1245
2019-01-26 16:58:49 -05:00
Brown
fcc9d1a979 Fix #1244 and fix #1243 - add template-extends checks 2019-01-25 15:31:17 -05:00
Brown
c9e1df510e Fix #1241 - allow negative string offsets on a string 2019-01-25 10:23:50 -05:00
Brown
c0f3197790 Fix #1238 - only emit MissingTemplateParam on direct interface implementers 2019-01-25 10:10:22 -05:00
Brown
cd0a7441d9 Add warnings for extended template param counts off 2019-01-24 17:55:03 -05:00
Brown
650c2b70f8 Fix #1236 - forbid bad class names in @extends 2019-01-24 16:43:22 -05:00
Brown
5352084188 Fix #1234 - apply @template-extends to inherited method signatures 2019-01-24 16:09:04 -05:00
Brown
0d52dc4e00 Fix #1232 - allow checking of extended templated function returns 2019-01-24 15:03:13 -05:00
Brown
67a14cefde Still complain about less specific types when signature type is present
Ref #1233
2019-01-24 10:58:59 -05:00
Brown
8a97e32e16 Add code to make handling interfaces with magic get/set
Ref #1228
2019-01-23 16:58:50 -05:00
Brown
60e9d4f245 Don’t give up after method_exists if static method exists 2019-01-23 15:50:12 -05:00
Brown
59baa53b3d Fix #1229 - only check for inheritance if class exists 2019-01-23 13:02:07 -05:00
Matthew Brown
8bc17e47be Fix #1227 - allow genric params in @psalm-assert 2019-01-22 23:42:54 -05:00
Brown
51c6621925 Add property lookup 2019-01-22 11:10:37 -05:00
Matthew Brown
1c5f6963a6 Skip callable tests for PHP 7 2019-01-21 18:01:15 -05:00
Matthew Brown
ea137fc20c Don’t complain about mixed after unpacking arg 2019-01-21 17:42:25 -05:00
Matthew Brown
e0067e53c5 Fix param chosen to be expected 2019-01-21 17:35:55 -05:00
Matthew Brown
1b0c426c52 Improve error message when type cannot be inferred, fixes #1110 2019-01-21 17:29:12 -05:00
Matthew Brown
99569e8ee3 Fix #1173 - transform const X = true to a true type 2019-01-21 16:55:50 -05:00
Matthew Brown
075446e7df Fix #1223 - MissingClosureParamType should use all known suppressed issues 2019-01-21 12:36:17 -05:00
Matthew Brown
5eb0bb8126 Make foreach var annotation use more cautious 2019-01-20 11:49:13 -05:00
Matthew Brown
03c5823051 Fix #1217 - allow protected property to be se by parent constructor 2019-01-20 11:20:39 -05:00
Matthew Brown
60088b1189 Fix #1215 - prevent bad code from crashing Psalm 2019-01-20 11:10:12 -05:00
Matthew Brown
681391f970 Fix #1220 - improve constant resolution 2019-01-20 09:52:26 -05:00
Matthew Brown
0ac7d106a3 Fix #1221 - no TypeDoesNotContainType in catch or finally 2019-01-20 09:27:46 -05:00
Matthew Brown
7fa05abb5a Remove unused vars 2019-01-20 01:52:58 -05:00
Matthew Brown
7dfcefd35d Support intersections on LHS of static calls 2019-01-19 23:25:23 -05:00
Matthew Brown
394d6509c6 Restrict class-string types to named objects (and intersections) 2019-01-19 22:46:06 -05:00
Matthew Brown
1c17d2e2f2 Extract template params from string/array callables cc @weirdan
The culmination of what you were getting at
2019-01-19 20:18:45 -05:00
Matthew Brown
590bea305d Fix #1218 - find issues with bad callables 2019-01-19 19:49:58 -05:00
Matthew Brown
ed68cb973d Fix #1109 - add bad usort protection 2019-01-19 18:11:49 -05:00
Matthew Brown
e28bf1a29b Fix null ref 2019-01-19 16:01:43 -05:00
Matthew Brown
44b51cdf8e Support @inherits and @extends keywords too 2019-01-19 15:12:13 -05:00
Matthew Brown
9c5ef33997 Allow @property to override parent class property type
Fixes #1214
2019-01-19 14:26:27 -05:00
Matthew Brown
ee2b06ac43 Add initial support for @param-out 2019-01-19 13:32:43 -05:00
Matthew Brown
bf13ff2e7d Detect bad interface types 2019-01-19 12:19:51 -05:00
Matthew Brown
9bd5f06c7d Allow inheritdoc to propogate param types 2019-01-19 12:19:07 -05:00
Matthew Brown
545c7e3cba Fix #1211 - allow docblocks to override foreach type earlier 2019-01-19 11:31:51 -05:00
Matthew Brown
94af3b6c51 Add automatic inheritance to properties
Fixes #1210
2019-01-19 10:09:26 -05:00
Matthew Brown
b313971935 Remove unused code 2019-01-18 11:57:52 -05:00
Matthew Brown
eddaaea01b Add support for static @method annotations 2019-01-18 11:37:52 -05:00
Matthew Brown
22ec7e537c Fix #1208 - respect inheritance when combining in boolean operation
Also fixes issue reconciling inside trait
2019-01-18 10:08:16 -05:00
Matthew Brown
4ec7903e8b Fix #390 - add support for object{foo:int, bar:string} annotation 2019-01-18 00:56:24 -05:00
Brown
d78c70d521 Add better messaging for MixedMethodCall 2019-01-17 14:04:40 -05:00
Brown
d068f1535d Fix issue with implemented class interface in subclass 2019-01-16 15:08:11 -05:00
Brown
1ac51fcea6 Allow binding params of extended templates
Fixes #1207
2019-01-16 12:07:30 -05:00
Brown
ee366015f7 Fix #1205 - allow traits to override inheritance checks 2019-01-16 10:59:06 -05:00
Matthew Brown
ee97c9dbaf Add support for T of Foo 2019-01-16 09:23:25 -05:00
Matthew Brown
c43734f3ab Don’t localise PropertyNotSetInConstructor issues 2019-01-15 21:34:18 -05:00
Brown
8d61cb4816 Fix #1200 - no fatal error in array_map when not checking functions 2019-01-15 17:53:23 -05:00
Brown
f5a81249e0 Fix #1202 - don’t allow undefined constants in enums 2019-01-15 11:31:13 -05:00
Matthew Brown
3ca5ec9281 Fix templated class conversion allowing child class 2019-01-13 14:40:21 -05:00
Matthew Brown
94aa51ba6d abstract trait method return type override should not be MethodSignatureMistmatch 2019-01-13 13:27:07 -05:00
Matthew Brown
bd9f2ec546 Add separate issue type for undefined interface method 2019-01-13 13:07:53 -05:00
Matthew Brown
0cca0d76cb Fix #813 - allow constant array to be refined with isset 2019-01-13 11:54:39 -05:00
Matthew Brown
7e0928d775 Fix #833 - warn on some invalid operands 2019-01-13 10:15:15 -05:00
Matthew Brown
e9b7c9e08b Fix #1129 - mock class method arguments should be evaluated 2019-01-13 09:49:34 -05:00
Matthew Brown
9ef1ce1535 Make @template-extends more robust 2019-01-12 18:18:23 -05:00
Matthew Brown
b43a6a31f1 Enable casing plugin and fix issues it found 2019-01-12 10:52:23 -05:00
Matthew Brown
a49b5af3e9 Refactor the method call analyzer a little 2019-01-12 09:13:54 -05:00
Brown
2195caaeae Check type var 2019-01-11 17:28:57 -05:00
Brown
1fddc19172 Add initial support for property types 2019-01-11 17:21:50 -05:00
Brown
cdbc63c99a Fix #1195 - check assignments in byref 2019-01-11 14:57:21 -05:00
Brown
bf327f4933 Prevent echo removing all types 2019-01-11 14:46:03 -05:00
Brown
eb7fc96ac1 Make param type checks use template_extends too 2019-01-11 11:18:51 -05:00
Brown
4ec8d1a8dd Fix #1198 - add support for template param extends checks 2019-01-11 10:55:44 -05:00
Matthew Brown
d891c068b4 Fix #1197 - add support for method templating without override 2019-01-11 09:35:32 -05:00
Matthew Brown
ff958ef643 Fix inheritance of method params 2019-01-11 08:54:10 -05:00
Brown
9947bc56f6 Fix Psalm errors and improve error output 2019-01-10 19:18:02 -05:00
Brown
0d28d5d82b Add check for @template-extends return types 2019-01-10 19:01:30 -05:00