danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-09 06:28:36 +01:00
Code Issues Projects Releases Wiki Activity
14,016 Commits 43 Branches 314 Tags 108 MiB
fb93aede12
Commit Graph

9593 Commits

Author SHA1 Message Date
Ivan Sidorov
8bb68e9b3f Find properties and methods annotated by mixin 2023-11-17 15:50:34 +00:00
Ivan Sidorov
0c4b8a3c49 Find annotated magic static methods on traits 2023-11-17 15:50:34 +00:00
Ivan Sidorov
ceba3d889d Find annotated magic static methods on parent class 2023-11-17 15:50:34 +00:00
Ivan Sidorov
75394c5037 Find declared methods on parent classes and traits 
Partial revert commit 2f039f9072
 2023-11-17 15:50:26 +00:00
Ivan Sidorov
d533bb8c2e Ignore annotated magic static methods with usage object gap 
Magic methods annotated by methods `__call` and `__callStatic`.
Magic static methods implemented in `__callStatic`
are not required implementation in `__call'.
 2023-11-17 15:14:56 +00:00
Ivan Sidorov
715f6f51e1 Ignore annotated magic properties with usage static gap 
In PHP is not exists methods for implementation magic static properties.
So, these magic static properties must not be presented.
 2023-11-17 15:14:56 +00:00
Ivan Sidorov
1cfc343c43 Ignore declared static properties with usage object gap 
Usage static properties in PHP is allow only by static gap.
 2023-11-17 15:14:56 +00:00
Ivan Sidorov
6f19440b02 Fix text-labels with type of property 
The labels for magic and declared properties must be equal.
 2023-11-17 15:14:56 +00:00
kkmuffme
88e3cda3b9 remove unused function, fix unusedVariable error after suppress 2023-11-13 20:24:58 +01:00
kkmuffme
dcd53cadab Suppressing NoValue should not treat subsequent code as unevaluated 
Fix https://github.com/vimeo/psalm/issues/10302
 2023-11-13 18:57:41 +01:00
robchett
3578b42e5c Add stubs for rdKafka 
Fixes #3406
 2023-11-08 09:51:12 +00:00
orklah
7acc50eef0
Merge pull request #10318 from danog/finalize 
Finalize all internal classes
 2023-11-03 20:57:06 +01:00
orklah
41acef50a1
Merge pull request #10319 from danog/rm_73 
Get rid of legacy 7.3 logic
 2023-11-03 20:56:39 +01:00
Ivan Sidorov
2f039f9072 Fix auto-completion with declared static method by DocBlock 2023-10-27 09:35:30 +00:00
Ivan Sidorov
d6faff2844 Fix auto comletion by partial property or method 2023-10-26 21:31:47 +00:00
Daniil Gentili
07b45b8116 Get rid of legacy 7.3 logic 2023-10-26 17:18:33 +02:00
Daniil Gentili
ec23f998ea Finalize all internal classes 2023-10-26 17:00:29 +02:00
Daniel Linjama
a375f441f2 fix @param-out with named arguments 2023-10-23 10:39:09 +03:00
Daniil Gentili
4c656f0a2b Revert 2023-10-21 20:50:08 +02:00
Daniil Gentili
596ee11d0d cs-fix 2023-10-21 20:48:06 +02:00
Daniil Gentili
3b66272aa0 More rector fixes 2023-10-21 20:45:09 +02:00
Daniil Gentili
cddf6a9a57 Rector fixes 2023-10-21 20:44:04 +02:00
orklah
915d801508
Merge pull request #10295 from nicelocal/fix_extension_loaded 
Fix method calls and property accesses after extension_loaded
 2023-10-21 13:27:32 +02:00
Daniil Gentili
8ca610ae60 Fix 2023-10-19 11:23:24 +02:00
Daniil Gentili
576e4d2bc4 Fix method calls and property accesses after extension_loaded 2023-10-19 11:16:20 +02:00
Aleksandr
a652db4170
Update IssueBuffer.php 2023-10-19 11:54:03 +04:00
orklah
5a862784ac
Merge pull request #10289 from ging-dev/add-fix 
Additional caching fixes
 2023-10-17 20:32:03 +02:00
robchett
e2d1e83b87 Fix memory explosion with calls to method_exists 2023-10-17 19:15:23 +01:00
ging-dev
18c037ec6e fix: bug fixes for test cases 2023-10-17 20:23:11 +07:00
ging-dev
0162e75ee8 fix: #10080 2023-10-17 02:43:22 +07:00
orklah
b432d812fb
Merge pull request #10274 from tuqqu/enum-case-value-type-from-class-constant 
Fix inferring enum case value from a class constant
 2023-10-16 20:25:11 +02:00
orklah
c9c3067044
Merge pull request #10279 from trusting-thompson/final-static-constant-type 
fix final class constant type
 2023-10-16 20:24:25 +02:00
orklah
7a7d6a25af
Merge pull request #10242 from cgocast/5.x 
Allow tainted numerics except for 'html' and 'has_quotes'
 2023-10-16 20:17:39 +02:00
Daniel Linjama
545e21b56b fix final class constant type 2023-10-13 14:18:58 +03:00
tuqqu
d0825b5fe2 Fix for inferring enum case value from a class constant, const test fix 2023-10-13 01:15:05 +02:00
tuqqu
6039e2be9b Fix for inferring enum case value from a class constant 2023-10-10 22:56:36 +02:00
orklah
ee4e8aa720
Merge pull request #10271 from klimick/type-check-nested-templates 
Type check nested templates
 2023-10-09 19:47:15 +02:00
orklah
3f7306d8df
Merge pull request #10254 from tuqqu/never-function-return-error-message 
Fix error message for implicitly returning functions with `never` return type
 2023-10-09 18:51:11 +02:00
klimick
a3df6505f0 Type check nested templates 2023-10-09 17:07:52 +03:00
cgocast
eea7c33309
Merge branch 'vimeo:5.x' into 5.x 2023-10-09 14:17:50 +02:00
tuqqu
a4cebb2cb8 Disallow never type for parameters 2023-10-08 20:47:37 +02:00
orklah
16be90c351
Merge pull request #10262 from robchett/negated_class_exist_convert_class-string_to_string 
Negated class_exist check on class-string converts to string instead of mixed
 2023-10-08 19:09:14 +02:00
orklah
67ac81e220
Merge pull request #10261 from robchett/allow_named_params_for_callables 
Allow parameter names in callable docblocks with templates
 2023-10-08 19:08:23 +02:00
robchett
d874aab881 Add alias support to psalm-check-type 2023-10-08 17:46:59 +01:00
robchett
c729fcd5c8 Negated class_exist check on class-string converts to string instead of mixed 2023-10-08 15:48:48 +01:00
robchett
fc7f846fbd Fix test case for named variadic callable docblock 2023-10-07 16:59:43 +01:00
robchett
a93b35853e Allow names in callable docblocks 2023-10-07 14:49:21 +01:00
tuqqu
2a910d1f17 Changed error message for never return error 2023-10-04 21:00:04 +02:00
tuqqu
413f1d6ce3 Fix error message for returning function with never return type 2023-10-04 20:51:31 +02:00
tuqqu
9f9e5f1e18 Emit MethodSignatureMismatch when descendant does not return by reference 2023-10-03 03:41:11 +02:00
cgocast
e0c24cbe7a Remove unused parents_nodes 2023-10-02 15:38:01 +02:00
cgocast
6eb40e7897 Fix code style 2023-10-02 15:22:57 +02:00
cgocast
2eca720e9d Merge branch '5.x' of https://github.com/cgocast/psalm into 5.x 2023-10-02 15:13:07 +02:00
cgocast
94a98ccddd Allow tainted numerics except for 'html' and 'has_quotes' 2023-10-02 15:08:26 +02:00
kkmuffme
1306b62fed code style 2023-10-01 21:35:45 +02:00
kkmuffme
480708637b Fix https://psalm.dev/r/77be914054 2023-10-01 21:32:34 +02:00
orklah
c67dce7d14
Merge pull request #10240 from ging-dev/cache 
fix: #10239
 2023-09-30 18:26:59 +02:00
ging-dev
f8c225c576 fix: #10239 2023-09-30 10:36:21 +07:00
orklah
2d3a625379
Merge pull request #10230 from ging-dev/lsp 
feat(LSP): Improve the autocomplete for nested array shape
 2023-09-28 23:42:02 +02:00
orklah
f57088646b
Merge pull request #10191 from boesing/bugfix/inherited-conditional-return-types 
Resolve inherited conditional return types
 2023-09-28 23:08:20 +02:00
orklah
bbcf50396d
Merge pull request #10189 from boesing/feature/inherited-assertions-v2 
Inherited assertions v2
 2023-09-28 23:07:15 +02:00
cgocast
d9400ba191 Handle possibly null $arg_type 2023-09-28 15:34:05 +02:00
cgocast
55843b5ac8 Handle positional argument 2023-09-28 15:23:35 +02:00
cgocast
2217f5e118 Loop over PDOStatement::fetch() arguments 2023-09-28 14:37:44 +02:00
orklah
83485f3fcf
Merge pull request #10234 from tuqqu/block-mode-declare-check 
Check for declare strict_types in block mode
 2023-09-28 09:13:13 +02:00
orklah
a8ef5a213d
Merge pull request #10202 from gmessier/issue-handlers-priority 
Issue handlers priority
 2023-09-28 09:09:33 +02:00
orklah
a843c30950
Merge pull request #10207 from boesing/bugfix/issue-10203 
Allow object assertions for `mixed` values
 2023-09-28 09:08:43 +02:00
orklah
d7236efd76
Merge pull request #10194 from MidnightDesign/issue-8582 
Allow class-string<T> where T is a union
 2023-09-28 09:04:57 +02:00
tuqqu
09fbe99f5b Check for declare strict types block mode 2023-09-26 20:59:06 +02:00
ging-dev
45807e27b8 feat(LSP): Improve the autocomplete for nested array shape 2023-09-26 01:52:23 +07:00
kkmuffme
c6648aff87 add FILTER_SANITIZE_URL filter to filter_var 2023-09-18 14:51:20 +02:00
Rudolph Gottesheim
3b775f4617 Allow class-string<T> where T is a union 2023-09-18 12:13:34 +02:00
robchett
03e8d19eec Only the binary op 'plus' works with two arrays 
Treat the result of any other operation as int|float
Fixes #2123
 2023-09-16 15:55:59 +01:00
Maximilian Bösing
3e100b15d9
bugfix: allow object assertions for mixed 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-09-15 20:19:54 +02:00
Guillaume Messier
bb364a23ad Fix Code Style 2023-09-13 16:44:53 -04:00
Guillaume Messier
ae427fd60e Add 'safe' methods to prevent overriding issueHandlers already defined in the configuration 2023-09-13 16:30:33 -04:00
Maximilian Bösing
7c8a5e8b09
bugfix: resolve recursive conditional return types containing templates 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-09-11 00:04:01 +02:00
Maximilian Bösing
e3920e6f4d
qa: remove unnecessary type juggling regarding inherited assertions 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-09-10 22:17:30 +02:00
Maximilian Bösing
ad463f38e9
bugfix: always gather class templates 
No clue why there are conditions on when templates are allowed to get picked up. I've removed this check which actually solves a problem in inherited assertions.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-09-10 22:17:30 +02:00
Tinjo Schöni
8fbe14a34b
Restore support for namespaced functions in referencedFunction config 2023-09-09 01:47:09 +02:00
Bruce Weirdan
cd8fc46554
Flag invalid declares 2023-09-02 23:41:50 +02:00
robchett
d0c4d170b0
Apply psalm-inheritors to interfaces too 2023-08-31 23:12:10 +02:00
robchett
e23971ca29
InheritorViolation was only being triggered on grand-childen classes 
Fixes #10167
 2023-08-31 23:12:07 +02:00
Bruce Weirdan
cc7ed9586e
Merge pull request #10156 from boesing/bugfix/prevent-infinite-loop-in-type-parser 2023-08-28 12:06:45 +02:00
Bruce Weirdan
3814fbb231
Merge pull request #10157 from boesing/bugfix/assertions-from-inherited-docblock 2023-08-28 12:04:47 +02:00
Maximilian Bösing
66c01813c1
refactor: move assertion detection based on inherited classes/interfaces into internal resolver 
This also enables `ExistingAtomicStaticCallAnalyzer` to detect those inherited assertions.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-08-28 11:09:23 +02:00
Bruce Weirdan
b3150d451a
Fix crash on property access to undefined property on a class with a missing dependncy 2023-08-28 01:58:02 +02:00
Maximilian Bösing
2a0ce2fecc
qa: add newlines to prevent exceeding 120 character line-length limit 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-08-28 01:15:49 +02:00
Maximilian Bösing
5e520e6bff
bugfix: properly inherit assertions from parents or implemented interfaces 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-08-28 01:12:28 +02:00
Maximilian Bösing
3fa5710400
qa: preserve already detected modifications 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-08-27 22:38:43 +02:00
Maximilian Bösing
d9ebab6b75
bugfix: prevent infinite-loop when resolving type-aliases 
The type-expander returns the same `intersection_type` in case something is not properly expandable. To avoid infinite-loop, we do explicitly verify that the expanded  alias is actually resolved

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-08-27 17:08:55 +02:00
Bruce Weirdan
ad0a132d7f
Update src/Psalm/Type.php 2023-08-25 19:30:16 -04:00
Maximilian Bösing
e985e8aadb
qa: add proper parameter type-hint to suit psalm analysis 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-08-26 00:49:02 +02:00
Maximilian Bösing
a6b646f0e3
qa: re-arrange code to avoid line-length limit of 120 chars 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-08-26 00:42:33 +02:00
Maximilian Bösing
a8bb8d38ea
qa: ensure that we do have at least one enum case extracted from the value-of<Enum> usage 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-08-26 00:41:06 +02:00
Maximilian Bösing
f93ac70a0a
qa: resolving psalm issues 
- remove unused variable
- add assertion to reduce possible types from `TEnumCase`
- use `TypeCombiner` to provide proper `Union` containing all literals

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-08-26 00:36:20 +02:00
Maximilian Bösing
cd3e294bfd
bugfix: remove atomic type comparator regarding TEnumCase 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-08-26 00:15:53 +02:00
Maximilian Bösing
6c1899df13
qa: apply coding standard 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-08-26 00:08:14 +02:00
Maximilian Bösing
5948559a31
feature: introducing proper handling of value-of in combination with backed enums 
This introduces both:
- a bugfix for a regression introduced by `31eaf83c4` which prevents backed enums are incorrectly identified as literals
- an additional feature so that `value-of` can be used with backed enums to assert any of the enum cases values

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-08-25 23:58:53 +02:00
Maximilian Bösing
31eaf83c49
bugfix: prevent enums from being detected as literals 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
 2023-08-25 23:54:31 +02:00
Bruce Weirdan
b1c25fa30a
Show success message and type stats with GHA formatter 2023-08-24 03:32:18 +02:00
Bruce Weirdan
c34d5132b5
Merge pull request #10115 from edsrzf/file-find-unused-baseline 2023-08-21 09:44:07 +02:00
Bruce Weirdan
0a9e647603
Do not change baseline when checking specific files 2023-08-21 09:25:37 +02:00
Bruce Weirdan
e6aa3fd23c
Extract the list of impure functions into its own dictionary 2023-08-21 06:14:56 +02:00
Bruce Weirdan
46ebe72e69
Correct exit code for invalid version format 
Addresses https://github.com/vimeo/psalm/pull/10129#discussion_r1299442729
 2023-08-21 00:14:26 +02:00
Bruce Weirdan
1474340cf2
Fix crash on array access to undefined class 2023-08-20 23:45:30 +02:00
Nitamet
005eed3d06 Throw and catch exception when specified PHP version is invalid 2023-08-19 00:14:39 +03:00
Nitamet
18b74b1814 Add 8.3 as supported version 2023-08-19 00:01:17 +03:00
Nitamet
2c7391a649 Add versions 5.4-7.3 as supported 2023-08-18 20:32:05 +03:00
Nitamet
5f40d26539 Fix PHP version checking 
Separate condition to check both cases if the specified string is a valid version and if it is supported
Remove unsupported versions up to 7.4 from regex
 2023-08-18 20:09:17 +03:00
Bruce Weirdan
bf8e150f8f
Merge pull request #10123 from weirdan/fix-crash-with-removed-assertion 2023-08-17 22:23:23 +02:00
Bruce Weirdan
73ce16de96
Fixes crash when assertion array is not a list 
Fixes vimeo/psalm#9984
 2023-08-17 22:10:32 +02:00
Bruce Weirdan
32445023d8
strip_tags()/$allowed_tags can accept arrays since 7.4 
Fixes vimeo/psalm#4317
 2023-08-17 21:36:47 +02:00
Evan Shaw
670bd6afce Filter baseline when checking individual files 
This prevents reporting unused baseline entries for other files that
aren't being checked.
 2023-08-15 21:16:18 +12:00
orklah
a6e2e31aae
Merge pull request #10093 from kkmuffme/inconsistent-argv-argc-in-context 
argv and argc were inconsistent in Context with VariableFetchAnalyzer
 2023-08-13 19:32:19 +02:00
Bruce Weirdan
4ca9dccb1d
Merge branch '5.x' into fix-10090 2023-08-13 06:03:16 +02:00
Bruce Weirdan
03f7c263fe
Correct type for $enum->name 2023-08-13 05:56:33 +02:00
Bruce Weirdan
dbd94ef85d
Cleanup test command and fixAll action 
None were working.
 2023-08-13 05:53:46 +02:00
Kuba Werłos
35183b9542 Add fix 2023-08-12 12:50:24 +02:00
kkmuffme
801cca2aa3 argv and argc were inconsistent in Context with VariableFetchAnalyzer 
Not sure why argv/argc are declared in context independently in the first place though
 2023-08-08 22:29:18 +02:00
Yannick Gottschalk
a4de6d9dc0 Fix #9997 
- make SimpleXmlElement and SimpleXmlIterator not a universal object crate
- added typed magic __get method to SimpleXmlElement
- adjusted tests to reflect new behaviour of SimpleXmlElement
- added tests
 2023-08-05 17:07:08 +02:00
kkmuffme
02385c2b49 code style + update tests 2023-08-04 23:56:47 +02:00
kkmuffme
0a58a68e9a make (s)printf error reporting more correct/literal 
Fix https://github.com/vimeo/psalm/issues/10021
Fix https://github.com/vimeo/psalm/issues/9987 again now for all cases (specifically https://github.com/vimeo/psalm/issues/9987#issuecomment-1624360506)

Use RedundantFunctionCall instead of InvalidArgument, where it's technically valid.
Report TooManyArguments when a format without placeholders is used
Report an error for splat with vprintf/vsprintf
 2023-08-04 23:38:48 +02:00
Bruce Weirdan
378b31b67b
Merge pull request #10068 from Nitamet/9949-isset-non-variables 2023-08-01 18:24:50 +02:00
Nitamet
f742af0221 Check if argument passed to isset() is valid 2023-08-01 14:39:10 +03:00
orklah
b9d355e082
Merge pull request #10071 from weirdan/fix-10070 
Allow method-like strings in `referencedFunction`
 2023-08-01 07:16:55 +02:00
Bruce Weirdan
ec842c0f3d
Allow method-like strings in referencedFunction 
Fixes vimeo/psalm#10070
 2023-08-01 06:37:01 +02:00
klimick
809b27c499 Fix variadic callable type check 2023-07-30 11:43:07 +03:00
orklah
80ddbd3898
Merge pull request #10039 from nicelocal/non_falsy_string_literal 
Fix combination of non-falsy-string and falsy literal
 2023-07-29 16:49:47 +02:00
Daniil Gentili
63347e71ae
Merge remote-tracking branch 'hub/5.x' into non_falsy_string_literal 2023-07-29 15:04:04 +02:00
Daniil Gentili
068bfbf8c1
Merge remote-tracking branch 'hub/master' into fix_intersection_scanning 2023-07-28 11:48:01 +02:00
orklah
73ebe227b2
Merge pull request #10055 from thbley/master 
Add type detection for PDOStatement::fetchAll(PDO::FETCH_CLASS, SomeClass::class)
 2023-07-27 19:03:09 +02:00
Thomas Bley
88ddb89763 #9974 fixed return type for FETCH_COLUMN 2023-07-27 16:11:32 +02:00
Thomas Bley
d600705b0c #9974 removed references_in_scope for setFetchMode 2023-07-27 15:53:05 +02:00
Thomas Bley
13d53ecbf1 #9974 cleanup 2023-07-27 01:59:06 +02:00
Thomas Bley
3d525cbd0e #9974 cleanup 2023-07-27 01:48:00 +02:00
Thomas Bley
8a6774ba82 #9974 fixed coding styles 2023-07-27 01:45:21 +02:00
Thomas Bley
66bc28d2a8 #9974 extended return type detection for PDOStatement::fetchAll/fetch with FETCH_COLUMN and FETCH_KEY_PAIR 2023-07-27 01:39:21 +02:00
Thomas Bley
fc74ae83e6 #9974 added return type detection for PDOStatement::fetchAll, extended return type detection for PDOStatement::fetch 2023-07-27 00:40:26 +02:00
Daniil Gentili
8364fef8b8
Fix intersection scanning 2023-07-26 10:04:20 +02:00
Bruce Weirdan
a34222aa76
Drop unused parameters for RPC methods 
Parameters are marshalled using their names and docblock tags, so it's safe to do.
 2023-07-26 05:17:38 +02:00
Bruce Weirdan
c2a05c2e90
Ensure correct method call order 2023-07-26 05:17:13 +02:00
Bruce Weirdan
85b2af83da
Cosmetic changes for VSCode 2023-07-26 05:16:36 +02:00
Bruce Weirdan
5f828c75d1
Make sure we get the token 
Name does matter, as is the presence of docblock
 2023-07-26 05:15:55 +02:00
Bruce Weirdan
902f90b19b
Modernize LSP progress reporting 
This will use `$/progress` when available and fall back to old
telemetry-based reporting otherwise
 2023-07-26 05:10:27 +02:00
Bruce Weirdan
be82c3a948
Merge pull request #10033 from weirdan/lsp-container-path-mapping 2023-07-25 01:00:47 +02:00
Bruce Weirdan
4a0a12d9e2
Fix unused var 2023-07-25 00:17:12 +02:00
Bruce Weirdan
e1a30a20a1
Map special RPC paths 
Now `$/cancelRequest` will be resolved to `$server->cancelRequest()`
and `$/textDocument/whatever` to `$server->textDocument->whatever()`
 2023-07-25 00:11:35 +02:00
Bruce Weirdan
bb102760ea Drop unused property 2023-07-24 21:59:34 +02:00
Bruce Weirdan
0a2a0feaf2 CS fix 2023-07-24 21:59:34 +02:00