getFilePath()); } parent::__construct($class, $source, $fq_class_name); if (!$this->class instanceof PhpParser\Node\Stmt\Class_) { throw new \InvalidArgumentException('Bad'); } if ($this->class->extends) { $this->parent_fq_class_name = self::getFQCLNFromNameObject( $this->class->extends, $this->source->getAliases() ); } } /** * @param PhpParser\Node\Stmt\Class_ $class * @param string $file_path * * @return string */ public static function getAnonymousClassName(PhpParser\Node\Stmt\Class_ $class, $file_path) { return preg_replace('/[^A-Za-z0-9]/', '_', $file_path . ':' . $class->getLine()); } /** * Determine whether or not a given class exists * * @param string $fq_class_name * @param FileChecker $file_checker * * @return bool */ public static function classExists(ProjectChecker $project_checker, $fq_class_name) { if (isset(self::$SPECIAL_TYPES[$fq_class_name])) { return false; } if ($fq_class_name === 'Generator') { return true; } return $project_checker->hasFullyQualifiedClassName($fq_class_name); } /** * Determine whether or not a class has the correct casing * * @param string $fq_class_name * * @return bool */ public static function hasCorrectCasing(ProjectChecker $project_checker, $fq_class_name) { if ($fq_class_name === 'Generator') { return true; } return isset($project_checker->existing_classes[$fq_class_name]); } /** * Determine whether or not a class extends a parent * * @param string $fq_class_name * @param string $possible_parent * * @return bool */ public static function classExtends(ProjectChecker $project_checker, $fq_class_name, $possible_parent) { $fq_class_name = strtolower($fq_class_name); if ($fq_class_name === 'generator') { return false; } $class_storage = $project_checker->classlike_storage_provider->get($fq_class_name); return in_array(strtolower($possible_parent), $class_storage->parent_classes, true); } /** * Check whether a class implements an interface * * @param string $fq_class_name * @param string $interface * * @return bool */ public static function classImplements(ProjectChecker $project_checker, $fq_class_name, $interface) { $interface_id = strtolower($interface); $fq_class_name = strtolower($fq_class_name); if ($interface_id === 'callable' && $fq_class_name === 'closure') { return true; } if ($interface_id === 'traversable' && $fq_class_name === 'generator') { return true; } if (isset(self::$SPECIAL_TYPES[$interface_id]) || isset(self::$SPECIAL_TYPES[$fq_class_name])) { return false; } $class_storage = $project_checker->classlike_storage_provider->get($fq_class_name); return isset($class_storage->class_implements[$interface_id]); } /** * @param Context|null $class_context * @param Context|null $global_context * * @return null|false */ public function analyze( Context $class_context = null, Context $global_context = null ) { if (!$this->class instanceof PhpParser\Node\Stmt\Class_) { throw new \LogicException('Something went badly wrong'); } $fq_class_name = $class_context && $class_context->self ? $class_context->self : $this->fq_class_name; if (preg_match( '/(^|\\\)(int|float|bool|string|void|null|false|true|resource|object|numeric|mixed)$/i', $fq_class_name ) ) { $class_name_parts = explode('\\', $fq_class_name); $class_name = array_pop($class_name_parts); if (IssueBuffer::accepts( new ReservedWord( $class_name . ' is a reserved word', new CodeLocation( $this, $this->class, null, true ) ), $this->source->getSuppressedIssues() )) { // fall through } return null; } $storage = $this->storage; $project_checker = $this->file_checker->project_checker; $classlike_storage_provider = $project_checker->classlike_storage_provider; if ($this->class->extends) { if (!$this->parent_fq_class_name) { throw new \UnexpectedValueException('Parent class should be filled in for ' . $fq_class_name); } $parent_reference_location = new CodeLocation($this, $this->class->extends); if (self::checkFullyQualifiedClassLikeName( $this, $this->parent_fq_class_name, $parent_reference_location, $this->getSuppressedIssues(), false ) === false) { return false; } } foreach ($this->class->implements as $interface_name) { $fq_interface_name = self::getFQCLNFromNameObject( $interface_name, $this->source->getAliases() ); $interface_location = new CodeLocation($this, $interface_name); if (self::checkFullyQualifiedClassLikeName( $this, $fq_interface_name, $interface_location, $this->getSuppressedIssues(), false ) === false) { return false; } } $class_interfaces = $storage->class_implements; if (!$this->class->isAbstract()) { foreach ($class_interfaces as $interface_name) { try { $interface_storage = $classlike_storage_provider->get($interface_name); } catch (\InvalidArgumentException $e) { continue; } $storage->public_class_constants += $interface_storage->public_class_constants; $code_location = new CodeLocation( $this, $this->class, $class_context ? $class_context->include_location : null, true ); foreach ($interface_storage->methods as $method_name => $interface_method_storage) { if ($interface_method_storage->visibility === self::VISIBILITY_PUBLIC) { $implementer_declaring_method_id = MethodChecker::getDeclaringMethodId( $project_checker, $this->fq_class_name . '::' . $method_name ); $implementer_fq_class_name = null; if ($implementer_declaring_method_id) { list($implementer_fq_class_name) = explode('::', $implementer_declaring_method_id); } $implementer_classlike_storage = $implementer_fq_class_name ? $classlike_storage_provider->get($implementer_fq_class_name) : null; $implementer_method_storage = $implementer_declaring_method_id ? MethodChecker::getStorage($project_checker, $implementer_declaring_method_id) : null; if (!$implementer_method_storage) { if (IssueBuffer::accepts( new UnimplementedInterfaceMethod( 'Method ' . $method_name . ' is not defined on class ' . $storage->name, $code_location ), $this->source->getSuppressedIssues() )) { return false; } return null; } if ($implementer_method_storage->visibility !== self::VISIBILITY_PUBLIC) { if (IssueBuffer::accepts( new InaccessibleMethod( 'Interface-defined method ' . $implementer_method_storage->cased_name . ' must be public in ' . $storage->name, $code_location ), $this->source->getSuppressedIssues() )) { return false; } return null; } FunctionLikeChecker::compareMethods( $project_checker, $implementer_classlike_storage ?: $storage, $interface_storage, $implementer_method_storage, $interface_method_storage, $code_location, $implementer_method_storage->suppressed_issues ); } } } } if (!$class_context) { $class_context = new Context($this->fq_class_name); $class_context->collect_references = $this->getFileChecker()->project_checker->collect_references; $class_context->parent = $this->parent_fq_class_name; } if ($this->leftover_stmts) { (new StatementsChecker($this))->analyze($this->leftover_stmts, $class_context); } if (!$storage->abstract) { foreach ($storage->declaring_method_ids as $method_name => $declaring_method_id) { $method_storage = MethodChecker::getStorage($project_checker, $declaring_method_id); list($declaring_class_name, $method_name) = explode('::', $declaring_method_id); if ($method_storage->abstract) { if (IssueBuffer::accepts( new UnimplementedAbstractMethod( 'Method ' . $method_name . ' is not defined on class ' . $this->fq_class_name . ', defined abstract in ' . $declaring_class_name, new CodeLocation( $this, $this->class, $class_context->include_location, true ) ), $this->source->getSuppressedIssues() )) { return false; } } } } foreach ($storage->appearing_property_ids as $property_name => $appearing_property_id) { $property_class_name = self::getDeclaringClassForProperty($project_checker, $appearing_property_id); $property_class_storage = $classlike_storage_provider->get((string)$property_class_name); $property_class_name = self::getDeclaringClassForProperty($project_checker, $appearing_property_id); $property = $property_class_storage->properties[$property_name]; if ($property->type) { $property_type = clone $property->type; if (!$property_type->isMixed() && !$property->has_default && !$property->type->isNullable() ) { $property_type->initialized = false; } if ($storage->template_types) { $generic_types = []; $property_type->replaceTemplateTypesWithStandins($storage->template_types, $generic_types); } } else { $property_type = Type::getMixed(); } if ($property->type_location && !$property_type->isMixed()) { $fleshed_out_type = ExpressionChecker::fleshOutType( $project_checker, $property_type, $this->fq_class_name, null ); $fleshed_out_type->check($this, $property->type_location, $this->getSuppressedIssues(), [], false); } if ($property->is_static) { $property_id = $this->fq_class_name . '::$' . $property_name; $class_context->vars_in_scope[$property_id] = $property_type; } else { $class_context->vars_in_scope['$this->' . $property_name] = $property_type; } } $constructor_checker = null; foreach ($this->class->stmts as $stmt) { if ($stmt instanceof PhpParser\Node\Stmt\ClassMethod) { $method_checker = $this->analyzeClassMethod( $stmt, $this, $class_context, $global_context ); if ($stmt->name === '__construct') { $constructor_checker = $method_checker; } } elseif ($stmt instanceof PhpParser\Node\Stmt\TraitUse) { $previous_context_include_location = $class_context->include_location; foreach ($stmt->traits as $trait) { $class_context->include_location = new CodeLocation($this, $trait, null, true); $fq_trait_name = self::getFQCLNFromNameObject( $trait, $this->source->getAliases() ); if (!TraitChecker::traitExists($fq_trait_name, $this->getFileChecker())) { if (IssueBuffer::accepts( new UndefinedTrait( 'Trait ' . $fq_trait_name . ' does not exist', new CodeLocation($this, $trait) ), $this->source->getSuppressedIssues() )) { return false; } } else { if (!TraitChecker::hasCorrectCase($fq_trait_name, $this->getFileChecker())) { if (IssueBuffer::accepts( new UndefinedTrait( 'Trait ' . $fq_trait_name . ' has wrong casing', new CodeLocation($this, $trait) ), $this->source->getSuppressedIssues() )) { return false; } continue; } if (!isset(self::$trait_checkers[strtolower($fq_trait_name)])) { throw new \UnexpectedValueException( 'Expecting trait statements to exist for ' . $fq_trait_name ); } $trait_checker = self::$trait_checkers[strtolower($fq_trait_name)]; foreach ($trait_checker->class->stmts as $trait_stmt) { if ($trait_stmt instanceof PhpParser\Node\Stmt\ClassMethod) { $trait_method_checker = $this->analyzeClassMethod( $trait_stmt, $trait_checker, $class_context, $global_context ); if ($trait_stmt->name === '__construct') { $constructor_checker = $trait_method_checker; } } } } } $class_context->include_location = $previous_context_include_location; } } $config = Config::getInstance(); if ($config->reportIssueInFile('PropertyNotSetInConstructor', $this->getFilePath())) { $uninitialized_variables = []; $uninitialized_properties = []; foreach ($storage->appearing_property_ids as $property_name => $appearing_property_id) { $property_class_name = self::getDeclaringClassForProperty($project_checker, $appearing_property_id); $property_class_storage = $classlike_storage_provider->get((string)$property_class_name); $property_class_name = self::getDeclaringClassForProperty($project_checker, $appearing_property_id); $property = $property_class_storage->properties[$property_name]; $property_is_initialized = isset($property_class_storage->initialized_properties[$property_name]); if ($property->has_default || $property->is_static || !$property->type || $property_is_initialized) { continue; } if ($property->type->isMixed() || $property->type->isNullable()) { continue; } $constructor_class_storage = null; if (isset($storage->methods['__construct'])) { $constructor_class_storage = $storage; } elseif (isset($property_class_storage->methods['__construct']) && $property_class_storage !== $storage ) { $constructor_class_storage = $property_class_storage; } elseif (!empty($property_class_storage->overridden_method_ids['__construct'])) { list($construct_fqcln) = explode('::', $property_class_storage->overridden_method_ids['__construct'][0]); $constructor_class_storage = $classlike_storage_provider->get($construct_fqcln); } if ($constructor_class_storage && $constructor_class_storage->all_properties_set_in_constructor && $constructor_class_storage->methods['__construct']->visibility !== self::VISIBILITY_PRIVATE ) { continue; } $uninitialized_variables[] = '$this->' . $property_name; $uninitialized_properties[$property_name] = $property; } if ($uninitialized_properties) { if (!$storage->abstract && !$constructor_checker && isset($storage->declaring_method_ids['__construct']) && $this->class->extends ) { list($construct_fqcln) = explode('::', $storage->declaring_method_ids['__construct']); $constructor_class_storage = $classlike_storage_provider->get($construct_fqcln); // ignore oldstyle constructors and classes without any declared properties if (isset($constructor_class_storage->methods['__construct'])) { $constructor_storage = $constructor_class_storage->methods['__construct']; $fake_constructor_params = array_map( /** @return PhpParser\Node\Param */ function (\Psalm\FunctionLikeParameter $param) { $fake_param = (new PhpParser\Builder\Param($param->name)); if ($param->signature_type) { $fake_param->setTypehint((string)$param->signature_type); } return $fake_param->getNode(); }, $constructor_storage->params ); $fake_constructor_stmt_args = array_map( /** @return PhpParser\Node\Arg */ function (\Psalm\FunctionLikeParameter $param) { return new PhpParser\Node\Arg(new PhpParser\Node\Expr\Variable($param->name)); }, $constructor_storage->params ); $fake_constructor_stmts = [ new PhpParser\Node\Expr\StaticCall( new PhpParser\Node\Name(['parent']), '__construct', $fake_constructor_stmt_args, [ 'line' => $this->class->extends->getLine(), 'startFilePos' => $this->class->extends->getAttribute('startFilePos'), 'endFilePos' => $this->class->extends->getAttribute('endFilePos'), ] ), ]; $fake_stmt = new PhpParser\Node\Stmt\ClassMethod( '__construct', [ 'type' => PhpParser\Node\Stmt\Class_::MODIFIER_PUBLIC, 'params' => $fake_constructor_params, 'stmts' => $fake_constructor_stmts, ] ); $constructor_checker = $this->analyzeClassMethod( $fake_stmt, $this, $class_context, $global_context ); } } if ($constructor_checker) { $method_context = clone $class_context; $method_context->collect_initializations = true; $method_context->vars_in_scope['$this'] = Type::parseString($fq_class_name); $method_context->vars_possibly_in_scope['$this'] = true; $constructor_checker->analyze($method_context, $global_context, true); $all_properties_set_in_constructor = true; foreach ($uninitialized_properties as $property_name => $property) { if (!isset($method_context->vars_in_scope['$this->' . $property_name])) { throw new \UnexpectedValueException('$this->' . $property_name . ' should be in scope'); } $end_type = $method_context->vars_in_scope['$this->' . $property_name]; if (!$end_type->initialized) { $all_properties_set_in_constructor = false; } if (!$end_type->initialized && $property->location) { $property_id = $this->fq_class_name . '::$' . $property_name; if (!$config->reportIssueInFile( 'PropertyNotSetInConstructor', $property->location->file_path ) && $this->class->extends ) { $error_location = new CodeLocation($this, $this->class->extends); } else { $error_location = $property->location; } if (IssueBuffer::accepts( new PropertyNotSetInConstructor( 'Property ' . $property_id . ' is not defined in constructor of ' . $this->fq_class_name . ' or in any private methods called in the constructor', $error_location ), array_merge($this->source->getSuppressedIssues(), $storage->suppressed_issues) )) { continue; } } } $storage->all_properties_set_in_constructor = $all_properties_set_in_constructor; } elseif (!$storage->abstract) { $first_uninitialized_property = array_shift($uninitialized_properties); if ($first_uninitialized_property->location) { if (IssueBuffer::accepts( new MissingConstructor( $fq_class_name . ' has an uninitialized variable ' . $uninitialized_variables[0] . ', but no constructor', $first_uninitialized_property->location ), $this->source->getSuppressedIssues() )) { // fall through } } } } } foreach ($this->class->stmts as $stmt) { if ($stmt instanceof PhpParser\Node\Stmt\Property) { $this->checkForMissingPropertyType($project_checker, $stmt); } elseif ($stmt instanceof PhpParser\Node\Stmt\TraitUse) { foreach ($stmt->traits as $trait) { $fq_trait_name = self::getFQCLNFromNameObject( $trait, $this->source->getAliases() ); if (!isset(self::$trait_checkers[strtolower($fq_trait_name)])) { throw new \UnexpectedValueException( 'Expecting trait statements to exist for ' . $fq_trait_name ); } $trait_checker = self::$trait_checkers[strtolower($fq_trait_name)]; foreach ($trait_checker->class->stmts as $trait_stmt) { if ($trait_stmt instanceof PhpParser\Node\Stmt\Property) { $this->checkForMissingPropertyType($project_checker, $trait_stmt); } } } } } } /** * @param PhpParser\Node\Stmt\Property $stmt * * @return void */ private function checkForMissingPropertyType(ProjectChecker $project_checker, PhpParser\Node\Stmt\Property $stmt) { $comment = $stmt->getDocComment(); if (!$comment || !$comment->getText()) { $fq_class_name = $this->fq_class_name; $property_name = $stmt->props[0]->name; $declaring_property_class = ClassLikeChecker::getDeclaringClassForProperty( $project_checker, $fq_class_name . '::$' . $property_name ); if (!$declaring_property_class) { throw new \UnexpectedValueException( 'Cannot get declaring class for ' . $fq_class_name . '::$' . $property_name ); } $fq_class_name = $declaring_property_class; $message = 'Property ' . $fq_class_name . '::$' . $property_name . ' does not have a declared type'; $class_storage = $project_checker->classlike_storage_provider->get($fq_class_name); $property_storage = $class_storage->properties[$property_name]; if ($property_storage->suggested_type && !$property_storage->suggested_type->isNull()) { $message .= ' - consider ' . str_replace( ['', ''], '', (string)$property_storage->suggested_type ); } if (IssueBuffer::accepts( new MissingPropertyType( $message, new CodeLocation($this, $stmt) ), $this->source->getSuppressedIssues() )) { // fall through } } } /** * @param PhpParser\Node\Stmt\ClassMethod $stmt * @param StatementsSource $source * @param Context $class_context * @param Context|null $global_context * * @return MethodChecker|null */ private function analyzeClassMethod( PhpParser\Node\Stmt\ClassMethod $stmt, StatementsSource $source, Context $class_context, Context $global_context = null ) { $config = Config::getInstance(); $method_checker = new MethodChecker($stmt, $source); $actual_method_id = (string)$method_checker->getMethodId(); $project_checker = $source->getFileChecker()->project_checker; if ($class_context->self && $class_context->self !== $source->getFQCLN()) { $analyzed_method_id = (string)$method_checker->getMethodId($class_context->self); $declaring_method_id = MethodChecker::getDeclaringMethodId($project_checker, $analyzed_method_id); if ($actual_method_id !== $declaring_method_id) { return; } } $method_checker->analyze( clone $class_context, $global_context ? clone $global_context : null ); if ($stmt->name !== '__construct' && $config->reportIssueInFile('InvalidReturnType', $source->getFilePath())) { $return_type_location = null; $secondary_return_type_location = null; $actual_method_storage = MethodChecker::getStorage($project_checker, $actual_method_id); if (!$actual_method_storage->has_template_return_type) { if ($actual_method_id) { $return_type_location = MethodChecker::getMethodReturnTypeLocation( $project_checker, $actual_method_id, $secondary_return_type_location ); } $return_type = MethodChecker::getMethodReturnType($project_checker, $actual_method_id); $method_checker->verifyReturnType( $project_checker, $return_type ? clone $return_type : null, $class_context->self, $return_type_location ); } } return $method_checker; } }