1
0
mirror of https://github.com/danog/psalm.git synced 2024-11-26 12:24:49 +01:00
Go to file
Bruce Weirdan 052d4f6217 Plugin loading (#855)
* add ability to load plugins by class names

- Plugins need to implement `__invoke(PluginFacade $psalm):void` method
- Plugins are enabled by adding `<pluginClass
class="Qualified\Class\Name"/>`
- `PluginFacade` provides a single point of contact with Psalm, so that
plugins cannot become coupled to Psalm internals

* added `psalm-plugin` cli tool to manage plugins

Available commands:
 `psalm-plugin list` - lists available and enabled plugins
 `psalm-plugin enable 'Plugin\Class\Name'` - enables plugin (modifies `psalm.xml`)
 `psalm-plugin disable 'Plugin\Class\Name'` - disables plugin (modifies `psalm.xml`)

Plugin installation:
 `composer install plugin-vendor/plugin-package-name`

Plugin authoring:
 Plugins are identified by package `type` field, which should contain
 `psalm-plugin` string.
 `extra.pluginClass` should refer to the name of the class implementing
 `__invoke(PluginFacade $psalm):void` function

Todo:
 - better config file search
 - better output for `psalm-plugin`
 - better formatting for modified xml file
 - composer skeleton project for plugins
 - ability to refer to plugins by package name (cli only)
 - composer plugin to (optionally) enable plugin upon installation
 - documentation on plugin installation and authoring
 - interfaces for plugin dependencies
 - interface for plugin entry point
 - migration path for legacy plugins

* documented previously undocumented plugin methods

* split legacy plugin registration into a wrapper class

also added `PluginApi` namespace and `RegistrationInterface`

* reuse psalm's config search algorithm

* enable/disable plugins by composer package name

* allow specifying alternative config file name

* whitelist PluginApi namespace

three times, but well, it works now

* interface for plugin entry points

* psalm-plugin as a symfony console app

* fixed errors found by psalm

* suppressed false positive UnusedMethods

* cs fix

* better psalm-plugin output

* don't leave empty `plugins` node to avoid old schema violation

* removed junk file that shouldn't be there

* cs fix

* fixed phpunit failure (constant redefinition)

* work around missing docblock in on symfony console

* php 7.0 compatibility

* allow `pluginClass` child elements as plugin configuration

* decouple console commands from undelying implementation

- introduce PluginListFactory
- add `PluginList::enable(string $class)` and `PluginList::disable(string $class)`

* PluginList tests

* ComposerLock test

* droppped debugging statement

* added part of console command tests

* added tests for EnableCommand

* added DisableCommand tests

* ignore unused args

* ConfigFile test

* disable travis cache in attempt to fix builds

* nah, that didn't work

* update for upstream changes

* rebase fixes

* namespaced `extra` entry for entry point

* s/PluginFacade/PluginRegistrationSocket/g

* Added $config parameter to PluginEntryPointInterface::__invoke()

* cs fixes

* entry point interface php7.0 compatibility

* cleaned up old cruft

- dropped todos I'm not going to pursues
- locked entry point to be a class implementing entry point interface

* fixed legacy plugins docs

* Added RegistrationInterface::registerHooksFromClass()

It mimics the way old plugins were registered in Psalm\Config, so
handler classes extending Psalm\Plugin should be fully compatible with
it.

Since Psalm\Plugin-style plugin registration was moved to
RegistrationSocket, LegacyPlugin now only load file-based plugins, so it
was renamed to FileBasedPluginAdapter.

* Converted EchoChecker plugin to composer-based format

- Its subfolder is registered as a local composer package in the root
composer.json, so it's directly installable with
	```
	composer require psalm/echo-checker-plugin
	```
- Migration is trivial: drop the plugin into a separate folder, then add
simple composer.json and the entry point class.

* Updated docs

* Don't reject hook handlers that inherit handling methods

* strip void return type in stub file
2018-11-10 23:23:36 -05:00
assets/config_levels Add support for checking DeprecatedTrait and DeprecatedConstant 2018-08-10 13:25:25 -04:00
bin Multi-stage builds (#928) 2018-08-02 00:44:15 -04:00
docs Plugin loading (#855) 2018-11-10 23:23:36 -05:00
examples Plugin loading (#855) 2018-11-10 23:23:36 -05:00
src Plugin loading (#855) 2018-11-10 23:23:36 -05:00
tests Plugin loading (#855) 2018-11-10 23:23:36 -05:00
vendor-bin/box Bump Box 2018-10-08 10:18:54 -04:00
.editorconfig adding editorconfig that seems to match the php files (#163) 2017-06-26 00:22:05 -04:00
.gitignore Ignore .ds_store 2018-05-19 18:57:14 -04:00
.php_cs.dist Fix formatting in examples 2018-01-18 17:41:14 -05:00
.scrutinizer.yml Attempt to fix builds on scrutinizer-ci (#788) 2018-06-01 09:38:10 -04:00
.travis.yml Add secure github token 2018-08-07 13:54:02 -04:00
box.json.dist Bump Box 2018-10-08 10:18:54 -04:00
CHANGELOG.md Solidify changes to V2 2018-05-11 18:45:19 -04:00
CODE_OF_CONDUCT.md Add code of conduct 2017-12-31 16:53:56 -05:00
composer.json Plugin loading (#855) 2018-11-10 23:23:36 -05:00
config.xsd Plugin loading (#855) 2018-11-10 23:23:36 -05:00
CONTRIBUTING.md Add reference to how Psalm works overview 2018-01-14 15:35:52 -05:00
LICENSE Add license 2016-11-21 14:48:17 -05:00
NEWS.md Prepare v2 dev release 2018-04-19 17:29:07 -04:00
phpcs.xml Add server mode support with error reporting only 2018-10-17 15:54:31 -04:00
phpunit.xml.dist Plugin loading (#855) 2018-11-10 23:23:36 -05:00
psalm Move Psalm execution code into PHP file that Psalm can analyse 2017-12-29 17:02:56 -05:00
psalm-language-server Change permissions on the language server executable 2018-10-19 14:04:22 -04:00
psalm-plugin Plugin loading (#855) 2018-11-10 23:23:36 -05:00
psalm.xml.dist Plugin loading (#855) 2018-11-10 23:23:36 -05:00
PsalmLogo.png New and improved logo 2017-01-16 17:24:26 -05:00
psalter Break file manipulation out into Psalter 2018-01-07 17:25:23 -05:00
README.md Fix wording nits in documentation 2018-10-27 13:05:49 -04:00
scoper.inc.php Plugin loading (#855) 2018-11-10 23:23:36 -05:00

logo

Packagist Packagist Travis CI Coverage Status

Psalm is a static analysis tool for finding errors in PHP applications, built on top of PHP Parser.

It's able to find a large number of issues, but it can also be configured to only care about a small subset of those.

Try a live demo, or install it in your project by following the Quickstart Guide below.

Psalm documentation

Documentation is available on Psalms website, generated from the docs folder.

Quickstart Guide

Install via Composer:

composer require --dev vimeo/psalm

Add a config:

./vendor/bin/psalm --init

Then run Psalm:

./vendor/bin/psalm

The config created above will show you all issues in your code, but will emit INFO issues (as opposed to ERROR) for certain common trivial code problems. If you want a more lenient config, you can specify the level with

./vendor/bin/psalm --init [source_dir] [level]

You can also learn how to suppress certain issues.

How Psalm Works

A basic rundown of Psalms internals can be found in docs/how_psalm_works.md.

Acknowledgements

The engineering team @vimeo for encouragement and patience, especially @nbeliard, @erunion and @nickyr.