mirror of
https://github.com/danog/psalm.git
synced 2024-11-30 04:39:00 +01:00
Daniil Gentili
1986c8b4a8
* Immutable CodeLocation * Remove excess clones * Remove external clones * Remove leftover clones * Fix final clone issue * Immutable storages * Refactoring * Fixes * Fixes * Fix * Fix * Fixes * Simplify * Fixes * Fix * Fixes * Update * Fix * Cache global types * Fix * Update * Update * Fixes * Fixes * Refactor * Fixes * Fix * Fix * More caching * Fix * Fix * Update * Update * Fix * Fixes * Update * Refactor * Update * Fixes * Break one more test * Fix * FIx * Fix * Fix * Fix * Fix * Improve performance and readability * Equivalent logic * Fixes * Revert * Revert "Revert" This reverts commit f9175100c8452c80559234200663fd4c4f4dd889. * Fix * Fix reference bug * Make default TypeVisitor immutable * Bugfix * Remove clones * Partial refactoring * Refactoring * Fixes * Fix * Fixes * Fixes * cs-fix * Fix final bugs * Add test * Misc fixes * Update * Fixes * Experiment with removing different property * revert "Experiment with removing different property" This reverts commit ac1156e077fc4ea633530d51096d27b6e88bfdf9. * Uniform naming * Uniform naming * Hack hotfix * Clean up $_FILES ref #8621 * Undo hack, try fixing properly * Helper method * Remove redundant call * Partially fix bugs * Cleanup * Change defaults * Fix bug * Fix (?, hope this doesn't break anything else) * cs-fix * Review fixes * Bugfix * Bugfix * Improve logic * Add support for list{} and callable-list{} types, properly implement array_is_list assertions (fixes #8389) * Default to sealed arrays * Fix array_merge bug * Fixes * Fix * Sealed type checks * Properly infer properties-of and get_object_vars on final classes * Fix array_map zipping * Fix tests * Fixes * Fixes * Fix more stuff * Recursively resolve type aliases * Fix typo * Fixes * Fix array_is_list assertion on keyed array * Add BC docs * Fixes * fix * Update * Update * Update * Update * Seal arrays with count assertions * Fix #8528 * Fix * Update * Improve sealed array foreach logic * get_object_vars on template properties * Fix sealed array assertion reconciler logic * Improved reconciler * Add tests * Single source of truth for test types * Fix tests * Fixup tests * Fixup tests * Fixup tests * Update * Fix tests * Fix tests * Final fixes * Fixes * Use list syntax only when needed * Fix tests * Cs-fix * Update docs * Update docs * Update docs * Update docs * Update docs * Document missing types * Update docs * Improve class-string-map docs * Update * Update * I love working on psalm :) * Keep arrays unsealed by default * Fixup tests * Fix syntax mistake * cs-fix * Fix typo * Re-import missing types * Keep strict types only in return types * argc/argv fixes * argc/argv fixes * Fix test * Comment-out valinor code, pinging @romm pls merge https://github.com/CuyZ/Valinor/pull/246 so we can add valinor to the psalm docs :)
405 lines
12 KiB
PHP
405 lines
12 KiB
PHP
<?php
|
|
|
|
namespace Psalm\Tests;
|
|
|
|
use Psalm\Tests\Traits\InvalidCodeAnalysisTestTrait;
|
|
use Psalm\Tests\Traits\ValidCodeAnalysisTestTrait;
|
|
|
|
class IfThisIsTest extends TestCase
|
|
{
|
|
use ValidCodeAnalysisTestTrait;
|
|
use InvalidCodeAnalysisTestTrait;
|
|
|
|
/**
|
|
*
|
|
*/
|
|
public function providerValidCodeParse(): iterable
|
|
{
|
|
return [
|
|
'worksAfterConvert' => [
|
|
'code' => '<?php
|
|
interface I {
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function test();
|
|
}
|
|
|
|
class F implements I
|
|
{
|
|
/**
|
|
* @psalm-this-out I
|
|
* @return void
|
|
*/
|
|
public function convert() {}
|
|
|
|
/**
|
|
* @psalm-if-this-is I
|
|
* @return void
|
|
*/
|
|
public function test() {}
|
|
}
|
|
|
|
$f = new F();
|
|
$f->convert();
|
|
$f->test();
|
|
'
|
|
],
|
|
'withTemplate' => [
|
|
'code' => '<?php
|
|
class Frozen {}
|
|
class Unfrozen {}
|
|
|
|
/**
|
|
* @template T of Frozen|Unfrozen
|
|
*/
|
|
class Foo
|
|
{
|
|
/**
|
|
* @var T
|
|
*/
|
|
private $state;
|
|
|
|
/**
|
|
* @param T $state
|
|
*/
|
|
public function __construct($state)
|
|
{
|
|
$this->state = $state;
|
|
}
|
|
|
|
/**
|
|
* @param string $name
|
|
* @param mixed $val
|
|
* @psalm-if-this-is Foo<Unfrozen>
|
|
* @return void
|
|
*/
|
|
public function set($name, $val)
|
|
{
|
|
}
|
|
|
|
/**
|
|
* @return Foo<Frozen>
|
|
*/
|
|
public function freeze()
|
|
{
|
|
/** @var Foo<Frozen> */
|
|
$f = clone $this;
|
|
return $f;
|
|
}
|
|
}
|
|
|
|
$f = new Foo(new Unfrozen());
|
|
$f->set("asd", 10);
|
|
'
|
|
],
|
|
'subclass' => [
|
|
'code' => '<?php
|
|
class G
|
|
{
|
|
/**
|
|
* @psalm-if-this-is G
|
|
* @return void
|
|
*/
|
|
public function test() {}
|
|
}
|
|
|
|
class F extends G
|
|
{
|
|
}
|
|
|
|
$f = new F();
|
|
$f->test();
|
|
'
|
|
],
|
|
'ifThisIsWithSelfAlias' => [
|
|
'code' => '<?php
|
|
/**
|
|
* @template T of string
|
|
*/
|
|
final class App
|
|
{
|
|
/**
|
|
* @psalm-if-this-is self<"idle">
|
|
* @psalm-this-out self<"started">
|
|
*/
|
|
public function start(): void
|
|
{
|
|
throw new RuntimeException("???");
|
|
}
|
|
}
|
|
|
|
/** @var App<"idle"> */
|
|
$app = new App();
|
|
$app->start();
|
|
'
|
|
],
|
|
'ifThisIsAndThisOutAtTheSameTime' => [
|
|
'code' => '<?php
|
|
/**
|
|
* @template T of string
|
|
*/
|
|
final class App
|
|
{
|
|
/**
|
|
* @psalm-if-this-is App<"idle">
|
|
* @psalm-this-out App<"started">
|
|
*/
|
|
public function start(): void
|
|
{
|
|
throw new RuntimeException("???");
|
|
}
|
|
}
|
|
|
|
/** @var App<"idle"> */
|
|
$app = new App();
|
|
$app->start();
|
|
'
|
|
],
|
|
'ifThisIsChangeThisTypeInsideMethod' => [
|
|
'code' => '<?php
|
|
/**
|
|
* @template T
|
|
*/
|
|
final class Option
|
|
{
|
|
/**
|
|
* @return T|null
|
|
*/
|
|
public function unwrap()
|
|
{
|
|
throw new RuntimeException("???");
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @template T
|
|
*/
|
|
final class ArrayList
|
|
{
|
|
/** @var list<T> */
|
|
private $items;
|
|
|
|
/**
|
|
* @param list<T> $items
|
|
*/
|
|
public function __construct(array $items)
|
|
{
|
|
$this->items = $items;
|
|
}
|
|
|
|
/**
|
|
* @psalm-if-this-is ArrayList<Option<int>>
|
|
* @return ArrayList<int>
|
|
*/
|
|
public function compact(): ArrayList
|
|
{
|
|
$values = [];
|
|
|
|
foreach ($this->items as $item) {
|
|
$value = $item->unwrap();
|
|
|
|
if (null !== $value) {
|
|
$values[] = $value;
|
|
}
|
|
}
|
|
|
|
return new self($values);
|
|
}
|
|
}
|
|
|
|
/** @var ArrayList<Option<int>> $list */
|
|
$list = new ArrayList([]);
|
|
$numbers = $list->compact();
|
|
',
|
|
'assertions' => [
|
|
'$numbers' => 'ArrayList<int>'
|
|
],
|
|
],
|
|
'ifThisIsResolveTemplateParams' => [
|
|
'code' => '<?php
|
|
/**
|
|
* @template-covariant T
|
|
*/
|
|
final class Option
|
|
{
|
|
/** @return T|null */
|
|
public function unwrap() { throw new RuntimeException("???"); }
|
|
}
|
|
|
|
/**
|
|
* @template-covariant L
|
|
* @template-covariant R
|
|
*/
|
|
final class Either
|
|
{
|
|
/** @return R|null */
|
|
public function unwrap() { throw new RuntimeException("???"); }
|
|
}
|
|
|
|
/**
|
|
* @template T
|
|
*/
|
|
final class ArrayList
|
|
{
|
|
/** @var list<T> */
|
|
private $items;
|
|
|
|
/**
|
|
* @param list<T> $items
|
|
*/
|
|
public function __construct(array $items)
|
|
{
|
|
$this->items = $items;
|
|
}
|
|
|
|
/**
|
|
* @template A
|
|
* @template B
|
|
* @template TOption of Option<A>
|
|
* @template TEither of Either<mixed, B>
|
|
*
|
|
* @psalm-if-this-is ArrayList<TOption|TEither>
|
|
* @return ArrayList<A|B>
|
|
*/
|
|
public function compact(): ArrayList
|
|
{
|
|
$values = [];
|
|
|
|
foreach ($this->items as $item) {
|
|
$value = $item->unwrap();
|
|
|
|
if (null !== $value) {
|
|
$values[] = $value;
|
|
}
|
|
}
|
|
|
|
return new self($values);
|
|
}
|
|
}
|
|
|
|
/** @var ArrayList<Either<Exception, int>|Option<int>> $list */
|
|
$list = new ArrayList([]);
|
|
$numbers = $list->compact();
|
|
',
|
|
'assertions' => [
|
|
'$numbers' => 'ArrayList<int>'
|
|
],
|
|
],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @return array<string, strict-array{code: string, error_message: string}>
|
|
*/
|
|
public function providerInvalidCodeParse(): iterable
|
|
{
|
|
return [
|
|
'failsWithWrongTemplate1' => [
|
|
'code' => '<?php
|
|
|
|
/**
|
|
* @template T
|
|
*/
|
|
class a {
|
|
/**
|
|
* @var T
|
|
*/
|
|
private $data;
|
|
/**
|
|
* @param T $data
|
|
*/
|
|
public function __construct($data) {
|
|
$this->data = $data;
|
|
}
|
|
/**
|
|
* @psalm-if-this-is a<int>
|
|
*/
|
|
public function test(): void {
|
|
}
|
|
}
|
|
|
|
$i = new a("test");
|
|
$i->test();
|
|
',
|
|
'error_message' => 'IfThisIsMismatch'
|
|
],
|
|
'failsWithWrongTemplate2' => [
|
|
'code' => '<?php
|
|
class Frozen {}
|
|
class Unfrozen {}
|
|
|
|
/**
|
|
* @template T of Frozen|Unfrozen
|
|
*/
|
|
class Foo
|
|
{
|
|
/**
|
|
* @var T
|
|
*/
|
|
private $state;
|
|
|
|
/**
|
|
* @param T $state
|
|
*/
|
|
public function __construct($state)
|
|
{
|
|
$this->state = $state;
|
|
}
|
|
|
|
/**
|
|
* @param string $name
|
|
* @param mixed $val
|
|
* @psalm-if-this-is Foo<Unfrozen>
|
|
* @return void
|
|
*/
|
|
public function set($name, $val) {}
|
|
|
|
/**
|
|
* @return Foo<Frozen>
|
|
*/
|
|
public function freeze()
|
|
{
|
|
/** @var Foo<Frozen> */
|
|
$f = clone $this;
|
|
return $f;
|
|
}
|
|
}
|
|
|
|
$f = new Foo(new Unfrozen());
|
|
$f->set("asd", 10);
|
|
$g = $f->freeze();
|
|
$g->set("asd", 20); // Fails
|
|
',
|
|
'error_message' => 'IfThisIsMismatch'
|
|
],
|
|
'failWithInvalidTemplateConstraint' => [
|
|
'code' => '<?php
|
|
/** @template T */
|
|
final class Option { }
|
|
|
|
/**
|
|
* @template T
|
|
*/
|
|
final class ArrayList
|
|
{
|
|
/**
|
|
* @template A
|
|
* @psalm-if-this-is ArrayList<Option<A>>
|
|
* @return ArrayList<A>
|
|
*/
|
|
public function compact(): ArrayList
|
|
{
|
|
throw new RuntimeException("???");
|
|
}
|
|
}
|
|
|
|
/** @var ArrayList<int> $list */
|
|
$list = new ArrayList();
|
|
$numbers = $list->compact();',
|
|
'error_message' => 'IfThisIsMismatch'
|
|
],
|
|
];
|
|
}
|
|
}
|