mirror of
https://github.com/danog/psalm.git
synced 2024-11-27 04:45:20 +01:00
1cf5153700
* Run tests in random order Being able to run tests in any order is a pre-requisite for being able to run them in parallel. * Reset type coverage between tests, fix affected tests * Reset parser and lexer between test runs and on php version change Previously lexer was reset, but parser kept the reference to the old one, and reference to the parser was kept by StatementsProvider. This resulted in order-dependent tests - if the parser was first initialized with phpVersion set to 7.4 then arrow functions worked fine, but were failing when the parser was initially constructed with settings for 7.3 This can be demonstrated on current master by upgrading to nikic/php-parser:4.9 and running: ``` vendor/bin/phpunit --no-coverage --filter="inferredArgArrowFunction" tests/ClosureTest.php ``` Now all tests using PHP 7.4 features must set the PHP version accordingly. * Marked more tests using 7.4 syntax * Reset newline-between-annotation flag between tests * Resolve real paths before passing them to checkPaths When checkPaths is called from psalm.php the paths are resolved, so we just mimicking SUT behaviour here. * Restore newline-between-annotations in DocCommentTest * Tweak Appveyor caches * Tweak TravisCI caches * Tweak CircleCI caches * Run tests in parallel Use `vendor/bin/paratest` instead of `vendor/bin/phpunit` * Use default paratest runner on Windows WrapperRunner is not supported on Windows. * TRAVIS_TAG could be empty * Restore appveyor conditional caching
529 lines
16 KiB
PHP
529 lines
16 KiB
PHP
<?php
|
|
namespace Psalm\Tests\LanguageServer;
|
|
|
|
use LanguageServerProtocol\Position;
|
|
use Psalm\Context;
|
|
use Psalm\Internal\Analyzer\FileAnalyzer;
|
|
use Psalm\Internal\Analyzer\ProjectAnalyzer;
|
|
use Psalm\Internal\Provider\Providers;
|
|
use Psalm\Internal\RuntimeCaches;
|
|
use Psalm\Tests\Internal\Provider;
|
|
use Psalm\Tests\TestConfig;
|
|
|
|
class SymbolLookupTest extends \Psalm\Tests\TestCase
|
|
{
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function setUp() : void
|
|
{
|
|
parent::setUp();
|
|
|
|
$this->file_provider = new \Psalm\Tests\Internal\Provider\FakeFileProvider();
|
|
|
|
$config = new TestConfig();
|
|
|
|
$providers = new Providers(
|
|
$this->file_provider,
|
|
new \Psalm\Tests\Internal\Provider\ParserInstanceCacheProvider(),
|
|
null,
|
|
null,
|
|
new Provider\FakeFileReferenceCacheProvider(),
|
|
new \Psalm\Tests\Internal\Provider\ProjectCacheProvider()
|
|
);
|
|
|
|
$this->project_analyzer = new ProjectAnalyzer(
|
|
$config,
|
|
$providers
|
|
);
|
|
|
|
$this->project_analyzer->setPhpVersion('7.3');
|
|
$this->project_analyzer->getCodebase()->store_node_types = true;
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testSimpleSymbolLookup()
|
|
{
|
|
$this->addFile(
|
|
'somefile.php',
|
|
'<?php
|
|
namespace B;
|
|
|
|
class A {
|
|
/** @var int|null */
|
|
protected $a;
|
|
|
|
const BANANA = "🍌";
|
|
|
|
public function foo() : void {
|
|
$a = 1;
|
|
echo $a;
|
|
}
|
|
}
|
|
|
|
function bar() : int {
|
|
return 5;
|
|
}
|
|
|
|
function baz(int $a) : int {
|
|
return $a;
|
|
}
|
|
|
|
function qux(int $a, int $b) : int {
|
|
return $a + $b;
|
|
}'
|
|
);
|
|
|
|
new FileAnalyzer($this->project_analyzer, 'somefile.php', 'somefile.php');
|
|
|
|
$codebase = $this->project_analyzer->getCodebase();
|
|
|
|
$this->analyzeFile('somefile.php', new Context());
|
|
|
|
$this->assertSame('<?php public function foo() : void', $codebase->getSymbolInformation('somefile.php', 'B\A::foo()'));
|
|
$this->assertSame('<?php protected int|null $a', $codebase->getSymbolInformation('somefile.php', 'B\A::$a'));
|
|
$this->assertSame('<?php function B\bar() : int', $codebase->getSymbolInformation('somefile.php', 'B\bar()'));
|
|
$this->assertSame('<?php BANANA', $codebase->getSymbolInformation('somefile.php', 'B\A::BANANA'));
|
|
$this->assertSame("<?php function B\baz(\n int \$a\n) : int", $codebase->getSymbolInformation('somefile.php', 'B\baz()'));
|
|
$this->assertSame("<?php function B\qux(\n int \$a,\n int \$b\n) : int", $codebase->getSymbolInformation('somefile.php', 'B\qux()'));
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testSimpleSymbolLocation()
|
|
{
|
|
$this->addFile(
|
|
'somefile.php',
|
|
'<?php
|
|
namespace B;
|
|
|
|
class A {
|
|
/** @var int|null */
|
|
protected $a;
|
|
|
|
const BANANA = "nana";
|
|
|
|
public function foo() : void {
|
|
$a = 1;
|
|
echo $a;
|
|
}
|
|
}
|
|
|
|
function bar() : int {
|
|
return 5;
|
|
}'
|
|
);
|
|
|
|
new FileAnalyzer($this->project_analyzer, 'somefile.php', 'somefile.php');
|
|
|
|
$codebase = $this->project_analyzer->getCodebase();
|
|
|
|
$this->analyzeFile('somefile.php', new Context());
|
|
|
|
$method_symbol_location = $codebase->getSymbolLocation('somefile.php', 'B\A::foo()');
|
|
|
|
$this->assertNotNull($method_symbol_location);
|
|
$this->assertSame(10, $method_symbol_location->getLineNumber());
|
|
$this->assertSame(37, $method_symbol_location->getColumn());
|
|
|
|
$property_symbol_location = $codebase->getSymbolLocation('somefile.php', 'B\A::$a');
|
|
|
|
$this->assertNotNull($property_symbol_location);
|
|
$this->assertSame(6, $property_symbol_location->getLineNumber());
|
|
$this->assertSame(31, $property_symbol_location->getColumn());
|
|
|
|
$constant_symbol_location = $codebase->getSymbolLocation('somefile.php', 'B\A::BANANA');
|
|
|
|
$this->assertNotNull($constant_symbol_location);
|
|
$this->assertSame(8, $constant_symbol_location->getLineNumber());
|
|
$this->assertSame(27, $constant_symbol_location->getColumn());
|
|
|
|
$function_symbol_location = $codebase->getSymbolLocation('somefile.php', 'B\bar()');
|
|
|
|
$this->assertNotNull($function_symbol_location);
|
|
$this->assertSame(16, $function_symbol_location->getLineNumber());
|
|
$this->assertSame(26, $function_symbol_location->getColumn());
|
|
|
|
$function_symbol_location = $codebase->getSymbolLocation('somefile.php', '257-259');
|
|
|
|
$this->assertNotNull($function_symbol_location);
|
|
$this->assertSame(11, $function_symbol_location->getLineNumber());
|
|
$this->assertSame(25, $function_symbol_location->getColumn());
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testSymbolLookupAfterAlteration()
|
|
{
|
|
$codebase = $this->project_analyzer->getCodebase();
|
|
$config = $codebase->config;
|
|
$config->throw_exception = false;
|
|
|
|
$this->addFile(
|
|
'somefile.php',
|
|
'<?php
|
|
namespace B;
|
|
|
|
class A {
|
|
/** @var int|null */
|
|
protected $a;
|
|
|
|
public function foo() : voi {
|
|
$a = 1;
|
|
$b = $this->a;
|
|
$c = $b;
|
|
|
|
echo $a;
|
|
}
|
|
|
|
public function bar() : void {
|
|
$a = 2;
|
|
echo $a;
|
|
}
|
|
}'
|
|
);
|
|
|
|
$codebase->file_provider->openFile('somefile.php');
|
|
$codebase->scanFiles();
|
|
$this->analyzeFile('somefile.php', new Context());
|
|
|
|
$codebase->addTemporaryFileChanges(
|
|
'somefile.php',
|
|
'<?php
|
|
namespace B;
|
|
|
|
class A {
|
|
/** @var int|null */
|
|
protected $a;
|
|
|
|
public function foo() : void {
|
|
$a = 1;
|
|
$b = $this->a;
|
|
$c = $b;
|
|
|
|
echo $a;
|
|
}
|
|
|
|
public function bar() : void {
|
|
$a = 2;
|
|
echo $a;
|
|
}
|
|
}'
|
|
);
|
|
|
|
$codebase->reloadFiles($this->project_analyzer, ['somefile.php']);
|
|
|
|
$codebase->analyzer->analyzeFiles($this->project_analyzer, 1, false);
|
|
|
|
$symbol_at_position = $codebase->getReferenceAtPosition('somefile.php', new Position(10, 30));
|
|
|
|
$this->assertNotNull($symbol_at_position);
|
|
|
|
$this->assertSame('245-246:int|null', $symbol_at_position[0]);
|
|
|
|
$symbol_at_position = $codebase->getReferenceAtPosition('somefile.php', new Position(12, 30));
|
|
|
|
$this->assertNotNull($symbol_at_position);
|
|
|
|
$this->assertSame('213-214:int(1)', $symbol_at_position[0]);
|
|
|
|
$symbol_at_position = $codebase->getReferenceAtPosition('somefile.php', new Position(17, 30));
|
|
|
|
$this->assertNotNull($symbol_at_position);
|
|
|
|
$this->assertSame('425-426:int(2)', $symbol_at_position[0]);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testGetSymbolPositionMissingArg()
|
|
{
|
|
$codebase = $this->project_analyzer->getCodebase();
|
|
$config = $codebase->config;
|
|
$config->throw_exception = false;
|
|
|
|
$this->addFile(
|
|
'somefile.php',
|
|
'<?php
|
|
namespace B;
|
|
|
|
class A {
|
|
public function foo(int $i) : string {
|
|
return "hello";
|
|
}
|
|
|
|
public function bar() : void {
|
|
$this->foo();
|
|
}
|
|
}'
|
|
);
|
|
|
|
$codebase->file_provider->openFile('somefile.php');
|
|
$codebase->scanFiles();
|
|
$this->analyzeFile('somefile.php', new Context());
|
|
|
|
$symbol_at_position = $codebase->getReferenceAtPosition('somefile.php', new Position(9, 33));
|
|
|
|
$this->assertNotNull($symbol_at_position);
|
|
|
|
$this->assertSame('B\A::foo()', $symbol_at_position[0]);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testGetSymbolPositionNullableArg()
|
|
{
|
|
$codebase = $this->project_analyzer->getCodebase();
|
|
$config = $codebase->config;
|
|
$config->throw_exception = false;
|
|
|
|
$this->addFile(
|
|
'somefile.php',
|
|
'<?php
|
|
namespace B;
|
|
class AClass {
|
|
}
|
|
function B( ?AClass $class ) {
|
|
}'
|
|
);
|
|
|
|
$codebase->file_provider->openFile('somefile.php');
|
|
$codebase->scanFiles();
|
|
$this->analyzeFile('somefile.php', new Context());
|
|
|
|
$symbol_at_position = $codebase->getReferenceAtPosition('somefile.php', new Position(4, 33));
|
|
$this->assertNotNull($symbol_at_position);
|
|
|
|
$this->assertSame('B\AClass', $symbol_at_position[0]);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testGetSymbolPositionMethodWrongReturnType()
|
|
{
|
|
$codebase = $this->project_analyzer->getCodebase();
|
|
$config = $codebase->config;
|
|
$config->throw_exception = false;
|
|
|
|
$this->addFile(
|
|
'somefile.php',
|
|
'<?php
|
|
namespace B;
|
|
class AClass {
|
|
/**
|
|
* @return Some
|
|
*/
|
|
protected function get_command() : AClass {
|
|
}
|
|
}
|
|
'
|
|
);
|
|
|
|
$codebase->file_provider->openFile('somefile.php');
|
|
$codebase->scanFiles();
|
|
$this->analyzeFile('somefile.php', new Context());
|
|
|
|
$symbol_at_position = $codebase->getReferenceAtPosition('somefile.php', new Position(6, 60));
|
|
$this->assertNotNull($symbol_at_position);
|
|
|
|
$this->assertSame('B\AClass', $symbol_at_position[0]);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testGetSymbolPositionUseStatement()
|
|
{
|
|
$codebase = $this->project_analyzer->getCodebase();
|
|
$config = $codebase->config;
|
|
$config->throw_exception = false;
|
|
|
|
$this->addFile(
|
|
'somefile.php',
|
|
'<?php
|
|
namespace B;
|
|
use StreamWrapper;
|
|
'
|
|
);
|
|
|
|
$codebase->file_provider->openFile('somefile.php');
|
|
$codebase->scanFiles();
|
|
$this->analyzeFile('somefile.php', new Context());
|
|
|
|
$symbol_at_position = $codebase->getReferenceAtPosition('somefile.php', new Position(2, 25));
|
|
$this->assertNotNull($symbol_at_position);
|
|
|
|
$this->assertSame('StreamWrapper', $symbol_at_position[0]);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testGetSymbolPositionRange()
|
|
{
|
|
$codebase = $this->project_analyzer->getCodebase();
|
|
$config = $codebase->config;
|
|
$config->throw_exception = false;
|
|
|
|
$this->addFile(
|
|
'somefile.php',
|
|
'<?php
|
|
namespace B;
|
|
|
|
function foo() : string {
|
|
}
|
|
|
|
$active_symbol = foo();'
|
|
);
|
|
|
|
$codebase->file_provider->openFile('somefile.php');
|
|
$codebase->scanFiles();
|
|
$this->analyzeFile('somefile.php', new Context());
|
|
|
|
// This is focusing the $active_symbol variable, the LSP Range that is
|
|
// returned should also point to the same variable (that's where hover popovers will show)
|
|
$symbol_at_position = $codebase->getReferenceAtPosition('somefile.php', new Position(6, 26));
|
|
|
|
$this->assertNotNull($symbol_at_position);
|
|
$this->assertSame(16, $symbol_at_position[1]->start->character);
|
|
$this->assertSame(30, $symbol_at_position[1]->end->character);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testGetTypeInDocblock()
|
|
{
|
|
$codebase = $this->project_analyzer->getCodebase();
|
|
$config = $codebase->config;
|
|
$config->throw_exception = false;
|
|
|
|
$this->addFile(
|
|
'somefile.php',
|
|
'<?php
|
|
namespace B;
|
|
|
|
class A {
|
|
/** @var \Exception|null */
|
|
public $prop;
|
|
}'
|
|
);
|
|
|
|
$codebase->file_provider->openFile('somefile.php');
|
|
$codebase->scanFiles();
|
|
$this->analyzeFile('somefile.php', new Context());
|
|
|
|
$symbol_at_position = $codebase->getReferenceAtPosition('somefile.php', new Position(4, 35));
|
|
|
|
$this->assertNotNull($symbol_at_position);
|
|
|
|
$this->assertSame('Exception', $symbol_at_position[0]);
|
|
}
|
|
|
|
/**
|
|
* @return array<int, array{0: Position, 1: ?string, 2: ?int, 3: ?int}>
|
|
*/
|
|
public function providerGetSignatureHelp(): array
|
|
{
|
|
return [
|
|
[new Position(5, 34), null, null, null],
|
|
[new Position(5, 35), 'B\A::foo', 0, 2],
|
|
[new Position(5, 36), null, null, null],
|
|
[new Position(6, 34), null, null, null],
|
|
[new Position(6, 35), 'B\A::foo', 0, 2],
|
|
[new Position(6, 40), 'B\A::foo', 0, 2],
|
|
[new Position(6, 41), 'B\A::foo', 1, 2],
|
|
[new Position(6, 47), 'B\A::foo', 1, 2],
|
|
[new Position(6, 48), null, null, null],
|
|
[new Position(7, 40), 'B\A::foo', 0, 2],
|
|
[new Position(7, 41), 'B\A::foo', 1, 2],
|
|
[new Position(7, 42), 'B\A::foo', 1, 2],
|
|
[new Position(8, 40), 'B\A::foo', 0, 2],
|
|
[new Position(8, 46), 'B\A::bar', 0, 1],
|
|
[new Position(8, 47), 'B\A::foo', 0, 2],
|
|
[new Position(10, 40), 'B\A::staticfoo', 0, 1],
|
|
#[new Position(12, 28), 'B\foo', 0, 1],
|
|
[new Position(14, 30), 'B\A::__construct', 0, 0],
|
|
[new Position(16, 31), 'strlen', 0, 1],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider providerGetSignatureHelp
|
|
*/
|
|
public function testGetSignatureHelp(
|
|
Position $position,
|
|
?string $expected_symbol,
|
|
?int $expected_argument_number,
|
|
?int $expected_param_count
|
|
): void {
|
|
$codebase = $this->project_analyzer->getCodebase();
|
|
$config = $codebase->config;
|
|
$config->throw_exception = false;
|
|
|
|
$this->addFile(
|
|
'somefile.php',
|
|
'<?php
|
|
namespace B;
|
|
|
|
class A {
|
|
public function foo(string $a, array $b) {
|
|
$this->foo();
|
|
$this->foo("Foo", "Bar");
|
|
$this->foo("Foo", );
|
|
$this->foo($this->bar());
|
|
|
|
self::staticFoo();
|
|
|
|
foo();
|
|
|
|
new A();
|
|
|
|
strlen();
|
|
}
|
|
|
|
public function bar(string $a) {}
|
|
|
|
public static function staticFoo(string $a) {}
|
|
|
|
public function __construct() {}
|
|
}
|
|
|
|
function foo(string $a) {
|
|
}'
|
|
);
|
|
|
|
$codebase->file_provider->openFile('somefile.php');
|
|
$codebase->scanFiles();
|
|
$this->analyzeFile('somefile.php', new Context());
|
|
|
|
$reference_location = $codebase->getFunctionArgumentAtPosition('somefile.php', $position);
|
|
|
|
if ($expected_symbol !== null) {
|
|
$this->assertNotNull($reference_location);
|
|
list($symbol, $argument_number) = $reference_location;
|
|
$this->assertSame($expected_symbol, $symbol);
|
|
$this->assertSame($expected_argument_number, $argument_number);
|
|
|
|
$symbol_information = $codebase->getSignatureInformation($reference_location[0]);
|
|
|
|
if ($expected_param_count === null) {
|
|
$this->assertNull($symbol_information);
|
|
} else {
|
|
$this->assertNotNull($symbol_information);
|
|
$this->assertNotNull($symbol_information->parameters);
|
|
$this->assertCount($expected_param_count, $symbol_information->parameters);
|
|
}
|
|
} else {
|
|
$this->assertNull($reference_location);
|
|
}
|
|
}
|
|
}
|