1
0
mirror of https://github.com/danog/psalm.git synced 2024-11-26 20:34:47 +01:00
psalm/tests/MethodMutationTest.php
Matthew Brown e29dd140e3 Refactor scanning and analysis, introducing multithreading (#191)
* Add failing test

* Add visitor to soup up classlike references

* Move a whole bunch of code into the visitor

* Move some methods back, move onto analysis stage

* Use the getAliases method everywhere

* Fix refs

* Fix more refs

* Fix some tests

* Fix more tests

* Fix include tests

* Shift config class finding to project checker and fix bugs

* Fix a few more tests

* transition test to new syntax

* Remove var_dump

* Delete a bunch of code and fix mutation test

* Remove unnecessary visitation

* Transition to better mocked out file provider, breaking some cached statement loading

* Use different scheme for naming anonymous classes

* Fix anonymous class issues

* Refactor file/statement loading

* Add specific property types

* Fix mapped property assignment

* Improve how we deal with traits

* Fix trait checking

* Pass Psalm checks

* Add multi-process support

* Delay console output until the end

* Remove PHP 7 syntax

* Update file storage with classes

* Fix scanning individual files and add reflection return types

* Always turn XDebug off

* Add quicker method of getting method mutations

* Queue return types for crawling

* Interpret all strings as possible classes once we see a `get_class` call

* Check invalid return types again

* Fix template namespacing issues

* Default to class-insensitive file names for includes

* Don’t overwrite existing issues data

* Add var docblocks for scanning

* Add null check

* Fix loading of external classes in templates

* Only try to populate class when we haven’t yet seen it’s not a class

* Fix trait property accessibility

* Only ever improve docblock param type

* Make param replacement more robust

* Fix static const missing inferred type

* Fix a few more tests

* Register constant definitions

* Fix trait aliasing

* Skip constant type tests for now

* Fix linting issues

* Make sure caching is off for tests

* Remove unnecessary return

* Use emulative parser if on PHP 5.6

* Cache parser for faster first-time parse

* Fix constant resolution when scanning classes

* Remove test that’s beyond a practical scope

* Add back --diff support

* Add --help for --threads

* Remove unused vars
2017-07-25 16:11:02 -04:00

172 lines
4.4 KiB
PHP

<?php
namespace Psalm\Tests;
use Psalm\Checker\FileChecker;
use Psalm\Context;
class MethodMutationTest extends TestCase
{
/**
* @return void
*/
public function testControllerMutation()
{
$this->addFile(
'somefile.php',
'<?php
class User {
/** @var string */
public $name;
/**
* @param string $name
*/
protected function __construct($name) {
$this->name = $name;
}
/** @return User|null */
public static function loadUser(int $id) {
if ($id === 3) {
$user = new User("bob");
return $user;
}
return null;
}
}
class UserViewData {
/** @var string|null */
public $name;
}
class Response {
public function __construct (UserViewData $viewdata) {}
}
class UnauthorizedException extends Exception { }
class Controller {
/** @var UserViewData */
public $user_viewdata;
/** @var string|null */
public $title;
public function __construct() {
$this->user_viewdata = new UserViewData();
}
public function setUser() : void
{
$user_id = (int)$_GET["id"];
if (!$user_id) {
throw new UnauthorizedException("No user id supplied");
}
$user = User::loadUser($user_id);
if (!$user) {
throw new UnauthorizedException("User not found");
}
$this->user_viewdata->name = $user->name;
}
}
class FooController extends Controller {
public function barBar() : Response {
$this->setUser();
if (rand(0, 1)) {
$this->title = "hello";
}
return new Response($this->user_viewdata);
}
}'
);
$file_checker = new FileChecker('somefile.php', $this->project_checker);
$this->project_checker->scanFiles();
$method_context = new Context();
$this->project_checker->getMethodMutations('FooController::barBar', $method_context);
$this->assertSame('UserViewData', (string)$method_context->vars_in_scope['$this->user_viewdata']);
$this->assertSame('string', (string)$method_context->vars_in_scope['$this->user_viewdata->name']);
$this->assertSame(true, $method_context->vars_possibly_in_scope['$this->title']);
}
/**
* @return void
*/
public function testParentControllerSet()
{
$this->addFile(
'somefile.php',
'<?php
class Foo { }
class Controller {
/** @var Foo|null */
public $foo;
public function __construct() {
$this->foo = new Foo();
}
}
class FooController extends Controller {
public function __construct() {
parent::__construct();
}
}'
);
$file_checker = new FileChecker('somefile.php', $this->project_checker);
$this->project_checker->scanFiles();
$method_context = new Context();
$this->project_checker->getMethodMutations('FooController::__construct', $method_context);
$this->assertSame('Foo', (string)$method_context->vars_in_scope['$this->foo']);
}
/**
* @return void
*/
public function testTraitMethod()
{
$this->addFile(
'somefile.php',
'<?php
class Foo { }
trait T {
private function setFoo() : void {
$this->foo = new Foo();
}
}
class FooController {
use T;
/** @var Foo|null */
public $foo;
public function __construct() {
$this->setFoo();
}
}'
);
$file_checker = new FileChecker('somefile.php', $this->project_checker);
$this->project_checker->scanFiles();
$method_context = new Context();
$this->project_checker->getMethodMutations('FooController::__construct', $method_context);
$this->assertSame('Foo', (string)$method_context->vars_in_scope['$this->foo']);
}
}