1
0
mirror of https://github.com/danog/psalm.git synced 2024-12-15 02:47:02 +01:00
psalm/src/Psalm/IssueBuffer.php
Matthew Brown e29dd140e3 Refactor scanning and analysis, introducing multithreading (#191)
* Add failing test

* Add visitor to soup up classlike references

* Move a whole bunch of code into the visitor

* Move some methods back, move onto analysis stage

* Use the getAliases method everywhere

* Fix refs

* Fix more refs

* Fix some tests

* Fix more tests

* Fix include tests

* Shift config class finding to project checker and fix bugs

* Fix a few more tests

* transition test to new syntax

* Remove var_dump

* Delete a bunch of code and fix mutation test

* Remove unnecessary visitation

* Transition to better mocked out file provider, breaking some cached statement loading

* Use different scheme for naming anonymous classes

* Fix anonymous class issues

* Refactor file/statement loading

* Add specific property types

* Fix mapped property assignment

* Improve how we deal with traits

* Fix trait checking

* Pass Psalm checks

* Add multi-process support

* Delay console output until the end

* Remove PHP 7 syntax

* Update file storage with classes

* Fix scanning individual files and add reflection return types

* Always turn XDebug off

* Add quicker method of getting method mutations

* Queue return types for crawling

* Interpret all strings as possible classes once we see a `get_class` call

* Check invalid return types again

* Fix template namespacing issues

* Default to class-insensitive file names for includes

* Don’t overwrite existing issues data

* Add var docblocks for scanning

* Add null check

* Fix loading of external classes in templates

* Only try to populate class when we haven’t yet seen it’s not a class

* Fix trait property accessibility

* Only ever improve docblock param type

* Make param replacement more robust

* Fix static const missing inferred type

* Fix a few more tests

* Register constant definitions

* Fix trait aliasing

* Skip constant type tests for now

* Fix linting issues

* Make sure caching is off for tests

* Remove unnecessary return

* Use emulative parser if on PHP 5.6

* Cache parser for faster first-time parse

* Fix constant resolution when scanning classes

* Remove test that’s beyond a practical scope

* Add back --diff support

* Add --help for --threads

* Remove unused vars
2017-07-25 16:11:02 -04:00

339 lines
9.3 KiB
PHP

<?php
namespace Psalm;
use Psalm\Checker\ProjectChecker;
use Psalm\Issue\CodeIssue;
class IssueBuffer
{
/**
* @var array<int, array{severity: string, line_number: string, type: string, message: string, file_name: string,
* file_path: string, snippet: string, from: int, to: int, snippet_from: int, snippet_to: int, column: int}>
*/
protected static $issues_data = [];
/**
* @var array<int, array>
*/
protected static $console_issues = [];
/**
* @var int
*/
protected static $error_count = 0;
/**
* @var array<string, bool>
*/
protected static $emitted = [];
/** @var int */
protected static $recording_level = 0;
/** @var array<int, array<int, CodeIssue>> */
protected static $recorded_issues = [];
/**
* @var int
*/
protected static $start_time = 0;
/**
* @param CodeIssue $e
* @param array $suppressed_issues
*
* @return bool
*/
public static function accepts(CodeIssue $e, array $suppressed_issues = [])
{
$config = Config::getInstance();
$fqcn_parts = explode('\\', get_class($e));
$issue_type = array_pop($fqcn_parts);
if (in_array($issue_type, $suppressed_issues, true)) {
return false;
}
if (!$config->reportIssueInFile($issue_type, $e->getFilePath())) {
return false;
}
if (self::$recording_level > 0) {
self::$recorded_issues[self::$recording_level][] = $e;
return false;
}
return self::add($e);
}
/**
* @param CodeIssue $e
*
* @throws Exception\CodeException
*
* @return bool
*/
public static function add(CodeIssue $e)
{
$config = Config::getInstance();
$project_checker = ProjectChecker::getInstance();
$fqcn_parts = explode('\\', get_class($e));
$issue_type = array_pop($fqcn_parts);
$error_message = $issue_type . ' - ' . $e->getShortLocation() . ' - ' . $e->getMessage();
$reporting_level = $config->getReportingLevelForFile($issue_type, $e->getFilePath());
if ($reporting_level === Config::REPORT_SUPPRESS) {
return false;
}
if ($reporting_level === Config::REPORT_INFO) {
if ($project_checker->show_info && !self::alreadyEmitted($error_message)) {
self::$issues_data[] = $e->toArray(Config::REPORT_INFO);
}
return false;
}
if ($config->throw_exception) {
throw new Exception\CodeException($error_message);
}
if (!self::alreadyEmitted($error_message)) {
self::$issues_data[] = $e->toArray(Config::REPORT_ERROR);
}
if ($config->stop_on_first_error) {
exit(1);
}
return true;
}
/**
* @param array{severity: string, line_number: string, type: string, message: string, file_name: string,
* file_path: string, snippet: string, from: int, to: int, snippet_from: int, snippet_to: int,
* column: int} $issue_data
*
* @return string
*/
protected static function getEmacsOutput(array $issue_data)
{
return $issue_data['file_path'] . ':' . $issue_data['line_number'] . ':' . $issue_data['column'] . ':' .
($issue_data['severity'] === Config::REPORT_ERROR ? 'error' : 'warning') . ' - ' . $issue_data['message'];
}
/**
* @param array{severity: string, line_number: string, type: string, message: string, file_name: string,
* file_path: string, snippet: string, from: int, to: int, snippet_from: int, snippet_to: int,
* column: int} $issue_data
* @param bool $use_color
*
* @return string
*/
protected static function getConsoleOutput(array $issue_data, $use_color)
{
$issue_string = '';
if ($issue_data['severity'] === Config::REPORT_ERROR) {
$issue_string .= ($use_color ? "\e[0;31mERROR\e[0m" : 'ERROR');
} else {
$issue_string .= 'INFO';
}
$issue_string .= ': ' . $issue_data['type'] . ' - ' . $issue_data['file_name'] . ':' .
$issue_data['line_number'] . ':' . $issue_data['column'] . ' - ' . $issue_data['message'] . PHP_EOL;
$snippet = $issue_data['snippet'];
if (!$use_color) {
$issue_string .= $snippet;
} else {
$selection_start = $issue_data['from'] - $issue_data['snippet_from'];
$selection_length = $issue_data['to'] - $issue_data['from'];
$issue_string .= substr($snippet, 0, $selection_start) .
"\e[97;41m" . substr($snippet, $selection_start, $selection_length) .
"\e[0m" . substr($snippet, $selection_length + $selection_start) . PHP_EOL;
}
return $issue_string;
}
/**
* @return array<int, array{severity: string, line_number: string, type: string, message: string, file_name: string,
* file_path: string, snippet: string, from: int, to: int, snippet_from: int, snippet_to: int, column: int}>
*/
public static function getIssuesData()
{
return self::$issues_data;
}
/**
* @param array<int, array{severity: string, line_number: string, type: string, message: string,
* file_name: string, file_path: string, snippet: string, from: int, to: int, snippet_from: int,
* snippet_to: int, column: int}> $issues_data
*
* @return void
*/
public static function addIssues(array $issues_data)
{
self::$issues_data = array_merge($issues_data, self::$issues_data);
}
/**
* @param bool $is_full
* @param int|null $start_time
* @param array<string, bool> $visited_files
*
* @return void
*/
public static function finish($is_full, $start_time, array $visited_files)
{
Provider\FileReferenceProvider::updateReferenceCache($visited_files);
$has_error = false;
$project_checker = ProjectChecker::getInstance();
if (self::$issues_data) {
if ($project_checker->output_format === ProjectChecker::TYPE_JSON) {
echo json_encode(self::$issues_data) . PHP_EOL;
} elseif ($project_checker->output_format === ProjectChecker::TYPE_EMACS) {
foreach (self::$issues_data as $issue_data) {
if ($issue_data['severity'] === Config::REPORT_ERROR) {
$has_error = true;
}
echo self::getEmacsOutput($issue_data) . PHP_EOL;
}
} else {
foreach (self::$issues_data as $issue_data) {
if ($issue_data['severity'] === Config::REPORT_ERROR) {
$has_error = true;
}
echo self::getConsoleOutput($issue_data, $project_checker->use_color) . PHP_EOL . PHP_EOL;
}
}
}
if ($start_time) {
echo 'Checks took ' . ((float)microtime(true) - self::$start_time);
echo ' and used ' . number_format(memory_get_peak_usage() / (1024 * 1024), 3) . 'MB' . PHP_EOL;
}
if ($has_error) {
exit(1);
}
if ($is_full && $start_time) {
$project_checker->cache_provider->processSuccessfulRun($start_time);
}
}
/**
* @param string $message
*
* @return bool
*/
protected static function alreadyEmitted($message)
{
$sham = sha1($message);
if (isset(self::$emitted[$sham])) {
return true;
}
self::$emitted[$sham] = true;
return false;
}
/**
* @param int $time
*
* @return void
*/
public static function setStartTime($time)
{
self::$start_time = $time;
}
/**
* @return void
*/
public static function clearCache()
{
self::$issues_data = [];
self::$emitted = [];
self::$error_count = 0;
self::$recording_level = 0;
self::$recorded_issues = [];
self::$console_issues = [];
}
/**
* @return bool
*/
public static function isRecording()
{
return self::$recording_level > 0;
}
/**
* @return void
*/
public static function startRecording()
{
++self::$recording_level;
self::$recorded_issues[self::$recording_level] = [];
}
/**
* @return void
*/
public static function stopRecording()
{
if (self::$recording_level === 0) {
throw new \UnexpectedValueException('Cannot stop recording - already at base level');
}
--self::$recording_level;
}
/**
* @return array<int, CodeIssue>
*/
public static function clearRecordingLevel()
{
if (self::$recording_level === 0) {
throw new \UnexpectedValueException('Not currently recording');
}
$recorded_issues = self::$recorded_issues[self::$recording_level];
self::$recorded_issues[self::$recording_level] = [];
return $recorded_issues;
}
/**
* @return void
*/
public static function bubbleUp(CodeIssue $e)
{
if (self::$recording_level === 0) {
self::add($e);
return;
}
self::$recorded_issues[self::$recording_level][] = $e;
}
}