1
0
mirror of https://github.com/danog/psalm.git synced 2024-11-30 04:39:00 +01:00
psalm/tests/SwitchTypeTest.php
Matthew Brown f16642dad2
Better switch analysis (#343)
* Experiment with good switch analysis

* Improve switch accuracy at expense of some processor cycles

* Evaluate switch case expression in case context
2017-11-28 00:25:21 -05:00

342 lines
10 KiB
PHP

<?php
namespace Psalm\Tests;
class SwitchTypeTest extends TestCase
{
use Traits\FileCheckerInvalidCodeParseTestTrait;
use Traits\FileCheckerValidCodeParseTestTrait;
/**
* @return array
*/
public function providerFileCheckerValidCodeParse()
{
return [
'getClassArg' => [
'<?php
class A {
/**
* @return void
*/
public function fooFoo() {
}
}
class B {
/**
* @return void
*/
public function barBar() {
}
}
$a = rand(0, 10) ? new A() : new B();
switch (get_class($a)) {
case "A":
$a->fooFoo();
break;
case "B":
$a->barBar();
break;
}',
],
'getClassConstArg' => [
'<?php
class A {
/**
* @return void
*/
public function fooFoo() {
}
}
class B {
/**
* @return void
*/
public function barBar() {
}
}
$a = rand(0, 10) ? new A() : new B();
switch (get_class($a)) {
case A::class:
$a->fooFoo();
break;
case B::class:
$a->barBar();
break;
}',
],
'getClassExteriorArgClassConsts' => [
'<?php
/** @return void */
function foo(Exception $e) {
switch (get_class($e)) {
case InvalidArgumentException::class:
$e->getMessage();
break;
case LogicException::class:
$e->getMessage();
break;
}
}
',
],
'getClassExteriorArg' => [
'<?php
/** @return void */
function foo(Exception $e) {
switch (get_class($e)) {
case "InvalidArgumentException":
$e->getMessage();
break;
case "LogicException":
$e->getMessage();
break;
}
}
',
],
'getTypeArg' => [
'<?php
function testInt(int $var) : void {
}
function testString(string $var) : void {
}
$a = rand(0, 10) ? 1 : "two";
switch (gettype($a)) {
case "string":
testString($a);
break;
case "integer":
testInt($a);
break;
}',
],
'switchTruthy' => [
'<?php
class A {
/**
* @var ?string
*/
public $a = null;
/**
* @var ?string
*/
public $b = null;
}
function f(A $obj): string {
switch (true) {
case $obj->a !== null:
return $obj->a; // definitely not null
case !is_null($obj->b):
return $obj->b; // definitely not null
default:
throw new \InvalidArgumentException("$obj->a or $obj->b must be set");
}
}',
],
'switchMoTruthy' => [
'<?php
class A {
/**
* @var ?string
*/
public $a = null;
/**
* @var ?string
*/
public $b = null;
}
function f(A $obj): string {
switch (true) {
case $obj->a:
return $obj->a; // definitely not null
case $obj->b:
return $obj->b; // definitely not null
default:
throw new \InvalidArgumentException("$obj->a or $obj->b must be set");
}
}',
],
'switchWithBadBreak' => [
'<?php
class A {}
function foo(): A {
switch (rand(0,1)) {
case true:
return new A;
break;
default:
return new A;
}
}',
],
'switchCaseExpression' => [
'<?php
switch (true) {
case preg_match("/(d)ata/", "some data in subject string", $matches):
return $matches[1];
default:
throw new RuntimeException("none found");
}',
],
];
}
/**
* @return array
*/
public function providerFileCheckerInvalidCodeParse()
{
return [
'switchReturnTypeWithFallthroughAndBreak' => [
'<?php
class A {
/** @return bool */
public function fooFoo() {
switch (rand(0,10)) {
case 1:
break;
default:
return true;
}
}
}',
'error_message' => 'InvalidReturnType',
],
'switchReturnTypeWithFallthroughAndConditionalBreak' => [
'<?php
class A {
/** @return bool */
public function fooFoo() {
switch (rand(0,10)) {
case 1:
if (rand(0,10) === 5) {
break;
}
default:
return true;
}
}
}',
'error_message' => 'InvalidReturnType',
],
'switchReturnTypeWithNoDefault' => [
'<?php
class A {
/** @return bool */
public function fooFoo() {
switch (rand(0,10)) {
case 1:
case 2:
return true;
}
}
}',
'error_message' => 'InvalidReturnType',
],
'getClassArgWrongClass' => [
'<?php
class A {
/** @return void */
public function fooFoo() {
}
}
class B {
/** @return void */
public function barBar() {
}
}
$a = rand(0, 10) ? new A() : new B();
switch (get_class($a)) {
case "A":
$a->barBar();
break;
}',
'error_message' => 'UndefinedMethod',
],
'getClassMissingClass' => [
'<?php
class A {}
class B {}
$a = rand(0, 10) ? new A() : new B();
switch (get_class($a)) {
case "C":
break;
}',
'error_message' => 'UndefinedClass',
],
'getTypeNotAType' => [
'<?php
$a = rand(0, 10) ? 1 : "two";
switch (gettype($a)) {
case "int":
break;
}',
'error_message' => 'UnevaluatedCode',
],
'getTypeArgWrongArgs' => [
'<?php
function testInt(int $var) : void {
}
function testString(string $var) : void {
}
$a = rand(0, 10) ? 1 : "two";
switch (gettype($a)) {
case "string":
testInt($a);
case "integer":
testString($a);
}',
'error_message' => 'InvalidScalarArgument',
],
'switchBadMethodCallInCase' => [
'<?php
function f(string $p) : void { }
switch (true) {
case $q = (bool) rand(0,1):
f($q); // this type problem is not detected
break;
}',
'error_message' => 'InvalidScalarArgument',
],
];
}
}