1
0
mirror of https://github.com/danog/psalm.git synced 2024-12-11 00:39:38 +01:00
psalm/tests/Php71Test.php
AndrolGenhald d4590711d6
Fix object-like array keys when combining string and automatic keys (fixes #5427). (#5428)
* Fix object-like array keys (fixes #5427).

* Fix incorrect return types for tests.

* Fix false positive list with literal int key.
2021-03-19 21:44:44 -04:00

367 lines
12 KiB
PHP

<?php
namespace Psalm\Tests;
class Php71Test extends TestCase
{
use Traits\InvalidCodeAnalysisTestTrait;
use Traits\ValidCodeAnalysisTestTrait;
/**
* @return iterable<string,array{string,assertions?:array<string,string>,error_levels?:string[]}>
*/
public function providerValidCodeParse(): iterable
{
return [
'nullableReturnType' => [
'<?php
function a(): ?string
{
return rand(0, 10) ? "elePHPant" : null;
}
$a = a();',
'assertions' => [
'$a' => 'null|string',
],
],
'nullableReturnTypeInDocblock' => [
'<?php
/** @return ?string */
function a() {
return rand(0, 10) ? "elePHPant" : null;
}
$a = a();',
'assertions' => [
'$a' => 'null|string',
],
],
'nullableArgument' => [
'<?php
function test(?string $name): ?string
{
return $name;
}
test("elePHPant");
test(null);',
],
'protectedClassConst' => [
'<?php
class A
{
protected const IS_PROTECTED = 1;
}
class B extends A
{
function fooFoo(): int {
return A::IS_PROTECTED;
}
}',
],
'privateClassConst' => [
'<?php
class A
{
private const IS_PRIVATE = 1;
function fooFoo(): int {
return A::IS_PRIVATE;
}
}',
],
'publicClassConstFetch' => [
'<?php
class A
{
public const IS_PUBLIC = 1;
const IS_ALSO_PUBLIC = 2;
}
class B extends A
{
function fooFoo(): int {
echo A::IS_PUBLIC;
return A::IS_ALSO_PUBLIC;
}
}
echo A::IS_PUBLIC;
echo A::IS_ALSO_PUBLIC;',
],
'arrayDestructuringList' => [
'<?php
$data = [
[1, "Tom"],
[2, "Fred"],
];
// list() style
list($id1, $name1) = $data[0];
// [] style
[$id2, $name2] = $data[1];',
'assertions' => [
'$id1' => 'int',
'$name1' => 'string',
'$id2' => 'int',
'$name2' => 'string',
],
],
'arrayDestructuringInForeach' => [
'<?php
$data = [
[1, "Tom"],
[2, "Fred"],
];
// [] style
foreach ($data as [$id, $name]) {
echo $id;
echo $name;
}',
],
'arrayDestructuringWithKeys' => [
'<?php
$data = [
["id" => 1, "name" => "Tom"],
["id" => 2, "name" => "Fred"],
];
// list() style
list("id" => $id1, "name" => $name1) = $data[0];
// [] style
["id" => $id2, "name" => $name2] = $data[1];',
'assertions' => [
'$id1' => 'int',
'$name1' => 'string',
'$id2' => 'int',
'$name2' => 'string',
],
],
'arrayListDestructuringInForeachWithKeys' => [
'<?php
$data = [
["id" => 1, "name" => "Tom"],
["id" => 2, "name" => "Fred"],
];
// list() style
foreach ($data as list("id" => $id, "name" => $name)) {
$last_id = $id;
$last_name = $name;
}',
'assertions' => [
'$last_id' => 'int',
'$last_name' => 'string',
],
],
'arrayDestructuringInForeachWithKeys' => [
'<?php
$data = [
["id" => 1, "name" => "Tom"],
["id" => 2, "name" => "Fred"],
];
// [] style
foreach ($data as ["id" => $id, "name" => $name]) {
$last_id = $id;
$last_name = $name;
}',
'assertions' => [
'$last_id' => 'int',
'$last_name' => 'string',
],
],
'iterableArg' => [
'<?php
/**
* @param iterable<int, int> $iter
*/
function iterator(iterable $iter): void
{
foreach ($iter as $val) {
//
}
}
iterator([1, 2, 3, 4]);
/** @psalm-suppress MixedArgumentTypeCoercion */
iterator(new SplFixedArray(5));',
],
'traversableObject' => [
'<?php
class IteratorObj implements Iterator {
function rewind(): void {}
/** @return mixed */
function current() { return null; }
function key(): int { return 0; }
function next(): void {}
function valid(): bool { return false; }
}
function foo(\Traversable $t): void {
}
foo(new IteratorObj);',
],
'iterableIsArrayOrTraversable' => [
'<?php
function castToArray(iterable $arr): array {
if ($arr instanceof \Traversable) {
return iterator_to_array($arr, false);
}
return $arr;
}
function castToArray2(iterable $arr): array {
if (is_array($arr)) {
return $arr;
}
return iterator_to_array($arr, false);
}',
],
'substituteIterable' => [
'<?php
function foo(iterable $i): array {
if (!is_array($i)) {
$i = iterator_to_array($i, false);
}
return $i;
}',
],
'iterator_to_arrayMixedKey' => [
'<?php
/**
* @template TKey
* @template TValue
* @param Traversable<TKey, TValue> $traversable
* @return array<TValue>
*/
function toArray(Traversable $traversable): array
{
return iterator_to_array($traversable);
}',
],
'noReservedWordInDocblock' => [
'<?php
/**
* @param Closure():(resource|false) $op
* @return resource|false
*/
function create_resource($op) {
return $op();
}',
],
'arrayDestructuringOnArrayObject' => [
'<?php
$var = new ArrayObject([0 => "first", "dos" => "second"]);
[0 => $first, "dos" => $second] = $var;
echo $first;
echo $second;',
],
];
}
/**
* @return iterable<string,array{string,error_message:string,1?:string[],2?:bool,3?:string}>
*/
public function providerInvalidCodeParse(): iterable
{
return [
'invalidPrivateClassConstFetch' => [
'<?php
class A
{
private const IS_PRIVATE = 1;
}
echo A::IS_PRIVATE;',
'error_message' => 'InaccessibleClassConstant',
],
'invalidPrivateClassConstFetchFromSubclass' => [
'<?php
class A
{
private const IS_PRIVATE = 1;
}
class B extends A
{
function fooFoo(): int {
return A::IS_PRIVATE;
}
}',
'error_message' => 'InaccessibleClassConstant',
],
'invalidProtectedClassConstFetch' => [
'<?php
class A
{
protected const IS_PROTECTED = 1;
}
echo A::IS_PROTECTED;',
'error_message' => 'InaccessibleClassConstant',
],
'invalidIterableArg' => [
'<?php
/**
* @param iterable<string> $iter
*/
function iterator(iterable $iter): void
{
foreach ($iter as $val) {
//
}
}
class A {
}
iterator(new A());',
'error_message' => 'InvalidArgument',
],
'voidDoesntWorkIn70' => [
'<?php
function foo(): void {
}',
'error_message' => 'ReservedWord',
[],
false,
'7.0',
],
'objectDoesntWorkIn71' => [
'<?php
function foo(): object {
return new stdClass();
}',
'error_message' => 'ReservedWord',
[],
false,
'7.0',
],
'arrayDestructuringInvalidList' => [
'<?php
$a = 42;
list($id1, $name1) = $a;',
'error_message' => 'InvalidArrayOffset',
],
'arrayDestructuringInvalidArray' => [
'<?php
$a = 42;
[$id2, $name2] = $a;',
'error_message' => 'InvalidArrayOffset',
],
];
}
}