mirror of
https://github.com/danog/psalm.git
synced 2024-11-27 04:45:20 +01:00
dabfb16e34
* Run tests in random order Being able to run tests in any order is a pre-requisite for being able to run them in parallel. * Reset type coverage between tests, fix affected tests * Reset parser and lexer between test runs and on php version change Previously lexer was reset, but parser kept the reference to the old one, and reference to the parser was kept by StatementsProvider. This resulted in order-dependent tests - if the parser was first initialized with phpVersion set to 7.4 then arrow functions worked fine, but were failing when the parser was initially constructed with settings for 7.3 This can be demonstrated on current master by upgrading to nikic/php-parser:4.9 and running: ``` vendor/bin/phpunit --no-coverage --filter="inferredArgArrowFunction" tests/ClosureTest.php ``` Now all tests using PHP 7.4 features must set the PHP version accordingly. * Marked more tests using 7.4 syntax * Reset newline-between-annotation flag between tests * Resolve real paths before passing them to checkPaths When checkPaths is called from psalm.php the paths are resolved, so we just mimicking SUT behaviour here. * Restore newline-between-annotations in DocCommentTest * Tweak Appveyor caches * Tweak TravisCI caches * Tweak CircleCI caches * Run tests in parallel Use `vendor/bin/paratest` instead of `vendor/bin/phpunit` * Use default paratest runner on Windows WrapperRunner is not supported on Windows. * TRAVIS_TAG could be empty * Restore appveyor conditional caching
316 lines
10 KiB
PHP
316 lines
10 KiB
PHP
<?php
|
|
namespace Psalm\Tests;
|
|
|
|
use function preg_quote;
|
|
use Prophecy\Argument;
|
|
use Prophecy\Prophecy\ObjectProphecy;
|
|
use Psalm\Internal\PluginManager\Command\DisableCommand;
|
|
use Psalm\Internal\PluginManager\Command\EnableCommand;
|
|
use Psalm\Internal\PluginManager\Command\ShowCommand;
|
|
use Psalm\Internal\PluginManager\PluginList;
|
|
use Psalm\Internal\PluginManager\PluginListFactory;
|
|
use Psalm\Internal\RuntimeCaches;
|
|
use Symfony\Component\Console\Application;
|
|
use Symfony\Component\Console\Input\InputOption;
|
|
use Symfony\Component\Console\Tester\CommandTester;
|
|
|
|
/** @group PluginManager */
|
|
class PsalmPluginTest extends TestCase
|
|
{
|
|
/** @var ObjectProphecy */
|
|
private $plugin_list;
|
|
/** @var ObjectProphecy */
|
|
private $plugin_list_factory;
|
|
|
|
/** @var Application */
|
|
private $app;
|
|
|
|
public function setUp() : void
|
|
{
|
|
RuntimeCaches::clearAll();
|
|
$this->plugin_list = $this->prophesize(PluginList::class);
|
|
$this->plugin_list_factory = $this->prophesize(PluginListFactory::class);
|
|
$this->plugin_list_factory->__invoke(Argument::any(), Argument::any())->willReturn($this->plugin_list->reveal());
|
|
|
|
$this->app = new Application('psalm-plugin', '0.1');
|
|
$this->app->addCommands([
|
|
new ShowCommand($this->plugin_list_factory->reveal()),
|
|
new EnableCommand($this->plugin_list_factory->reveal()),
|
|
new DisableCommand($this->plugin_list_factory->reveal()),
|
|
]);
|
|
|
|
$this->app->getDefinition()->addOption(
|
|
new InputOption('config', 'c', InputOption::VALUE_REQUIRED, 'Path to Psalm config file')
|
|
);
|
|
|
|
$this->app->setDefaultCommand('show');
|
|
|
|
$this->plugin_list->getEnabled()->willReturn([]);
|
|
$this->plugin_list->getAvailable()->willReturn([]);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
* @test
|
|
*/
|
|
public function showsNoticesWhenTheresNoPlugins()
|
|
{
|
|
$show_command = new CommandTester($this->app->find('show'));
|
|
$show_command->execute([]);
|
|
|
|
$output = $show_command->getDisplay();
|
|
$this->assertStringContainsString('No plugins enabled', $output);
|
|
$this->assertStringContainsString('No plugins available', $output);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
* @test
|
|
*/
|
|
public function showsEnabledPlugins()
|
|
{
|
|
$this->plugin_list->getEnabled()->willReturn(['a\b\c' => 'vendor/package']);
|
|
|
|
$show_command = new CommandTester($this->app->find('show'));
|
|
$show_command->execute([]);
|
|
|
|
$output = $show_command->getDisplay();
|
|
$this->assertStringContainsString('vendor/package', $output);
|
|
$this->assertStringContainsString('a\b\c', $output);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
* @test
|
|
*/
|
|
public function showsAvailablePlugins()
|
|
{
|
|
$this->plugin_list->getAvailable()->willReturn(['a\b\c' => 'vendor/package']);
|
|
|
|
$show_command = new CommandTester($this->app->find('show'));
|
|
$show_command->execute([]);
|
|
|
|
$output = $show_command->getDisplay();
|
|
$this->assertStringContainsString('vendor/package', $output);
|
|
$this->assertStringContainsString('a\b\c', $output);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
* @test
|
|
*/
|
|
public function passesExplicitConfigToPluginListFactory()
|
|
{
|
|
$this->plugin_list_factory->__invoke(Argument::any(), '/a/b/c')->willReturn($this->plugin_list->reveal());
|
|
|
|
$show_command = new CommandTester($this->app->find('show'));
|
|
$show_command->execute([
|
|
'--config' => '/a/b/c',
|
|
]);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
* @test
|
|
*/
|
|
public function showsColumnHeaders()
|
|
{
|
|
$this->plugin_list->getAvailable()->willReturn(['a\b\c' => 'vendor/package']);
|
|
$this->plugin_list->getAvailable()->willReturn(['c\d\e' => 'another-vendor/package']);
|
|
|
|
$show_command = new CommandTester($this->app->find('show'));
|
|
$show_command->execute([]);
|
|
|
|
$output = $show_command->getDisplay();
|
|
|
|
$this->assertStringContainsString('Package', $output);
|
|
$this->assertStringContainsString('Class', $output);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
* @dataProvider commands
|
|
* @test
|
|
*/
|
|
public function listsCommands(string $command)
|
|
{
|
|
$list_command = new CommandTester($this->app->find('list'));
|
|
$list_command->execute([]);
|
|
$output = $list_command->getDisplay();
|
|
$this->assertStringContainsString($command, $output);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
* @dataProvider commands
|
|
* @test
|
|
*/
|
|
public function showsHelpForCommand(string $command)
|
|
{
|
|
$help_command = new CommandTester($this->app->find('help'));
|
|
$help_command->execute(['command_name' => $command]);
|
|
$output = $help_command->getDisplay();
|
|
$this->assertRegExp('/Usage:.*$\s+' . preg_quote($command, '/') . '\b/m', $output);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
* @test
|
|
*/
|
|
public function requiresPluginNameToEnable()
|
|
{
|
|
$enable_command = new CommandTester($this->app->find('enable'));
|
|
$this->expectExceptionMessage('missing: "pluginName"');
|
|
$enable_command->execute([]);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
* @test
|
|
*/
|
|
public function enableComplainsWhenPassedUnresolvablePlugin()
|
|
{
|
|
$this->plugin_list->resolvePluginClass(Argument::any())->willThrow(new \InvalidArgumentException);
|
|
|
|
$enable_command = new CommandTester($this->app->find('enable'));
|
|
$enable_command->execute(['pluginName' => 'vendor/package']);
|
|
|
|
$output = $enable_command->getDisplay();
|
|
|
|
$this->assertStringContainsString('ERROR', $output);
|
|
$this->assertStringContainsString('Unknown plugin', $output);
|
|
$this->assertNotSame(0, $enable_command->getStatusCode());
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
* @test
|
|
*/
|
|
public function enableComplainsWhenPassedAlreadyEnabledPlugin()
|
|
{
|
|
$this->plugin_list->resolvePluginClass('vendor/package')->will(
|
|
function (array $_args, ObjectProphecy $plugin_list): string {
|
|
$plugin_list->isEnabled('Vendor\Package\PluginClass')->willReturn(true);
|
|
|
|
return 'Vendor\Package\PluginClass';
|
|
}
|
|
);
|
|
|
|
$enable_command = new CommandTester($this->app->find('enable'));
|
|
$enable_command->execute(['pluginName' => 'vendor/package']);
|
|
|
|
$output = $enable_command->getDisplay();
|
|
$this->assertStringContainsString('Plugin already enabled', $output);
|
|
$this->assertNotSame(0, $enable_command->getStatusCode());
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
* @test
|
|
*/
|
|
public function enableReportsSuccessWhenItEnablesPlugin()
|
|
{
|
|
$this->plugin_list->resolvePluginClass('vendor/package')->will(
|
|
function (array $_args, ObjectProphecy $plugin_list): string {
|
|
$plugin_class = 'Vendor\Package\PluginClass';
|
|
$plugin_list->isEnabled($plugin_class)->willReturn(false);
|
|
$plugin_list->enable($plugin_class)->shouldBeCalled();
|
|
|
|
return $plugin_class;
|
|
}
|
|
);
|
|
|
|
$enable_command = new CommandTester($this->app->find('enable'));
|
|
$enable_command->execute(['pluginName' => 'vendor/package']);
|
|
|
|
$output = $enable_command->getDisplay();
|
|
$this->assertStringContainsString('Plugin enabled', $output);
|
|
$this->assertSame(0, $enable_command->getStatusCode());
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
* @test
|
|
*/
|
|
public function requiresPluginNameToDisable()
|
|
{
|
|
$disable_command = new CommandTester($this->app->find('disable'));
|
|
$this->expectExceptionMessage('missing: "pluginName"');
|
|
$disable_command->execute([]);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
* @test
|
|
*/
|
|
public function disableComplainsWhenPassedUnresolvablePlugin()
|
|
{
|
|
$this->plugin_list->resolvePluginClass(Argument::any())->willThrow(new \InvalidArgumentException);
|
|
|
|
$disable_command = new CommandTester($this->app->find('disable'));
|
|
$disable_command->execute(['pluginName' => 'vendor/package']);
|
|
|
|
$output = $disable_command->getDisplay();
|
|
|
|
$this->assertStringContainsString('ERROR', $output);
|
|
$this->assertStringContainsString('Unknown plugin', $output);
|
|
$this->assertNotSame(0, $disable_command->getStatusCode());
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
* @test
|
|
*/
|
|
public function disableComplainsWhenPassedNotEnabledPlugin()
|
|
{
|
|
$this->plugin_list->resolvePluginClass('vendor/package')->will(
|
|
function (array $_args, ObjectProphecy $plugin_list): string {
|
|
$plugin_list->isEnabled('Vendor\Package\PluginClass')->willReturn(false);
|
|
|
|
return 'Vendor\Package\PluginClass';
|
|
}
|
|
);
|
|
|
|
$disable_command = new CommandTester($this->app->find('disable'));
|
|
$disable_command->execute(['pluginName' => 'vendor/package']);
|
|
|
|
$output = $disable_command->getDisplay();
|
|
$this->assertStringContainsString('Plugin already disabled', $output);
|
|
$this->assertNotSame(0, $disable_command->getStatusCode());
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
* @test
|
|
*/
|
|
public function disableReportsSuccessWhenItDisablesPlugin()
|
|
{
|
|
$this->plugin_list->resolvePluginClass('vendor/package')->will(
|
|
function (array $_args, ObjectProphecy $plugin_list): string {
|
|
$plugin_class = 'Vendor\Package\PluginClass';
|
|
$plugin_list->isEnabled($plugin_class)->willReturn(true);
|
|
$plugin_list->disable($plugin_class)->shouldBeCalled();
|
|
|
|
return $plugin_class;
|
|
}
|
|
);
|
|
|
|
$disable_command = new CommandTester($this->app->find('disable'));
|
|
$disable_command->execute(['pluginName' => 'vendor/package']);
|
|
|
|
$output = $disable_command->getDisplay();
|
|
$this->assertStringContainsString('Plugin disabled', $output);
|
|
$this->assertSame(0, $disable_command->getStatusCode());
|
|
}
|
|
|
|
/** @return string[][] */
|
|
public function commands(): array
|
|
{
|
|
return [
|
|
['show'],
|
|
['enable'],
|
|
['disable'],
|
|
];
|
|
}
|
|
}
|