mirror of
https://github.com/danog/psalm.git
synced 2024-11-27 04:45:20 +01:00
Daniil Gentili
1986c8b4a8
* Immutable CodeLocation * Remove excess clones * Remove external clones * Remove leftover clones * Fix final clone issue * Immutable storages * Refactoring * Fixes * Fixes * Fix * Fix * Fixes * Simplify * Fixes * Fix * Fixes * Update * Fix * Cache global types * Fix * Update * Update * Fixes * Fixes * Refactor * Fixes * Fix * Fix * More caching * Fix * Fix * Update * Update * Fix * Fixes * Update * Refactor * Update * Fixes * Break one more test * Fix * FIx * Fix * Fix * Fix * Fix * Improve performance and readability * Equivalent logic * Fixes * Revert * Revert "Revert" This reverts commit f9175100c8452c80559234200663fd4c4f4dd889. * Fix * Fix reference bug * Make default TypeVisitor immutable * Bugfix * Remove clones * Partial refactoring * Refactoring * Fixes * Fix * Fixes * Fixes * cs-fix * Fix final bugs * Add test * Misc fixes * Update * Fixes * Experiment with removing different property * revert "Experiment with removing different property" This reverts commit ac1156e077fc4ea633530d51096d27b6e88bfdf9. * Uniform naming * Uniform naming * Hack hotfix * Clean up $_FILES ref #8621 * Undo hack, try fixing properly * Helper method * Remove redundant call * Partially fix bugs * Cleanup * Change defaults * Fix bug * Fix (?, hope this doesn't break anything else) * cs-fix * Review fixes * Bugfix * Bugfix * Improve logic * Add support for list{} and callable-list{} types, properly implement array_is_list assertions (fixes #8389) * Default to sealed arrays * Fix array_merge bug * Fixes * Fix * Sealed type checks * Properly infer properties-of and get_object_vars on final classes * Fix array_map zipping * Fix tests * Fixes * Fixes * Fix more stuff * Recursively resolve type aliases * Fix typo * Fixes * Fix array_is_list assertion on keyed array * Add BC docs * Fixes * fix * Update * Update * Update * Update * Seal arrays with count assertions * Fix #8528 * Fix * Update * Improve sealed array foreach logic * get_object_vars on template properties * Fix sealed array assertion reconciler logic * Improved reconciler * Add tests * Single source of truth for test types * Fix tests * Fixup tests * Fixup tests * Fixup tests * Update * Fix tests * Fix tests * Final fixes * Fixes * Use list syntax only when needed * Fix tests * Cs-fix * Update docs * Update docs * Update docs * Update docs * Update docs * Document missing types * Update docs * Improve class-string-map docs * Update * Update * I love working on psalm :) * Keep arrays unsealed by default * Fixup tests * Fix syntax mistake * cs-fix * Fix typo * Re-import missing types * Keep strict types only in return types * argc/argv fixes * argc/argv fixes * Fix test * Comment-out valinor code, pinging @romm pls merge https://github.com/CuyZ/Valinor/pull/246 so we can add valinor to the psalm docs :)
146 lines
4.0 KiB
PHP
146 lines
4.0 KiB
PHP
<?php
|
|
|
|
namespace Psalm\Tests;
|
|
|
|
use Psalm\Internal\Analyzer\ProjectAnalyzer;
|
|
use Psalm\Internal\Provider\FakeFileProvider;
|
|
use Psalm\Internal\Provider\Providers;
|
|
use Psalm\Internal\RuntimeCaches;
|
|
use Psalm\Internal\Type\Comparator\UnionTypeComparator;
|
|
use Psalm\Internal\Type\TypeTokenizer;
|
|
use Psalm\Tests\Internal\Provider\FakeParserCacheProvider;
|
|
use Psalm\Type;
|
|
use Psalm\Type\Atomic\TPropertiesOf;
|
|
|
|
use function array_diff_key;
|
|
use function array_keys;
|
|
use function array_map;
|
|
|
|
class TypeComparatorTest extends TestCase
|
|
{
|
|
public function setUp(): void
|
|
{
|
|
RuntimeCaches::clearAll();
|
|
$this->file_provider = new FakeFileProvider();
|
|
|
|
$config = new TestConfig();
|
|
|
|
$providers = new Providers(
|
|
$this->file_provider,
|
|
new FakeParserCacheProvider()
|
|
);
|
|
|
|
$this->project_analyzer = new ProjectAnalyzer(
|
|
$config,
|
|
$providers
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @dataProvider getAllBasicTypes
|
|
*/
|
|
public function testTypeAcceptsItself(string $type_string): void
|
|
{
|
|
$type_1 = Type::parseString($type_string);
|
|
$type_2 = Type::parseString($type_string);
|
|
|
|
$this->assertTrue(
|
|
UnionTypeComparator::isContainedBy(
|
|
$this->project_analyzer->getCodebase(),
|
|
$type_1,
|
|
$type_2
|
|
)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @return array<strict-array{string}>
|
|
*/
|
|
public function getAllBasicTypes(): array
|
|
{
|
|
// these types are not valid without generics attached
|
|
$basic_generic_types = [
|
|
'key-of' => true,
|
|
'arraylike-object' => true,
|
|
'value-of' => true,
|
|
'class-string-map' => true,
|
|
'int-mask-of' => true,
|
|
'int-mask' => true,
|
|
'pure-Closure' => true,
|
|
];
|
|
foreach (TPropertiesOf::tokenNames() as $token_name) {
|
|
$basic_generic_types[$token_name] = true;
|
|
}
|
|
|
|
$basic_types = array_diff_key(
|
|
TypeTokenizer::PSALM_RESERVED_WORDS,
|
|
$basic_generic_types,
|
|
[
|
|
'open-resource' => true, // unverifiable
|
|
'non-empty-countable' => true, // bit weird, maybe a bug?
|
|
],
|
|
[
|
|
'strict-array' => true, // Requires a shape
|
|
'strict-list' => true, // Requires a shape
|
|
]
|
|
);
|
|
$basic_types['strict-array{test: 123}'] = true;
|
|
$basic_types['strict-list{123}'] = true;
|
|
|
|
return array_map(
|
|
fn($type) => [$type],
|
|
array_keys($basic_types)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @dataProvider getAllowedChildTypes
|
|
*/
|
|
public function testTypeAcceptsType(string $parent_type_string, string $child_type_string): void
|
|
{
|
|
$parent_type = Type::parseString($parent_type_string);
|
|
$child_type = Type::parseString($child_type_string);
|
|
|
|
$this->assertTrue(
|
|
UnionTypeComparator::isContainedBy(
|
|
$this->project_analyzer->getCodebase(),
|
|
$child_type,
|
|
$parent_type
|
|
)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @return array<strict-array{string, string}>
|
|
*/
|
|
public function getAllowedChildTypes(): array
|
|
{
|
|
return [
|
|
'iterableAcceptsArray' => [
|
|
'iterable',
|
|
'array',
|
|
],
|
|
'listAcceptsEmptyArray' => [
|
|
'list',
|
|
'array<never, never>',
|
|
],
|
|
'arrayAcceptsEmptyArray' => [
|
|
'array',
|
|
'array<never, never>',
|
|
],
|
|
'arrayOptionalKeyed1AcceptsEmptyArray' => [
|
|
'strict-array{foo?: string}',
|
|
'array<never, never>',
|
|
],
|
|
'arrayOptionalKeyed2AcceptsEmptyArray' => [
|
|
'strict-array{foo?: string}&array<string, mixed>',
|
|
'array<never, never>',
|
|
],
|
|
'Lowercase-stringAndCallable-string' => [
|
|
'lowercase-string',
|
|
'callable-string',
|
|
],
|
|
];
|
|
}
|
|
}
|