mirror of
https://github.com/danog/psalm.git
synced 2024-12-11 16:59:45 +01:00
Daniil Gentili
1986c8b4a8
* Immutable CodeLocation * Remove excess clones * Remove external clones * Remove leftover clones * Fix final clone issue * Immutable storages * Refactoring * Fixes * Fixes * Fix * Fix * Fixes * Simplify * Fixes * Fix * Fixes * Update * Fix * Cache global types * Fix * Update * Update * Fixes * Fixes * Refactor * Fixes * Fix * Fix * More caching * Fix * Fix * Update * Update * Fix * Fixes * Update * Refactor * Update * Fixes * Break one more test * Fix * FIx * Fix * Fix * Fix * Fix * Improve performance and readability * Equivalent logic * Fixes * Revert * Revert "Revert" This reverts commit f9175100c8452c80559234200663fd4c4f4dd889. * Fix * Fix reference bug * Make default TypeVisitor immutable * Bugfix * Remove clones * Partial refactoring * Refactoring * Fixes * Fix * Fixes * Fixes * cs-fix * Fix final bugs * Add test * Misc fixes * Update * Fixes * Experiment with removing different property * revert "Experiment with removing different property" This reverts commit ac1156e077fc4ea633530d51096d27b6e88bfdf9. * Uniform naming * Uniform naming * Hack hotfix * Clean up $_FILES ref #8621 * Undo hack, try fixing properly * Helper method * Remove redundant call * Partially fix bugs * Cleanup * Change defaults * Fix bug * Fix (?, hope this doesn't break anything else) * cs-fix * Review fixes * Bugfix * Bugfix * Improve logic * Add support for list{} and callable-list{} types, properly implement array_is_list assertions (fixes #8389) * Default to sealed arrays * Fix array_merge bug * Fixes * Fix * Sealed type checks * Properly infer properties-of and get_object_vars on final classes * Fix array_map zipping * Fix tests * Fixes * Fixes * Fix more stuff * Recursively resolve type aliases * Fix typo * Fixes * Fix array_is_list assertion on keyed array * Add BC docs * Fixes * fix * Update * Update * Update * Update * Seal arrays with count assertions * Fix #8528 * Fix * Update * Improve sealed array foreach logic * get_object_vars on template properties * Fix sealed array assertion reconciler logic * Improved reconciler * Add tests * Single source of truth for test types * Fix tests * Fixup tests * Fixup tests * Fixup tests * Update * Fix tests * Fix tests * Final fixes * Fixes * Use list syntax only when needed * Fix tests * Cs-fix * Update docs * Update docs * Update docs * Update docs * Update docs * Document missing types * Update docs * Improve class-string-map docs * Update * Update * I love working on psalm :) * Keep arrays unsealed by default * Fixup tests * Fix syntax mistake * cs-fix * Fix typo * Re-import missing types * Keep strict types only in return types * argc/argv fixes * argc/argv fixes * Fix test * Comment-out valinor code, pinging @romm pls merge https://github.com/CuyZ/Valinor/pull/246 so we can add valinor to the psalm docs :)
220 lines
5.8 KiB
PHP
220 lines
5.8 KiB
PHP
<?php
|
|
|
|
namespace Psalm\Tests\FileManipulation;
|
|
|
|
use Psalm\Context;
|
|
use Psalm\Internal\Analyzer\ProjectAnalyzer;
|
|
use Psalm\Internal\Provider\FakeFileProvider;
|
|
use Psalm\Internal\Provider\Providers;
|
|
use Psalm\Internal\RuntimeCaches;
|
|
use Psalm\Tests\Internal\Provider\FakeParserCacheProvider;
|
|
use Psalm\Tests\TestCase;
|
|
use Psalm\Tests\TestConfig;
|
|
|
|
use function strpos;
|
|
|
|
class PropertyMoveTest extends TestCase
|
|
{
|
|
/** @var ProjectAnalyzer */
|
|
protected $project_analyzer;
|
|
|
|
public function setUp(): void
|
|
{
|
|
RuntimeCaches::clearAll();
|
|
|
|
$this->file_provider = new FakeFileProvider();
|
|
}
|
|
|
|
/**
|
|
* @dataProvider providerValidCodeParse
|
|
*
|
|
* @param array<string, string> $properties_to_move
|
|
*/
|
|
public function testValidCode(
|
|
string $input_code,
|
|
string $output_code,
|
|
array $properties_to_move
|
|
): void {
|
|
$test_name = $this->getTestName();
|
|
if (strpos($test_name, 'SKIPPED-') !== false) {
|
|
$this->markTestSkipped('Skipped due to a bug.');
|
|
}
|
|
|
|
$config = new TestConfig();
|
|
|
|
$this->project_analyzer = new ProjectAnalyzer(
|
|
$config,
|
|
new Providers(
|
|
$this->file_provider,
|
|
new FakeParserCacheProvider()
|
|
)
|
|
);
|
|
|
|
$context = new Context();
|
|
|
|
$file_path = self::$src_dir_path . 'somefile.php';
|
|
|
|
$this->addFile(
|
|
$file_path,
|
|
$input_code
|
|
);
|
|
|
|
$codebase = $this->project_analyzer->getCodebase();
|
|
|
|
$this->project_analyzer->refactorCodeAfterCompletion($properties_to_move);
|
|
|
|
$this->analyzeFile($file_path, $context);
|
|
|
|
$this->project_analyzer->prepareMigration();
|
|
|
|
$codebase->analyzer->updateFile($file_path, false);
|
|
|
|
$this->project_analyzer->migrateCode();
|
|
|
|
$this->assertSame($output_code, $codebase->getFileContents($file_path));
|
|
}
|
|
|
|
/**
|
|
* @return array<string,strict-array{input:string,output:string,migrations:array<string, string>}>
|
|
*/
|
|
public function providerValidCodeParse(): array
|
|
{
|
|
return [
|
|
'moveSimpleStaticProperty' => [
|
|
'input' => '<?php
|
|
namespace Ns;
|
|
|
|
use ArrayObject;
|
|
|
|
class A {
|
|
/** @var ArrayObject<int, int> */
|
|
public static $foo;
|
|
}
|
|
|
|
class B {
|
|
public static function bar() : void {
|
|
foreach (A::$foo as $f) {}
|
|
}
|
|
}',
|
|
'output' => '<?php
|
|
namespace Ns;
|
|
|
|
use ArrayObject;
|
|
|
|
class A {
|
|
|
|
}
|
|
|
|
class B {
|
|
public static function bar() : void {
|
|
foreach (B::$fooBar as $f) {}
|
|
}
|
|
|
|
/** @var ArrayObject<int, int> */
|
|
public static $fooBar;
|
|
}',
|
|
'migrations' => [
|
|
'Ns\A::$foo' => 'Ns\B::$fooBar',
|
|
],
|
|
],
|
|
'renameInstanceProperty' => [
|
|
'input' => '<?php
|
|
namespace Ns;
|
|
|
|
class A {
|
|
/** @var ?int */
|
|
public $foo;
|
|
}
|
|
|
|
function foo(A $a) {
|
|
echo $a->foo;
|
|
$a->foo = 10;
|
|
}',
|
|
'output' => '<?php
|
|
namespace Ns;
|
|
|
|
class A {
|
|
/** @var ?int */
|
|
public $fooBar;
|
|
}
|
|
|
|
function foo(A $a) {
|
|
echo $a->fooBar;
|
|
$a->fooBar = 10;
|
|
}',
|
|
'migrations' => [
|
|
'Ns\A::$foo' => 'Ns\A::$fooBar',
|
|
],
|
|
],
|
|
'renameStaticProperty' => [
|
|
'input' => '<?php
|
|
namespace Ns;
|
|
|
|
class A {
|
|
/** @var ?int */
|
|
public static $foo;
|
|
}
|
|
|
|
function foo() {
|
|
echo A::$foo;
|
|
A::$foo = 10;
|
|
}',
|
|
'output' => '<?php
|
|
namespace Ns;
|
|
|
|
class A {
|
|
/** @var ?int */
|
|
public static $fooBar;
|
|
}
|
|
|
|
function foo() {
|
|
echo A::$fooBar;
|
|
A::$fooBar = 10;
|
|
}',
|
|
'migrations' => [
|
|
'Ns\A::$foo' => 'Ns\A::$fooBar',
|
|
],
|
|
],
|
|
'moveStaticProperty' => [
|
|
'input' => '<?php
|
|
namespace Ns;
|
|
|
|
class A {
|
|
/** @var ?int */
|
|
public static $foo;
|
|
}
|
|
|
|
class B {
|
|
|
|
}
|
|
|
|
function foo() {
|
|
echo A::$foo;
|
|
A::$foo = 10;
|
|
}',
|
|
'output' => '<?php
|
|
namespace Ns;
|
|
|
|
class A {
|
|
|
|
}
|
|
|
|
class B {
|
|
|
|
|
|
/** @var int|null */
|
|
public static $fooBar;
|
|
}
|
|
|
|
function foo() {
|
|
echo B::$fooBar;
|
|
B::$fooBar = 10;
|
|
}',
|
|
'migrations' => [
|
|
'Ns\A::$foo' => 'Ns\B::$fooBar',
|
|
],
|
|
],
|
|
];
|
|
}
|
|
}
|