mirror of
https://github.com/danog/psalm.git
synced 2025-01-22 05:41:20 +01:00
93c5df6bfc
* in PHP 8.0, `ReflectionUnionType` is composed on `ReflectionNamedType`s
* in PHP 8.1, `ReflectionIntersectionType` is composed of `ReflectionNamedType`s
* in PHP 8.2, `ReflectionUnionType` is composed of `ReflectionIntersectionType|ReflectionNamedType`s
Slight variations for each PHP version.
As per local testing, this doesn't work yet.
## Local testing setup:
I did some digging to make sure that the stubs work as expected.
Here's what I did to validate this patch locally (since I don't think it can really be fully automated)
## Create a dummy file to verify used symbols
```php
<?php
namespace Testing;
/** @return \ReflectionClass<\stdClass> */
function getAClass(): \ReflectionClass { throw new \Exception('irrelevant'); }
function getAnUnionType(): \ReflectionUnionType { throw new \Exception('irrelevant'); }
function getAnIntersectionType(): \ReflectionIntersectionType { throw new \Exception('irrelevant'); }
// verifying that `getName()` is stubbed in all versions: this should always be a `class-string<\stdClass>`
$name = getAClass()->getName();
// union types should appear starting with PHP 8.0. Starting with PHP 8.2, they allow for intersections.
$unionTypes = getAnUnionType()->getTypes();
// intersection types should appear starting with PHP 8.1
$intersectionTypes = getAnIntersectionType()->getTypes();
$results = [$name, $unionTypes, $intersectionTypes];
/** @psalm-trace $results */ // tracing this will show us the differences between versions
return $results;
```
## Run the script against various `vimeo/psalm` versions
```sh
docker run --rm -ti -v $(pwd):/app -w /app php:7.4 ./psalm --php-version=7.4 --no-cache reflection-test.php | grep Trace
docker run --rm -ti -v $(pwd):/app -w /app php:8.0 ./psalm --php-version=8.0 --no-cache reflection-test.php | grep Trace
docker run --rm -ti -v $(pwd):/app -w /app php:8.1 ./psalm --php-version=8.1 --no-cache reflection-test.php | grep Trace
docker run --rm -ti -v $(pwd):/app -w /app php:8.2.0RC7-cli ./psalm --php-version=8.2 --no-cache reflection-test.php | grep Trace
```
## Evaluate output
```
❯ docker run --rm -ti -v $(pwd):/app -w /app php:7.4 ./psalm --php-version=7.4 --no-cache reflection-test.php | grep Trace
ERROR: Trace - reflection-test.php:20:1 - $results: list{class-string<stdClass>, mixed, mixed} (see https://psalm.dev/224)
❯ docker run --rm -ti -v $(pwd):/app -w /app php:8.0 ./psalm --php-version=8.0 --no-cache reflection-test.php | grep Trace
ERROR: Trace - reflection-test.php:20:1 - $results: list{class-string<stdClass>, non-empty-list<ReflectionNamedType>, mixed} (see https://psalm.dev/224)
❯ docker run --rm -ti -v $(pwd):/app -w /app php:8.1 ./psalm --php-version=8.1 --no-cache reflection-test.php | grep Trace
ERROR: Trace - reflection-test.php:20:1 - $results: list{class-string<stdClass>, non-empty-list<ReflectionNamedType>, non-empty-list<ReflectionNamedType>} (see https://psalm.dev/224)
psalm on feature/#8720-improve-types-and-purity-for-reflection-symbols [!?] via 🐘 v8.1.13 via ❄️ impure (nix-shell) took 4s
❯ docker run --rm -ti -v $(pwd):/app -w /app php:8.2.0RC7-cli ./psalm --php-version=8.2 --no-cache reflection-test.php | grep Trace
ERROR: Trace - reflection-test.php:20:1 - $results: list{class-string<stdClass>, non-empty-list<ReflectionNamedType>, non-empty-list<ReflectionNamedType>} (see https://psalm.dev/224)
```
92 lines
2.2 KiB
PHP
92 lines
2.2 KiB
PHP
<?php
|
|
namespace {
|
|
interface UnitEnum {
|
|
/** @var non-empty-string $name */
|
|
public readonly string $name;
|
|
|
|
/**
|
|
* @psalm-pure
|
|
* @return list<static>
|
|
*/
|
|
public static function cases(): array;
|
|
}
|
|
|
|
interface BackedEnum extends UnitEnum
|
|
{
|
|
public readonly int|string $value;
|
|
|
|
/**
|
|
* @psalm-pure
|
|
*/
|
|
public static function from(string|int $value): static;
|
|
|
|
/**
|
|
* @psalm-pure
|
|
*/
|
|
public static function tryFrom(string|int $value): ?static;
|
|
}
|
|
|
|
class ReflectionClass implements Reflector {
|
|
/** @psalm-pure */
|
|
public function isEnum(): bool {}
|
|
}
|
|
|
|
/** @psalm-immutable */
|
|
class ReflectionEnum extends ReflectionClass implements Reflector
|
|
{
|
|
public function getBackingType(): ?ReflectionType;
|
|
public function getCase(string $name): ReflectionEnumUnitCase;
|
|
/** @return list<ReflectionEnumUnitCase> */
|
|
public function getCases(): array;
|
|
public function hasCase(string $name): bool;
|
|
public function isBacked(): bool;
|
|
}
|
|
|
|
/** @psalm-immutable */
|
|
class ReflectionEnumUnitCase extends ReflectionClassConstant implements Reflector
|
|
{
|
|
public function getEnum(): ReflectionEnum;
|
|
public function getValue(): UnitEnum;
|
|
}
|
|
|
|
/** @psalm-immutable */
|
|
class ReflectionEnumBackedCase extends ReflectionEnumUnitCase implements Reflector
|
|
{
|
|
public function getBackingValue(): int|string;
|
|
}
|
|
|
|
/** @psalm-immutable */
|
|
class ReflectionIntersectionType extends ReflectionType {
|
|
/** @return non-empty-list<ReflectionNamedType> */
|
|
public function getTypes(): array {}
|
|
|
|
/** @return false */
|
|
public function allowsNull(): bool {}
|
|
}
|
|
}
|
|
|
|
namespace FTP {
|
|
final class Connection {}
|
|
}
|
|
|
|
namespace IMAP {
|
|
final class Connection {}
|
|
}
|
|
|
|
namespace LDAP {
|
|
final class Connection {}
|
|
final class Result {}
|
|
final class ResultEntry {}
|
|
}
|
|
|
|
namespace PgSql {
|
|
final class Connection {}
|
|
final class Result {}
|
|
final class Lob {}
|
|
}
|
|
|
|
namespace PSpell {
|
|
final class Config {}
|
|
final class Dictionary {}
|
|
}
|