mirror of
https://github.com/danog/psalm.git
synced 2024-12-15 19:07:00 +01:00
ffe7874906
* extract the operation out of the loop when possible * remove unnecessary interfaces when already inherited in parent * simplify expressions * avoid using alias functions * redundant phpdoc * unused imports
163 lines
5.2 KiB
PHP
163 lines
5.2 KiB
PHP
<?php
|
|
namespace Psalm\Internal\Analyzer\Statements\Block;
|
|
|
|
use PhpParser;
|
|
use Psalm\Internal\Analyzer\ScopeAnalyzer;
|
|
use Psalm\Internal\Analyzer\StatementsAnalyzer;
|
|
use Psalm\Context;
|
|
use Psalm\Internal\Scope\LoopScope;
|
|
use Psalm\Type;
|
|
use function in_array;
|
|
use function array_merge;
|
|
|
|
/**
|
|
* @internal
|
|
*/
|
|
class WhileAnalyzer
|
|
{
|
|
/**
|
|
* @return false|null
|
|
*/
|
|
public static function analyze(
|
|
StatementsAnalyzer $statements_analyzer,
|
|
PhpParser\Node\Stmt\While_ $stmt,
|
|
Context $context
|
|
): ?bool {
|
|
$while_true = ($stmt->cond instanceof PhpParser\Node\Expr\ConstFetch && $stmt->cond->name->parts === ['true'])
|
|
|| ($stmt->cond instanceof PhpParser\Node\Scalar\LNumber && $stmt->cond->value > 0);
|
|
|
|
$pre_context = null;
|
|
|
|
if ($while_true) {
|
|
$pre_context = clone $context;
|
|
}
|
|
|
|
$while_context = clone $context;
|
|
|
|
$while_context->inside_loop = true;
|
|
$while_context->break_types[] = 'loop';
|
|
|
|
$codebase = $statements_analyzer->getCodebase();
|
|
|
|
if ($codebase->alter_code) {
|
|
$while_context->branch_point = $while_context->branch_point ?: (int) $stmt->getAttribute('startFilePos');
|
|
}
|
|
|
|
$loop_scope = new LoopScope($while_context, $context);
|
|
$loop_scope->protected_var_ids = $context->protected_var_ids;
|
|
|
|
if (LoopAnalyzer::analyze(
|
|
$statements_analyzer,
|
|
$stmt->stmts,
|
|
self::getAndExpressions($stmt->cond),
|
|
[],
|
|
$loop_scope,
|
|
$inner_loop_context
|
|
) === false) {
|
|
return false;
|
|
}
|
|
|
|
if (!$inner_loop_context) {
|
|
throw new \UnexpectedValueException('Should always enter loop');
|
|
}
|
|
|
|
$always_enters_loop = false;
|
|
|
|
if ($stmt_cond_type = $statements_analyzer->node_data->getType($stmt->cond)) {
|
|
$always_enters_loop = true;
|
|
|
|
foreach ($stmt_cond_type->getAtomicTypes() as $iterator_type) {
|
|
if ($iterator_type instanceof Type\Atomic\TArray
|
|
|| $iterator_type instanceof Type\Atomic\TKeyedArray
|
|
) {
|
|
if ($iterator_type instanceof Type\Atomic\TKeyedArray) {
|
|
if (!$iterator_type->sealed) {
|
|
$always_enters_loop = false;
|
|
}
|
|
} elseif (!$iterator_type instanceof Type\Atomic\TNonEmptyArray) {
|
|
$always_enters_loop = false;
|
|
}
|
|
|
|
continue;
|
|
}
|
|
|
|
if ($iterator_type instanceof Type\Atomic\TTrue) {
|
|
continue;
|
|
}
|
|
|
|
if ($iterator_type instanceof Type\Atomic\TLiteralString
|
|
&& $iterator_type->value
|
|
) {
|
|
continue;
|
|
}
|
|
|
|
if ($iterator_type instanceof Type\Atomic\TLiteralInt
|
|
&& $iterator_type->value
|
|
) {
|
|
continue;
|
|
}
|
|
|
|
$always_enters_loop = false;
|
|
break;
|
|
}
|
|
}
|
|
|
|
$can_leave_loop = !$while_true
|
|
|| in_array(ScopeAnalyzer::ACTION_BREAK, $loop_scope->final_actions, true);
|
|
|
|
if ($always_enters_loop && $can_leave_loop) {
|
|
foreach ($inner_loop_context->vars_in_scope as $var_id => $type) {
|
|
// if there are break statements in the loop it's not certain
|
|
// that the loop has finished executing, so the assertions at the end
|
|
// the loop in the while conditional may not hold
|
|
if (in_array(ScopeAnalyzer::ACTION_BREAK, $loop_scope->final_actions, true)
|
|
|| in_array(ScopeAnalyzer::ACTION_CONTINUE, $loop_scope->final_actions, true)
|
|
) {
|
|
if (isset($loop_scope->possibly_defined_loop_parent_vars[$var_id])) {
|
|
$context->vars_in_scope[$var_id] = Type::combineUnionTypes(
|
|
$type,
|
|
$loop_scope->possibly_defined_loop_parent_vars[$var_id]
|
|
);
|
|
}
|
|
} else {
|
|
$context->vars_in_scope[$var_id] = $type;
|
|
}
|
|
}
|
|
}
|
|
|
|
$while_context->loop_scope = null;
|
|
|
|
if ($can_leave_loop) {
|
|
$context->vars_possibly_in_scope = array_merge(
|
|
$context->vars_possibly_in_scope,
|
|
$while_context->vars_possibly_in_scope
|
|
);
|
|
} elseif ($pre_context) {
|
|
$context->vars_possibly_in_scope = $pre_context->vars_possibly_in_scope;
|
|
}
|
|
|
|
$context->referenced_var_ids = array_merge(
|
|
$context->referenced_var_ids,
|
|
$while_context->referenced_var_ids
|
|
);
|
|
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* @return list<PhpParser\Node\Expr>
|
|
*/
|
|
private static function getAndExpressions(
|
|
PhpParser\Node\Expr $expr
|
|
) : array {
|
|
if ($expr instanceof PhpParser\Node\Expr\BinaryOp\BooleanAnd) {
|
|
return array_merge(
|
|
self::getAndExpressions($expr->left),
|
|
self::getAndExpressions($expr->right)
|
|
);
|
|
}
|
|
|
|
return [$expr];
|
|
}
|
|
}
|