1
0
mirror of https://github.com/danog/psalm.git synced 2024-12-12 01:09:38 +01:00
psalm/tests/ClassScopeTest.php
Daniil Gentili 1986c8b4a8
Add support for strict arrays, fix type alias intersection, fix array_is_list assertion on non-lists (#8395)
* Immutable CodeLocation

* Remove excess clones

* Remove external clones

* Remove leftover clones

* Fix final clone issue

* Immutable storages

* Refactoring

* Fixes

* Fixes

* Fix

* Fix

* Fixes

* Simplify

* Fixes

* Fix

* Fixes

* Update

* Fix

* Cache global types

* Fix

* Update

* Update

* Fixes

* Fixes

* Refactor

* Fixes

* Fix

* Fix

* More caching

* Fix

* Fix

* Update

* Update

* Fix

* Fixes

* Update

* Refactor

* Update

* Fixes

* Break one more test

* Fix

* FIx

* Fix

* Fix

* Fix

* Fix

* Improve performance and readability

* Equivalent logic

* Fixes

* Revert

* Revert "Revert"

This reverts commit f9175100c8452c80559234200663fd4c4f4dd889.

* Fix

* Fix reference bug

* Make default TypeVisitor immutable

* Bugfix

* Remove clones

* Partial refactoring

* Refactoring

* Fixes

* Fix

* Fixes

* Fixes

* cs-fix

* Fix final bugs

* Add test

* Misc fixes

* Update

* Fixes

* Experiment with removing different property

* revert "Experiment with removing different property"

This reverts commit ac1156e077fc4ea633530d51096d27b6e88bfdf9.

* Uniform naming

* Uniform naming

* Hack hotfix

* Clean up $_FILES ref #8621

* Undo hack, try fixing properly

* Helper method

* Remove redundant call

* Partially fix bugs

* Cleanup

* Change defaults

* Fix bug

* Fix (?, hope this doesn't break anything else)

* cs-fix

* Review fixes

* Bugfix

* Bugfix

* Improve logic

* Add support for list{} and callable-list{} types, properly implement array_is_list assertions (fixes #8389)

* Default to sealed arrays

* Fix array_merge bug

* Fixes

* Fix

* Sealed type checks

* Properly infer properties-of and get_object_vars on final classes

* Fix array_map zipping

* Fix tests

* Fixes

* Fixes

* Fix more stuff

* Recursively resolve type aliases

* Fix typo

* Fixes

* Fix array_is_list assertion on keyed array

* Add BC docs

* Fixes

* fix

* Update

* Update

* Update

* Update

* Seal arrays with count assertions

* Fix #8528

* Fix

* Update

* Improve sealed array foreach logic

* get_object_vars on template properties

* Fix sealed array assertion reconciler logic

* Improved reconciler

* Add tests

* Single source of truth for test types

* Fix tests

* Fixup tests

* Fixup tests

* Fixup tests

* Update

* Fix tests

* Fix tests

* Final fixes

* Fixes

* Use list syntax only when needed

* Fix tests

* Cs-fix

* Update docs

* Update docs

* Update docs

* Update docs

* Update docs

* Document missing types

* Update docs

* Improve class-string-map docs

* Update

* Update

* I love working on psalm :)

* Keep arrays unsealed by default

* Fixup tests

* Fix syntax mistake

* cs-fix

* Fix typo

* Re-import missing types

* Keep strict types only in return types

* argc/argv fixes

* argc/argv fixes

* Fix test

* Comment-out valinor code, pinging @romm pls merge https://github.com/CuyZ/Valinor/pull/246 so we can add valinor to the psalm docs :)
2022-11-05 22:34:42 +01:00

322 lines
10 KiB
PHP

<?php
namespace Psalm\Tests;
use Psalm\Tests\Traits\InvalidCodeAnalysisTestTrait;
use Psalm\Tests\Traits\ValidCodeAnalysisTestTrait;
class ClassScopeTest extends TestCase
{
use InvalidCodeAnalysisTestTrait;
use ValidCodeAnalysisTestTrait;
public function providerValidCodeParse(): iterable
{
return [
'accessiblePrivateMethodFromSubclass' => [
'code' => '<?php
class A {
private function fooFoo(): void {
}
private function barBar(): void {
$this->fooFoo();
}
}',
],
'accessibleProtectedMethodFromSubclass' => [
'code' => '<?php
class A {
protected function fooFoo(): void {
}
}
class B extends A {
public function doFoo(): void {
$this->fooFoo();
}
}',
],
'accessibleProtectedMethodFromOtherSubclass' => [
'code' => '<?php
class A {
protected function fooFoo(): void {
}
}
class B extends A { }
class C extends A {
public function doFoo(): void {
(new B)->fooFoo();
}
}',
],
'accessibleProtectedPropertyFromSubclass' => [
'code' => '<?php
class A {
/** @var string */
protected $fooFoo = "";
}
class B extends A {
public function doFoo(): void {
echo $this->fooFoo;
}
}',
],
'accessibleProtectedPropertyFromGreatGrandparent' => [
'code' => '<?php
class A {
/** @var string */
protected $fooFoo = "";
}
class B extends A { }
class C extends B { }
class D extends C {
public function doFoo(): void {
echo $this->fooFoo;
}
}',
],
'accessibleProtectedPropertyFromOtherSubclass' => [
'code' => '<?php
class A {
/** @var string */
protected $fooFoo = "";
}
class B extends A {
}
class C extends A {
public function fooFoo(): void {
$b = new B();
$b->fooFoo = "hello";
}
}',
],
'accessibleStaticPropertyFromSubclass' => [
'code' => '<?php
class A {
/** @var string */
protected static $fooFoo = "";
public function barBar(): void {
echo self::$fooFoo;
}
}
class B extends A {
public function doFoo(): void {
echo A::$fooFoo;
}
}',
],
'definedPrivateMethod' => [
'code' => '<?php
class A {
public function foo(): void {
if ($this instanceof B) {
$this->boop();
}
}
private function boop(): void {}
}
class B extends A {
private function boop(): void {}
}',
],
'allowMethodCallToProtectedFromParent' => [
'code' => '<?php
class A {
public function __construct() {
B::foo();
}
}
class B extends A {
protected static function foo(): void {
echo "here";
}
}'
],
];
}
/**
*
*/
public function providerInvalidCodeParse(): iterable
{
return [
'inaccessiblePrivateMethod' => [
'code' => '<?php
class A {
private function fooFoo(): void {
}
}
(new A())->fooFoo();',
'error_message' => 'InaccessibleMethod',
],
'inaccessibleProtectMethod' => [
'code' => '<?php
class A {
protected function fooFoo(): void {
}
}
(new A())->fooFoo();',
'error_message' => 'InaccessibleMethod',
],
'inaccessiblePrivateMethodFromSubclass' => [
'code' => '<?php
class A {
private function fooFoo(): void {
}
}
class B extends A {
public function doFoo(): void {
$this->fooFoo();
}
}',
'error_message' => 'UndefinedMethod',
],
'inaccessibleProtectredMethodFromOtherSubclass' => [
'code' => '<?php
trait T {
protected function fooFoo(): void {
}
}
class B {
use T;
}
class C {
use T;
public function doFoo(): void {
(new B)->fooFoo();
}
}',
'error_message' => 'InaccessibleMethod',
],
'inaccessiblePrivateProperty' => [
'code' => '<?php
class A {
/** @var string */
private $fooFoo;
}
echo (new A())->fooFoo;',
'error_message' => 'InaccessibleProperty',
],
'inaccessibleProtectedProperty' => [
'code' => '<?php
class A {
/** @var string */
protected $fooFoo;
}
echo (new A())->fooFoo;',
'error_message' => 'InaccessibleProperty',
],
'inaccessiblePrivatePropertyFromSubclass' => [
'code' => '<?php
class A {
/** @var string */
private $fooFoo = "";
}
class B extends A {
public function doFoo(): void {
echo $this->fooFoo;
}
}',
'error_message' => 'UndefinedThisPropertyFetch',
],
'inaccessibleStaticPrivateProperty' => [
'code' => '<?php
class A {
/** @var string */
private static $fooFoo;
}
echo A::$fooFoo;',
'error_message' => 'InaccessibleProperty',
],
'inaccessibleStaticProtectedProperty' => [
'code' => '<?php
class A {
/** @var string */
protected static $fooFoo;
}
echo A::$fooFoo;',
'error_message' => 'InaccessibleProperty',
],
'inaccessibleStaticPrivatePropertyFromSubclass' => [
'code' => '<?php
class A {
/** @var string */
private static $fooFoo;
}
class B extends A {
public function doFoo(): void {
echo A::$fooFoo;
}
}',
'error_message' => 'InaccessibleProperty',
],
'privateConstructorInheritanceNoCall' => [
'code' => '<?php
class A {
private function __construct() { }
}
class B extends A {}
new B();',
'error_message' => 'InaccessibleMethod',
],
'privateConstructorInheritanceCall' => [
'code' => '<?php
class A {
private function __construct() { }
}
class B extends A {
public function __construct() {
parent::__construct();
}
}',
'error_message' => 'InaccessibleMethod',
],
'noSelfInFunctionConstant' => [
'code' => '<?php
function foo() : void {
echo self::SOMETHING;
}',
'error_message' => 'NonStaticSelfCall',
],
'noSelfInFunctionCall' => [
'code' => '<?php
function foo() : void {
echo self::bar();
}',
'error_message' => 'NonStaticSelfCall',
],
];
}
}